[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Woohoo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124429/new/ https://reviews.llvm.org/D124429 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere updated this revision to Diff 425113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124430/new/ https://reviews.llvm.org/D124430 Files: lldb/test/API/functionalities/step_scripted/TestStepScripted.py lldb/test/API/lldbtest.py

[Lldb-commits] [PATCH] D124430: [lldb] Remove Python 2 checks from the test suite

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, lanza. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. Remove Python 2 checks from the test suite Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D124429: [lldb] Remove Python 2 support from the ScriptInterpreter plugin

JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, lanza. Herald added a project: All. JDevlieghere requested review of this revision. We dropped downstream support for Python 2 in the previous release. Now that we have branched for the next release the window

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35e60f5de180: [NFC][trace] simplify the instruction dumper (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 35e60f5 - [NFC][trace] simplify the instruction dumper

Author: Walter Erquinigo Date: 2022-04-25T20:02:48-07:00 New Revision: 35e60f5de180aea55ed478298f4b40f04dcc57d1 URL: https://github.com/llvm/llvm-project/commit/35e60f5de180aea55ed478298f4b40f04dcc57d1 DIFF:

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

wallace updated this revision to Diff 425109. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124064/new/ https://reviews.llvm.org/D124064 Files: lldb/include/lldb/Target/TraceInstructionDumper.h

[Lldb-commits] [PATCH] D124064: [NFC][trace] simplify the instruction dumper

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceInstructionDumper.h:26 + lldb::InstructionSP instruction; + lldb_private::ExecutionContext exe_ctx; +}; jj10306 wrote: > It shouldn't be an issue now because this struct is never stored

[Lldb-commits] [lldb] 059f39d - [trace][intel pt] Support events

Author: Walter Erquinigo Date: 2022-04-25T19:01:23-07:00 New Revision: 059f39d2f44503862cb9c752c28a3a77275b0e51 URL: https://github.com/llvm/llvm-project/commit/059f39d2f44503862cb9c752c28a3a77275b0e51 DIFF:

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

This revision was automatically updated to reflect the committed changes. Closed by commit rG059f39d2f445: [trace][intel pt] Support events (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123982/new/

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5cbf516cb79f: Refactor protected virtual functions from SymbolFile into new SymbolFileCommon… (authored by yinghuitan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5cbf516 - Refactor protected virtual functions from SymbolFile into new SymbolFileCommon class.

Author: Jeffrey Tan Date: 2022-04-25T18:33:47-07:00 New Revision: 5cbf516cb79fa27395dabb33002ab20243b1ee5d URL: https://github.com/llvm/llvm-project/commit/5cbf516cb79fa27395dabb33002ab20243b1ee5d DIFF: https://github.com/llvm/llvm-project/commit/5cbf516cb79fa27395dabb33002ab20243b1ee5d.diff

[Lldb-commits] [PATCH] D124338: [lldb] Update online help text (consistency, typo)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe07c092b8529: [lldb] Update online help text (consistency, typo) (authored by hawkinsw, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] e07c092 - [lldb] Update online help text (consistency, typo)

Author: Will Hawkins Date: 2022-04-25T16:31:26-07:00 New Revision: e07c092b8529c6ef0f7ba722fd7188b1bc731d8c URL: https://github.com/llvm/llvm-project/commit/e07c092b8529c6ef0f7ba722fd7188b1bc731d8c DIFF: https://github.com/llvm/llvm-project/commit/e07c092b8529c6ef0f7ba722fd7188b1bc731d8c.diff

[Lldb-commits] [lldb] 827ff1e - [LLDB][NativePDB] Fix incorrect file index of inlinees introduced by f00cd23caed5f920495bcae2055f4c478d8383d6

Author: Zequan Wu Date: 2022-04-25T16:07:04-07:00 New Revision: 827ff1e576f71fd3b81c4b012bf852eb6f46f808 URL: https://github.com/llvm/llvm-project/commit/827ff1e576f71fd3b81c4b012bf852eb6f46f808 DIFF: https://github.com/llvm/llvm-project/commit/827ff1e576f71fd3b81c4b012bf852eb6f46f808.diff

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jasonmolenda added a comment. Herald added a project: All. Hi all, getting back to this one after six months, hah. Reading through Jim's thoughts on this, I think we're OK to add this refinement. Tatyana also thought that removing this altogether would be an option, but this has been sitting

[Lldb-commits] [PATCH] D124338: [lldb] Update online help text (consistency, typo)

hawkinsw added a comment. Added that extra space, as requested! And, yes, I will need someone to land this one for me. I am going to ask for commit access, but so far have not! Thanks for your help, @JDevlieghere ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124338: [lldb] Update online help text (consistency, typo)

hawkinsw updated this revision to Diff 425032. hawkinsw added a comment. Updating thanks to @jdevlieghere feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124338/new/ https://reviews.llvm.org/D124338 Files:

[Lldb-commits] [PATCH] D124110: Refactor protected virtual functions from SymbolFile into new SymbolFileActual class.

JDevlieghere accepted this revision. JDevlieghere added a comment. Before I read the comments I was going to make the same suggestion as Greg, but this makes sense to limit churn. LGMT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124110/new/

[Lldb-commits] [PATCH] D122988: [BOLT][DWARF] Add version 5 split dwarf support

ayermolo updated this revision to Diff 425001. ayermolo added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122988/new/

[Lldb-commits] [PATCH] D123982: [trace][intel pt] Support events

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. Thanks for making those changes - lgtm! Comment at: lldb/source/Plugins/Trace/intel-pt/DecodedThread.h:258 /// first one. Otherwise, this map will be empty. std::map

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

dblaikie added a comment. I take it no tests fail upon removing this condition? Any hints in version history about its purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new/ https://reviews.llvm.org/D124370

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus created this revision. siggi-alpheus added a reviewer: labath. siggi-alpheus added a project: LLDB. Herald added subscribers: JDevlieghere, arphaman. Herald added a reviewer: shafik. Herald added a project: All. siggi-alpheus requested review of this revision. Herald added a

[Lldb-commits] [PATCH] D121631: Introduce new symbol on-demand for debug info

clayborg added a comment. LGTM. Anyone else have any issues? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121631/new/ https://reviews.llvm.org/D121631 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

clayborg added a comment. So I believe the reason we need to be able to add methods to a class is for templates. Templates in DWARF are really poorly emitted all in the name of saving space. There is no full definition of template classes that get emitted, just a class definition with _only_

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

shafik added a comment. This mostly makes sense, the purpose of the `|| alternate_defn` was not clear to me either. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124370/new/ https://reviews.llvm.org/D124370

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

MaskRay closed this revision. MaskRay added a comment. a749e3295df4aee18a0ad723875a6501f30ac744 pushed by Aaron does not have a `Differential Revision:` line. Manual closing. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3402469 , @aaron.ballman wrote: > In D121078#3400810 , @SimplyDanny > wrote: > >> @tonic, can you please have another look? > > If @tonic has any additional feedback, we can

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

ldionne added inline comments. Comment at: libcxx/utils/gdb/libcxx/printers.py:192 class StdStringPrinter(object): """Print a std::string.""" philnik wrote: > labath wrote: > > philnik wrote: > > > dblaikie wrote: > > > > philnik wrote: > > > > > jgorbe

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5

maksfb accepted this revision. maksfb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121876/new/ https://reviews.llvm.org/D121876

[Lldb-commits] [PATCH] D121876: [BOLT][DWARF] Implement monolithic DWARF5.

ayermolo added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_TAG_variable-DW_AT_decl_file-DW_AT_abstract_origin-crosscu1.s:17 -# RUN: %clang_host -o %t %s \ +# RUN: %clang_host -gdwarf-4 -o %t %s \ # RUN:

[Lldb-commits] [PATCH] D123580: [libc++] Use bit field for checking if string is in long or short mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29c8c070a177: [libc++] Use bit field for checking if string is in long or short mode (authored by philnik). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D124338: [lldb] Update online help text (consistency, typo)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the inline comment addressed. Do you need someone to commit this for you? Comment at: lldb/source/Commands/Options.td:155 Arg<"Selector">,

[Lldb-commits] [PATCH] D123500: [lldb][NFC] Add more tests for GenerateOptionsUsage

DavidSpickett updated this revision to Diff 424900. DavidSpickett added a comment. I realised that in theory the tests could still pass if your ordering just happend to land in the right way. For the short option `[-ABCabc]` there's not a lot I can do about that, so I added another check for a

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a comment. > If we don't have a thread yet we can't have a mask. Though this isn't a watertight argument since I think Mach corefiles can have a note that tells you the number of addressable bits. In our case there's nothing like that. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a comment. There's some argument that the thing asking for the mask shouldn't ask so early but I think the logic here is still an improvement regardless. If we don't have a thread yet we can't have a mask. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

DavidSpickett added a comment. The current assumption is that once you've got a valid (currently anything non-zero) mask then that's it, it's not going to change. I think a future extension could change the meaning of the existing non-address bits at runtime, but that wouldn't be a problem

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

omjavaid added a comment. Very corner case but Is there a possibility of masks changing positions during the life-time of an inferior ? So this makes me think that code/data masks are per process and cant be changes once set. Should we worry about it?AFAIK this is fine but just asking to clear

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124000/new/ https://reviews.llvm.org/D124000

[Lldb-commits] [PATCH] D124370: [lldb] Fix PR54761

labath created this revision. labath added reviewers: shafik, clayborg. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. The issue is somewhat hard to describe (I recommend reading the bug), but what roughly happens is that we have a type with