[Lldb-commits] [PATCH] D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe53019a8ff77: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory (authored by JDevlieghere). Herald added a project:

[Lldb-commits] [lldb] e53019a - [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

Author: Jonas Devlieghere Date: 2022-05-02T21:07:11-07:00 New Revision: e53019a8ff778048dd83aee29dd659af8b771920 URL: https://github.com/llvm/llvm-project/commit/e53019a8ff778048dd83aee29dd659af8b771920 DIFF:

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

aperez added a comment. In D124814#3487179 , @jasonmolenda wrote: > Ah, I see what you're doing. You've got a shell running x86_64 or something > (maybe started lldb as x86_64) so everything that is spawned from that is > x86_64 -- debugserver and

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

jasonmolenda added a comment. (tbh every case I've seen, it's someone who checked "Run in Rosetta" on the Xcode.app bundle with Finder, and are running their entire IDE as x86_64) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124814/new/

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

jasonmolenda added a comment. Ah, I see what you're doing. You've got a shell running x86_64 or something (maybe started lldb as x86_64) so everything that is spawned from that is x86_64 -- debugserver and the inferior process -- and so you hit this. let me look more closely later tonight,

[Lldb-commits] [PATCH] D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG322b4130415a: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC) (authored by JDevlieghere). Herald added a project: LLDB.

[Lldb-commits] [PATCH] D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41c0ff1e740b: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 322b413 - [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)

Author: Jonas Devlieghere Date: 2022-05-02T17:34:40-07:00 New Revision: 322b4130415ac51ba48c993dfebc9c0b38d5bc32 URL: https://github.com/llvm/llvm-project/commit/322b4130415ac51ba48c993dfebc9c0b38d5bc32 DIFF:

[Lldb-commits] [lldb] 41c0ff1 - [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)

Author: Jonas Devlieghere Date: 2022-05-02T17:34:40-07:00 New Revision: 41c0ff1e740bc0962104a2619b908f8c24e28741 URL: https://github.com/llvm/llvm-project/commit/41c0ff1e740bc0962104a2619b908f8c24e28741 DIFF:

[Lldb-commits] [lldb] d006773 - [lldb] Remove unused PlatformRemoteDarwinDevice::FindFileInAllSDKs

Author: Jonas Devlieghere Date: 2022-05-02T17:34:39-07:00 New Revision: d0067738e0cf764a92e1cc5ee0c8b2af8659bada URL: https://github.com/llvm/llvm-project/commit/d0067738e0cf764a92e1cc5ee0c8b2af8659bada DIFF:

[Lldb-commits] [lldb] d75cc08 - [lldb] Remove PlatformRemoteMacOSX::GetFileWithUUID overload (NFC)

Author: Jonas Devlieghere Date: 2022-05-02T17:34:36-07:00 New Revision: d75cc0859391e90a79bb0de6300d5d69db015421 URL: https://github.com/llvm/llvm-project/commit/d75cc0859391e90a79bb0de6300d5d69db015421 DIFF:

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

wallace updated this revision to Diff 426546. wallace added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124648/new/ https://reviews.llvm.org/D124648 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [PATCH] D124814: Fix debugserver translation check

aperez created this revision. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. aperez edited the summary of this revision. aperez added a project: LLDB. Herald added a subscriber: JDevlieghere. aperez added reviewers: clayborg, jasonmolenda. aperez published this

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

clayborg accepted this revision. clayborg added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Target/Language.h:225 + // symbol was really B::A::my_function. We want that to be + // a match. But we wouldn't want this to match

[Lldb-commits] [PATCH] D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124801/new/ https://reviews.llvm.org/D124801 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124800/new/ https://reviews.llvm.org/D124800 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124799/new/ https://reviews.llvm.org/D124799 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D124801: [lldb] Make GetSharedModuleWithLocalCache consider the device support directory

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added a project: All. JDevlieghere requested review of this revision. Make GetSharedModuleWithLocalCache consider the device support directory. In the past we only needed the device support

[Lldb-commits] [PATCH] D124800: [lldb] Move GetSharedModuleWithLocalCache to PlatformDarwinDevice (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D124800 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp

[Lldb-commits] [PATCH] D124799: [lldb] Hoist device support out of PlatformRemoteDarwinDevice (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda, mib. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. https://reviews.llvm.org/D124799 Files:

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1873-1875 + if (message.size() + prefix_width + suffix_width >= term_width) +message.erase(message.begin() + term_width - prefix_width - suffix_width, + message.end());

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

JDevlieghere added a comment. Can we add a pexpect test for this? Comment at: lldb/source/Core/Debugger.cpp:1873-1875 + if (message.size() + prefix_width + suffix_width >= term_width) +message.erase(message.begin() + term_width - prefix_width - suffix_width, +

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus added a comment. This is passing lldb-checks locally. Is there anything else I need to add or tweak, or is this ready for review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409

[Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

siggi-alpheus updated this revision to Diff 426452. siggi-alpheus added a comment. Fix awkwardly named variable in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124409/new/ https://reviews.llvm.org/D124409 Files:

[Lldb-commits] [PATCH] D124785: [lldb/Core] Fix "sticky" long progress messages

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. When the terminal window is too small, lldb would wrap progress messages accross multiple lines

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.h:136 - /// Manages a list of thread traces. class IntelPTThreadTraceCollection { wallace wrote: > jj10306 wrote: > > update doc since this is no longer tied to

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

MaskRay accepted this revision. MaskRay added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:315 + uint32_t endian = header.e_ident[EI_DATA]; + if(endian == ELFDATA2LSB) +return ArchSpec::eCore_ppc64le_generic;

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:498 // Binary data kinds: -//- threadTraceBuffer: trace buffer for a thread. +//- traceBuffer: trace buffer for a thread. //- procFsCpuInfo: contents of the /proc/cpuinfo file.

[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

wallace added inline comments. Comment at: lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp:66 OptionParsingStarting(ExecutionContext *execution_context) { - m_thread_buffer_size = kDefaultThreadBufferSize; + m_trace_buffer_size =

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. There were probably easier ways to test this, but it's nice to have the core file nonetheless. LGTM, assuming the core is of a reasonable size.

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace added a comment. thanks for your review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:369 +// +// /* process tracing only */ // "processBufferSizeLimit": , jj10306 wrote: > Why do we only want this option for process tracing? > Per cpu tracing collects all trace

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

jj10306 added a comment. Much cleaner now, thanks for separating out the procfs logic  Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 ___ lldb-commits

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de0a3e9da72: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing… (authored by Walter Erquinigo wall...@fb.com).

[Lldb-commits] [lldb] 5de0a3e - [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

Author: Walter Erquinigo Date: 2022-05-02T08:48:49-07:00 New Revision: 5de0a3e9da721189dd648a90e87829d375c5d17f URL: https://github.com/llvm/llvm-project/commit/5de0a3e9da721189dd648a90e87829d375c5d17f DIFF:

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace updated this revision to Diff 426424. wallace added a comment. final nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 Files: lldb/docs/lldb-gdb-remote.txt

[Lldb-commits] [PATCH] D124648: [trace][intelpt] Support system-wide tracing [3] - Refactor IntelPTThreadTrace

jj10306 requested changes to this revision. jj10306 added inline comments. This revision now requires changes to proceed. Comment at: lldb/docs/lldb-gdb-remote.txt:498 // Binary data kinds: -//- threadTraceBuffer: trace buffer for a thread. +//- traceBuffer: trace

[Lldb-commits] [PATCH] D123415: [lldb] Fix crash when a type has no definition

siggi-alpheus abandoned this revision. siggi-alpheus added a comment. This is not a good fix for the crash. A better fix is in https://reviews.llvm.org/D124370. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123415/new/

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace updated this revision to Diff 426422. wallace added a comment. Herald added a subscriber: mgorny. move procfs functions to Procfs.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124573/new/ https://reviews.llvm.org/D124573 Files:

[Lldb-commits] [PATCH] D124640: [trace][intelpt] Support system-wide tracing [2] - Add a dummy --per-core-tracing option

jj10306 requested changes to this revision. jj10306 added a comment. This revision now requires changes to proceed. Before doing a complete review can you provide clarity on the decision to only support perCore for process wide (see my inline comment with my thoughts/questions)? Understanding

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

JDevlieghere added a comment. In D124673#3484157 , @MaskRay wrote: > I vaguely recall that some lldb bots use a stand-alone build. Yup, that's correct. The bot in question is https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-standalone/

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

wallace added inline comments. Comment at: lldb/unittests/Process/Linux/PerfTests.cpp:53 +TEST(Perf, HardcodedLogicalCoreIDs) { + Expected> core_ids = jj10306 wrote: > Not directly related to this diff, but I just realized the proc fs parsing > logic doesn't

[Lldb-commits] [PATCH] D124573: [trace][intelpt] Support system-wide tracing [1] - Add a method for accessing the list of logical core ids

jj10306 accepted this revision. jj10306 added inline comments. Comment at: lldb/unittests/Process/Linux/PerfTests.cpp:53 +TEST(Perf, HardcodedLogicalCoreIDs) { + Expected> core_ids = Not directly related to this diff, but I just realized the proc fs parsing

[Lldb-commits] [PATCH] D124760: [lldb] Fix ppc64 detection in lldb

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, jasonmolenda, labath. Herald added subscribers: StephenFan, shchenz, kbarton, nemanjai, emaste. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: LLDB.