[Lldb-commits] [PATCH] D126260: [lldb/crashlog] Add support for Application Specific Backtraces & Information

mib updated this revision to Diff 465232. mib marked 2 inline comments as done. mib retitled this revision from "[lldb/crashlog] Add support for Application Specific Backtraces" to "[lldb/crashlog] Add support for Application Specific Backtraces & Information". mib edited the summary of this

[Lldb-commits] [PATCH] D134906: Have MemoryCache cache addresses that were unreadable, so duplicate read attempts can be suppressed

jasonmolenda added a comment. In D134906#3835260 , @jasonmolenda wrote: > We ask for 32 bytes starting at 0x1017c, get back 4 bytes. Then we try > to read the remaining 28 bytes starting at 0x10180, and get an error. So > this is different

[Lldb-commits] [PATCH] D134906: Have MemoryCache cache addresses that were unreadable, so duplicate read attempts can be suppressed

jasonmolenda added a comment. Jim & David, thanks so much for the comments. The most important question of correctness that David asks is whether we might try to read 32k from an address and mark that address as inaccessible because a page 24k into the memory read failed (for instance). I

[Lldb-commits] [lldb] 40501f1 - buildbot-based-debugging a Microsoft lldb test XPASS

Author: David Blaikie Date: 2022-10-04T21:38:33Z New Revision: 40501f1b4139e472094ac0d4102923d2730515a1 URL: https://github.com/llvm/llvm-project/commit/40501f1b4139e472094ac0d4102923d2730515a1 DIFF: https://github.com/llvm/llvm-project/commit/40501f1b4139e472094ac0d4102923d2730515a1.diff

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

Ericson2314 added a comment. Thanks @MaskRay that's good to know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 2c43cd8 - Turn off the warning that the undefined behavior I am using in

Author: Jim Ingham Date: 2022-10-04T11:38:32-07:00 New Revision: 2c43cd883c20b603bc7d9461bfa2591e80a36a3b URL: https://github.com/llvm/llvm-project/commit/2c43cd883c20b603bc7d9461bfa2591e80a36a3b DIFF: https://github.com/llvm/llvm-project/commit/2c43cd883c20b603bc7d9461bfa2591e80a36a3b.diff

[Lldb-commits] [PATCH] D135178: [lldb][test] Skip import-std-module/vector tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9abeb0cbd983: [lldb][test] Skip import-std-module/vector tests (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135178/new/

[Lldb-commits] [lldb] 9abeb0c - [lldb][test] Skip import-std-module/vector tests

Author: Michael Buch Date: 2022-10-04T18:38:47+01:00 New Revision: 9abeb0cbd983c7e32a729e333b033673546e5485 URL: https://github.com/llvm/llvm-project/commit/9abeb0cbd983c7e32a729e333b033673546e5485 DIFF: https://github.com/llvm/llvm-project/commit/9abeb0cbd983c7e32a729e333b033673546e5485.diff

[Lldb-commits] [PATCH] D134570: [lldb] Skip check for conflicting filter/synth when adding a new regex.

jgorbe added a comment. Ping? If anyone has other suggestions for reviewers I'd appreciate them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134570/new/ https://reviews.llvm.org/D134570 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D135178: [lldb][test] Skip import-std-module/vector tests

Michael137 created this revision. Michael137 added a reviewer: aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests have begun failing starting with commit

[Lldb-commits] [PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

shafik added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:733 + static CXXBoolLiteralExpr *Create(const ASTContext , bool Val, QualType Ty, +SourceLocation Loc) { I think this makes sense but if we are

[Lldb-commits] [PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. For https://github.com/llvm/llvm-project/issues/58135. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135169/new/ https://reviews.llvm.org/D135169

[Lldb-commits] [PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

DavidSpickett created this revision. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. As with static bool for whatever reason printing them on their own worked fine but wasn't

[Lldb-commits] [PATCH] D135169: [LLDB] Fix printing a static bool struct member when using "image lookup -t"

DavidSpickett created this revision. Herald added a reviewer: shafik. Herald added a project: All. DavidSpickett requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Fixes #58135 Somehow lldb was able to print the member on

[Lldb-commits] [PATCH] D135031: [lldb] [llgs] Move client-server communication into a separate thread (WIP)

labath added a comment. I think we should get some measurements (e.g. from the `process plugin packet speed-test` cmd) of the overhead of this approach. The latency/RTT of the connection is very important for some users, and I fear that all of this ping pong could significantly regress that.

[Lldb-commits] [PATCH] D135029: [lldb] [gdb-remote] Isolate ClientBase from Communication

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h:116-118 + GDBRemoteCommunication () { +return m_comm; + } mgorny wrote: > labath wrote: > > Is the plan to make this private/protected at some point, or

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

labath added a comment. In D134882#3831137 , @jingham wrote: > That seems fine. I think it's useful to be able to see breakpoint hit counts > up to the point where you start a new process. From looking at the code, it > looks like putting the clear

[Lldb-commits] [PATCH] D134882: [lldb] Move breakpoint hit reset code to Target::CleanupProcess

labath updated this revision to Diff 465012. labath added a comment. Check breakpoint hit counts after termination Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134882/new/ https://reviews.llvm.org/D134882 Files: lldb/source/Target/Process.cpp

[Lldb-commits] [PATCH] D134991: [lldb] Add diagnostics

DavidSpickett added a comment. > I think that part should be easy to test and I was planning on adding a test > as part of that. Sounds good to me. Nothing needed in this change then. A command also gives you a chance to get the diagnostics out if running until the actual crash fails to dump

[Lldb-commits] [PATCH] D134906: Have MemoryCache cache addresses that were unreadable, so duplicate read attempts can be suppressed

labath added a comment. I don't know about debugserver, but both lldb-server and gdbserver currently return an error when the memory is partially accessible, even though the protocol explicitly allows the possibility of truncated reads. It is somewhat hard to reproduce, because the caching