[Lldb-commits] [PATCH] D137466: [lldb/crashlog] Fix frame parser regex for when there is no source info

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e8c1c4fc48a: [lldb/crashlog] Fix frame parser regex for when there is no source info (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] acba66f - [lldb/crashlog] Standardize file path key in the ScriptedProcess Dictionary

Author: Med Ismail Bennani Date: 2022-11-04T22:05:58-07:00 New Revision: acba66fdde0ea918d4b7bd16863ac1bba7d1521b URL: https://github.com/llvm/llvm-project/commit/acba66fdde0ea918d4b7bd16863ac1bba7d1521b DIFF:

[Lldb-commits] [lldb] 40afc69 - [lldb/test] Fix StructuredDataTest::GetDescriptionEmpty warning (NFC)

Author: Med Ismail Bennani Date: 2022-11-04T22:05:58-07:00 New Revision: 40afc69e6dc0cc39e9e090ed96df95d6334db17c URL: https://github.com/llvm/llvm-project/commit/40afc69e6dc0cc39e9e090ed96df95d6334db17c DIFF:

[Lldb-commits] [lldb] 3e8c1c4 - [lldb/crashlog] Fix frame parser regex for when there is no source info

Author: Med Ismail Bennani Date: 2022-11-04T22:05:58-07:00 New Revision: 3e8c1c4fc48a286dd546899a7374dce680633d93 URL: https://github.com/llvm/llvm-project/commit/3e8c1c4fc48a286dd546899a7374dce680633d93 DIFF:

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Considering https://discourse.llvm.org/t/should-we-continue-embed-the-full-llvm-version-in-lib-clang/62094 and this thread, I think overall people favor this patch. If a

[Lldb-commits] [PATCH] D137003: [lldb-vscode] Send Statistics Dump in terminated event

clayborg added a comment. In D137003#3908918 , @shafik wrote: > It looks like this change broke `TestVSCode_terminatedEvent.py` see Green > Dragon build bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48111/ > > Please fix or revert.

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:96 CompilerType method_ct = m_ast_builder.ToCompilerType(method_qt); - lldb::opaque_compiler_type_t derived_opaque_ty =

[Lldb-commits] [lldb] 03c7cd3 - Revert "[lldb-vscode] Send Statistics Dump in terminated event"

Author: George Hu Date: 2022-11-04T15:37:18-07:00 New Revision: 03c7cd3a616b731cf041fbf164078b349223c4ef URL: https://github.com/llvm/llvm-project/commit/03c7cd3a616b731cf041fbf164078b349223c4ef DIFF: https://github.com/llvm/llvm-project/commit/03c7cd3a616b731cf041fbf164078b349223c4ef.diff

[Lldb-commits] [lldb] 7b7ec60 - Fix test TestVSCode_terminatedEvent.py

Author: Wanyi Ye Date: 2022-11-04T14:54:29-07:00 New Revision: 7b7ec60dccb5f44d33c36e89bd4df008c618468b URL: https://github.com/llvm/llvm-project/commit/7b7ec60dccb5f44d33c36e89bd4df008c618468b DIFF: https://github.com/llvm/llvm-project/commit/7b7ec60dccb5f44d33c36e89bd4df008c618468b.diff

[Lldb-commits] [PATCH] D137466: [lldb/crashlog] Fix frame parser regex for when there is no source info

mib created this revision. mib added reviewers: kastiglione, JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. It can happen that the originator of a crash report doesn't have access to certain

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:96 CompilerType method_ct = m_ast_builder.ToCompilerType(method_qt); - lldb::opaque_compiler_type_t derived_opaque_ty = m_derived_ct.GetOpaqueQualType(); +

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

zequanwu updated this revision to Diff 473336. zequanwu marked an inline comment as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066 Files:

[Lldb-commits] [PATCH] D137464: [NFC][lldb] Remove unnecessary branch in TypeSystemClang::DumpTypeDescription()

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137464 Files:

[Lldb-commits] [PATCH] D137003: [lldb-vscode] Send Statistics Dump in terminated event

kusmour added a comment. In D137003#3908918 , @shafik wrote: > It looks like this change broke `TestVSCode_terminatedEvent.py` see Green > Dragon build bot: > https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48111/ > > Please fix or revert. I

[Lldb-commits] [PATCH] D137003: [lldb-vscode] Send Statistics Dump in terminated event

shafik added a comment. Herald added a subscriber: JDevlieghere. It looks like this change broke `TestVSCode_terminatedEvent.py` see Green Dragon build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/48111/ Please fix or revert. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

mib added inline comments. Comment at: lldb/unittests/Utility/StructuredDataTest.cpp:41 + object_sp->GetDescription(S); + EXPECT_EQ(0, S.GetSize()); +} shafik wrote: > When doing a build I am seeing: > > ``` > warning: comparison of integers of different

[Lldb-commits] [PATCH] D135547: [lldb/Utility] Add GetDescription(Stream&) to StructureData::*

shafik added inline comments. Comment at: lldb/unittests/Utility/StructuredDataTest.cpp:41 + object_sp->GetDescription(S); + EXPECT_EQ(0, S.GetSize()); +} When doing a build I am seeing: ``` warning: comparison of integers of different signs: 'const int' and

[Lldb-commits] [lldb] b6cf94e - Fix format specifier warning in EmulateInstructionRISCV more

Author: Benjamin Kramer Date: 2022-11-04T18:58:43+01:00 New Revision: b6cf94e973f9659086633ca56dc51bc74d4125eb URL: https://github.com/llvm/llvm-project/commit/b6cf94e973f9659086633ca56dc51bc74d4125eb DIFF:

[Lldb-commits] [lldb] 234e08e - [lldb] Fix format specifier warning in EmulateInstructionRISCV

Author: Jonas Devlieghere Date: 2022-11-04T10:46:31-07:00 New Revision: 234e08ec3c1a94bf67ee78c25d1c5241cc69aaa5 URL: https://github.com/llvm/llvm-project/commit/234e08ec3c1a94bf67ee78c25d1c5241cc69aaa5 DIFF:

[Lldb-commits] [PATCH] D137287: [Test] Fix CHECK typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7fa5febaa43: [Test] Fix CHECK typo. (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137287/new/ https://reviews.llvm.org/D137287

[Lldb-commits] [lldb] a7fa5fe - [Test] Fix CHECK typo.

Author: Zequan Wu Date: 2022-11-04T10:18:04-07:00 New Revision: a7fa5febaa43d860cbd6a4061f239b283c4d8032 URL: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032 DIFF: https://github.com/llvm/llvm-project/commit/a7fa5febaa43d860cbd6a4061f239b283c4d8032.diff

[Lldb-commits] [PATCH] D125860: [clang] Only use major version in resource dir

tbaeder updated this revision to Diff 473208. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860 Files: clang/include/clang/Basic/Version.inc.in clang/lib/Driver/Driver.cpp clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

avogelsgesang added a comment. @labath @aprantl Thank you for your reviews on https://reviews.llvm.org/D132815 and https://reviews.llvm.org/D132735 I would appreciate if you also have time to review this change here, as it is a pre-requisite for the other two changes :) Repository: rG LLVM

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type it has incomplete type debug info.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1 +#include "/tmp/debug.h" #include "PdbAstBuilder.h" oops? Comment at: lldb/source/Plugins/SymbolFile/NativePDB/UdtRecordCompleter.cpp:96

[Lldb-commits] [PATCH] D137137: [lldb/Interpreter] Open saved transcript in GUI Editor

This revision was automatically updated to reflect the committed changes. Closed by commit rG902ba8b0c9b0: [lldb/Interpreter] Open saved transcript in GUI Editor (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137137/new/

[Lldb-commits] [lldb] 902ba8b - [lldb/Interpreter] Open saved transcript in GUI Editor

Author: Med Ismail Bennani Date: 2022-11-03T23:13:13-07:00 New Revision: 902ba8b0c9b013043aa04dc548be3ec907ef5571 URL: https://github.com/llvm/llvm-project/commit/902ba8b0c9b013043aa04dc548be3ec907ef5571 DIFF: