[Lldb-commits] [PATCH] D138892: [DataFormatter] Fix variant npos with `_LIBCPP_ABI_VARIANT_INDEX_TYPE_OPTIMIZATION` enabled.

rupprecht created this revision. rupprecht added reviewers: labath, Michael137, kastiglione. Herald added a subscriber: arphaman. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This data formatter

[Lldb-commits] [PATCH] D138310: [NFC] Make headers self-contained.

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: lldb/source/Plugins/Instruction/RISCV/RISCVInstructions.h:15 -#include "EmulateInstructionRISCV.h" #include

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

kastiglione updated this revision to Diff 478419. kastiglione added a comment. Address @labath's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138315/new/ https://reviews.llvm.org/D138315 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D138879: [lldb] Make SWIG an autodetected depenency

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, mib, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch makes SWIG itself an autodetected dependency. This allows us to look for SWIG once in a centralized place and makes it

[Lldb-commits] [PATCH] D138878: [lldb] Remove timer from Module::GetNumCompileUnits

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `GetNumCompileUnits` has fast execution, and is high

[Lldb-commits] [PATCH] D138430: [lldb/test] Use SBPlatform info for lldbplatformutil.getPlatform()

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138430/new/ https://reviews.llvm.org/D138430

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:747-749 + if (ParseTemplateParameterInfos(die, template_param_infos) && + (!template_param_infos.args.empty() || + template_param_infos.packed_args)) {

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks updated this revision to Diff 478323. aeubanks marked an inline comment as done. aeubanks added a comment. don't use stl in test simplify some code a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/

[Lldb-commits] [PATCH] D138850: [test] Implement layout for unstable std::string garbage formatter tests.

rupprecht created this revision. rupprecht added a reviewer: labath. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The layout is essentially just reversed from the stable std::string layout.

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

dblaikie added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:747-749 + if (ParseTemplateParameterInfos(die, template_param_infos) && + (!template_param_infos.args.empty() || + template_param_infos.packed_args)) {

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks added a comment. depends on D132624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138834/new/ https://reviews.llvm.org/D138834 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D138834: [lldb] Fix simple template names interaction with debug info declarations

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Without checking template parameters, we would sometimes lookup the wrong type

[Lldb-commits] [PATCH] D138612: [lldb] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks added a comment. @jasonmolenda could you run check-lldb with this patch? I think this patch may fix the test by changing its expectations for logging. (removed "NFC" from title because the logging changes actually mattered) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

aeubanks updated this revision to Diff 478272. aeubanks added a comment. potential test fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138612/new/ https://reviews.llvm.org/D138612 Files:

[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

JDevlieghere added a comment. In D138176#3937163 , @avl wrote: > That might be an error if referenced DIE is not cloned. @friss and I were starting to wonder the same thing. I was out last week because of Thanksgiving but I'll dig into this a bit more

[Lldb-commits] [PATCH] D138315: [lldb] Introduce dwim-print command

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectDWIMPrint.cpp:65 +Target *target_ptr = exe_ctx.GetTargetPtr(); +Target = target_ptr ? *target_ptr :