[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

paulkirth added a comment. Sorry for the noise, I missed that that bot is setting a CMake flag that affects LLVM_EXPORTS. Please disregard my earlier message. I just need to update the CMake invocation to fix this, so I don't think there is anything required on your end. Repository: rG

[Lldb-commits] [PATCH] D137838: [Support] Move TargetParsers to new component

paulkirth added a comment. Hi, we're seeing some build failures after this change. Seems like the TargetParser isn't getting added to LLVMExports correctly. Can you take a look and address these? Failing bot

[Lldb-commits] [lldb] 81d1b61 - [lldb] Fix a warning

Author: Kazu Hirata Date: 2022-12-22T12:01:35-08:00 New Revision: 81d1b61e900cefc67d59fcd3ba55e5a01e3fba78 URL: https://github.com/llvm/llvm-project/commit/81d1b61e900cefc67d59fcd3ba55e5a01e3fba78 DIFF: https://github.com/llvm/llvm-project/commit/81d1b61e900cefc67d59fcd3ba55e5a01e3fba78.diff

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added inline comments. Comment at: lldb/include/lldb/Utility/Status.h:65 + template + explicit Status(const char *format, Args &&...args) { +SetErrorToGenericError(); labath wrote: > I don't think you've converted all the callers of this one.

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 484920. ayermolo marked 11 inline comments as done. ayermolo added a comment. addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files:

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85cc6009aa7: [lldb] Add LTO dependency to lldb test suite (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/

[Lldb-commits] [lldb] f85cc60 - [lldb] Add LTO dependency to lldb test suite

Author: Augusto Noronha Date: 2022-12-22T10:15:20-08:00 New Revision: f85cc6009aa790dd9970981408401072702ea886 URL: https://github.com/llvm/llvm-project/commit/f85cc6009aa790dd9970981408401072702ea886 DIFF:

[Lldb-commits] [PATCH] D140051: [lldb] Add LTO dependency to lldb test suite

augusto2112 added a comment. @DavidSpickett thanks for the review, I've updated the commit message to be clearer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140051/new/ https://reviews.llvm.org/D140051

[Lldb-commits] [PATCH] D139881: [clang] Use a StringRef instead of a raw char pointer to store builtin and call information

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139881/new/ https://reviews.llvm.org/D139881 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3afe296c81b9: [test][lldb-vscode] Relax assertion to allow multiple compile units returned. (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 3afe296 - [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

Author: Jordan Rupprecht Date: 2022-12-22T05:19:29-08:00 New Revision: 3afe296c81b93473c1e5008514d6225a2200ad19 URL: https://github.com/llvm/llvm-project/commit/3afe296c81b93473c1e5008514d6225a2200ad19 DIFF:

[Lldb-commits] [PATCH] D138344: [test][lldb-vscode] Relax assertion to allow multiple compile units returned.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138344/new/ https://reviews.llvm.org/D138344