[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3677ee65d192: Move from llvm::makeArrayRef to ArrayRef deduction

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille updated this revision to Diff 486172. serge-sans-paille added a comment. Split the original patch in pieces: first just introduce the deduction guide. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140896/new/ https://reviews.llvm.org/D140896 Files:

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

MaskRay accepted this revision. MaskRay added a comment. LGTM if `makeArrayRef` is kept in this patch. Do we foresee compiler bugs (for supported compilers) in this area? If there may be a risk, consider migrate a part of the code base first. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille updated this revision to Diff 486049. serge-sans-paille added a comment. + keep deprecated version, flagged appropriately CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140896/new/ https://reviews.llvm.org/D140896 Files: bolt/tools/bat-dump/bat-dump.cpp

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. @dblaikie Happy New Year! Penny for your thoughts on this patch? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. @labath ping. Is there anything else I need to do? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

jpienaar added inline comments. Comment at: llvm/include/llvm/ADT/ArrayRef.h:502 + /// Deduction guide to construct an ArrayRef from a C array. + template ArrayRef(const T ()[N]) -> ArrayRef; mehdi_amini wrote: > Can we keep the makeArrayRef functions for

[Lldb-commits] [lldb] 7174568 - [lldb] Remove spurious `n` at the end of option error message

Author: Jonas Devlieghere Date: 2023-01-03T08:31:09-08:00 New Revision: 7174568c9ccf2959b95563252c1bdbf59c5746c7 URL: https://github.com/llvm/llvm-project/commit/7174568c9ccf2959b95563252c1bdbf59c5746c7 DIFF:

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

mehdi_amini added inline comments. Herald added a subscriber: Michael137. Comment at: llvm/include/llvm/ADT/ArrayRef.h:502 + /// Deduction guide to construct an ArrayRef from a C array. + template ArrayRef(const T ()[N]) -> ArrayRef; Can we keep the

[Lldb-commits] [PATCH] D140896: [WIP] Move from llvm::makeArrayRef to ArrayRef deduction guides

serge-sans-paille created this revision. Herald added subscribers: libc-commits, hanchung, kadircet, Moerafaat, kmitropoulou, zero9178, Enna1, bzcheeseman, kosarev, mattd, gchakrabarti, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, arjunp, sdasgup3, asavonic, carlosgalvezp, Groverkss,

[Lldb-commits] [lldb] 21be357 - [LLDB] Skip python exception unit test on AArch64/Windows

Author: Muhammad Omair Javaid Date: 2023-01-03T18:42:43+04:00 New Revision: 21be357873c0325495c7f6599259579735f54f3e URL: https://github.com/llvm/llvm-project/commit/21be357873c0325495c7f6599259579735f54f3e DIFF:

[Lldb-commits] [lldb] 2b8c308 - [LLDB] Skip TestThreadSpecificBreakpoint.py on AArch64/Windows

Author: Muhammad Omair Javaid Date: 2023-01-03T18:42:43+04:00 New Revision: 2b8c308fa1d3ba504c1bde16f262683685b19726 URL: https://github.com/llvm/llvm-project/commit/2b8c308fa1d3ba504c1bde16f262683685b19726 DIFF:

[Lldb-commits] [lldb] 9bfc8ba - [lldb][Test] TestDataFormatterLibcxxRangesRefView.py: skip on old compiler versions

Author: Michael Buch Date: 2023-01-03T13:12:31Z New Revision: 9bfc8ba7a70fd4b2f224bde5d8a405056a83954e URL: https://github.com/llvm/llvm-project/commit/9bfc8ba7a70fd4b2f224bde5d8a405056a83954e DIFF: https://github.com/llvm/llvm-project/commit/9bfc8ba7a70fd4b2f224bde5d8a405056a83954e.diff LOG:

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 485931. serge-sans-paille added a comment. (rebased on main. Note that this patch is applied on top of https://reviews.llvm.org/D140699) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 Files:

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. In D140800#4021282 , @thakis wrote: > I'm guessing on non-empty files this is a negligible win even in clang. As showcased by

[Lldb-commits] [PATCH] D140800: Precompute OptTable prefixes union table through tablegen

serge-sans-paille updated this revision to Diff 485929. serge-sans-paille added a comment. Added to versions of OptTable, one that uses a precomputed Table, generated by TableGen, and one that relies on the old, generic approach. Both are tested using the same test bench. Updated benchmark: