[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

mib added a subscriber: mehdi_amini. mib added a comment. In D141219#4038658 , @mib wrote: > I guess we could even throw MLIR formatters in there for completeness I don't know exactly how well those are maintained ... @mehdi_amini do you think it would

[Lldb-commits] [PATCH] D141219: Add a .lldbinit file to autoload LLVM/Clang data formatters

mib added a comment. I guess we could even throw MLIR formatters in there for completeness Comment at: .lldbinit:2-3 +# To autoload set `settings set target.load-cwd-lldbinit true` in ~/.lldbinit +command script import ./llvm/utils/lldbDataFormatters.py +command script import

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I think this patch is correct, but could be clearer - mostly because the original code didn't choose good enough names. What's going on here is that the "internal_breakpoint"

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

JDevlieghere updated this revision to Diff 487613. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Make `lldb-framework-cleanup` a dependency of `install-liblldb`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141021/new/ https://reviews.llvm.org/D141021

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

JDevlieghere added a comment. In D141021#4037840 , @bulbazord wrote: > I think this idea will work but I have a few comments and questions: > > Based on my understanding of this change, we're supposed to manually run the > build system with the target

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D139379#4015624 , @ayermolo wrote: > In D139379#4015569 , @dblaikie > wrote: > >> In

[Lldb-commits] [PATCH] D141330: [lldb] Limit 8b259fe573e1 to dSYMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG9b737f148d88: [lldb] Limit trusting aranges to dSYMs only. (authored by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to commit:

[Lldb-commits] [lldb] 9b737f1 - [lldb] Limit trusting aranges to dSYMs only.

Author: Jonas Devlieghere Date: 2023-01-09T15:38:05-08:00 New Revision: 9b737f148d88501a0a778e1adacf342108286bb0 URL: https://github.com/llvm/llvm-project/commit/9b737f148d88501a0a778e1adacf342108286bb0 DIFF:

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4037687 , @JDevlieghere wrote: > In D141318#4037640 , @augusto2112 > wrote: > >> In D141318#4037557 , @JDevlieghere >> wrote:

[Lldb-commits] [PATCH] D141100: Return a shared_ptr from ScratchTypeSystemClang::GetForTarget()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8d7ab8cf8e8: Return a shared_ptr from ScratchTypeSystemClang::GetForTarget() (authored by aprantl). Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] f8d7ab8 - Return a shared_ptr from ScratchTypeSystemClang::GetForTarget()

Author: Adrian Prantl Date: 2023-01-09T15:04:53-08:00 New Revision: f8d7ab8cf8e859dcc7f696e8d01ed6fca502446a URL: https://github.com/llvm/llvm-project/commit/f8d7ab8cf8e859dcc7f696e8d01ed6fca502446a DIFF: https://github.com/llvm/llvm-project/commit/f8d7ab8cf8e859dcc7f696e8d01ed6fca502446a.diff

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

mib added inline comments. Comment at: lldb/cmake/modules/AddLLDB.cmake:247-249 + # Create a target to remove the target again before the install phase. We + # intentionally use remove_directory because the target can be a directory + # and it's harmless for files.

[Lldb-commits] [PATCH] D141021: [lldb] Add lldb-framework-cleanup target

bulbazord added a comment. I think this idea will work but I have a few comments and questions: Based on my understanding of this change, we're supposed to manually run the build system with the target `lldb-framework-cleanup` before we perform an install. Is this the case? This seems most

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b259fe573e1: [lldb] Trust the arange accelerator tables in dSYMs (authored by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68655/new/

[Lldb-commits] [lldb] 8b259fe - [lldb] Trust the arange accelerator tables in dSYMs

Author: Jonas Devlieghere Date: 2023-01-09T14:34:57-08:00 New Revision: 8b259fe573e109ea03c91aca34d5bd60f1a432ff URL: https://github.com/llvm/llvm-project/commit/8b259fe573e109ea03c91aca34d5bd60f1a432ff DIFF:

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

JDevlieghere added a comment. In D141318#4037640 , @augusto2112 wrote: > In D141318#4037557 , @JDevlieghere > wrote: > >> In D141318#4037541 , @augusto2112 >> wrote:

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. In D141318#4037557 , @JDevlieghere wrote: > In D141318#4037541 , @augusto2112 > wrote: > >> I changed the value of the map to a shared pointer, but could change it to a >> weak

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

jasonmolenda added a comment. I agree with landing this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68655/new/ https://reviews.llvm.org/D68655 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

JDevlieghere added a comment. In D141318#4037541 , @augusto2112 wrote: > I changed the value of the map to a shared pointer, but could change it to a > weak pointer instead, not sure which is more appropriate in this case. I was about to ask the same

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 added a comment. Herald added a subscriber: JDevlieghere. I changed the value of the map to a shared pointer, but could change it to a weak pointer instead, not sure which is more appropriate in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D141318: [lldb] Store shared pointers in DieToTypePtr map instead of raw pointers

augusto2112 created this revision. augusto2112 added reviewers: labath, clayborg, aprantl. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Storing raw pointers in

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. Thanks for reviewing, really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe262b8f48af9: [LLDB] Change formatting to use llvm::formatv (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] e262b8f - [LLDB] Change formatting to use llvm::formatv

Author: Alexander Yermolovich Date: 2023-01-09T11:29:43-08:00 New Revision: e262b8f48af9fdca8380f2f079e50291956aad71 URL: https://github.com/llvm/llvm-project/commit/e262b8f48af9fdca8380f2f079e50291956aad71 DIFF:

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo updated this revision to Diff 487512. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 Files: lldb/include/lldb/Core/Module.h

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

JDevlieghere updated this revision to Diff 487509. JDevlieghere added a comment. > Apparently for very small / gapless programs, clang emits single-value > DW_AT_low_pc/high_pc in the compile unit, and dsymutil does not rewrite that > into DW_AT_ranges. Although this statement is correct, it

[Lldb-commits] [lldb] 1d6243d - [lldb] Fix symbol table use after free

Author: Augusto Noronha Date: 2023-01-09T10:27:18-08:00 New Revision: 1d6243db90b09c61d78a14268bb88a73792b63ab URL: https://github.com/llvm/llvm-project/commit/1d6243db90b09c61d78a14268bb88a73792b63ab DIFF:

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

serge-sans-paille added a comment. @nikic : gentle ping :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140800/new/ https://reviews.llvm.org/D140800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D141298: Move from llvm::makeArrayRef to ArrayRef deduction guides - last part

mehdi_amini added a comment. Seems mechanical, and if it build everywhere LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141298/new/ https://reviews.llvm.org/D141298 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D141298: Move from llvm::makeArrayRef to ArrayRef deduction guides - last part

serge-sans-paille added a comment. Herald added subscribers: Michael137, JDevlieghere. Once that patch lands, I'll mark `makeArrayRef` as deprecated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141298/new/ https://reviews.llvm.org/D141298

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955

[Lldb-commits] [PATCH] D140368: [lldb] Consider all breakpoints in breakpoint detection

kpdev42 added a comment. @jingham May I kindly ask you to take a look at this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140368/new/ https://reviews.llvm.org/D140368 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

labath accepted this revision. labath added a comment. I'm sorry for the delay, I was out for the holidays. Looks now, thanks for your patience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D140630: [lldb-vscode] Add data breakpoint support

cimacmillan added a comment. Ping! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140630/new/ https://reviews.llvm.org/D140630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org