[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 496655. kkcode0 added a comment. added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 496654. kkcode0 added a comment. added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Target/RegisterContext.h Index:

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

kastiglione added a comment. details is good, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143690/new/ https://reviews.llvm.org/D143690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 29fa21e - [lldb] Fix passing None as an env variable in TestMultipleDebuggers

Author: Augusto Noronha Date: 2023-02-10T17:32:48-08:00 New Revision: 29fa21eb61293e677a8de4bacd843ef57192b60b URL: https://github.com/llvm/llvm-project/commit/29fa21eb61293e677a8de4bacd843ef57192b60b DIFF:

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

This revision was automatically updated to reflect the committed changes. Closed by commit rG294ca122956f: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN (authored by augusto2112). Changed prior to commit: https://reviews.llvm.org/D143772?vs=496567=496643#toc Repository:

[Lldb-commits] [lldb] 294ca12 - Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

Author: Augusto Noronha Date: 2023-02-10T17:19:21-08:00 New Revision: 294ca122956f78aef3ab4e81108b69518e353b07 URL: https://github.com/llvm/llvm-project/commit/294ca122956f78aef3ab4e81108b69518e353b07 DIFF:

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. Does anybody have any further concerns or objections? I'd like to get this change in early next week if possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926

[Lldb-commits] [PATCH] D143687: [lldb] Add an SB API to get progress events as SBStructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ac8dfd0587a: [lldb] Add an SB API to get progress events as SBStructuredData (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 0ac8dfd - [lldb] Add an SB API to get progress events as SBStructuredData

Author: Jonas Devlieghere Date: 2023-02-10T17:18:00-08:00 New Revision: 0ac8dfd0587a1a95e8ed464bc59741837aae9c1f URL: https://github.com/llvm/llvm-project/commit/0ac8dfd0587a1a95e8ed464bc59741837aae9c1f DIFF:

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/source/Core/Debugger.cpp:838 +std::error_code ec = +llvm::sys::fs::copy_file(entry.first(), destination.GetPath()); +

[Lldb-commits] [PATCH] D143687: [lldb] Add an SB API to get progress events as SBStructuredData

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Thanks! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143687/new/ https://reviews.llvm.org/D143687 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D143792: [lldb] Fix image lookup crash

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143792/new/ https://reviews.llvm.org/D143792 ___

[Lldb-commits] [PATCH] D143792: [lldb] Fix image lookup crash

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. lldb may crash when performing `image lookup --verbose --address

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a subscriber: probinson. dblaikie added a comment. In D143501#4116200 , @Michael137 wrote: >> I'd recommend a possible long-term solution would be simplified template >> names (so we don't have to worry about encoding this in the

[Lldb-commits] [lldb] d2cc2c5 - Revert "[lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing"

Author: Michael Buch Date: 2023-02-10T23:02:57Z New Revision: d2cc2c5610ffa78736aa99512bc85a85417efb0a URL: https://github.com/llvm/llvm-project/commit/d2cc2c5610ffa78736aa99512bc85a85417efb0a DIFF: https://github.com/llvm/llvm-project/commit/d2cc2c5610ffa78736aa99512bc85a85417efb0a.diff LOG:

[Lldb-commits] [lldb] c46e15e - Revert "[lldb][Test] TestExternalCtorDtorLookup.py: skip on Windows and dwo"

Author: Michael Buch Date: 2023-02-10T23:02:50Z New Revision: c46e15e1dec9bb504f8a534b001cea553c7ab623 URL: https://github.com/llvm/llvm-project/commit/c46e15e1dec9bb504f8a534b001cea553c7ab623 DIFF: https://github.com/llvm/llvm-project/commit/c46e15e1dec9bb504f8a534b001cea553c7ab623.diff LOG:

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 added a comment. In D143652#4119484 , @MaskRay wrote: > This seems to cause many lldb failures > https://lab.llvm.org/buildbot/#/builders/68/builds/47790 Argh thanks for reporting, let me revert for now and try on my linux machine

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

MaskRay added a comment. This seems to cause many lldb failures https://lab.llvm.org/buildbot/#/builders/68/builds/47790 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143652/new/ https://reviews.llvm.org/D143652

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. In D143772#4119227 , @augusto2112 wrote: > "env -i " means only use the enviroments passed in that line (discard > everything else).

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

aprantl added a comment. > Why are only these two tests affected? Should this be something we set > globally for all the tests? The API tests already have support for forwarding > ASAN_OPTIONS and lit has a similar concept. We do, but only for dotest tests, and our dotest test launches another

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

aprantl added a comment. Generally LGTM, with one possible improvement inline! Comment at: lldb/test/API/api/multiple-debuggers/TestMultipleDebuggers.py:20 + # We need this in order to run under ASAN, in case only LLDB is ASANified. +

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

JDevlieghere updated this revision to Diff 496577. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. - update -> details - expose title and details separately in structured data CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143690/new/

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/DebuggerEvents.h:48-49 + } + const std::string () const { return m_title; } + const std::string () const { return m_update; } bool IsDebuggerSpecific()

[Lldb-commits] [PATCH] D143687: [lldb] Add an SB API to get progress events as SBStructuredData

JDevlieghere updated this revision to Diff 496575. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address @mib's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143687/new/ https://reviews.llvm.org/D143687 Files:

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

augusto2112 added a comment. In D143772#4119213 , @JDevlieghere wrote: > Why are only these two tests affected? Should this be something we set > globally for all the tests? The API tests already have support for forwarding > `ASAN_OPTIONS` and lit

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

JDevlieghere added a comment. Why are only these two tests affected? Should this be something we set globally for all the tests? The API tests already have support for forwarding `ASAN_OPTIONS` and lit has a similar concept. I can imagine why `TestMultipleSimultaneousDebuggers` would be

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

kastiglione accepted this revision. kastiglione added a comment. nice Comment at: lldb/include/lldb/Core/DebuggerEvents.h:48-49 + } + const std::string () const { return m_title; } + const std::string () const { return m_update; } bool IsDebuggerSpecific() const { return

[Lldb-commits] [PATCH] D143772: Adapt TestCustomShell and TestMultipleDebuggers to run under ASAN

augusto2112 created this revision. augusto2112 added reviewers: JDevlieghere, jingham, aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In situations where only LLDB is ASANified, a false

[Lldb-commits] [PATCH] D143690: [lldb] Add the ability to provide a message to a progress event update

bulbazord accepted this revision. bulbazord added a comment. Thanks for including the motivation in your summary, that made following this change a lot easier. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143690/new/ https://reviews.llvm.org/D143690

[Lldb-commits] [lldb] f889d6f - [lldb][Test] TestExternalCtorDtorLookup.py: skip on Windows and dwo

Author: Michael Buch Date: 2023-02-10T18:49:55Z New Revision: f889d6f9d05b2b1bd188ddf40b3d38a3488c212e URL: https://github.com/llvm/llvm-project/commit/f889d6f9d05b2b1bd188ddf40b3d38a3488c212e DIFF: https://github.com/llvm/llvm-project/commit/f889d6f9d05b2b1bd188ddf40b3d38a3488c212e.diff LOG:

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

jingham added a comment. A tiny quibble: GetThreadPointer seems like it should return a pointer to the thread that has this register set. I would not guess it's a pointer to the Thread's local storage. Maybe GetThreadLSPointer + a doc string saying what it does would clear this up?

[Lldb-commits] [lldb] b296ddd - [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Author: Michael Buch Date: 2023-02-10T17:22:02Z New Revision: b296ddd91cb8e7676b3c38ca7f6d7bdbd84eb4af URL: https://github.com/llvm/llvm-project/commit/b296ddd91cb8e7676b3c38ca7f6d7bdbd84eb4af DIFF: https://github.com/llvm/llvm-project/commit/b296ddd91cb8e7676b3c38ca7f6d7bdbd84eb4af.diff LOG:

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

This revision was automatically updated to reflect the committed changes. Closed by commit rGb296ddd91cb8: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

asi-sc added a comment. Similar fixes review: D141848 LLVM YAML parser improvement that depends on this: D140474 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143727/new/

[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

asi-sc created this revision. Herald added a project: All. asi-sc requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. YAML specification does not allow keys duplication an a mapping. However, YAML parser in LLVM does not have any check on that

[Lldb-commits] [PATCH] D143698: Support Debugging TLS variable with lldb

kkcode0 updated this revision to Diff 496392. kkcode0 added a comment. enabled the tls test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

This revision was automatically updated to reflect the committed changes. Closed by commit rGbaca3c150733: Move SIMD alignment calculation to LLVM Frontend (authored by domada). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/

[Lldb-commits] [lldb] baca3c1 - Move SIMD alignment calculation to LLVM Frontend

Author: Dominik Adamski Date: 2023-02-10T04:11:54-06:00 New Revision: baca3c150733c89686287ba4927c351eec9695e2 URL: https://github.com/llvm/llvm-project/commit/baca3c150733c89686287ba4927c351eec9695e2 DIFF:

[Lldb-commits] [lldb] d768bf9 - [NFC][TargetParser] Replace uses of llvm/Support/Host.h

Author: Archibald Elliott Date: 2023-02-10T09:59:46Z New Revision: d768bf994f508d7eaf9541a568be3d71096febf5 URL: https://github.com/llvm/llvm-project/commit/d768bf994f508d7eaf9541a568be3d71096febf5 DIFF: https://github.com/llvm/llvm-project/commit/d768bf994f508d7eaf9541a568be3d71096febf5.diff

[Lldb-commits] [PATCH] D143698: Cleanedup and added comments

kkcode0 updated this revision to Diff 496360. kkcode0 added a comment. rebased with main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143698/new/ https://reviews.llvm.org/D143698 Files: lldb/include/lldb/Host/common/NativeRegisterContext.h