[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

rupprecht accepted this revision. rupprecht added a comment. This revision is now accepted and ready to land. Thanks! This indeed fixes the issue I'm seeing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146668/new/

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

bulbazord added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:439 /// The section offset based address for this function. + /// \param[in] range + /// The symbol name this function should trampoline to. Comment

[Lldb-commits] [PATCH] D146679: [lldb] Add support for the DW_AT_trampoline attribute with mangled names

augusto2112 created this revision. augusto2112 added reviewers: aprantl, jingham, dblaikie. Herald added a reviewer: shafik. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds support

[Lldb-commits] [PATCH] D146152: Add __lldb_init_module_with_target for use when sourcing modules for a target

jingham added a comment. Polite review ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146152/new/ https://reviews.llvm.org/D146152 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord updated this revision to Diff 507546. bulbazord added a comment. Adding a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146668/new/ https://reviews.llvm.org/D146668 Files:

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord added a comment. Herald added a subscriber: JDevlieghere. With this patch: alex@ubuntu:~/llvm-project/build$ ./bin/lldb foo (lldb) target create "foo" Current executable set to '/home/alex/llvm-project/build/foo' (aarch64). (lldb) r Process 19623 launched:

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); bulbazord wrote: > rupprecht

[Lldb-commits] [PATCH] D146668: [lldb-server] Use Platform plugin corresponding to the host

bulbazord created this revision. bulbazord added a reviewer: rupprecht. Herald added a subscriber: krytarowski. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); rupprecht wrote: > bulbazord

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507528. ayermolo added a comment. updated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo updated this revision to Diff 507526. ayermolo added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. added test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

rupprecht added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); bulbazord wrote: > rupprecht

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

clayborg added a comment. Is there no test case catching this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146659/new/ https://reviews.llvm.org/D146659 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 4d18d97 - [lldb] Fix dwim-print error message for missing expr

Author: Dave Lee Date: 2023-03-22T14:25:32-07:00 New Revision: 4d18d97b594ccaa3cbd79beb4afef45e4156dc8d URL: https://github.com/llvm/llvm-project/commit/4d18d97b594ccaa3cbd79beb4afef45e4156dc8d DIFF: https://github.com/llvm/llvm-project/commit/4d18d97b594ccaa3cbd79beb4afef45e4156dc8d.diff

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); rupprecht wrote: > I think the

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

rupprecht added inline comments. Comment at: lldb/source/Target/UnixSignals.cpp:39 + // If we have no host platform, be resilient and use default UnixSignals. + if (!host_platform_sp) +s_unix_signals_sp = std::make_shared(); I think the divergence might be

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord added a comment. In D146263#4214336 , @rupprecht wrote: > This seems to cause a regression on Linux where we no longer get the signal > details. > > Given an intentionally-crashy test binary, such as: > > void crash() { > // Allocate

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

rupprecht added a comment. This seems to cause a regression on Linux where we no longer get the signal details. Given an intentionally-crashy test binary, such as: void crash() { // Allocate valid but non-accessible memory and attempt to write to it, // triggering a Segmentation

[Lldb-commits] [PATCH] D146659: [LLDB] Fix for D139955 Summary:

ayermolo created this revision. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixing a small typo. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

manas added a comment. Hi, I came across this due to changes in Static Analyzer. One of the changes is not related to the Github issue mentioned above. Maybe we can drop that file? Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1214-1215

Re: [Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

That general facility is why we think of plugins as something more than just implementations. Along with the "on load" actions, they also have the job of detecting "Am I the right implementation for this binary, this language, this OS version, etc". That also informs the proper way to use

Re: [Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

David, I think you were also thinking about things like the `language cplusplus` commands or the `settings set plugin.***` settings. That isn't a case of generic code depending on specific plugin implementations. Rather that's a general feature of the plugin loader, it queries the plugin to

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG984354fbbe4e: [lldb] Update some uses of Python2 API in typemaps. (authored by jgorbe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 984354f - [lldb] Update some uses of Python2 API in typemaps.

Author: Jorge Gorbe Moya Date: 2023-03-22T11:28:52-07:00 New Revision: 984354fbbe4e207798f6d83c6f46b7603952dd36 URL: https://github.com/llvm/llvm-project/commit/984354fbbe4e207798f6d83c6f46b7603952dd36 DIFF:

[Lldb-commits] [PATCH] D146590: [lldb] Update some uses of Python2 API in typemaps.

jgorbe updated this revision to Diff 507442. jgorbe added a comment. Modified one of the existing test cases for `SBData.SetDataFromUInt64Array` to add a 2**63 to actually exercise the uint64 range. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146590/new/

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

This revision was automatically updated to reflect the committed changes. Closed by commit rG16b7cf245ec0: SymbolFile: ensure that we have a value before invoking `getBitWidth` (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 16b7cf2 - SymbolFile: ensure that we have a value before invoking `getBitWidth`

Author: Saleem Abdulrasool Date: 2023-03-22T14:14:13-04:00 New Revision: 16b7cf245ec0ff5428daee4f71af62e1938bfc73 URL: https://github.com/llvm/llvm-project/commit/16b7cf245ec0ff5428daee4f71af62e1938bfc73 DIFF:

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

aheejin added a comment. Thanks for the investigation! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145181/new/ https://reviews.llvm.org/D145181 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D145181: Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4125a37806a: Revert Remove the LINK_COMPONENTS entry from lldb-instr CMakery (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] c4125a3 - Revert "Remove the LINK_COMPONENTS entry from lldb-instr CMakery"

Author: Heejin Ahn Date: 2023-03-22T10:54:04-07:00 New Revision: c4125a37806aa2f663018f4f8dc5bbd5159c51c1 URL: https://github.com/llvm/llvm-project/commit/c4125a37806aa2f663018f4f8dc5bbd5159c51c1 DIFF: https://github.com/llvm/llvm-project/commit/c4125a37806aa2f663018f4f8dc5bbd5159c51c1.diff

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

bulbazord added inline comments. Comment at: lldb/source/Commands/CommandObjectRegister.cpp:229 +if (!DumpRegister(m_exe_ctx, strm, reg_ctx, reg_info, + /*print_flags=*/true, type_system)) strm.Printf("%-12s = error:

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

bulbazord added a comment. In D146553#4212417 , @DavidSpickett wrote: > Is this policy documented anywhere? Perhaps you can update one of the design > pages if it isn't already there. > > Because I am a bit confused about it. Some parts of lldb use

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

aprantl added inline comments. Comment at: lldb/source/Core/DumpRegisterValue.cpp:136-137 + // See if we have made this type before and can reuse it. + CompilerType fields_type = ast->GetTypeForIdentifier( + ConstString(register_type_name.c_str())); +

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added inline comments. Comment at: lldb/source/Commands/CommandObjectRegister.cpp:229 +if (!DumpRegister(m_exe_ctx, strm, reg_ctx, reg_info, + /*print_flags=*/true, type_system)) strm.Printf("%-12s = error:

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added inline comments. Comment at: lldb/source/Core/DumpRegisterValue.cpp:136-137 + // See if we have made this type before and can reuse it. + CompilerType fields_type = ast->GetTypeForIdentifier( + ConstString(register_type_name.c_str())); +

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

aprantl added inline comments. Comment at: lldb/source/Commands/CommandObjectRegister.cpp:229 +if (!DumpRegister(m_exe_ctx, strm, reg_ctx, reg_info, + /*print_flags=*/true, type_system)) strm.Printf("%-12s = error:

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

aprantl added inline comments. Comment at: lldb/source/Core/DumpRegisterValue.cpp:136-137 + // See if we have made this type before and can reuse it. + CompilerType fields_type = ast->GetTypeForIdentifier( + ConstString(register_type_name.c_str())); +

[Lldb-commits] [PATCH] D146041: Fix weirdly apologetic diagnostic messages

ipriyanshi1708 added a comment. Hi @AryanGodara , I am an Outreachy applicant. I was also working on this issue and also created a patch for this issue i.e., https://reviews.llvm.org/D146530 . Can we collaborate to solve this issue so that only one patch will be there for a issue as told by

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

sgraenitz accepted this revision. sgraenitz added a comment. This revision is now accepted and ready to land. Perfect, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146536/new/ https://reviews.llvm.org/D146536

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

compnerd updated this revision to Diff 507330. compnerd added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146536/new/

[Lldb-commits] [PATCH] D146536: SymbolFile: ensure that we have a value before invoking `getBitWidth`

compnerd added a comment. In D146536#4210062 , @sgraenitz wrote: > Thanks for tackling this! Yes, I hit it as well during development and > wondered what is the right thing to do. The effect of the proposed change > will be log messages like this

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb78886246da: [lldb] Add test for unavailable registers (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145940/new/

[Lldb-commits] [lldb] eb78886 - [lldb] Add test for unavailable registers

Author: David Spickett Date: 2023-03-22T09:42:21Z New Revision: eb78886246da610bd78e4a8be82d3b820e12ee2b URL: https://github.com/llvm/llvm-project/commit/eb78886246da610bd78e4a8be82d3b820e12ee2b DIFF: https://github.com/llvm/llvm-project/commit/eb78886246da610bd78e4a8be82d3b820e12ee2b.diff

[Lldb-commits] [PATCH] D145940: [lldb] Add test for unavailable registers

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/TestRegistersUnavailable.py:43-53 +self.expect("register read --all", patterns=[ +"(?sm)^general purpose registers:\n" +

[Lldb-commits] [PATCH] D146553: [lldb][CMake] Enforce not linking against plugin libs in core libs

DavidSpickett added a comment. Is this policy documented anywhere? Perhaps you can update one of the design pages if it isn't already there. Because I am a bit confused about it. Some parts of lldb use plugins and those parts are called by commands through a few other layers. However commands

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 507272. kpdev42 added a comment. Update patch after landing D145057 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files:

[Lldb-commits] [PATCH] D145580: [lldb] Show register fields using bitfield struct types

DavidSpickett added inline comments. Comment at: lldb/source/Core/DumpRegisterValue.cpp:136-137 + // See if we have made this type before and can reuse it. + CompilerType fields_type = ast->GetTypeForIdentifier( + ConstString(register_type_name.c_str())); +