[Lldb-commits] [PATCH] D147841: [lldb][NFC] Update syntax description for language cplusplus demangle

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, Michael137, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Also added some tests because this is completely

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

jasonmolenda added a comment. In D147833#4252681 , @bulbazord wrote: > In D147833#4252651 , @jasonmolenda > wrote: > >> Am I missing something, how does this work when we have uses like >>

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

bulbazord added a comment. In D147833#4252651 , @jasonmolenda wrote: > Am I missing something, how does this work when we have uses like > `event_data->GetFlavor() == TargetEventData::GetFlavorString()` - is this > changing from a one-time

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

jasonmolenda added a comment. Am I missing something, how does this work when we have uses like `event_data->GetFlavor() == TargetEventData::GetFlavorString()` - is this changing from a one-time construction of a ConstString to a construction of a ConstString every time it's called by implicit

[Lldb-commits] [PATCH] D147833: [lldb] Change return type of EventData::GetFlavor

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, labath, jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's no reason these strings need to be

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

rupprecht added a reviewer: rupprecht. rupprecht added a comment. The `pid` plumbing looks fine for the happy case, but I think we could be more lenient if (for whatever reason) the pid flag isn't being set on non-Linux systems that won't actually be using it. Even on a Linux system, this is

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe created this revision. jgorbe added reviewers: clayborg, wallace, labath, rupprecht. jgorbe added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jgorbe requested review of this revision. This is an optional request, but supporting it makes the

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

jasonmolenda added a comment. Thanks Omair! Yeah we have the same problem on Darwin - AArch64 doesn't require that the address we get on a watchpoint trap in the FAR register point within the address range we are watching. I never fixed this on Darwin so I know the failure mode - lldb says

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

omjavaid added a comment. I agree that silent continue was wrong and should be fixed. I tried for to remember what I was trying to do when I wrote that patch ... still dont remember much but digged out some information that may be useful for this patch review. We had a bunch of funny behaving

[Lldb-commits] [PATCH] D147674: Interpret ESR/FAR bits directly on watchpoint exceptions in debugserver, clarify how watchpoint descriptions in stop packets work

omjavaid added a comment. I agree that silent continue was wrong and should be fixed. I tried for to remember what I was trying to do when I wrote that patch ... still dont remember much but digged out some information that may be useful for this patch review. We had a bunch of funny

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

augusto2112 added inline comments. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441 + /// associated with that compilation unit. + std::unordered_map GetCompileOptions() { +std::unordered_map args; JDevlieghere wrote: > Any reason you picked

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::GetCompileOptions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with or without the DenseMap, whichever makes the most sense. Comment at: lldb/include/lldb/Symbol/SymbolFile.h:441 + /// associated with that compilation

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe updated this revision to Diff 511818. jgorbe added a comment. Added a `--debugger-pid` flag that needs to be passed with `--launch-target` so that we can restrict `PR_SET_PTRACER` to the main lldb-vscode instance instead of using `PR_SET_PTRACER_ANY`. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 updated this revision to Diff 511815. augusto2112 marked an inline comment as done. augusto2112 added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Changed implementation to GetCompileOptions Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D147674: Interpret ESR/FAR bits directly on watchpoint exceptions in debugserver, clarify how watchpoint descriptions in stop packets work

jasonmolenda abandoned this revision. jasonmolenda added a comment. Intermixing generic/linux AArch64 lldb watchpoint StopInfo changes in with a change to debugserver made this a difficult patch to ask anyone to review in total. I've separated it into one phab for the lldb watchpoint StopInfo

[Lldb-commits] [PATCH] D147820: debugserver: move AArch64 watchpoint traps within a watchpointed region, parse ESR flags and send them to lldb

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added subscribers: omjavaid, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

kastiglione added inline comments. Comment at: lldb/examples/python/crashlog.py:669 + r'(0x[0-9a-fA-F]{4,}) +' # addr (4 chars or more) + r'((.*)(?:(?: +\+ +)([0-9]+))|[^\s]+)' # symbol + offset

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

jasonmolenda created this revision. jasonmolenda added reviewers: labath, omjavaid, DavidSpickett. jasonmolenda added a project: LLDB. Herald added subscribers: JDevlieghere, atanasyan, kristof.beyls, arichardson, sdardis. Herald added a project: All. jasonmolenda requested review of this

[Lldb-commits] [PATCH] D146765: [lldb/crashlog] Load inlined symbol into interactive crashlog

mib updated this revision to Diff 511805. mib marked 7 inline comments as done and an inline comment as not done. mib added a comment. Address some of the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146765/new/ https://reviews.llvm.org/D146765 Files:

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

wallace added a comment. wow, nice improvement. I don't have anything else to add besides what @rupprecht said Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147805/new/ https://reviews.llvm.org/D147805

[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

This revision was automatically updated to reflect the committed changes. Closed by commit rGde5f96e99aed: [lldb] Add unittests for a few FileSpec methods (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147801/new/

[Lldb-commits] [lldb] de5f96e - [lldb] Add unittests for a few FileSpec methods

Author: Alex Langford Date: 2023-04-07T13:50:27-07:00 New Revision: de5f96e99aedd641cc0bbb9ae4a156db4ae3c4c4 URL: https://github.com/llvm/llvm-project/commit/de5f96e99aedd641cc0bbb9ae4a156db4ae3c4c4 DIFF: https://github.com/llvm/llvm-project/commit/de5f96e99aedd641cc0bbb9ae4a156db4ae3c4c4.diff

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

rupprecht added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:3158 +#if defined(__linux__) + (void)prctl(PR_SET_PTRACER, PR_SET_PTRACER_ANY, 0, 0, 0); +#endif https://manpages.debian.org/bullseye/manpages-dev/prctl.2.en.html#PR_SET_PTRACER

[Lldb-commits] [PATCH] D147805: [lldb-vscode] Fix two issues with runInTerminal test.

jgorbe created this revision. jgorbe added reviewers: clayborg, wallace. jgorbe added a project: LLDB. Herald added subscribers: JDevlieghere, krytarowski. Herald added a project: All. jgorbe requested review of this revision. With ptrace_scope = 1 the kernel only allows tracing descendants of a

[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

mib accepted this revision. mib added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:330 /// filename has no extension, ConstString(nullptr) is returned. The dot - /// ('.') character is not returned as part of the extension + /// ('.') character is the

[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147801/new/ https://reviews.llvm.org/D147801

[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:330 /// filename has no extension, ConstString(nullptr) is returned. The dot - /// ('.') character is not returned as part of the extension + /// ('.') character is the first character in

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

JDevlieghere added a comment. Jim asked me to land this on his behalf as he's OOO. I've addressed my own comments :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147753/new/ https://reviews.llvm.org/D147753

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

This revision was automatically updated to reflect the committed changes. Closed by commit rG730c8e160c9d: [lldb] Move SelectMostRelevantFrame from Thread::WillStop (authored by jingham, committed by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D147753?vs=511579=511768#toc

[Lldb-commits] [lldb] 730c8e1 - [lldb] Move "SelectMostRelevantFrame" from Thread::WillStop

Author: Jim Ingham Date: 2023-04-07T12:21:00-07:00 New Revision: 730c8e160c9dead94ba534d5ad7cc8e47ce892db URL: https://github.com/llvm/llvm-project/commit/730c8e160c9dead94ba534d5ad7cc8e47ce892db DIFF: https://github.com/llvm/llvm-project/commit/730c8e160c9dead94ba534d5ad7cc8e47ce892db.diff

[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

mib added inline comments. Comment at: lldb/include/lldb/Utility/FileSpec.h:330 /// filename has no extension, ConstString(nullptr) is returned. The dot - /// ('.') character is not returned as part of the extension + /// ('.') character is the first character in the

[Lldb-commits] [PATCH] D147801: [lldb] Add unittests for a few FileSpec methods

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, clayborg. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds tests for: -

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. This makes sense to me. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147753/new/ https://reviews.llvm.org/D147753

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

augusto2112 added a comment. In D147748#4251543 , @JDevlieghere wrote: > At a higher level I wonder if this is really the best interface. If you ever > need all the compile options, you probably want something like `Args >

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

JDevlieghere added a comment. (adding myself as a reviewer so this shows up in my review queue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147748/new/ https://reviews.llvm.org/D147748 ___

[Lldb-commits] [PATCH] D147748: [lldb] Implement SymbolFile::ContainsCompileOption

JDevlieghere added a comment. At a higher level I wonder if this is really the best interface. If you ever need all the compile options, you probably want something like `Args SymbolFile::GetCompileOptions()`. Wouldn't that be a more generic way to do the same thing here? Or do we expect that

[Lldb-commits] [PATCH] D147669: PECOFF: consume errors properly

compnerd updated this revision to Diff 511706. compnerd retitled this revision from "PECOFF: enforce move semantics and consume errors properly" to "PECOFF: consume errors properly". compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147669/new/

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

compnerd added a comment. In D147669#4251441 , @compnerd wrote: > In D147669#4249968 , @sgraenitz > wrote: > >> First of all, yes the existing code is incorrect. Thanks for looking into >> this. However, I am

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

compnerd added a comment. In D147669#4249968 , @sgraenitz wrote: > First of all, yes the existing code is incorrect. Thanks for looking into > this. However, I am afraid this isn't the right solution. > You probably mean

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { +

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1483 +// base with all fields having [[no_unique_address]] attribute. +for (auto it = base_classes.rbegin(); it != base_classes.rend(); ++it) { +

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

kpdev42 updated this revision to Diff 511683. kpdev42 edited the summary of this revision. kpdev42 added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143347/new/ https://reviews.llvm.org/D143347 Files:

[Lldb-commits] [PATCH] D147669: PECOFF: enforce move semantics and consume errors properly

alvinhochun added a comment. Thanks for adding me in the loop. And thanks for looking into the fix, though this bit is a bit confusing to me: > Ensure that we explicitly indicate that we would like the move semantics > in the assignment. With MSVC 14.35.32215, the assignment would not > trigger

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

JDevlieghere added inline comments. Comment at: lldb/source/Target/StackFrameList.cpp:823 +SelectMostRelevantFrame(); +m_selected_frame_set = true; + } jingham wrote: > JDevlieghere wrote: > > IIUC `SetSelectedFrame` always sets `m_selected_frame_set`

[Lldb-commits] [PATCH] D147753: Move "SelectMostRelevantFrame" from Thread::WillStop

jingham added inline comments. Comment at: lldb/include/lldb/Target/StackFrameList.h:139-144 /// The currently selected frame. uint32_t m_selected_frame_idx; + // Records whether anyone has set the selected frame on this stack yet. + // We only let recognizers change the