[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

MaskRay added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string ) { + if (!MangledName) +return false; Why is this change? The original contract is that `MangledName` must be

[Lldb-commits] [PATCH] D151966: [lldb] Default can_create to true in GetChildMemberWithName (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, bulbazord. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It turns out all existing callers of `GetChildMemberWithName` pass

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG00e52cc4a8cc: [lldb] Take StringRef names in GetChildAtNamePath (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151813/new/

[Lldb-commits] [lldb] 00e52cc - [lldb] Take StringRef names in GetChildAtNamePath (NFC)

Author: Dave Lee Date: 2023-06-01T20:42:29-07:00 New Revision: 00e52cc4a8cc06cfafe787caea686810ac6c37ac URL: https://github.com/llvm/llvm-project/commit/00e52cc4a8cc06cfafe787caea686810ac6c37ac DIFF: https://github.com/llvm/llvm-project/commit/00e52cc4a8cc06cfafe787caea686810ac6c37ac.diff

[Lldb-commits] [PATCH] D151813: [lldb] Take StringRef names in GetChildAtNamePath (NFC)

kastiglione updated this revision to Diff 527715. kastiglione added a comment. Change auto to StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151813/new/ https://reviews.llvm.org/D151813 Files: lldb/include/lldb/Core/ValueObject.h

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dae706259da: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 5dae706 - [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

Author: Dave Lee Date: 2023-06-01T20:24:01-07:00 New Revision: 5dae706259da2ef8d51439e29a8764461da63cf7 URL: https://github.com/llvm/llvm-project/commit/5dae706259da2ef8d51439e29a8764461da63cf7 DIFF: https://github.com/llvm/llvm-project/commit/5dae706259da2ef8d51439e29a8764461da63cf7.diff

[Lldb-commits] [PATCH] D151811: [lldb] Take StringRef name in GetIndexOfChildWithName (NFC)

kastiglione added inline comments. Comment at: lldb/source/Core/ValueObjectSyntheticFilter.cpp:338 if (!did_find && m_synth_filter_up != nullptr) { uint32_t index = m_synth_filter_up->GetIndexOfChildWithName(name); if (index == UINT32_MAX)

[Lldb-commits] [lldb] df1bb2e - Restrict the test from 22667e3220de5ead353a2148265d841644b63824

Author: Jim Ingham Date: 2023-06-01T18:45:45-07:00 New Revision: df1bb2e65bf4b2ca1140f4c9d19ff2a36ab94e6e URL: https://github.com/llvm/llvm-project/commit/df1bb2e65bf4b2ca1140f4c9d19ff2a36ab94e6e DIFF: https://github.com/llvm/llvm-project/commit/df1bb2e65bf4b2ca1140f4c9d19ff2a36ab94e6e.diff

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. LGTM. It also works with the mojo REPL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151962/new/ https://reviews.llvm.org/D151962

[Lldb-commits] [PATCH] D151962: [lldb][NFCI] Change return type of REPL::GetSourceFileBasename

bulbazord created this revision. bulbazord added reviewers: wallace, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These don't really need to be in the ConstString StringPool. I've

[Lldb-commits] [PATCH] D151960: [lldb][NFCI] Change the way Process stores StructuredData plugins

bulbazord created this revision. bulbazord added reviewers: jingham, mib, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Instead of having a map from ConstString to

[Lldb-commits] [lldb] 78ecb42 - [lldb/crashlog] Add test for non-symbolicated report crash

Author: Med Ismail Bennani Date: 2023-06-01T17:50:55-07:00 New Revision: 78ecb428d564d618d785a85743528c2f14397bbf URL: https://github.com/llvm/llvm-project/commit/78ecb428d564d618d785a85743528c2f14397bbf DIFF:

[Lldb-commits] [lldb] 0b08026 - [lldb/crashlog] Run python formatter (nfc)

Author: Med Ismail Bennani Date: 2023-06-01T17:13:16-07:00 New Revision: 0b080260541dc7942500092b300aee6901647056 URL: https://github.com/llvm/llvm-project/commit/0b080260541dc7942500092b300aee6901647056 DIFF:

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

bulbazord added a comment. LGTM modulo typo Comment at: lldb/examples/python/crashlog.py:1374 +if not arch: +raise InteractiveCrashLogException("couldn't create find the architecture to create the target") +target =

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG032d91cb2fb5: [lldb/crashlog] Create interactive crashlog with no binary (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 032d91c - [lldb/crashlog] Create interactive crashlog with no binary

Author: Med Ismail Bennani Date: 2023-06-01T17:10:57-07:00 New Revision: 032d91cb2fb539a541f24558a8c61a40b1577dfd URL: https://github.com/llvm/llvm-project/commit/032d91cb2fb539a541f24558a8c61a40b1577dfd DIFF:

[Lldb-commits] [PATCH] D151844: [lldb/crashlog] Fix crash when loading non-symbolicated report

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a6c03c448b: [lldb/crashlog] Fix crash when loading non-symbolicated report (authored by mib). Changed prior to commit: https://reviews.llvm.org/D151844?vs=527212=527673#toc Repository: rG LLVM

[Lldb-commits] [lldb] a5a6c03 - [lldb/crashlog] Fix crash when loading non-symbolicated report

Author: Med Ismail Bennani Date: 2023-06-01T17:10:57-07:00 New Revision: a5a6c03c448ba1ab404b58673eef1f7b68498dff URL: https://github.com/llvm/llvm-project/commit/a5a6c03c448ba1ab404b58673eef1f7b68498dff DIFF:

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

mib updated this revision to Diff 527672. mib marked 2 inline comments as done. mib added a comment. Address @bulbazord last comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151849/new/ https://reviews.llvm.org/D151849 Files: lldb/examples/python/crashlog.py

[Lldb-commits] [PATCH] D151951: [lldb][NFCI] Change return type of Properties::GetExperimentalSettingsName

bulbazord created this revision. bulbazord added reviewers: jingham, jasonmolenda, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Most users of this stick it into a StringRef. The one user that

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 updated this revision to Diff 527670. augusto2112 added a comment. Herald added a subscriber: JDevlieghere. Add radar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151950/new/ https://reviews.llvm.org/D151950 Files:

[Lldb-commits] [PATCH] D151950: [lldb] Unconditionally increment depth when printing children

augusto2112 created this revision. augusto2112 added reviewers: kastiglione, aprantl, DavidSpickett. Herald added a project: All. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `target.max-children-depth` setting and

[Lldb-commits] [PATCH] D151949: [lldb][NFCI] Use size_t in OptionValueProperties

bulbazord created this revision. bulbazord added reviewers: jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In many places we're using uint32_t where we should be using size_t. We should

[Lldb-commits] [PATCH] D151940: Fix regex & startsWith name lookup in SBTarget::FindGlobalVariables

This revision was automatically updated to reflect the committed changes. Closed by commit rG22667e3220de: Fix regex startsWith name lookup in SBTarget::FindGlobalVariables (authored by jingham). Changed prior to commit: https://reviews.llvm.org/D151940?vs=527606=527657#toc Repository: rG

[Lldb-commits] [lldb] 22667e3 - Fix regex & startsWith name lookup in SBTarget::FindGlobalVariables

Author: Jim Ingham Date: 2023-06-01T16:15:06-07:00 New Revision: 22667e3220de5ead353a2148265d841644b63824 URL: https://github.com/llvm/llvm-project/commit/22667e3220de5ead353a2148265d841644b63824 DIFF: https://github.com/llvm/llvm-project/commit/22667e3220de5ead353a2148265d841644b63824.diff

[Lldb-commits] [PATCH] D151940: Fix regex & startsWith name lookup in SBTarget::FindGlobalVariables

mib accepted this revision. mib added a comment. LGTM! Comment at: lldb/test/API/lang/cpp/class_static/TestStaticVariables.py:182 self.DebugSBValue(val) -self.assertEqual(val.GetName(), "A::g_points") +value_check_A.check_value(self, val, "FiindValue

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:889 +"Package unit with a non-zero abbreviation offset"); + + auto *unit_contrib = index_entry->getContribution(); aprantl wrote: > I know this was also in

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:889 +"Package unit with a non-zero abbreviation offset"); + + auto *unit_contrib =

[Lldb-commits] [PATCH] D151940: Fix regex & startsWith name lookup in SBTarget::FindGlobalVariables

jingham created this revision. jingham added reviewers: aprantl, jasonmolenda, mib, JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There were two bugs here. 1. eMatchTypeStartsWith

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

bulbazord added a comment. I feel a little strange about having `SBTarget::SetLabel` give a label to a target that is anything other than what the user specified. In the test, you attempt to name 2 targets `cat`. The first one succeeds, the second one also succeeds but names it `cat 2` (where

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set a label to targets

mib updated this revision to Diff 527580. mib marked an inline comment as done. mib retitled this revision from "[lldb/Target] Add ability to set name to targets" to "[lldb/Target] Add ability to set a label to targets". mib edited the summary of this revision. mib added a comment. Address

[Lldb-commits] [PATCH] D151859: [lldb/Target] Add ability to set name to targets

mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:546-551 +if (!name.empty()) { + if (name == target_idx_arg) { +target_idx = i; +break; +

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

mib updated this revision to Diff 527576. mib added a comment. Reload the previous version of this diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151849/new/ https://reviews.llvm.org/D151849 Files: lldb/examples/python/crashlog.py lldb/source/Target/Process.cpp Index:

[Lldb-commits] [PATCH] D151849: [lldb/crashlog] Create interactive crashlog with no binary

mib updated this revision to Diff 527575. mib marked an inline comment as done. mib added a subscriber: jingham. mib added a comment. Address @bulbazord & @jingham's comments: - Rename name -> label - Add test - Add sanity check to avoid having integer only labels - Add target index when label

[Lldb-commits] [PATCH] D151919: [lldb][NFCI] Apply IndexEntry to DWARFUnitHeader outside of extraction

bulbazord created this revision. bulbazord added reviewers: aprantl, fdeazeve, rastogishubham, JDevlieghere. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I plan

[Lldb-commits] [PATCH] D151843: Add EXC_SYSCALL to the allowable ignored exceptions for Darwin

mib added a comment. LGTM! Sorry I didn't look at this earlier... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151843/new/ https://reviews.llvm.org/D151843 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527514. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 Files: lldb/source/Core/Mangled.cpp

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527507. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - update comments as per @Maskray Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527502. nickdesaulniers added a comment. - rebase, reformat for presubmit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files:

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. needs rebasing for presubmit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003

[Lldb-commits] [PATCH] D151861: Don't emit a bunch of spurious "Unknown platform 0" warnings from debugserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG267a4cda8248: Prevent some spurious error messages in the debugserver logs. (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151861/new/

[Lldb-commits] [lldb] 267a4cd - Prevent some spurious error messages in the debugserver logs.

Author: Jim Ingham Date: 2023-06-01T10:21:23-07:00 New Revision: 267a4cda82481da159492bc6d6597d11101f8abb URL: https://github.com/llvm/llvm-project/commit/267a4cda82481da159492bc6d6597d11101f8abb DIFF: https://github.com/llvm/llvm-project/commit/267a4cda82481da159492bc6d6597d11101f8abb.diff

[Lldb-commits] [PATCH] D151843: Add EXC_SYSCALL to the allowable ignored exceptions for Darwin

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG620dc1224ff9: Add EXC_SYSCALL to the set of ignorable mach exceptions. (authored by jingham). Repository: rG LLVM

[Lldb-commits] [lldb] 620dc12 - Add EXC_SYSCALL to the set of ignorable mach exceptions.

Author: Jim Ingham Date: 2023-06-01T10:20:47-07:00 New Revision: 620dc1224ff9e4cb86e6e4d8e7c3941fc921887d URL: https://github.com/llvm/llvm-project/commit/620dc1224ff9e4cb86e6e4d8e7c3941fc921887d DIFF: https://github.com/llvm/llvm-project/commit/620dc1224ff9e4cb86e6e4d8e7c3941fc921887d.diff

[Lldb-commits] [PATCH] D151516: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

This revision was automatically updated to reflect the committed changes. Closed by commit rGab27431596c4: [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] ab27431 - [lldb][NFCI] Remove use of ConstString from UnixSignals::SignalCode

Author: Alex Langford Date: 2023-06-01T10:03:56-07:00 New Revision: ab27431596c4f61f84ce41e27aad09a4dde3fc5a URL: https://github.com/llvm/llvm-project/commit/ab27431596c4f61f84ce41e27aad09a4dde3fc5a DIFF: https://github.com/llvm/llvm-project/commit/ab27431596c4f61f84ce41e27aad09a4dde3fc5a.diff