[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

2023-08-24 Thread Jonas Devlieghere via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7bd632895816: [lldb-vscode] Update package.json (authored by 
JDevlieghere).
Herald added a project: LLDB.

Changed prior to commit:
  https://reviews.llvm.org/D158801?vs=553320=553363#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158801/new/

https://reviews.llvm.org/D158801

Files:
  lldb/tools/lldb-vscode/package.json

Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -1,26 +1,30 @@
 {
 	"name": "lldb-vscode",
-	"displayName": "LLDB native Debug stub",
+	"displayName": "LLDB VSCode",
 	"version": "0.1.0",
 	"publisher": "llvm",
-	"repository": "llvm.org",
-	"description": "Debug adapter for LLDB which uses a C++ tool to interface directly with LLDB.",
-	"author": {
-		"name": "Greg Clayton",
-		"email": "clayb...@gmail.com"
+	"homepage": "https://lldb.llvm.org;,
+	"description": "LLDB debugging from VSCode",
+	"license": "Apache 2.0 License with LLVM exceptions",
+	"repository": {
+		"type": "git",
+		"url": "https://github.com/llvm/llvm-project.git;
+	},
+	"bugs": {
+		"url": "https://github.com/llvm/llvm-project/issues;
 	},
-	"license": "LLVM",
 	"keywords": [
-		"multi-root ready"
+		"C",
+		"C++",
+		"LLVM",
+		"LLDB"
 	],
 	"engines": {
-		"vscode": "^1.18.0",
-		"node": "^7.9.0"
+		"vscode": "^1.18.0"
 	},
 	"categories": [
 		"Debuggers"
 	],
-	"private": true,
 	"devDependencies": {
 		"@types/node": "7.0.43",
 		"@types/mocha": "2.2.45",
@@ -34,69 +38,69 @@
 	"contributes": {
 		"languages": [
 			{
-"id": "lldb.disassembly",
-"aliases": [
-"Disassembly"
-],
-"extensions": [
-".disasm"
-]
+"id": "lldb.disassembly",
+"aliases": [
+	"Disassembly"
+],
+"extensions": [
+	".disasm"
+]
 			}
 		],
 		"grammars": [
 			{
-"language": "lldb.disassembly",
-"scopeName": "source.disassembly",
-"path": "./syntaxes/disassembly.json"
-}
-],
-"breakpoints": [
-  {
-"language": "ada"
-  },
-  {
-"language": "arm"
-  },
-  {
-"language": "asm"
-  },
-  {
-"language": "c"
-  },
-  {
-"language": "cpp"
-  },
-  {
-"language": "crystal"
-  },
-  {
-"language": "d"
-  },
-  {
-"language": "fortan"
-  },
-  {
-"language": "fortran-modern"
-  },
-  {
-"language": "nim"
-  },
-  {
-"language": "objective-c"
-  },
-  {
-"language": "objectpascal"
-  },
-  {
-"language": "pascal"
-  },
-  {
-"language": "rust"
-  },
-  {
-"language": "swift"
-  }
-],
+"language": "lldb.disassembly",
+"scopeName": "source.disassembly",
+"path": "./syntaxes/disassembly.json"
+			}
+		],
+		"breakpoints": [
+			{
+"language": "ada"
+			},
+			{
+"language": "arm"
+			},
+			{
+"language": "asm"
+			},
+			{
+"language": "c"
+			},
+			{
+"language": "cpp"
+			},
+			{
+"language": "crystal"
+			},
+			{
+"language": "d"
+			},
+			{
+"language": "fortan"
+			},
+			{
+"language": "fortran-modern"
+			},
+			{
+"language": "nim"
+			},
+			{
+"language": "objective-c"
+			},
+			{
+"language": "objectpascal"
+			},
+			{
+"language": "pascal"
+			},
+			{
+"language": "rust"
+			},
+			{
+"language": "swift"
+			}
+		],
 		"debuggers": [
 			{
 "type": "lldb-vscode",
@@ -149,7 +153,7 @@
 			},
 			"env": {
 "type": "array",
-"description": "Additional environment variables to set when launching the program. This is an array of strings that contains the variable name followed by an optional '=' character and the environment variable's value. Example:  [\"FOO=BAR\", \"BAZ\"]",
+"description": "Additional environment variables to set when launching the program. This is an array of strings that contains the variable name followed by an optional '=' character and the environment variable's value.",
 "default": []
 			},
 			"stopOnEntry": {
@@ -183,12 +187,12 @@
 			},
 			"sourceMap": {
 "type": "array",
-"description": "Specify an array of path remappings; each element must itself be a two element array containing a source and destination pathname. Overrides sourcePath.",
+"description": "Specify an array of path remappings; each element must itself be a two element array

[Lldb-commits] [lldb] 7bd6328 - [lldb-vscode] Update package.json

2023-08-24 Thread Jonas Devlieghere via lldb-commits 

Author: Jonas Devlieghere
Date: 2023-08-24T22:36:53-07:00
New Revision: 7bd632895816206a9f868019124ebb190e4a65c1

URL: 
https://github.com/llvm/llvm-project/commit/7bd632895816206a9f868019124ebb190e4a65c1
DIFF: 
https://github.com/llvm/llvm-project/commit/7bd632895816206a9f868019124ebb190e4a65c1.diff

LOG: [lldb-vscode] Update package.json

 - Update license, display name, repository and keywords
 - Add homepage, issue page
 - Fix formatting and typos

Differential revision: https://reviews.llvm.org/D158801

Added: 


Modified: 
lldb/tools/lldb-vscode/package.json

Removed: 




diff  --git a/lldb/tools/lldb-vscode/package.json 
b/lldb/tools/lldb-vscode/package.json
index c5d7f2445619d6..cc6df03097a70e 100644
--- a/lldb/tools/lldb-vscode/package.json
+++ b/lldb/tools/lldb-vscode/package.json
@@ -1,26 +1,30 @@
 {
"name": "lldb-vscode",
-   "displayName": "LLDB native Debug stub",
+   "displayName": "LLDB VSCode",
"version": "0.1.0",
"publisher": "llvm",
-   "repository": "llvm.org",
-   "description": "Debug adapter for LLDB which uses a C++ tool to 
interface directly with LLDB.",
-   "author": {
-   "name": "Greg Clayton",
-   "email": "clayb...@gmail.com"
+   "homepage": "https://lldb.llvm.org;,
+   "description": "LLDB debugging from VSCode",
+   "license": "Apache 2.0 License with LLVM exceptions",
+   "repository": {
+   "type": "git",
+   "url": "https://github.com/llvm/llvm-project.git;
+   },
+   "bugs": {
+   "url": "https://github.com/llvm/llvm-project/issues;
},
-   "license": "LLVM",
"keywords": [
-   "multi-root ready"
+   "C",
+   "C++",
+   "LLVM",
+   "LLDB"
],
"engines": {
-   "vscode": "^1.18.0",
-   "node": "^7.9.0"
+   "vscode": "^1.18.0"
},
"categories": [
"Debuggers"
],
-   "private": true,
"devDependencies": {
"@types/node": "7.0.43",
"@types/mocha": "2.2.45",
@@ -34,69 +38,69 @@
"contributes": {
"languages": [
{
-"id": "lldb.disassembly",
-"aliases": [
-"Disassembly"
-],
-"extensions": [
-".disasm"
-]
+   "id": "lldb.disassembly",
+   "aliases": [
+   "Disassembly"
+   ],
+   "extensions": [
+   ".disasm"
+   ]
}
],
"grammars": [
{
-"language": "lldb.disassembly",
-"scopeName": "source.disassembly",
-"path": "./syntaxes/disassembly.json"
-}
-],
-"breakpoints": [
-  {
-"language": "ada"
-  },
-  {
-"language": "arm"
-  },
-  {
-"language": "asm"
-  },
-  {
-"language": "c"
-  },
-  {
-"language": "cpp"
-  },
-  {
-"language": "crystal"
-  },
-  {
-"language": "d"
-  },
-  {
-"language": "fortan"
-  },
-  {
-"language": "fortran-modern"
-  },
-  {
-"language": "nim"
-  },
-  {
-"language": "objective-c"
-  },
-  {
-"language": "objectpascal"
-  },
-  {
-"language": "pascal"
-  },
-  {
-"language": "rust"
-  },
-  {
-"language": "swift"
-  }
-],
+   "language": "lldb.disassembly",
+   "scopeName": "source.disassembly",
+   "path": "./syntaxes/disassembly.json"
+   }
+   ],
+   "breakpoints": [
+   {
+   "language": "ada"
+   },
+   {
+   "language": "arm"
+   },
+   {
+   "language": "asm"
+   },
+   {
+   "language": "c"
+   },
+   {
+   "language": "cpp"
+   },
+   {
+   "language": "crystal"
+

[Lldb-commits] [lldb] 653f776 - [mlir][complex] Convert complex.abs to arith with fastmath flag

2023-08-24 Thread Kai Sasaki via lldb-commits 

Author: Kai Sasaki
Date: 2023-08-25T12:10:43+09:00
New Revision: 653f77690bb2473ff405ccc681c73217fae8b748

URL: 
https://github.com/llvm/llvm-project/commit/653f77690bb2473ff405ccc681c73217fae8b748
DIFF: 
https://github.com/llvm/llvm-project/commit/653f77690bb2473ff405ccc681c73217fae8b748.diff

LOG: [mlir][complex] Convert complex.abs to arith with fastmath flag

Added: 


Modified: 
mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir

Removed: 
lldb/unittests/SymbolFile/PDB/Inputs/test-pdb.exe



diff  --git a/lldb/unittests/SymbolFile/PDB/Inputs/test-pdb.exe 
b/lldb/unittests/SymbolFile/PDB/Inputs/test-pdb.exe
deleted file mode 100644
index 3a2c64504ed93ca..000
Binary files a/lldb/unittests/SymbolFile/PDB/Inputs/test-pdb.exe and /dev/null 
diff er

diff  --git a/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp 
b/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
index 9c05cadc2f07e05..2bcec4ea10f92c5 100644
--- a/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
+++ b/mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
@@ -35,13 +35,18 @@ struct AbsOpConversion : public 
OpConversionPattern {
 auto loc = op.getLoc();
 auto type = op.getType();
 
+arith::FastMathFlagsAttr fmf = op.getFastMathFlagsAttr();
+
 Value real =
 rewriter.create(loc, type, adaptor.getComplex());
 Value imag =
 rewriter.create(loc, type, adaptor.getComplex());
-Value realSqr = rewriter.create(loc, real, real);
-Value imagSqr = rewriter.create(loc, imag, imag);
-Value sqNorm = rewriter.create(loc, realSqr, imagSqr);
+Value realSqr =
+rewriter.create(loc, real, real, fmf.getValue());
+Value imagSqr =
+rewriter.create(loc, imag, imag, fmf.getValue());
+Value sqNorm =
+rewriter.create(loc, realSqr, imagSqr, fmf.getValue());
 
 rewriter.replaceOpWithNewOp(op, sqNorm);
 return success();

diff  --git a/mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir 
b/mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir
index 5e8986a4a9a464c..bc2ea0dd7a5847a 100644
--- a/mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir
+++ b/mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir
@@ -707,3 +707,19 @@ func.func @complex_angle(%arg: complex) -> f32 {
 // CHECK: %[[IMAG:.*]] = complex.im %[[ARG]] : complex
 // CHECK: %[[RESULT:.*]] = math.atan2 %[[IMAG]], %[[REAL]] : f32
 // CHECK: return %[[RESULT]] : f32
+
+// -
+
+// CHECK-LABEL: func @complex_abs_with_fmf
+// CHECK-SAME: %[[ARG:.*]]: complex
+func.func @complex_abs_with_fmf(%arg: complex) -> f32 {
+  %abs = complex.abs %arg fastmath : complex
+  return %abs : f32
+}
+// CHECK: %[[REAL:.*]] = complex.re %[[ARG]] : complex
+// CHECK: %[[IMAG:.*]] = complex.im %[[ARG]] : complex
+// CHECK-DAG: %[[REAL_SQ:.*]] = arith.mulf %[[REAL]], %[[REAL]] 
fastmath : f32
+// CHECK-DAG: %[[IMAG_SQ:.*]] = arith.mulf %[[IMAG]], %[[IMAG]] 
fastmath : f32
+// CHECK: %[[SQ_NORM:.*]] = arith.addf %[[REAL_SQ]], %[[IMAG_SQ]] 
fastmath : f32
+// CHECK: %[[NORM:.*]] = math.sqrt %[[SQ_NORM]] : f32
+// CHECK: return %[[NORM]] : f32



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

2023-08-24 Thread walter erquinigo via Phabricator via lldb-commits 
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.

Awesome!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158801/new/

https://reviews.llvm.org/D158801

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

2023-08-24 Thread Jason Molenda via Phabricator via lldb-commits 
jasonmolenda updated this revision to Diff 553324.
jasonmolenda added a subscriber: jingham.
jasonmolenda added a comment.

After thinking about this more, and talking with @jingham I rewrote the patch 
so LC_NOTE "thread extrainfo" is a JSON dictionary with a key `threads` that 
has an array.  The number of entries in the array must match the number of 
LC_THREADs in the Mach-O corefile.  Each array entry may have a `thread_id` key 
with a thread id for that LC_THREAD, or lldb will create a thread_id for it.  I 
expect we will add more per-thread keys in the future.

The payload looks like

  
{"threads":[{"thread_id":18368681},{"thread_id":18368703},{"thread_id":18368704}]}

and JSON is stored as a c-string, requires a nul byte '\0' at the end.

I've treated the LC_NOTEs in Mach-O as strictly defined binary data until now, 
so producers and consumers both had a reference to work with.  But I think in 
the case of per-thread information in a corefile, we will have different people 
wanting to add different fields -- some fixed width, some variable length -- 
and specifying a JSON format that can be extended more easily is probably the 
correct way to go here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158785/new/

https://reviews.llvm.org/D158785

Files:
  lldb/include/lldb/Symbol/ObjectFile.h
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
  lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
  lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
  lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
  lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py

Index: lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py
===
--- lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py
+++ lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py
@@ -26,6 +26,11 @@
 self.runCmd("continue")
 
 self.runCmd("process save-core -s stack " + corefile)
+live_tids = []
+if self.TraceOn():
+self.runCmd("thread list")
+for t in process.threads:
+live_tids.append(t.GetThreadID())
 process.Kill()
 self.dbg.DeleteTarget(target)
 
@@ -42,3 +47,11 @@
 self.assertEqual(
 thread.GetStopDescription(256), "ESR_EC_DABORT_EL0 (fault address: 0x0)"
 )
+
+if self.TraceOn():
+self.runCmd("thread list")
+i = 0
+while i < process.GetNumThreads():
+t = process.GetThreadAtIndex(i)
+self.assertEqual(t.GetThreadID(), live_tids[i])
+i = i + 1
Index: lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
===
--- lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
+++ lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
@@ -17,7 +17,8 @@
 
 class ThreadMachCore : public lldb_private::Thread {
 public:
-  ThreadMachCore(lldb_private::Process , lldb::tid_t tid);
+  ThreadMachCore(lldb_private::Process , lldb::tid_t tid,
+ uint32_t objfile_lc_thread_idx);
 
   ~ThreadMachCore() override;
 
@@ -57,6 +58,7 @@
   std::string m_dispatch_queue_name;
   lldb::addr_t m_thread_dispatch_qaddr;
   lldb::RegisterContextSP m_thread_reg_ctx_sp;
+  uint32_t m_objfile_lc_thread_idx;
 
   // Protected member functions.
   bool CalculateStopInfo() override;
Index: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
===
--- lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
+++ lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
@@ -33,9 +33,11 @@
 
 // Thread Registers
 
-ThreadMachCore::ThreadMachCore(Process , lldb::tid_t tid)
+ThreadMachCore::ThreadMachCore(Process , lldb::tid_t tid,
+   uint32_t objfile_lc_thread_idx)
 : Thread(process, tid), m_thread_name(), m_dispatch_queue_name(),
-  m_thread_dispatch_qaddr(LLDB_INVALID_ADDRESS), m_thread_reg_ctx_sp() {}
+  m_thread_dispatch_qaddr(LLDB_INVALID_ADDRESS), m_thread_reg_ctx_sp(),
+  m_objfile_lc_thread_idx(objfile_lc_thread_idx) {}
 
 ThreadMachCore::~ThreadMachCore() { DestroyThread(); }
 
@@ -81,8 +83,8 @@
   ObjectFile *core_objfile =
   static_cast(process_sp.get())->GetCoreObjectFile();
   if (core_objfile)
-m_thread_reg_ctx_sp =
-core_objfile->GetThreadContextAtIndex(GetID(), *this);
+m_thread_reg_ctx_sp = core_objfile->GetThreadContextAtIndex(
+m_objfile_lc_thread_idx, *this);
 }
 reg_ctx_sp = m_thread_reg_ctx_sp;
   } else {
Index: lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
===
---

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

2023-08-24 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, wallace.
Herald added a project: All.
JDevlieghere requested review of this revision.

Update package.json:

- Update license, display name, repository and keywords
- Add homepage, issue page
- Fix formatting and typos


https://reviews.llvm.org/D158801

Files:
  lldb/tools/lldb-vscode/package.json

Index: lldb/tools/lldb-vscode/package.json
===
--- lldb/tools/lldb-vscode/package.json
+++ lldb/tools/lldb-vscode/package.json
@@ -1,26 +1,30 @@
 {
 	"name": "lldb-vscode",
-	"displayName": "LLDB native Debug stub",
+	"displayName": "LLDB VSCode",
 	"version": "0.1.0",
 	"publisher": "llvm",
-	"repository": "llvm.org",
-	"description": "Debug adapter for LLDB which uses a C++ tool to interface directly with LLDB.",
-	"author": {
-		"name": "Greg Clayton",
-		"email": "clayb...@gmail.com"
+	"homepage": "https://lldb.llvm.org;,
+	"description": "LLDB debugger for VSCode",
+	"license": "Apache 2.0 License with LLVM exceptions",
+	"repository": {
+		"type": "git",
+		"url": "https://github.com/llvm/llvm-project.git;
 	},
-	"license": "LLVM",
+	"bugs": {
+"url": "https://github.com/llvm/llvm-project/issues;
+  },
 	"keywords": [
-		"multi-root ready"
+		"C",
+		"C++",
+		"LLVM",
+		"LLDB"
 	],
 	"engines": {
-		"vscode": "^1.18.0",
-		"node": "^7.9.0"
+		"vscode": "^1.18.0"
 	},
 	"categories": [
 		"Debuggers"
 	],
-	"private": true,
 	"devDependencies": {
 		"@types/node": "7.0.43",
 		"@types/mocha": "2.2.45",
@@ -34,69 +38,69 @@
 	"contributes": {
 		"languages": [
 			{
-"id": "lldb.disassembly",
-"aliases": [
-"Disassembly"
-],
-"extensions": [
-".disasm"
-]
+"id": "lldb.disassembly",
+"aliases": [
+	"Disassembly"
+],
+"extensions": [
+	".disasm"
+]
 			}
 		],
 		"grammars": [
 			{
-"language": "lldb.disassembly",
-"scopeName": "source.disassembly",
-"path": "./syntaxes/disassembly.json"
-}
-],
-"breakpoints": [
-  {
-"language": "ada"
-  },
-  {
-"language": "arm"
-  },
-  {
-"language": "asm"
-  },
-  {
-"language": "c"
-  },
-  {
-"language": "cpp"
-  },
-  {
-"language": "crystal"
-  },
-  {
-"language": "d"
-  },
-  {
-"language": "fortan"
-  },
-  {
-"language": "fortran-modern"
-  },
-  {
-"language": "nim"
-  },
-  {
-"language": "objective-c"
-  },
-  {
-"language": "objectpascal"
-  },
-  {
-"language": "pascal"
-  },
-  {
-"language": "rust"
-  },
-  {
-"language": "swift"
-  }
-],
+"language": "lldb.disassembly",
+"scopeName": "source.disassembly",
+"path": "./syntaxes/disassembly.json"
+			}
+		],
+		"breakpoints": [
+			{
+"language": "ada"
+			},
+			{
+"language": "arm"
+			},
+			{
+"language": "asm"
+			},
+			{
+"language": "c"
+			},
+			{
+"language": "cpp"
+			},
+			{
+"language": "crystal"
+			},
+			{
+"language": "d"
+			},
+			{
+"language": "fortan"
+			},
+			{
+"language": "fortran-modern"
+			},
+			{
+"language": "nim"
+			},
+			{
+"language": "objective-c"
+			},
+			{
+"language": "objectpascal"
+			},
+			{
+"language": "pascal"
+			},
+			{
+"language": "rust"
+			},
+			{
+"language": "swift"
+			}
+		],
 		"debuggers": [
 			{
 "type": "lldb-vscode",
@@ -149,7 +153,7 @@
 			},
 			"env": {
 "type": "array",
-"description": "Additional environment variables to set when launching the program. This is an array of strings that contains the variable name followed by an optional '=' character and the environment variable's value. Example:  [\"FOO=BAR\", \"BAZ\"]",
+"description": "Additional environment variables to set when launching the program. This is an array of strings that contains the variable name followed by an optional '=' character and the environment variable's value.",
 "default": []
 			},
 			"stopOnEntry": {
@@ -183,12 +187,12 @@
 			},
 			"sourceMap": {
 "type": "array",
-"description": "Specify an array of path remappings; each element must itself be a two element array containing a source and destination pathname. Overrides sourcePath.",
+"description": "Specify an array of path remappings; each element must itself be a two element array containing a source and destination path name. Overrides sourcePath.",
 "default":

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

2023-08-24 Thread Jonas Devlieghere via Phabricator via lldb-commits 
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG719506769a89: [lldb-vscode] Use a switch to avoid 
else-after-return (NFC) (authored by JDevlieghere).
Herald added a project: LLDB.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158788/new/

https://reviews.llvm.org/D158788

Files:
  lldb/tools/lldb-vscode/ProgressEvent.cpp


Index: lldb/tools/lldb-vscode/ProgressEvent.cpp
===
--- lldb/tools/lldb-vscode/ProgressEvent.cpp
+++ lldb/tools/lldb-vscode/ProgressEvent.cpp
@@ -9,6 +9,7 @@
 #include "ProgressEvent.h"
 
 #include "JSONUtils.h"
+#include "llvm/Support/ErrorHandling.h"
 #include 
 
 using namespace lldb_vscode;
@@ -91,12 +92,15 @@
 ProgressEventType ProgressEvent::GetEventType() const { return m_event_type; }
 
 StringRef ProgressEvent::GetEventName() const {
-  if (m_event_type == progressStart)
+  switch (m_event_type) {
+  case progressStart:
 return "progressStart";
-  else if (m_event_type == progressEnd)
-return "progressEnd";
-  else
+  case progressUpdate:
 return "progressUpdate";
+  case progressEnd:
+return "progressEnd";
+  }
+  llvm_unreachable("All cases handled above!");
 }
 
 json::Value ProgressEvent::ToJSON() const {


Index: lldb/tools/lldb-vscode/ProgressEvent.cpp
===
--- lldb/tools/lldb-vscode/ProgressEvent.cpp
+++ lldb/tools/lldb-vscode/ProgressEvent.cpp
@@ -9,6 +9,7 @@
 #include "ProgressEvent.h"
 
 #include "JSONUtils.h"
+#include "llvm/Support/ErrorHandling.h"
 #include 
 
 using namespace lldb_vscode;
@@ -91,12 +92,15 @@
 ProgressEventType ProgressEvent::GetEventType() const { return m_event_type; }
 
 StringRef ProgressEvent::GetEventName() const {
-  if (m_event_type == progressStart)
+  switch (m_event_type) {
+  case progressStart:
 return "progressStart";
-  else if (m_event_type == progressEnd)
-return "progressEnd";
-  else
+  case progressUpdate:
 return "progressUpdate";
+  case progressEnd:
+return "progressEnd";
+  }
+  llvm_unreachable("All cases handled above!");
 }
 
 json::Value ProgressEvent::ToJSON() const {
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7195067 - [lldb-vscode] Use a switch to avoid else-after-return (NFC)

2023-08-24 Thread Jonas Devlieghere via lldb-commits 

Author: Jonas Devlieghere
Date: 2023-08-24T15:53:14-07:00
New Revision: 719506769a89c4f01fc8513cf3553e723591294c

URL: 
https://github.com/llvm/llvm-project/commit/719506769a89c4f01fc8513cf3553e723591294c
DIFF: 
https://github.com/llvm/llvm-project/commit/719506769a89c4f01fc8513cf3553e723591294c.diff

LOG: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

Use a switch to avoid else-after-return.

Differential revision: https://reviews.llvm.org/D158788

Added: 


Modified: 
lldb/tools/lldb-vscode/ProgressEvent.cpp

Removed: 




diff  --git a/lldb/tools/lldb-vscode/ProgressEvent.cpp 
b/lldb/tools/lldb-vscode/ProgressEvent.cpp
index 443d04892b4221..2930b5c1e24e92 100644
--- a/lldb/tools/lldb-vscode/ProgressEvent.cpp
+++ b/lldb/tools/lldb-vscode/ProgressEvent.cpp
@@ -9,6 +9,7 @@
 #include "ProgressEvent.h"
 
 #include "JSONUtils.h"
+#include "llvm/Support/ErrorHandling.h"
 #include 
 
 using namespace lldb_vscode;
@@ -91,12 +92,15 @@ bool ProgressEvent::EqualsForIDE(const ProgressEvent 
) const {
 ProgressEventType ProgressEvent::GetEventType() const { return m_event_type; }
 
 StringRef ProgressEvent::GetEventName() const {
-  if (m_event_type == progressStart)
+  switch (m_event_type) {
+  case progressStart:
 return "progressStart";
-  else if (m_event_type == progressEnd)
-return "progressEnd";
-  else
+  case progressUpdate:
 return "progressUpdate";
+  case progressEnd:
+return "progressEnd";
+  }
+  llvm_unreachable("All cases handled above!");
 }
 
 json::Value ProgressEvent::ToJSON() const {



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

2023-08-24 Thread walter erquinigo via Phabricator via lldb-commits 
wallace accepted this revision.
wallace added a comment.
This revision is now accepted and ready to land.

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158788/new/

https://reviews.llvm.org/D158788

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return

2023-08-24 Thread Jonas Devlieghere via Phabricator via lldb-commits 
JDevlieghere created this revision.
JDevlieghere added a reviewer: wallace.
Herald added a project: All.
JDevlieghere requested review of this revision.

Use a switch to avoid else-after-return.


https://reviews.llvm.org/D158788

Files:
  lldb/tools/lldb-vscode/ProgressEvent.cpp


Index: lldb/tools/lldb-vscode/ProgressEvent.cpp
===
--- lldb/tools/lldb-vscode/ProgressEvent.cpp
+++ lldb/tools/lldb-vscode/ProgressEvent.cpp
@@ -9,6 +9,7 @@
 #include "ProgressEvent.h"
 
 #include "JSONUtils.h"
+#include "llvm/Support/ErrorHandling.h"
 #include 
 
 using namespace lldb_vscode;
@@ -91,12 +92,15 @@
 ProgressEventType ProgressEvent::GetEventType() const { return m_event_type; }
 
 StringRef ProgressEvent::GetEventName() const {
-  if (m_event_type == progressStart)
+  switch (m_event_type) {
+  case progressStart:
 return "progressStart";
-  else if (m_event_type == progressEnd)
-return "progressEnd";
-  else
+  case progressUpdate:
 return "progressUpdate";
+  case progressEnd:
+return "progressEnd";
+  }
+  llvm_unreachable("All cases handled above!");
 }
 
 json::Value ProgressEvent::ToJSON() const {


Index: lldb/tools/lldb-vscode/ProgressEvent.cpp
===
--- lldb/tools/lldb-vscode/ProgressEvent.cpp
+++ lldb/tools/lldb-vscode/ProgressEvent.cpp
@@ -9,6 +9,7 @@
 #include "ProgressEvent.h"
 
 #include "JSONUtils.h"
+#include "llvm/Support/ErrorHandling.h"
 #include 
 
 using namespace lldb_vscode;
@@ -91,12 +92,15 @@
 ProgressEventType ProgressEvent::GetEventType() const { return m_event_type; }
 
 StringRef ProgressEvent::GetEventName() const {
-  if (m_event_type == progressStart)
+  switch (m_event_type) {
+  case progressStart:
 return "progressStart";
-  else if (m_event_type == progressEnd)
-return "progressEnd";
-  else
+  case progressUpdate:
 return "progressUpdate";
+  case progressEnd:
+return "progressEnd";
+  }
+  llvm_unreachable("All cases handled above!");
 }
 
 json::Value ProgressEvent::ToJSON() const {
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

2023-08-24 Thread Jason Molenda via Phabricator via lldb-commits 
jasonmolenda added a comment.

As soon as I started thinking about thread names and queue names and mach 
exception data, all variable length things, a binary format doesn't seem ideal. 
 We do already send a lot of thread information about processes in JSON in gdb 
remote serial protocol from debugserver today.  It's the first time we'd use 
JSON in a Mach-O LC_NOTE though, so I'm interested to hear other people's 
thoughts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158785/new/

https://reviews.llvm.org/D158785

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

2023-08-24 Thread Jason Molenda via Phabricator via lldb-commits 
jasonmolenda added a comment.

Or possibly we should just make "thread extrainfo" a JSON blob with a 
dictionary for each thread, which would make it easier to extend, instead of a 
binary format.  I'm not sure I have a strong opinion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158785/new/

https://reviews.llvm.org/D158785

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

2023-08-24 Thread Jason Molenda via Phabricator via lldb-commits 
jasonmolenda created this revision.
jasonmolenda added reviewers: JDevlieghere, bulbazord.
jasonmolenda added a project: LLDB.
Herald added a project: All.
jasonmolenda requested review of this revision.
Herald added a subscriber: lldb-commits.

This adds a new LC_NOTE to ObjectFileMachO to save the thread IDs of threads, 
and restore them in ProcessMachCore when reading the corefile back.  The 
LC_NOTE payload format is

  struct thread_extrainfo {
  uint32_t version;// currently 1
  uint32_t elem_size;  // size of each array element
  struct {
  uint64_t tid;// tid override for each LC_THREAD, 0 means none 
provided
  } __attribute__((packed)) thread_extras[NUM_LC_THREADS];
  };

My intention is that we can add additional fields in the future without bumping 
the version number; existing fields must always be included.  Each field will 
have sentinel values to indicate that they are unspecified -- if we add a 
"thread priority" uint64_t next year, but a producer only wants to specify 
thread priorities and not thread IDs, they can put 0 values for the thread IDs. 
 Consumers can skip fields that they don't know about.

The one down side to this layout is that variable-length fields can't be 
incorporated well -- thread names, libdispatch queue names on macOS for 
instance.  It might be better to have each element specify its size, so we can 
have variable length entries.  I'd love to hear opinions, the more I think 
about it, the more I worry someone is going to request thread names in 
corefiles about a week after I land this.

The patch adds support to ObjectFileMachO to emit this new LC_NOTE when 
creating a corefile for `process save-core`, and support to 
ObjectFileMachO/ProcessMachCore/ThreadMachCore to read those values back in 
again.  It adds a check to an existing API test that has sixteen threads for 
confirming that we select the faulting thread in a corefile.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D158785

Files:
  lldb/include/lldb/Symbol/ObjectFile.h
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
  lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h
  lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
  lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
  lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
  lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py

Index: lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py
===
--- lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py
+++ lldb/test/API/macosx/corefile-exception-reason/TestCorefileExceptionReason.py
@@ -26,6 +26,11 @@
 self.runCmd("continue")
 
 self.runCmd("process save-core -s stack " + corefile)
+live_tids = []
+if self.TraceOn():
+self.runCmd("thread list")
+for t in process.threads:
+live_tids.append(t.GetThreadID())
 process.Kill()
 self.dbg.DeleteTarget(target)
 
@@ -42,3 +47,11 @@
 self.assertEqual(
 thread.GetStopDescription(256), "ESR_EC_DABORT_EL0 (fault address: 0x0)"
 )
+
+if self.TraceOn():
+self.runCmd("thread list")
+i = 0
+while i < process.GetNumThreads():
+t = process.GetThreadAtIndex(i)
+self.assertEqual(t.GetThreadID(), live_tids[i])
+i = i + 1
Index: lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
===
--- lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
+++ lldb/source/Plugins/Process/mach-core/ThreadMachCore.h
@@ -17,7 +17,8 @@
 
 class ThreadMachCore : public lldb_private::Thread {
 public:
-  ThreadMachCore(lldb_private::Process , lldb::tid_t tid);
+  ThreadMachCore(lldb_private::Process , lldb::tid_t tid,
+ uint32_t objfile_lc_thread_idx);
 
   ~ThreadMachCore() override;
 
@@ -57,6 +58,7 @@
   std::string m_dispatch_queue_name;
   lldb::addr_t m_thread_dispatch_qaddr;
   lldb::RegisterContextSP m_thread_reg_ctx_sp;
+  uint32_t m_objfile_lc_thread_idx;
 
   // Protected member functions.
   bool CalculateStopInfo() override;
Index: lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
===
--- lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
+++ lldb/source/Plugins/Process/mach-core/ThreadMachCore.cpp
@@ -33,9 +33,11 @@
 
 // Thread Registers
 
-ThreadMachCore::ThreadMachCore(Process , lldb::tid_t tid)
+ThreadMachCore::ThreadMachCore(Process , lldb::tid_t tid,
+   uint32_t objfile_lc_thread_idx)
 : Thread(process, tid), m_thread_name(), m_dispatch_queue_name(),
-  m_thread_dispatch_qaddr(LLDB_INVALID_ADDRESS), m_thread_reg_ctx_sp() {}
+  m_thread_dispatch_qaddr(LLDB_INVALID_ADDRESS),

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

2023-08-24 Thread Greg Clayton via Phabricator via lldb-commits 
clayborg updated this revision to Diff 553259.
clayborg added a comment.

Fixed more header documentation and cleaned up the test even more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158583/new/

https://reviews.llvm.org/D158583

Files:
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp
  lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.h
  lldb/test/API/functionalities/dyld-multiple-rdebug/Makefile
  
lldb/test/API/functionalities/dyld-multiple-rdebug/TestDyldWithMultupleRDebug.py
  lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.cpp
  lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.h
  lldb/test/API/functionalities/dyld-multiple-rdebug/main.cpp

Index: lldb/test/API/functionalities/dyld-multiple-rdebug/main.cpp
===
--- /dev/null
+++ lldb/test/API/functionalities/dyld-multiple-rdebug/main.cpp
@@ -0,0 +1,32 @@
+#include "library_file.h"
+#include 
+#include 
+// Make a duplicate "_r_debug" symbol that is visible. This is the global
+// variable name that the dynamic loader uses to communicate changes in shared
+// libraries that get loaded and unloaded. LLDB finds the address of this
+// variable by reading the DT_DEBUG entry from the .dynamic section of the main
+// executable.
+// What will happen is the dynamic loader will use the "_r_debug" symbol from
+// itself until the a.out executable gets loaded. At this point the new
+// "_r_debug" symbol will take precedence over the orignal "_r_debug" symbol
+// from the dynamic loader and the copy below will get updated with shared
+// library state changes while the version that LLDB checks in the dynamic
+// loader stays the same for ever after this.
+//
+// When our DYLDRendezvous.cpp tries to check the state in the _r_debug
+// structure, it will continue to get the last eAdd as the state before the
+// switch in symbol resolution.
+//
+// Before a fix in LLDB, this would mean that we wouldn't ever load any shared
+// libraries since DYLDRendezvous was waiting to see a eAdd state followed by a
+// eConsistent state which would trigger the adding of shared libraries, but we
+// would never see this change because the local copy below is actually what
+// would get updated. Now if DYLDRendezvous detects two eAdd states in a row,
+// it will load the shared libraries instead of doing nothing and a log message
+// will be printed out if "log enable lldb dyld" is active.
+r_debug _r_debug;
+
+int main() {
+  library_function(); // Break here
+  return 0;
+}
Index: lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.h
===
--- /dev/null
+++ lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.h
@@ -0,0 +1 @@
+int library_function();
Index: lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.cpp
===
--- /dev/null
+++ lldb/test/API/functionalities/dyld-multiple-rdebug/library_file.cpp
@@ -0,0 +1,7 @@
+#include "library_file.h"
+#include 
+
+int library_function(void) {
+  puts(__FUNCTION__); // Library break here
+  return 0;
+}
Index: lldb/test/API/functionalities/dyld-multiple-rdebug/TestDyldWithMultupleRDebug.py
===
--- /dev/null
+++ lldb/test/API/functionalities/dyld-multiple-rdebug/TestDyldWithMultupleRDebug.py
@@ -0,0 +1,39 @@
+"""
+Test that LLDB can launch a linux executable through the dynamic loader where
+the main executable has an extra exported "_r_debug" symbol that used to mess
+up shared library loading with DYLDRendezvous and the POSIX dynamic loader
+plug-in. What used to happen is that any shared libraries other than the main
+executable and the dynamic loader and VSDO would not get loaded. This test
+checks to make sure that we still load libraries correctly when we have
+multiple "_r_debug" symbols. See comments in the main.cpp source file for full
+details on what the problem is.
+"""
+
+import lldb
+import os
+
+from lldbsuite.test import lldbutil
+from lldbsuite.test.decorators import *
+from lldbsuite.test.lldbtest import *
+
+
+class TestDyldWithMultipleRDebug(TestBase):
+@skipIf(oslist=no_match(["linux"]))
+@no_debug_info_test
+def test(self):
+self.build()
+# Run to a breakpoint in main.cpp to ensure we can hit breakpoints
+# in the main executable. Setting breakpoints by file and line ensures
+# that the main executable was loaded correctly by the dynamic loader
+(target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
+self, "// Break here", lldb.SBFileSpec("main.cpp"),
+extra_images=["testlib"]
+)
+# Set breakpoints both on shared library function to ensure that
+# we hit a source breakpoint in the shared library which only will

[Lldb-commits] [lldb] a902015 - [lldb] Fix grammar in error message emitted by IRExecutionUnit

2023-08-24 Thread Jonas Devlieghere via lldb-commits 

Author: Jonas Devlieghere
Date: 2023-08-24T14:11:30-07:00
New Revision: a902015f543097720fed4d2c04e34daa0fdfbda7

URL: 
https://github.com/llvm/llvm-project/commit/a902015f543097720fed4d2c04e34daa0fdfbda7
DIFF: 
https://github.com/llvm/llvm-project/commit/a902015f543097720fed4d2c04e34daa0fdfbda7.diff

LOG: [lldb] Fix grammar in error message emitted by IRExecutionUnit

The error message "Couldn't lookup symbols" emitted from IRExecutionUnit
is grammatically incorrect. "Lookup" is noun when spelled without a
space. Update the error message to use the verb "look up" instead.

Added: 


Modified: 
cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
lldb/source/Expression/IRExecutionUnit.cpp

lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py

lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py

lldb/test/API/lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py
lldb/test/API/lang/cpp/constructors/TestCppConstructors.py
lldb/test/API/lang/cpp/unique-types4/TestUniqueTypes4.py

Removed: 




diff  --git 
a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py 
b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
index b13e7435ba75a4..d601648e3748cf 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/lldb/LLDB.py
@@ -288,6 +288,7 @@ def evaluate_expression(self, expression, frame_idx=0) -> 
ValueIR:
 "use of undeclared identifier",
 "no member named",
 "Couldn't lookup symbols",
+"Couldn't look up symbols",
 "reference to local variable",
 "invalid use of 'this' outside of a non-static member 
function",
 ]

diff  --git a/lldb/source/Expression/IRExecutionUnit.cpp 
b/lldb/source/Expression/IRExecutionUnit.cpp
index 5a4ba04bff04ea..ac9cea7e731f09 100644
--- a/lldb/source/Expression/IRExecutionUnit.cpp
+++ b/lldb/source/Expression/IRExecutionUnit.cpp
@@ -419,7 +419,7 @@ void IRExecutionUnit::GetRunnableInfo(Status , 
lldb::addr_t _addr,
   if (m_failed_lookups.size()) {
 StreamString ss;
 
-ss.PutCString("Couldn't lookup symbols:\n");
+ss.PutCString("Couldn't look up symbols:\n");
 
 bool emitNewLine = false;
 

diff  --git 
a/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
 
b/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
index 94d0978b199c62..913d964578918c 100644
--- 
a/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
+++ 
b/lldb/test/API/commands/expression/import-std-module/empty-module/TestEmptyStdModule.py
@@ -38,5 +38,5 @@ def test(self):
 # Try to access our mock std::vector. This should fail but not crash 
LLDB as the
 # std::vector template should be missing from the std module.
 self.expect(
-"expr (size_t)v.size()", substrs=["Couldn't lookup symbols"], 
error=True
+"expr (size_t)v.size()", substrs=["Couldn't look up symbols"], 
error=True
 )

diff  --git 
a/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
 
b/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
index 7ec3ff12c6f8ee..530191e8a37ba1 100644
--- 
a/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
+++ 
b/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
@@ -90,7 +90,7 @@ def test(self):
 self.expect(
 "expr const int *i = ::int_val; *i",
 error=True,
-substrs=["Couldn't lookup symbols:"],
+substrs=["Couldn't look up symbols:"],
 )
 
 # This should work on all platforms.

diff  --git 
a/lldb/test/API/lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py
 
b/lldb/test/API/lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py
index 183be54a0307f3..72a2c629c90453 100644
--- 
a/lldb/test/API/lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py
+++ 
b/lldb/test/API/lang/cpp/const_static_integral_member_int128/TestConstStaticIntegralMemberInt128.py
@@ -23,14 +23,14 @@ def test_int128(self):
 # for them and just treats them as normal variables (which will lead
 # to linker errors as they are not defined anywhere).
 self.expect(
-"expr A::int128_max", error=True, substrs=["Couldn't lookup 
symbols:"]
+"expr A::int128_max", error=True, substrs=["Couldn't look up 
symbols:"]
 )
 self.expect(
-"expr

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Aaron Ballman via Phabricator via lldb-commits 
aaron.ballman added a comment.

In D158323#4614717 , @mib wrote:

> Given that the bot is still red, I've reverted the patch in 
> dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 
> 

Thank you for the revert! I can confirm the publish bot is now green again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Med Ismail Bennani via Phabricator via lldb-commits 
mib added a comment.

Given that the bot is still red, I've reverted the patch in 
dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] dfb48dc - Revert "[lldb/infra] Revamp lldb.llvm.org"

2023-08-24 Thread Med Ismail Bennani via lldb-commits 

Author: Med Ismail Bennani
Date: 2023-08-24T19:44:16+01:00
New Revision: dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7

URL: 
https://github.com/llvm/llvm-project/commit/dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7
DIFF: 
https://github.com/llvm/llvm-project/commit/dfb48dcc9cb6217bd62aed1dc8a5f30736eafba7.diff

LOG: Revert "[lldb/infra] Revamp lldb.llvm.org"

This patch reverts the lldb website revamp (eea8874) since the `furo` theme
that we use is not installed on the publisher bot. The prevents other
website from getting there documentation updated.

Signed-off-by: Med Ismail Bennani 

Added: 
lldb/docs/_static/lldb.css

Modified: 
lldb/docs/conf.py
lldb/docs/resources/build.rst
lldb/docs/resources/caveats.rst
lldb/docs/resources/overview.rst
lldb/docs/resources/projects.rst
lldb/docs/resources/test.rst
lldb/docs/use/formatting.rst
lldb/docs/use/intel_pt.rst
lldb/docs/use/map.rst
lldb/docs/use/ondemand.rst
lldb/docs/use/python-reference.rst
lldb/docs/use/python.rst
lldb/docs/use/qemu-testing.rst
lldb/docs/use/remote.rst
lldb/docs/use/symbolication.rst
lldb/docs/use/symbols.rst
lldb/docs/use/troubleshooting.rst
lldb/docs/use/tutorial.rst
lldb/docs/use/variable.rst

Removed: 




diff  --git a/lldb/docs/_static/lldb.css b/lldb/docs/_static/lldb.css
new file mode 100644
index 00..e1e49f84c90347
--- /dev/null
+++ b/lldb/docs/_static/lldb.css
@@ -0,0 +1,100 @@
+pre {
+  padding: 7px;
+}
+
+div.document {
+  width: 90%;
+}
+
+div.body {
+  max-width: 90%;
+}
+
+div.note {
+  padding: 20px 20px 10px 20px;
+}
+
+div.note p.admonition-title {
+  font-size: 130%;
+}
+
+table.mapping {
+  width: 100%;
+}
+
+table.mapping td {
+  width: 50%;
+  padding: 5px;
+}
+
+table.mapping td.hed {
+  background: #606060;
+  color: #fefefe;
+  text-align: left;
+  border-bottom: 2px #fefefe solid;
+  font-weight: bold;
+}
+
+table.mapping td.header {
+  background: #ee;
+}
+
+table.mapping td.content {
+  font-family: monospace;
+  padding-bottom: 15px;
+}
+
+/* Workaround for a Safari bug that would otherwise make table cells less wide
+than the containing text. This just sets it back to the default browser
+property.*/
+td {
+  -webkit-hyphens: manual !important;
+}
+
+div.sphinxsidebar .caption {
+  font-family: Helvetica, Verdana, sans-serif;
+  font-size: 10pt;
+  font-weight: bold;
+  color: #fefefe;
+  background: #606060;
+  margin-bottom: 0;
+  text-transform: uppercase;
+  padding: 7px;
+}
+
+div.sphinxsidebar a,
+div.sphinxsidebar a:hover {
+  border: none;
+}
+
+div.sphinxsidebar li {
+  padding-left: 7px;
+  border-bottom: 1px solid #fefefe;
+}
+
+div.sphinxsidebar li:hover {
+  background: #ee;
+}
+
+div.sphinxsidebar ul {
+  background: #e9e9e9;
+  margin: 0px;
+  padding: 0px;
+}
+
+div.sphinxsidebar ul a {
+  font-family: Helvetica, Verdana, sans-serif;
+  font-size: 8pt;
+  display: block;
+  padding: 5px 0;
+  line-height: 14pt;
+}
+
+div.sphinxsidebar ul li.toctree-l1 > a {
+  font-size: 100%;
+}
+
+div.sphinxsidebar h3 {
+  /* Hide Navigation. */
+  display: none;
+}

diff  --git a/lldb/docs/conf.py b/lldb/docs/conf.py
index c5b89d6880c736..d326a253b0a012 100644
--- a/lldb/docs/conf.py
+++ b/lldb/docs/conf.py
@@ -57,16 +57,6 @@
 )
 extensions.append("sphinx_automodapi.automodapi")
 
-try:
-import furo
-except ModuleNotFoundError:
-print(
-f"install sphinx furo theme with {sys.executable} -m pip install 
furo"
-)
-# The theme to use for HTML and HTML Help pages.  See the documentation for
-# a list of builtin themes.
-html_theme = "furo"
-
 # Add any paths that contain templates here, relative to this directory.
 templates_path = ["_templates"]
 
@@ -141,19 +131,23 @@
 
 # The theme to use for HTML and HTML Help pages.  See the documentation for
 # a list of builtin themes.
-html_theme = "furo"
+html_theme = "alabaster"
 
 # Theme options are theme-specific and customize the look and feel of a theme
 # further.  For a list of options available for each theme, see the
 # documentation.
-html_theme_options = {}
+html_theme_options = {
+"font_size": "11pt",
+# Don't generate any links to GitHub.
+"github_button": "false",
+}
 
 # Add any paths that contain custom themes here, relative to this directory.
 # html_theme_path = []
 
 # The name for this set of Sphinx documents.  If None, it defaults to
 # " v documentation".
-html_title = " LLDB"
+html_title = "The LLDB Debugger"
 
 # A shorter title for the navigation bar.  Default is the same as html_title.
 # html_short_title = None
@@ -172,6 +166,10 @@
 # so a file named "default.css" will overwrite the builtin "default.css".
 html_static_path = ["_static"]
 
+html_context = {
+"css_files": ["_static/lldb.css"],
+}
+
 html_extra_path = [".htaccess"]
 
 # If not '', a 'Last updated on:' timestamp is

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

2023-08-24 Thread Adrian Prantl via Phabricator via lldb-commits 
aprantl added a comment.

Test LGTM, I'll defer to others for the dynamic loader plugin.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158583/new/

https://reviews.llvm.org/D158583

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

2023-08-24 Thread walter erquinigo via Phabricator via lldb-commits 
wallace added inline comments.



Comment at: lldb/source/Commands/CommandObjectType.cpp:2174
 
-#if LLDB_ENABLE_PYTHON
-

wallace wrote:
> electriclilies wrote:
> > jingham wrote:
> > > electriclilies wrote:
> > > > rriddle wrote:
> > > > > Why is this dropped?
> > > > Walter and I want to use the synthetic types from C++, but right now 
> > > > it's only supported in Python. The motivation behind this is to make it 
> > > > so that we can actually use the synthetic types. 
> > > Just to be clear.  There are already lots of synthetic child providers 
> > > implemented in C++ in in lldb already (look for CXXSyntheticChildren 
> > > constructors in CPlusPlusLanguage.cpp for instance).  
> > > 
> > > I think what you are saying is that you are removing the restriction that 
> > > you have to BUILD lldb with Python in order to add C++ implemented 
> > > summaries.  If that's indeed what you are saying, then this is fine, 
> > > since that seems an odd restriction...
> > > 
> > > But it would be nice to have some kind of testing that this actually 
> > > works, since I don't think any of our bots build lldb w/o Python.
> > Yes that's exactly it! I agree it would be nice to have a test for it but I 
> > don't know how to add it. 
> @jingham , indeed, we couldn't add buildbot tests for this they all build 
> with python support.
> 
> However, a good compromise is to enable all these commands except for the 
> `add` ones, because they have the option to use python-defined extensions. 
> `clear`, `delete`, `info` and `list` should be fine even without python 
> scripting support.
> 
> What do you think?
After a second inspection of this diff, I want to rephrase my previous comment:

This patch is only enabling the `type synthetic` commands, and `type synthetic 
add` is the only one that can receive a python input. In fact, it only works 
with python, so @electriclilies, please keep `type synthetic add` guarded by 
`#if LLDB_ENABLE_PYTHON`, because it just doesn't work otherwise.

@jingham , we can't really test this in the buildbots, so, all good if Lily 
does some basic manual testing showing that these commands work even when the 
python scripting support is not enabled? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158010/new/

https://reviews.llvm.org/D158010

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Med Ismail Bennani via Phabricator via lldb-commits 
mib added a comment.

In D158323#4614469 , @aaron.ballman 
wrote:

> In D158323#4614446 , @mib wrote:
>
>> In D158323#4614373 , 
>> @aaron.ballman wrote:
>>
>>> In D158323#4613878 , @mib wrote:
>>>
 Given we didn't receive more feedback on this, I'll land it now. If there 
 are other comments, we can address those after the fact.
>>>
>>> Hello! It seems the changes here have taken out the sphinx publish bot: 
>>> https://lab.llvm.org/buildbot/#/builders/89/builds/46884
>>>
>>> The issue appears to be this bit:
>>>
>>>   Theme error:
>>>   no theme named 'furo' found (missing theme.conf?)
>>>
>>> If it's going to take a while to address, I'd recommend reverting the patch 
>>> so that the bot goes back to green.
>>
>> Hey @aaron.ballman, I've reached out to @tonic & @gkistanova (who was CC'ed 
>> to the Buildbot failure email) via email to install the theme. It should be 
>> as simple as running `/usr/bin/python3 -m pip install furo` on the generator 
>> bot (`as-worker-4` I guess), so let's give them some time to do it. Thanks!
>
> Thanks!
>
> That bot is responsible for updating the documentation on the website, so it 
> being down for an extended period of time is disruptive (none of our docs get 
> updated). I'm fine giving the bot owners some time to do the install if 
> they're around and able to get to it quickly, but if it can't be resolved in 
> a few hours, I'd still appreciate a revert.

Makes sense. Thanks for your patience :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Aaron Ballman via Phabricator via lldb-commits 
aaron.ballman added a comment.

In D158323#4614446 , @mib wrote:

> In D158323#4614373 , @aaron.ballman 
> wrote:
>
>> In D158323#4613878 , @mib wrote:
>>
>>> Given we didn't receive more feedback on this, I'll land it now. If there 
>>> are other comments, we can address those after the fact.
>>
>> Hello! It seems the changes here have taken out the sphinx publish bot: 
>> https://lab.llvm.org/buildbot/#/builders/89/builds/46884
>>
>> The issue appears to be this bit:
>>
>>   Theme error:
>>   no theme named 'furo' found (missing theme.conf?)
>>
>> If it's going to take a while to address, I'd recommend reverting the patch 
>> so that the bot goes back to green.
>
> Hey @aaron.ballman, I've reached out to @tonic & @gkistanova (who was CC'ed 
> to the Buildbot failure email) via email to install the theme. It should be 
> as simple as running `/usr/bin/python3 -m pip install furo` on the generator 
> bot (`as-worker-4` I guess), so let's give them some time to do it. Thanks!

Thanks!

That bot is responsible for updating the documentation on the website, so it 
being down for an extended period of time is disruptive (none of our docs get 
updated). I'm fine giving the bot owners some time to do the install if they're 
around and able to get to it quickly, but if it can't be resolved in a few 
hours, I'd still appreciate a revert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Med Ismail Bennani via Phabricator via lldb-commits 
mib added subscribers: tonic, gkistanova.
mib added a comment.

In D158323#4614373 , @aaron.ballman 
wrote:

> In D158323#4613878 , @mib wrote:
>
>> Given we didn't receive more feedback on this, I'll land it now. If there 
>> are other comments, we can address those after the fact.
>
> Hello! It seems the changes here have taken out the sphinx publish bot: 
> https://lab.llvm.org/buildbot/#/builders/89/builds/46884
>
> The issue appears to be this bit:
>
>   Theme error:
>   no theme named 'furo' found (missing theme.conf?)
>
> If it's going to take a while to address, I'd recommend reverting the patch 
> so that the bot goes back to green.

Hey @aaron.ballman, I've reached out to @tonic & @gkistanova (who was CC'ed to 
the Buildbot failure email) via email to install the theme. It should be as 
simple as running `/usr/bin/python3 -m pip install furo` on the generator bot 
(`as-worker-4` I guess), so let's give them some time to do it. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Aaron Ballman via Phabricator via lldb-commits 
aaron.ballman added a comment.

In D158323#4613878 , @mib wrote:

> Given we didn't receive more feedback on this, I'll land it now. If there are 
> other comments, we can address those after the fact.

Hello! It seems the changes here have taken out the sphinx publish bot: 
https://lab.llvm.org/buildbot/#/builders/89/builds/46884

The issue appears to be this bit:

  Theme error:
  no theme named 'furo' found (missing theme.conf?)

If it's going to take a while to address, I'd recommend reverting the patch so 
that the bot goes back to green.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Med Ismail Bennani via Phabricator via lldb-commits 
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeea887406498: [lldb/infra] Revamp lldb.llvm.org (authored by 
mib).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

Files:
  lldb/docs/_static/lldb.css
  lldb/docs/conf.py
  lldb/docs/resources/build.rst
  lldb/docs/resources/caveats.rst
  lldb/docs/resources/overview.rst
  lldb/docs/resources/projects.rst
  lldb/docs/resources/test.rst
  lldb/docs/use/formatting.rst
  lldb/docs/use/intel_pt.rst
  lldb/docs/use/map.rst
  lldb/docs/use/ondemand.rst
  lldb/docs/use/python-reference.rst
  lldb/docs/use/python.rst
  lldb/docs/use/qemu-testing.rst
  lldb/docs/use/remote.rst
  lldb/docs/use/symbolication.rst
  lldb/docs/use/symbols.rst
  lldb/docs/use/troubleshooting.rst
  lldb/docs/use/tutorial.rst
  lldb/docs/use/variable.rst

Index: lldb/docs/use/variable.rst
===
--- lldb/docs/use/variable.rst
+++ lldb/docs/use/variable.rst
@@ -1,9 +1,6 @@
 Variable Formatting
 ===
 
-.. contents::
-   :local:
-
 LLDB has a data formatters subsystem that allows users to define custom display
 options for their variables.
 
Index: lldb/docs/use/tutorial.rst
===
--- lldb/docs/use/tutorial.rst
+++ lldb/docs/use/tutorial.rst
@@ -5,9 +5,6 @@
 command set. We will start with some details on lldb command structure and
 syntax to help orient you.
 
-.. contents::
-   :local:
-
 Command Structure
 -
 
Index: lldb/docs/use/troubleshooting.rst
===
--- lldb/docs/use/troubleshooting.rst
+++ lldb/docs/use/troubleshooting.rst
@@ -1,9 +1,6 @@
 Troubleshooting
 ===
 
-.. contents::
-   :local:
-
 File and Line Breakpoints Are Not Getting Hit
 -
 
Index: lldb/docs/use/symbols.rst
===
--- lldb/docs/use/symbols.rst
+++ lldb/docs/use/symbols.rst
@@ -1,9 +1,6 @@
 Symbols on macOS
 
 
-.. contents::
-   :local:
-
 On macOS, debug symbols are often in stand alone bundles called **dSYM** files.
 These are bundles that contain DWARF debug information and other resources
 related to builds and debug info.
Index: lldb/docs/use/symbolication.rst
===
--- lldb/docs/use/symbolication.rst
+++ lldb/docs/use/symbolication.rst
@@ -1,10 +1,6 @@
 Symbolication
 =
 
-.. contents::
-   :local:
-
-
 LLDB is separated into a shared library that contains the core of the debugger,
 and a driver that implements debugging and a command interpreter. LLDB can be
 used to symbolicate your crash logs and can often provide more information than
Index: lldb/docs/use/remote.rst
===
--- lldb/docs/use/remote.rst
+++ lldb/docs/use/remote.rst
@@ -23,9 +23,6 @@
 debugging this whole process is transparent to the user. The platform binary is
 not used in this case, since no file transfers are needed.
 
-.. contents::
-   :local:
-
 Preparation for Remote Debugging
 -
 
Index: lldb/docs/use/qemu-testing.rst
===
--- lldb/docs/use/qemu-testing.rst
+++ lldb/docs/use/qemu-testing.rst
@@ -1,9 +1,6 @@
 Testing LLDB using QEMU
 ===
 
-.. contents::
-   :local:
-
 QEMU system mode emulation
 --
 
Index: lldb/docs/use/python.rst
===
--- lldb/docs/use/python.rst
+++ lldb/docs/use/python.rst
@@ -11,9 +11,6 @@
 Python scripting to find a bug in a program that searches for text in a
 large binary tree.
 
-.. contents::
-   :local:
-
 The Test Program and Input
 --
 
Index: lldb/docs/use/python-reference.rst
===
--- lldb/docs/use/python-reference.rst
+++ lldb/docs/use/python-reference.rst
@@ -10,9 +10,6 @@
 Of course, in this context it has full access to the LLDB API - with some
 additional conveniences we will call out in the FAQ.
 
-.. contents::
-   :local:
-
 Documentation
 --
 
Index: lldb/docs/use/ondemand.rst
===
--- lldb/docs/use/ondemand.rst
+++ lldb/docs/use/ondemand.rst
@@ -11,9 +11,6 @@
 is queried for very common types, or global name lookups fail due to a mistyped
 expression.
 
-.. contents::
-   :local:
-
 When should I consider enabling this feature?
 -
 
Index: lldb/docs/use/map.rst
===
--- lldb/docs/use/map.rst
+++ lldb/docs/use/map.rst

[Lldb-commits] [lldb] eea8874 - [lldb/infra] Revamp lldb.llvm.org

2023-08-24 Thread Med Ismail Bennani via lldb-commits 

Author: Med Ismail Bennani
Date: 2023-08-24T15:41:16+01:00
New Revision: eea887406498d3a420ed0afbb654915a7e08e2ad

URL: 
https://github.com/llvm/llvm-project/commit/eea887406498d3a420ed0afbb654915a7e08e2ad
DIFF: 
https://github.com/llvm/llvm-project/commit/eea887406498d3a420ed0afbb654915a7e08e2ad.diff

LOG: [lldb/infra] Revamp lldb.llvm.org

This patch brings a fresh coat of paint to the LLDB website.

This uses the `furo` theme from the suggested theme list, adds some
changes to the css to make it use the full browser window width and
removes the table of contents since the theme generates it automatically.

This patch also rewrites the tables for "GDB to LLDB command map" to
convert them from raw HTML to native inlined code blocks.

To generate the website, make sure you install the theme first with
`pip install furo`, enable sphinx in the cmake invocation` then run
`ninja docs-lldb-html`

Discourse: https://discourse.llvm.org/t/rfc-revamping-lldbs-website

Differential Revision: https://reviews.llvm.org/D158323

Signed-off-by: Med Ismail Bennani 

Added: 


Modified: 
lldb/docs/conf.py
lldb/docs/resources/build.rst
lldb/docs/resources/caveats.rst
lldb/docs/resources/overview.rst
lldb/docs/resources/projects.rst
lldb/docs/resources/test.rst
lldb/docs/use/formatting.rst
lldb/docs/use/intel_pt.rst
lldb/docs/use/map.rst
lldb/docs/use/ondemand.rst
lldb/docs/use/python-reference.rst
lldb/docs/use/python.rst
lldb/docs/use/qemu-testing.rst
lldb/docs/use/remote.rst
lldb/docs/use/symbolication.rst
lldb/docs/use/symbols.rst
lldb/docs/use/troubleshooting.rst
lldb/docs/use/tutorial.rst
lldb/docs/use/variable.rst

Removed: 
lldb/docs/_static/lldb.css



diff  --git a/lldb/docs/_static/lldb.css b/lldb/docs/_static/lldb.css
deleted file mode 100644
index e1e49f84c90347..00
--- a/lldb/docs/_static/lldb.css
+++ /dev/null
@@ -1,100 +0,0 @@
-pre {
-  padding: 7px;
-}
-
-div.document {
-  width: 90%;
-}
-
-div.body {
-  max-width: 90%;
-}
-
-div.note {
-  padding: 20px 20px 10px 20px;
-}
-
-div.note p.admonition-title {
-  font-size: 130%;
-}
-
-table.mapping {
-  width: 100%;
-}
-
-table.mapping td {
-  width: 50%;
-  padding: 5px;
-}
-
-table.mapping td.hed {
-  background: #606060;
-  color: #fefefe;
-  text-align: left;
-  border-bottom: 2px #fefefe solid;
-  font-weight: bold;
-}
-
-table.mapping td.header {
-  background: #ee;
-}
-
-table.mapping td.content {
-  font-family: monospace;
-  padding-bottom: 15px;
-}
-
-/* Workaround for a Safari bug that would otherwise make table cells less wide
-than the containing text. This just sets it back to the default browser
-property.*/
-td {
-  -webkit-hyphens: manual !important;
-}
-
-div.sphinxsidebar .caption {
-  font-family: Helvetica, Verdana, sans-serif;
-  font-size: 10pt;
-  font-weight: bold;
-  color: #fefefe;
-  background: #606060;
-  margin-bottom: 0;
-  text-transform: uppercase;
-  padding: 7px;
-}
-
-div.sphinxsidebar a,
-div.sphinxsidebar a:hover {
-  border: none;
-}
-
-div.sphinxsidebar li {
-  padding-left: 7px;
-  border-bottom: 1px solid #fefefe;
-}
-
-div.sphinxsidebar li:hover {
-  background: #ee;
-}
-
-div.sphinxsidebar ul {
-  background: #e9e9e9;
-  margin: 0px;
-  padding: 0px;
-}
-
-div.sphinxsidebar ul a {
-  font-family: Helvetica, Verdana, sans-serif;
-  font-size: 8pt;
-  display: block;
-  padding: 5px 0;
-  line-height: 14pt;
-}
-
-div.sphinxsidebar ul li.toctree-l1 > a {
-  font-size: 100%;
-}
-
-div.sphinxsidebar h3 {
-  /* Hide Navigation. */
-  display: none;
-}

diff  --git a/lldb/docs/conf.py b/lldb/docs/conf.py
index d326a253b0a012..c5b89d6880c736 100644
--- a/lldb/docs/conf.py
+++ b/lldb/docs/conf.py
@@ -57,6 +57,16 @@
 )
 extensions.append("sphinx_automodapi.automodapi")
 
+try:
+import furo
+except ModuleNotFoundError:
+print(
+f"install sphinx furo theme with {sys.executable} -m pip install 
furo"
+)
+# The theme to use for HTML and HTML Help pages.  See the documentation for
+# a list of builtin themes.
+html_theme = "furo"
+
 # Add any paths that contain templates here, relative to this directory.
 templates_path = ["_templates"]
 
@@ -131,23 +141,19 @@
 
 # The theme to use for HTML and HTML Help pages.  See the documentation for
 # a list of builtin themes.
-html_theme = "alabaster"
+html_theme = "furo"
 
 # Theme options are theme-specific and customize the look and feel of a theme
 # further.  For a list of options available for each theme, see the
 # documentation.
-html_theme_options = {
-"font_size": "11pt",
-# Don't generate any links to GitHub.
-"github_button": "false",
-}
+html_theme_options = {}
 
 # Add any paths that contain custom themes here, relative to this directory.
 # html_theme_path = []
 
 # The name for this set of Sphinx documents.  If None,

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

2023-08-24 Thread Med Ismail Bennani via Phabricator via lldb-commits 
mib added a comment.

Given we didn't receive more feedback on this, I'll land it now. If there are 
other comments, we can address those after the fact.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158323/new/

https://reviews.llvm.org/D158323

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits