[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/3] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/2] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/2] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread Jessica Clarke via lldb-commits
@@ -21,9 +21,6 @@ /* C23 7.20.1 Defines several macros for performing checked integer arithmetic*/ -#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L -#define __STDC_VERSION_STDCKDINT_H__ 202311L jrtc27 wrote: This needs to stay,

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread Jessica Clarke via lldb-commits
@@ -177,7 +177,7 @@ C23 Feature Support - Clang now supports ``N3007 Type inference for object definitions``. - Clang now supports which defines several macros for performing - checked integer arithmetic. + checked integer arithmetic. And it is also exposed in pre-C23

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread Jessica Clarke via lldb-commits
@@ -33,8 +33,3 @@ #error "__STDC_VERSION_STDINT_H__ not defined" // expected-error@-1 {{"__STDC_VERSION_STDINT_H__ not defined"}} #endif - -#include -#ifndef __STDC_VERSION_STDCKDINT_H__ -#error "__STDC_VERSION_STDCKDINT_H__ not defined" jrtc27 wrote: And

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (ZijunZhaoCCK) Changes Update some tests and docs. --- Full diff: https://github.com/llvm/llvm-project/pull/69649.diff 6 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1-1) - (modified)

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
https://github.com/ZijunZhaoCCK ready_for_review https://github.com/llvm/llvm-project/pull/69649 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via lldb-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH] Update stdckdint.h and make it available in pre-C23 modes.

[Lldb-commits] [lldb] 969ba9f - [lldb] Remove FileSpecList::GetFilesMatchingPartialPath (NFC)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-10-19T15:17:36-07:00 New Revision: 969ba9ff1477d9dc350aa1b3f5fd23b6f6af76cd URL: https://github.com/llvm/llvm-project/commit/969ba9ff1477d9dc350aa1b3f5fd23b6f6af76cd DIFF:

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

2023-10-19 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/69531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ea9e116 - [lldb][NFCI] Remove duplicated code in DWARFParser (#69531)

2023-10-19 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2023-10-19T14:10:31-07:00 New Revision: ea9e116e5a24e834142bc4024b57697b48599a9e URL: https://github.com/llvm/llvm-project/commit/ea9e116e5a24e834142bc4024b57697b48599a9e DIFF:

[Lldb-commits] [lldb] f9632ce - [lldb] Remove FileSpecList::GetFileSpecPointerAtIndex (NFC)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-10-19T13:13:31-07:00 New Revision: f9632cee30b788df7a6241d7802224d8f633973a URL: https://github.com/llvm/llvm-project/commit/f9632cee30b788df7a6241d7802224d8f633973a DIFF:

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Anton Rydahl via lldb-commits
https://github.com/AntonRydahl closed https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Anton Rydahl via lldb-commits
AntonRydahl wrote: > LG after fixing the header formatting. Thanks a bunch! I don't know how I did not notice the misformatted headers. I have fixed those now. https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
@@ -1,5 +1,7 @@ +add_subdirectory(Libsanitizers) usama54321 wrote: More specifically, I have named the file `ASanLibsanitizers/InstrumentationRuntimeASan.cpp` instead of `ASanLibsanitizers/InstrumentationRuntimeASanLibsanitizers.cpp`

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Joseph Huber via lldb-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Joseph Huber via lldb-commits
@@ -0,0 +1,19 @@ +//===-- Implementation of the GPU logbf function jhuber6 wrote: Fix header https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Joseph Huber via lldb-commits
https://github.com/jhuber6 approved this pull request. LG after fixing the header formatting. https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Joseph Huber via lldb-commits
@@ -0,0 +1,21 @@ +//===-- Implementation of the GPU atan2f function jhuber6 wrote: Fix header https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [libc][libm][GPU] Add missing vendor entrypoints to the GPU version of `libm` (PR #66034)

2023-10-19 Thread Joseph Huber via lldb-commits
@@ -0,0 +1,17 @@ +//===-- Implementation of the GPU lroundf function jhuber6 wrote: This and some other headers need to be reformatted. https://github.com/llvm/llvm-project/pull/66034 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-10-19 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/69516 >From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 18 Oct 2023 13:07:51 -0700 Subject: [PATCH 1/5] [lldb][progress] Add discrete boolean flag to

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
usama54321 wrote: Thanks a lot for the feedback @bulbazord and @JDevlieghere. I have updated the PR. I will appreciate any feedback about the directory/file naming convention after the update. https://github.com/llvm/llvm-project/pull/69388 ___

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
@@ -1,5 +1,7 @@ +add_subdirectory(Libsanitizers) usama54321 wrote: I moved the plugin in the parent directory. However, I was not sure how to name the plugin so I have currently named the folder as ASanLibsanitizers and named the files as

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] [lldb] Refactor InstrumentationRuntimeAsan and add a new plugin (PR #69388)

2023-10-19 Thread Usama Hameed via lldb-commits
https://github.com/usama54321 updated https://github.com/llvm/llvm-project/pull/69388 >From bafeea33e1aea4a9e947220a78801ef241106eac Mon Sep 17 00:00:00 2001 From: usama Date: Wed, 18 Oct 2023 17:16:50 -0700 Subject: [PATCH 1/2] [lldb] Refactor InstrumentationRuntimeAsan This commit refactors

[Lldb-commits] [lldb] 5bae3a0 - [lldb] Remove CompileUnit::SetSupportFiles overload (NFC)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-10-19T11:14:25-07:00 New Revision: 5bae3a0b0ccf8f4f2bcffc86453197f3cc5a9829 URL: https://github.com/llvm/llvm-project/commit/5bae3a0b0ccf8f4f2bcffc86453197f3cc5a9829 DIFF:

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

2023-10-19 Thread via lldb-commits
@@ -7183,7 +7183,8 @@ GetNthTemplateArgument(const clang::ClassTemplateSpecializationDecl *decl, // (including the ones preceding the parameter pack). const auto = args[last_idx]; const size_t pack_idx = idx - last_idx; - assert(pack_idx < pack.pack_size() &&

[Lldb-commits] [lldb] bd21efe - [lldb] Fix ASCII art in CommandObjectSource.h (NFC)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2023-10-19T10:30:38-07:00 New Revision: bd21efe24c7670bc8d6f5c3bb92f12b0d1983e0b URL: https://github.com/llvm/llvm-project/commit/bd21efe24c7670bc8d6f5c3bb92f12b0d1983e0b DIFF:

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

2023-10-19 Thread David Blaikie via lldb-commits
https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/69531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

2023-10-19 Thread David Blaikie via lldb-commits
@@ -73,137 +69,18 @@ bool DWARFDebugInfoEntry::Extract(const DWARFDataExtractor , m_tag = abbrevDecl->getTag(); m_has_children = abbrevDecl->hasChildren(); // Skip all data in the .debug_info or .debug_types for the attributes - dw_form_t form; for (const auto :

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

2023-10-19 Thread David Spickett via lldb-commits
@@ -7183,7 +7183,8 @@ GetNthTemplateArgument(const clang::ClassTemplateSpecializationDecl *decl, // (including the ones preceding the parameter pack). const auto = args[last_idx]; const size_t pack_idx = idx - last_idx; - assert(pack_idx < pack.pack_size() &&

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. I already discussed this offline with Chelsea, but yeah I agree that "discrete" isn't very informative. Regardless of the name we pick, we should include an example too to help clarify its meaning. I'd also prefer to use

[Lldb-commits] [lldb] [lldb][NFCI] Remove duplicated code in DWARFParser (PR #69531)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: 拾 https://github.com/llvm/llvm-project/pull/69531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

2023-10-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/69264 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-10-19 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: "Aggregate" can work. These are moreso status updates than than they are progress reports and I need to work on the documentation in the code that explains what I'm trying to accomplish. https://github.com/llvm/llvm-project/pull/69516

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

2023-10-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jeffreytan81) Changes This is relanding of https://github.com/llvm/llvm-project/pull/69253. `TestTemplatePackArgs.py` is passing now. https://github.com/llvm/llvm-project/pull/68012/files added new data formatters for LibStdC++

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

2023-10-19 Thread via lldb-commits
https://github.com/jeffreytan81 ready_for_review https://github.com/llvm/llvm-project/pull/69614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Reland] Detect against invalid variant index for LibStdC++ std::variant data formatters (PR #69614)

2023-10-19 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/69614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix std::variant invalid index crash (PR #69614)

2023-10-19 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/69614 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix std::variant invalid index crash (PR #69614)

2023-10-19 Thread via lldb-commits
https://github.com/jeffreytan81 created https://github.com/llvm/llvm-project/pull/69614 None >From 126723c82207d50e5d2b475b0b259312a8f1eb5c Mon Sep 17 00:00:00 2001 From: jeffreytan81 Date: Thu, 19 Oct 2023 09:42:21 -0700 Subject: [PATCH] Fix std::variant invalid index crash ---

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1742,20 +1742,37 @@ SymbolFileDWARF::GetDwoSymbolFileForCompileUnit( if (std::shared_ptr dwp_sp = GetDwpSymbolFile()) return dwp_sp; - FileSpec dwo_file(dwo_name); - FileSystem::Instance().Resolve(dwo_file); - bool found = false; + const char *comp_dir = +

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -0,0 +1,119 @@ +""" +Test module locate dwo callback functionality +""" + +import ctypes +import shutil +from lldbsuite.test.decorators import * +import lldb +from lldbsuite.test import lldbtest, lldbutil + + +class LocateDwoCallbackTestCase(lldbtest.TestBase): +

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback( return *sb_error_ptr; } + +// `comp_dir` is allowed to be NULL. All other arguments must be valid values. +static SBError LLDBSwigPythonCallLocateDwoCallback( +void *baton, const SBFileSpec

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -0,0 +1,119 @@ +""" +Test module locate dwo callback functionality +""" + +import ctypes +import shutil +from lldbsuite.test.decorators import * +import lldb +from lldbsuite.test import lldbtest, lldbutil + + +class LocateDwoCallbackTestCase(lldbtest.TestBase): +

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback( return *sb_error_ptr; } + +// `comp_dir` is allowed to be NULL. All other arguments must be valid values. +static SBError LLDBSwigPythonCallLocateDwoCallback( +void *baton, const SBFileSpec

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1742,20 +1742,37 @@ SymbolFileDWARF::GetDwoSymbolFileForCompileUnit( if (std::shared_ptr dwp_sp = GetDwpSymbolFile()) return dwp_sp; - FileSpec dwo_file(dwo_name); - FileSystem::Instance().Resolve(dwo_file); - bool found = false; + const char *comp_dir = +

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback( return *sb_error_ptr; } + +// `comp_dir` is allowed to be NULL. All other arguments must be valid values. +static SBError LLDBSwigPythonCallLocateDwoCallback( +void *baton, const SBFileSpec

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -139,6 +139,13 @@ typedef void (*SBDebuggerDestroyCallback)(lldb::user_id_t debugger_id, typedef SBError (*SBPlatformLocateModuleCallback)( void *baton, const SBModuleSpec _spec, SBFileSpec _file_spec, SBFileSpec _file_spec); + +typedef SBError

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback( return *sb_error_ptr; } + +// `comp_dir` is allowed to be NULL. All other arguments must be valid values. +static SBError LLDBSwigPythonCallLocateDwoCallback( +void *baton, const SBFileSpec

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -696,3 +696,55 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $input == Py_None; $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } + +// For lldb::SBModuleLocateDwoCallback +// The `baton` is the actual Python function passed, and we

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -677,3 +677,30 @@ void SBModule::GarbageCollectAllocatedModules() { const bool mandatory = false; ModuleList::RemoveOrphanSharedModules(mandatory); } + +void SBModule::SetLocateDwoCallback(lldb::SBModuleLocateDwoCallback callback, +

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback( return *sb_error_ptr; } + +// `comp_dir` is allowed to be NULL. All other arguments must be valid values. +static SBError LLDBSwigPythonCallLocateDwoCallback( +void *baton, const SBFileSpec

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Because SymbolFile is holding onto the function pointer as a static member, this is a global setting that you can't apply to only just one `SBDebugger` object. It's an all-or-nothing thing. Maybe that's what you want, but LLDB already has architectural

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -696,3 +696,55 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $input == Py_None; $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } + +// For lldb::SBModuleLocateDwoCallback +// The `baton` is the actual Python function passed, and we

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -1168,4 +1168,58 @@ static SBError LLDBSwigPythonCallLocateModuleCallback( return *sb_error_ptr; } + +// `comp_dir` is allowed to be NULL. All other arguments must be valid values. +static SBError LLDBSwigPythonCallLocateDwoCallback( +void *baton, const SBFileSpec

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
@@ -696,3 +696,55 @@ template <> bool SetNumberFromPyObject(double , PyObject *obj) { $1 = $input == Py_None; $1 = $1 || PyCallable_Check(reinterpret_cast($input)); } + +// For lldb::SBModuleLocateDwoCallback +// The `baton` is the actual Python function passed, and we

[Lldb-commits] [lldb] Add `SBModule.SetLocateDwoCallback` (PR #69517)

2023-10-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/69517 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Add discrete boolean flag to progress reports (PR #69516)

2023-10-19 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: I was thinking more about this last night, I'm not sure the word "discrete" is the right word for what this describes. It's not a bad word per se, but if a ProgressEvent isn't discrete, it's not really "continuous" either (or any of the other antonyms

[Lldb-commits] [lldb] [lldb-vscode] Allow specifying a custom escape prefix for LLDB commands (PR #69238)

2023-10-19 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/69238 >From adcf4b7ad6ec67805293af99300643075a02b75b Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 16 Oct 2023 15:08:20 -0400 Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape

[Lldb-commits] [lldb] [lldb-vscode] Allow specifying a custom escape prefix for LLDB commands (PR #69238)

2023-10-19 Thread Walter Erquinigo via lldb-commits
@@ -52,12 +52,17 @@ llvm::StringRef GetAsString(const llvm::json::Value ); /// \param[in] key /// The key to use when extracting the value /// +/// \param[in] defaultValue +/// The default value to return if the key is not present +/// /// \return /// A

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Timm Baeder via lldb-commits
tbaederr wrote: Have you seen the failing buildbots? https://github.com/llvm/llvm-project/pull/69010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via lldb-commits
https://github.com/lawben closed https://github.com/llvm/llvm-project/pull/69010 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Clang] Add __builtin_vectorelements to get number of elements in vector (PR #69010)

2023-10-19 Thread Lawrence Benson via lldb-commits
lawben wrote: As nobody has come forward in the the last two days, I'm gonna merge this now. I'll have a look a mangling this for Microsoft in a follow-up, as this may require a few changes. I'm not yet sure what has to be changed for mangling. https://github.com/llvm/llvm-project/pull/69010

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/68845 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-19 Thread David Spickett via lldb-commits
@@ -135,5 +135,5 @@ def test_watch_address_with_invalid_watch_size(self): self.expect( error.GetCString(), exe=False, -substrs=["watch size of %d is not supported" % 365], +substrs=["Setting one of the

[Lldb-commits] [lldb] [lldb] Rename lldb-vscode to lldb-dap (PR #69264)

2023-10-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/69264 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

2023-10-19 Thread James Henderson via lldb-commits
jh7370 wrote: @dankm, is there a particular reason you haven't merged this change in yet? FWIW, the formatter check failed for some reason, but I'm not sure it's related to any formatting issue. Please verify by running clang-format on your changes before merging.

[Lldb-commits] [lldb] [X86] Support -march=pantherlake, clearwaterforest (PR #69277)

2023-10-19 Thread Freddy Ye via lldb-commits
https://github.com/FreddyLeaf updated https://github.com/llvm/llvm-project/pull/69277 >From 9e673f332b8f7a3cfdeb1a73f6a77aee651f7664 Mon Sep 17 00:00:00 2001 From: Freddy Ye Date: Wed, 11 Oct 2023 10:25:36 +0800 Subject: [PATCH 1/2] [X86] Support -march=pantherlake,clearwaterforest ---