[Lldb-commits] [lldb] c9bfe04 - [lldb/test] Fix TestScriptedProcess.py failures on arm linux bots

2023-11-07 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-11-07T23:24:02-08:00 New Revision: c9bfe0411f1d3f1f7261675e972bf223f9167548 URL: https://github.com/llvm/llvm-project/commit/c9bfe0411f1d3f1f7261675e972bf223f9167548 DIFF:

[Lldb-commits] [lldb] 0a21144 - [lldb] Check for abstract methods implementation in Scripted Plugin Objects (#71260)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-11-07T22:01:41-08:00 New Revision: 0a21144614950ce063d8dac6394307bd3be604cd URL: https://github.com/llvm/llvm-project/commit/0a21144614950ce063d8dac6394307bd3be604cd DIFF:

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsString (PR #71613)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/71613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsString (PR #71613)

2023-11-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) Changes This patch changes the interface of StructuredData::Array::GetItemAtIndexAsString to return a `std::optionalllvm::StringRef` instead of taking an out parameter. More generally, this commit serves as

[Lldb-commits] [lldb] [lldb] Change interface of StructuredData::Array::GetItemAtIndexAsString (PR #71613)

2023-11-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord created https://github.com/llvm/llvm-project/pull/71613 This patch changes the interface of StructuredData::Array::GetItemAtIndexAsString to return a `std::optional` instead of taking an out parameter. More generally, this commit serves as proposal that we change

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-07 Thread Greg Clayton via lldb-commits
clayborg wrote: > > So I debugged lldb with lldb and adding a counter into the FileSpec > > constructor and came up a max of 721833 files after trying to set a > > breakpoint in Driver.cpp, so that storage is about 16.5MB which isn't too > > bad. This goes up to 27.5MB with the FileSpec being

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda edited https://github.com/llvm/llvm-project/pull/70300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread Jason Molenda via lldb-commits
@@ -62,7 +62,10 @@ struct RegisterInfo { /// rax ax, ah, and al. uint32_t *invalidate_regs; /// If not nullptr, a type defined by XML descriptions. - const RegisterFlags *flags_type; + /// This is mutable so that it may be updated after the register info tables + ///

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM fwiw. https://github.com/llvm/llvm-project/pull/70300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][split-dwarf] implement GetSeparateDebugInfo for SymbolFileOnDemand (PR #71230)

2023-11-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Looks good to me. FYI: here is how you might be able to try cross compiling by editing the Makefile and removing the `@skipIf*`. The compile command for cross compiling looks like: ``` clang++ -target x86_64-pc-linux-elf -g -gsplit-dwarf -c main.cpp ```

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: > So I debugged lldb with lldb and adding a counter into the FileSpec > constructor and came up a max of 721833 files after trying to set a > breakpoint in Driver.cpp, so that storage is about 16.5MB which isn't too > bad. This goes up to 27.5MB with the FileSpec being 40

[Lldb-commits] [llvm] [lldb] [lldb][AArch64][Linux] Add SME2 release notes and usage docs (PR #70935)

2023-11-07 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. looks good. https://github.com/llvm/llvm-project/pull/70935 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c2ad9f8 - Revert "[lldb] Check for abstract methods implementation in Scripted Plugin Objects (#71260)"

2023-11-07 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2023-11-07T13:04:01-08:00 New Revision: c2ad9f8b607931430e86da7420493599c48e62a0 URL: https://github.com/llvm/llvm-project/commit/c2ad9f8b607931430e86da7420493599c48e62a0 DIFF:

[Lldb-commits] [lldb] [clang] [libc] [llvm] [clang-tools-extra] [libcxx] [lld] [flang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-07 Thread Alexey Bataev via lldb-commits
@@ -0,0 +1,14 @@ +// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s --check-prefix=CHECK-DRIVER +// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc" + +// RUN: %clang -S -### -fopenacc -fexperimental-openacc-macro-override=202211 %s 2>&1 | FileCheck %s

[Lldb-commits] [flang] [llvm] [lld] [libcxx] [lldb] [clang-tools-extra] [libc] [clang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-07 Thread Alexey Bataev via lldb-commits
@@ -229,6 +230,9 @@ class Parser : public CodeCompletionHandler { /// Parsing OpenMP directive mode. bool OpenMPDirectiveParsing = false; + /// Parsing OpenACC directive mode. + bool OpenACCDirectiveParsing = false; alexey-bataev wrote: It is unused,

[Lldb-commits] [lldb] [lldb] Add Checksum to FileSpec (PR #71457)

2023-11-07 Thread Greg Clayton via lldb-commits
clayborg wrote: So I debugged lldb with lldb and adding a counter into the FileSpec constructor and came up a max of 721833 files after trying to set a breakpoint in Driver.cpp, so that storage is about 16.5MB which isn't too bad. This goes up to 27.5MB with the FileSpec being 40 bytes, so

[Lldb-commits] [lldb] cc9ad72 - [lldb] Check for abstract methods implementation in Scripted Plugin Objects (#71260)

2023-11-07 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2023-11-07T12:07:16-08:00 New Revision: cc9ad72713405ef8f2468c7a714a137b4a3343ba URL: https://github.com/llvm/llvm-project/commit/cc9ad72713405ef8f2468c7a714a137b4a3343ba DIFF:

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/71260 >From a98cf851f5947546eb76196ef945ce1fa8d9bfaa Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 6 Nov 2023 14:15:12 -0800 Subject: [PATCH] [lldb] Check for abstract methods implementation in

[Lldb-commits] [lldb] [lldb][test] Implement getting thread ID on OpenBSD (PR #71129)

2023-11-07 Thread Brad Smith via lldb-commits
brad0 wrote: Ping. https://github.com/llvm/llvm-project/pull/71129 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 03a92f0 - [lldb] BreakpointResolver{*}::CreateFromStructuredData should return shared pointers (#71477)

2023-11-07 Thread via lldb-commits
Author: Alex Langford Date: 2023-11-07T11:22:23-08:00 New Revision: 03a92f0ecabdf8065f4458a780484db92f032d14 URL: https://github.com/llvm/llvm-project/commit/03a92f0ecabdf8065f4458a780484db92f032d14 DIFF: https://github.com/llvm/llvm-project/commit/03a92f0ecabdf8065f4458a780484db92f032d14.diff

[Lldb-commits] [lldb] [lldb] BreakpointResolver{*}::CreateFromStructuredData should return shared pointers (PR #71477)

2023-11-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord closed https://github.com/llvm/llvm-project/pull/71477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-07 Thread Greg Clayton via lldb-commits
@@ -443,6 +455,9 @@ class FileSpec { /// The unique'd filename path. ConstString m_filename; + /// The optional MD5 checksum of the file. + Checksum m_checksum; + clayborg wrote: We are increasing the size of all FileSpec objects by 16 bytes here. Is.

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/71458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Read Checksum from DWARF line tables (PR #71458)

2023-11-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. I would love to see if we can do this without increasing the size of FileSpec objects. Can we have the DWARF line tables store a FileSpec + checksum and do its warning without making every file object contain a checksum object

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/70300 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] [lldb][AArch64][Linux] Add SME2 release notes and usage docs (PR #70935)

2023-11-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/70935 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71559 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread Alex Langford via lldb-commits
@@ -2594,34 +2594,30 @@ ValueObjectSP ValueObject::CreateConstantValue(ConstString name) { ValueObjectSP ValueObject::GetQualifiedRepresentationIfAvailable( lldb::DynamicValueType dynValue, bool synthValue) { - ValueObjectSP result_sp(GetSP()); - + ValueObjectSP

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71559 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [llvm] [clang] [lldb] [libc] [compiler-rt] [mlir] [flang] [libcxx] [libc][bazel] Add powf target and fix bazel overlay. (PR #71464)

2023-11-07 Thread via lldb-commits
https://github.com/michaelrj-google commented: LGTM, sorry I missed this yesterday. https://github.com/llvm/llvm-project/pull/71464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/71465 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7991412 - [lldb/Interpreter] Make Scripted*Interface base class abstract (#71465)

2023-11-07 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2023-11-07T09:56:22-08:00 New Revision: 7991412270ce1147ca0ab286e2479b5381a564ad URL: https://github.com/llvm/llvm-project/commit/7991412270ce1147ca0ab286e2479b5381a564ad DIFF:

[Lldb-commits] [openmp] [clang] [lldb] [llvm] [compiler-rt] [clang-tools-extra] [libcxx] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-07 Thread via lldb-commits
https://github.com/nmustakin updated https://github.com/llvm/llvm-project/pull/70667 >From 153c6d812939cd23bb71e53c71378117ed5b23c7 Mon Sep 17 00:00:00 2001 From: Nafis Mustakin Date: Mon, 30 Oct 2023 07:50:59 -0700 Subject: [PATCH 1/6] Add memory diff dump for kernel record-replay ---

[Lldb-commits] [lldb] [lldb] Fix calls to Type::getInt8PtrTy (PR #71561)

2023-11-07 Thread Paulo Matos via lldb-commits
https://github.com/pmatos closed https://github.com/llvm/llvm-project/pull/71561 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3267cd3 - [lldb] Fix calls to Type::getInt8PtrTy (#71561)

2023-11-07 Thread via lldb-commits
Author: Paulo Matos Date: 2023-11-07T18:49:11+01:00 New Revision: 3267cd3fa10651b46e9d1ce66940301e784c0533 URL: https://github.com/llvm/llvm-project/commit/3267cd3fa10651b46e9d1ce66940301e784c0533 DIFF: https://github.com/llvm/llvm-project/commit/3267cd3fa10651b46e9d1ce66940301e784c0533.diff

[Lldb-commits] [lldb] [lldb] Fix calls to Type::getInt8PtrTy (PR #71561)

2023-11-07 Thread Paulo Matos via lldb-commits
pmatos wrote: > LGTM. BTW, I found other uses of `Type::getInt8PtrTy` in > `llvm-project/llvm/include/llvm/ProfileData/InstrProfData.inc` and > `llvm-project/compiler-rt/include/profile/InstrProfData.inc`. Thanks, will fix those separately. Lets get lldb to build.

[Lldb-commits] [lldb] [lldb/Interpreter] Make Scripted*Interface base class abstract (PR #71465)

2023-11-07 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/71465 >From 2267c5fe10ceea0d16deb9a41508b698aa1aeecb Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Mon, 6 Nov 2023 16:12:36 -0800 Subject: [PATCH] [lldb/Interpreter] Make Scripted*Interface base class

[Lldb-commits] [lldb] [lldb] Fix calls to Type::getInt8PtrTy (PR #71561)

2023-11-07 Thread Yingwei Zheng via lldb-commits
https://github.com/dtcxzyw approved this pull request. LGTM. BTW, I found other uses of `Type::getInt8PtrTy` in `llvm-project/llvm/include/llvm/ProfileData/InstrProfData.inc` and `llvm-project/compiler-rt/include/profile/InstrProfData.inc`. https://github.com/llvm/llvm-project/pull/71561

[Lldb-commits] [lldb] [lldb] Fix calls to Type::getInt8PtrTy (PR #71561)

2023-11-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Paulo Matos (pmatos) Changes These have been removed in 7b9d73c2f90c0ed8497339a16fc39785349d9610. This is a followup patch to apply the changes to lldb. --- Full diff: https://github.com/llvm/llvm-project/pull/71561.diff 2 Files

[Lldb-commits] [lldb] [lldb] Fix calls to Type::getInt8PtrTy (PR #71561)

2023-11-07 Thread Paulo Matos via lldb-commits
https://github.com/pmatos created https://github.com/llvm/llvm-project/pull/71561 These have been removed in 7b9d73c2f90c0ed8497339a16fc39785349d9610. This is a followup patch to apply the changes to lldb. >From 7971aa9ebf887eefb5bfd67f78319b0811be Mon Sep 17 00:00:00 2001 From: Paulo

[Lldb-commits] [lldb] [clang] [flang] [clang-tools-extra] [llvm] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-11-07 Thread Markos Horro via lldb-commits
https://github.com/markoshorro updated https://github.com/llvm/llvm-project/pull/71072 >From 0c5299adb30888aa0dfd7c3106547a69606d5ab1 Mon Sep 17 00:00:00 2001 From: Marcos Horro Date: Thu, 2 Nov 2023 15:35:07 + Subject: [PATCH 1/2] [IndVars] Truncation also considered as bitcast

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

2023-11-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: > I'll post something shortly. https://discourse.llvm.org/t/rfc-fatal-error-handling-in-release-builds-aka-can-i-use-lldbassert-or-not/74738 https://github.com/llvm/llvm-project/pull/71175 ___ lldb-commits mailing list

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71559 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: rdar://118018930 https://github.com/llvm/llvm-project/pull/71559 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes I received a couple of nullptr-deref crash reports with no line numbers in this function. The way the function was written it was a bit diffucult to keep track of when result_sp could be null, so this

[Lldb-commits] [lldb] Simplify ValueObject::GetQualifiedRepresentationIfAvailable(). (PR #71559)

2023-11-07 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/71559 I received a couple of nullptr-deref crash reports with no line numbers in this function. The way the function was written it was a bit diffucult to keep track of when result_sp could be null, so this

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

2023-11-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: > It seems like there's enough different opinions on this topic that might > warrant a proper RFC. I'll post something shortly. https://github.com/llvm/llvm-project/pull/71175 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-07 Thread Adrian Prantl via lldb-commits
@@ -300,6 +300,16 @@ size_t SourceManager::DisplaySourceLinesWithLineNumbersUsingLastFile( break; } } + +Checksum checksum = last_file_sp->GetFileSpec().GetChecksum(); +if (checksum && checksum != last_file_sp->GetChecksum()) { +

[Lldb-commits] [lldb] [lldb] Print a warning on checksum mismatch (PR #71459)

2023-11-07 Thread Adrian Prantl via lldb-commits
@@ -300,6 +300,16 @@ size_t SourceManager::DisplaySourceLinesWithLineNumbersUsingLastFile( break; } } + +Checksum checksum = last_file_sp->GetFileSpec().GetChecksum(); +if (checksum && checksum != last_file_sp->GetChecksum()) { +

[Lldb-commits] [lldb] [lldb] Replace some register handling asserts with lldbassert (PR #71175)

2023-11-07 Thread Adrian Prantl via lldb-commits
adrian-prantl wrote: Since ReadRegister returns a Status anyway, this shouldn't be too difficult to achieve? https://github.com/llvm/llvm-project/pull/71175 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 066eea7 - Revert "Reland "clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (#70639)""

2023-11-07 Thread Hans Wennborg via lldb-commits
Author: Hans Wennborg Date: 2023-11-07T15:52:19+01:00 New Revision: 066eea75d38957353824b46474413ef2632d01a7 URL: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7 DIFF: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7.diff

[Lldb-commits] [lldb] [clang] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-11-07 Thread via lldb-commits
zmodem wrote: This causes Clang to assert: ``` llvm/lib/IR/Metadata.cpp:689: void llvm::MDNode::resolve(): Assertion `isUniqued() && "Expected this to be uniqued"' failed. ``` See https://bugs.chromium.org/p/chromium/issues/detail?id=1500262#c1 for a reproducer. I'll revert to

[Lldb-commits] [compiler-rt] [lldb] [mlir] [libc] [libcxx] [llvm] [clang] [lld] [flang] [libc][bazel] Add powf target and fix bazel overlay. (PR #71464)

2023-11-07 Thread via lldb-commits
https://github.com/lntue closed https://github.com/llvm/llvm-project/pull/71464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

2023-11-07 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/70779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [lldb] [mlir] [libc] [libcxx] [llvm] [clang] [lld] [flang] [libc][bazel] Add powf target and fix bazel overlay. (PR #71464)

2023-11-07 Thread via lldb-commits
https://github.com/lntue updated https://github.com/llvm/llvm-project/pull/71464 >From c5b8cfbae37c302158e3671a271634c71693123a Mon Sep 17 00:00:00 2001 From: Tue Ly Date: Mon, 6 Nov 2023 18:52:11 -0500 Subject: [PATCH] [libc][bazel] Add powf target and fix bazel overlay. ---

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

2023-11-07 Thread Michael Buch via lldb-commits
@@ -3059,9 +3059,8 @@ void DWARFASTParserClang::ParseSingleMember( // This needs to be done after updating FieldInfo which keeps track of where // field start/end so we don't later try to fill the space of this // artificial member with (unnamed bitfield) padding. - //

[Lldb-commits] [lldb] [LLDB] Don't ignore artificial variables and members for coroutines (PR #70779)

2023-11-07 Thread Michael Buch via lldb-commits
@@ -771,6 +771,10 @@ TypeSystemClang *TypeSystemClang::GetASTContext(clang::ASTContext *ast) { return clang_ast; } +bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) { + return Name.starts_with("_vptr$"); Michael137 wrote: On GCC I

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: DavidSpickett wrote: Please go through the unresolved comments and reply if you feel that you've done them, or ask questions if they don't make sense (I know Github doesn't make this super easy, but scrolling through the changed files

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -0,0 +1,25 @@ +# RUN: %clang_host -g %S/Inputs/main.c -o %t DavidSpickett wrote: Pick one of the two test files, I can't tell which one is supposed to be the actual one (perhaps you forgot to `git rm`

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -89,13 +97,18 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, s->Printf("<"); dumped_something = true; } else { - ConstString name; + ConstString name_func;

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, s->Printf(", value = 0x%16.16" PRIx64, m_addr_range.GetBaseAddress().GetOffset()); } - ConstString

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -89,13 +97,18 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, s->Printf("<"); dumped_something = true; } else { - ConstString name; + ConstString name_func;

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -163,6 +176,14 @@ bool SymbolContext::DumpStopContext(Stream *s, ExecutionContextScope *exe_scope, dumped_something = true; if (symbol->GetType() == eSymbolTypeTrampoline) s->PutCString("symbol stub

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, s->Printf(", value = 0x%16.16" PRIx64, m_addr_range.GetBaseAddress().GetOffset()); } - ConstString

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: @@ -252,11 +263,24 @@ void Symbol::GetDescription(Stream *s, lldb::DescriptionLevel level, s->Printf(", value = 0x%16.16" PRIx64, m_addr_range.GetBaseAddress().GetOffset()); } - ConstString

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-07 Thread David Spickett via lldb-commits
=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: DavidSpickett wrote: > While I was working in the test you recommended, I noticed the following: if > I run image lookup -r -s UNEXPECTED_PATTERN through the '-o' flag, any > command passed after that with another '-o' flag will not be

[Lldb-commits] [llvm] [lldb] [lldb][AArch64][Linux] Add SME2 release notes and usage docs (PR #70935)

2023-11-07 Thread David Spickett via lldb-commits
DavidSpickett wrote: ping! https://github.com/llvm/llvm-project/pull/70935 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/70300 >From 45a9d131ce6c9fb31355519cd810ceff32c05ee7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 11 Oct 2023 14:54:07 +0100 Subject: [PATCH 1/8] [lldb][AArch64][Linux] Add field information for the

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,102 @@ +//===-- RegisterFlagsLinux_arm64.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/70300 >From 45a9d131ce6c9fb31355519cd810ceff32c05ee7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 11 Oct 2023 14:54:07 +0100 Subject: [PATCH 1/7] [lldb][AArch64][Linux] Add field information for the

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4506de1e2bfe9352331d75fe6d3c89f3d2f5287c efeedcbf1ac6071f0cf480301cbc11f82db25b22 --

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread David Spickett via lldb-commits
@@ -0,0 +1,77 @@ +//===-- RegisterFlagsLinux_arm64.h --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Add field information for the CPSR register (PR #70300)

2023-11-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/70300 >From 45a9d131ce6c9fb31355519cd810ceff32c05ee7 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 11 Oct 2023 14:54:07 +0100 Subject: [PATCH 1/6] [lldb][AArch64][Linux] Add field information for the

[Lldb-commits] [llvm] [clang] [flang] [clang-tools-extra] [libcxx] [lldb] [openmp] [compiler-rt] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-07 Thread Giorgis Georgakoudis via lldb-commits
ggeorgakoudis wrote: LGTM but fix comments: 1. Comments should be in their own line, move them above the relevant line 2. Comments should be complete sentences ending with a full stop https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits

[Lldb-commits] [lldb] cab0a19 - [lldb][test] Remove xfail for integral member test on Windows

2023-11-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-07T09:37:21Z New Revision: cab0a19467ac2e6e1e022087f4b6cb90d55da040 URL: https://github.com/llvm/llvm-project/commit/cab0a19467ac2e6e1e022087f4b6cb90d55da040 DIFF: https://github.com/llvm/llvm-project/commit/cab0a19467ac2e6e1e022087f4b6cb90d55da040.diff

[Lldb-commits] [lldb] ea9d44f - Reland "[lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (#71402)"

2023-11-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-07T09:35:25Z New Revision: ea9d44f5ec13383372b0b972fceafca881e89186 URL: https://github.com/llvm/llvm-project/commit/ea9d44f5ec13383372b0b972fceafca881e89186 DIFF: https://github.com/llvm/llvm-project/commit/ea9d44f5ec13383372b0b972fceafca881e89186.diff

[Lldb-commits] [lldb] 75b195c - Revert "[lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (#71402)"

2023-11-07 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2023-11-07T09:07:35Z New Revision: 75b195cc4cee8d6f3216b7602f8247f5888a47af URL: https://github.com/llvm/llvm-project/commit/75b195cc4cee8d6f3216b7602f8247f5888a47af DIFF: https://github.com/llvm/llvm-project/commit/75b195cc4cee8d6f3216b7602f8247f5888a47af.diff

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/71402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4989c62 - [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (#71402)

2023-11-07 Thread via lldb-commits
Author: David Spickett Date: 2023-11-07T09:01:36Z New Revision: 4989c62b318229bff2643c244ebbd03c20e2f781 URL: https://github.com/llvm/llvm-project/commit/4989c62b318229bff2643c244ebbd03c20e2f781 DIFF: https://github.com/llvm/llvm-project/commit/4989c62b318229bff2643c244ebbd03c20e2f781.diff

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-07 Thread David Spickett via lldb-commits
@@ -108,10 +104,11 @@ bool ArchitectureAArch64::ReconfigureRegisterInfo(DynamicRegisterInfo _info, if (!vg_reg_value && !svg_reg_value) return false; + auto regs = reg_info.registers(); DavidSpickett wrote: I couldn't figure out how to get that to

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-07 Thread David Spickett via lldb-commits
@@ -89,12 +89,18 @@ class DynamicRegisterInfo { GetRegisterInfo(llvm::StringRef reg_name) const; typedef std::vector reg_collection; - llvm::iterator_range registers() const { -return llvm::iterator_range(m_regs); + + template T registers();

[Lldb-commits] [lldb] [lldb] Add template method for getting const or mutable regs from DynamicRegisterInfo (PR #71402)

2023-11-07 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/71402 >From 8b074aa5024deadfb74db6c10a812e5a474c6f1a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 6 Nov 2023 15:02:29 + Subject: [PATCH 1/2] [lldb] Add template method for getting const or