[Lldb-commits] [clang] [lldb] [clang] Split ObjectFilePCHContainerReader from ObjectFilePCHContainerWriter (PR #99599)

https://github.com/benlangmuir approved this pull request. LGTM other than what Jan already mentioned, thanks! https://github.com/llvm/llvm-project/pull/99599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [llvm] [clang][modules] Serialize `CodeGenOptions` (PR #146422)

https://github.com/benlangmuir approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/146422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFCI: Clean up `CompilerInstance::create{File, Source}Manager()` (PR #160748)

https://github.com/benlangmuir edited https://github.com/llvm/llvm-project/pull/160748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFCI: Clean up `CompilerInstance::create{File, Source}Manager()` (PR #160748)

@@ -382,17 +382,18 @@ IntrusiveRefCntPtr CompilerInstance::createDiagnostics( // File Manager -FileManager *CompilerInstance::createFileManager() { +void CompilerInstance::createFileManager() { assert(VFS && "CompilerInstance needs a VFS for creating FileManager"); Fil

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFCI: Clean up `CompilerInstance::create{File, Source}Manager()` (PR #160748)

https://github.com/benlangmuir approved this pull request. LGTM except for figuring out what to do about polly, if anything. https://github.com/llvm/llvm-project/pull/160748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [clang] NFCI: Clean up `CompilerInstance::create{File, Source}Manager()` (PR #160748)

https://github.com/benlangmuir commented: There is an additional reference to this function in polly https://github.com/llvm/llvm-project/blob/d48bda5421c5af9baa5bc98ba4e3a453937ff96a/polly/lib/External/isl/interface/extract_interface.cc#L550 https://github.com/llvm/llvm-project/pull/160748 ___