[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

delcypher created this revision. delcypher added reviewers: sgraenitz, JDevlieghere. Herald added a subscriber: mgorny. Herald added a project: LLDB. If we forget to build `libcxx` then previously the CMake configure would have errors like: CMake Error at

[Lldb-commits] [PATCH] D57750: [CMake] Don't add `cxx` to `LLDB_TEST_DEPS` if it doesn't exist.

delcypher added a comment. Wow phabricator has made a right mess of displaying this patch. It's easier to look at as. diff --git a/lldb/CMakeLists.txt b/lldb/CMakeLists.txt index fdd84a6e7b7..6b26adb3383 100644 --- a/lldb/CMakeLists.txt +++ b/lldb/CMakeLists.txt @@ -111,7 +111,11 @@

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added a comment. @daltenty The "This removes our dependency on psutil." text sounds broader than it actually is. Looking at the implementation the removal of the dependency is only for AIX. All other platforms still depends on the `psutil` module. I think the commit message should

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added inline comments. Comment at: llvm/utils/lit/lit/LitConfig.py:93 # See lit.util.killProcessAndChildren() -try: -import psutil # noqa: F401 -except ImportError: -self.fatal("Setting a timeout per

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added inline comments. Comment at: llvm/utils/lit/lit/LitConfig.py:81 +@property +def killProcessAndChildrenIsSupported(self): +""" Sorry to be pedantic but this (`LitConfig.killProcessAndChildrenIsSupported`) should be called

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added a comment. @daltenty Other than the minor nit, LGTM. Comment at: llvm/utils/lit/lit/util.py:449 +(recursively). It is currently implemented using the psutil module on some +plaftorms which provides a simple platform neutral implementation.

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher accepted this revision. delcypher added a comment. LGTM. @davide While I agree with sentiment of fixing psutil, the use of psutil was never meant to be permanent. As the owner of this code I don't mind making accommodations for other platforms provided we keep implementation details

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

delcypher added inline comments. Comment at: libcxx/utils/libcxx/util.py:256 """ -import psutil -try: -psutilProc = psutil.Process(pid) -# Handle the different psutil API versions +if platform.system() == 'AIX': +subprocess.call('kill

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:1316 +auto_generated_function.AppendString("def __user_code():"); +for (int i = 0; i < num_lines; ++i) { + sstr.Clear(); Why

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher updated this revision to Diff 500994. delcypher added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 Files: lldb/bindings/interface/SBWatchpointDocstrings.i

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher accepted this revision. delcypher added a comment. @mib Thanks for working on this. LGTM (with very minor nits), but you should probably wait for someone who works on LLDB more frequently than me to give you the ok. Comment at:

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher updated this revision to Diff 500993. delcypher added a comment. Herald added a subscriber: JDevlieghere. Fix reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 Files:

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher created this revision. Herald added a project: All. delcypher requested review of this revision. Herald added a project: LLDB. This patch adds the following methods: - `GetType()` - `IsWatchVariable()` - `GetWatchSpec()` These effectively expose methods that `lldb_private::Watchpoint`

[Lldb-commits] [PATCH] D144688: [lldb] Fix {break, watch}point command function stopping behaviour

delcypher added a comment. In D144688#4165144 , @kparzysz wrote: > This broke Lua support: > > In file included from > /w/src/llvm.org/lldb/source/Plugins/ScriptInterpreter/Lua/ScriptInterpreterLua.cpp:9: > >

[Lldb-commits] [PATCH] D144688: [lldb] Fix watchpoint command function stopping behavior

delcypher added inline comments. Comment at: lldb/source/Commands/CommandObjectWatchpointCommand.cpp:425 else if (!m_options.m_function_name.empty()) { -std::string oneliner(m_options.m_function_name); +std::string oneliner("return "); +

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher updated this revision to Diff 501582. delcypher edited the summary of this revision. delcypher added a comment. - Fix nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937 Files:

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher marked 2 inline comments as done. delcypher added a comment. Thanks for the review and approval. I've the fixed the nits so I'm going to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/ https://reviews.llvm.org/D144937

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rG55a363fea18b: [LLDB] Expose several methods in SBWatchpoint (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher added a comment. In D144937#4159324 , @jasonmolenda wrote: > Hi Dan, I hadn't looked this over very closely but one thing that jumped out > is that you're adding a member to SBWatchpoint, and we can't do that, it's an > API breaking change.

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher added inline comments. Comment at: lldb/source/API/SBWatchpoint.cpp:319 + } + return false; +} @bulbazord What I don't like about my implementation here is that the user can't tell the difference between 1. there's no shared pointer AND 2.

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher added inline comments. Comment at: lldb/test/API/python_api/watchpoint/TestSetWatchpoint.py:66 +if variable_watchpoint: +# FIXME: There should probably be an API to create a variable watchpoint +self.runCmd('watchpoint set variable -w

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher marked an inline comment as done. delcypher added inline comments. Comment at: lldb/source/API/SBWatchpoint.cpp:319 + } + return false; +} bulbazord wrote: > delcypher wrote: > > @bulbazord What I don't like about my implementation here is that the

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher updated this revision to Diff 501356. delcypher added a comment. - Add `WatchpointValueKind` enum - Use `WatchpointValueKind` for new `GetWatchValueKind()` method (previously named `SBWatchpoint::IsWatchVariable`) - Add `IsWatchingsRead()` method - Add `IsWatchingWrites()` method -

[Lldb-commits] [PATCH] D144937: [LLDB] Expose several methods in SBWatchpoint

delcypher marked an inline comment as done. delcypher added a comment. @JDevlieghere @mib @bulbazord Thanks for all the feedback. This patch is ready for another review pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144937/new/

[Lldb-commits] [PATCH] D149792: Add AArch64 MASK watchpoint support to debugserver

delcypher added inline comments. Comment at: lldb/test/API/python_api/watchpoint/watchlocation/TestTargetWatchAddress.py:132 value.GetType().GetPointeeType()) -# Watch for write to *g_char_ptr. -error = lldb.SBError() @jasonmolenda

[Lldb-commits] [PATCH] D149692: Allow scripted thread plans to modify the stop reason shown when the plan completes

delcypher added inline comments. Comment at: lldb/examples/python/scripted_step.py:130 +def stop_description(self, stream): +stream.Print("Simple step completed") @jingham Thanks for implementing this. Is there a reason why the interface needs to