[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. Thanks @jingham. > if the `IOHandlerDelegate` could say whether it wants to be notified for > `IOHandlerActivated` when non-interactive (like have a > "`ShouldNotifyWhenNonInteractive`" method), and then the `IOHandler` could > dispatch it or not based on the

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione updated this revision to Diff 153114. kastiglione added a comment. Update a comment https://reviews.llvm.org/D48658 Files: scripts/Python/python-extensions.swig Index: scripts/Python/python-extensions.swig === ---

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione added a subscriber: granata.enrico. kastiglione added a comment. Thanks @granata.enrico, sorry for the disruption, I noticed previous comments after I had submitted this. https://reviews.llvm.org/D48658 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione created this revision. kastiglione added reviewers: clayborg, granata.enrico. This change fixes one issue with `lldb.command`, and also reduces the implementation. The fix: a command function's docstring was not shown when running `help `. This is because the docstring attached the

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione added a comment. @clayborg I'll dig into how `python-extensions.swig` gets tested, and add something accordingly. I have only briefly looked at `cmdtemplate.py`. I can look into adding similar registration behavior to it. For what it's worth, I prefer functions to classes for

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

kastiglione created this revision. kastiglione added a reviewer: xiaobai. Fix a "Manay" in SBSymbolContext.i https://reviews.llvm.org/D48620 Files: scripts/interface/SBSymbolContext.i Index: scripts/interface/SBSymbolContext.i

[Lldb-commits] [PATCH] D48620: Fix a single typo in SBSymbolContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL335709: Fix a single typo in SBSymbolContext (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48620 Files:

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

kastiglione updated this revision to Diff 153654. kastiglione added a comment. Add tests and make command_name optional https://reviews.llvm.org/D48658 Files: packages/Python/lldbsuite/test/functionalities/command_script/TestCommandScript.py

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D49776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D48658: Fix and simplify lldb.command decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rL336287: Fix and simplify lldb.command decorator (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48658 Files:

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione created this revision. kastiglione added reviewers: clayborg, jingham. Within .lldbinit, regex commands can be structured as a list of substitutions over multiple lines. It's possible that this is uninentional, but it works and has benefits. For example: command regex

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. There are other commands that print instructions in the same way that `command regex` does, should they be updated in this change too? https://reviews.llvm.org/D48752 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione updated this revision to Diff 172488. kastiglione added a comment. Added IOHandlerActivatedInteractively https://reviews.llvm.org/D48752 Files: include/lldb/Core/IOHandler.h packages/Python/lldbsuite/test/functionalities/command_regex/TestCommandRegex.py

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

This revision was automatically updated to reflect the committed changes. Closed by commit rL346099: Update framework-header-fix to force system sed (authored by kastiglione, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

kastiglione added a comment. @Keith I screwed up and committed without amending the commit message to attribute you as the author :( Repository: rL LLVM https://reviews.llvm.org/D49776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. @jingham If you're still willing to review this change to `command regex`, it is updated per our previous discussion, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. @clayborg this has been updated the approach you suggested, adding an `interactive` parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355793: Quiet command regex instructions during batch execution (authored by kastiglione, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione added a comment. Thanks for reviewing @clayborg. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D59101: [SBAPI] Log from record macro

kastiglione added a comment. I'm getting build failures that appear to be caused by this patch. I'm compiling on macOS with Xcode 10.1. The failures are uses of `LLDB_RECORD_DUMMY()`, passing a callback function pointer as one of the args. This results in errors like:

[Lldb-commits] [PATCH] D48752: Quiet command regex instructions during batch execution

kastiglione updated this revision to Diff 187135. kastiglione added a comment. Herald added a subscriber: jdoerfert. Add interactive parameter CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48752/new/ https://reviews.llvm.org/D48752 Files: include/lldb/Core/IOHandler.h

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replaces references to svn commits with the lldb version number those commits first appeared in. Themotivation is to show that these features are

[Lldb-commits] [PATCH] D61778: [Docs] Replace SVN revisions with lldb versions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365559: [Docs] Replace SVN revisions with lldb versions (authored by kastiglione, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adds a few more aliases to the lldb translations. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69422 Files:

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. > I wonder if it is time to take the gdb commands out and just make this a task > -> lldb commands table? +1 from me > The abbrev script sounds cool. We have a bunch of useful Python examples in > examples/Python, this sounds like a perfect candidate for that if

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. Thanks. I thought this was reasonable since the documentation shows many uses of lldb aliases already. > intent was to train users in LLDB's more regular command syntax lldb's aliases, especially the regex ones, are great. In my experience, people prefer aliases,

[Lldb-commits] [PATCH] D69422: [lldb][Docs] Add extra lldb aliases to gdb->lldb map

kastiglione added a comment. fwiw I have a python command called `abbrev` that takes a command and shows you the alias you can use instead. (lldb) abbrev mem read -s 8 -c 10 -f x 0xfedcba00 x/10xg 0xfedcba00 (lldb) abbrev break set -f foo.c -l 123 b foo.c:23 (lldb) abbrev thread jump

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added a comment. > Given the `expr` status quo, I'd stick with that. I want to give a +1 to //not// copying `expr`. I think the tradeoff is not not worth it. My user perspective is that lldb could be improved by making more decisions with the user in mind, not lldb's engineers (to

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:65 + + return CommandParsed(command); +} this is missing error handling for unsupported languages, such as `script -l swift` Comment at:

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:50-51 + + std::tie(head, tail) = tail.split(' '); + if (head != "-l" && head != "--language") +return CommandParsed(command); generally, lldb supports more than

[Lldb-commits] [PATCH] D86996: [lldb] Add -l/--language option to script command

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectScript.cpp:37 +"default", +"The default scripting language.", +}, is the default's name available in a `define`? If maybe it'd be good to include it here? I

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. @teemperor I'm not sure what these build errors mean, for example https://reviews.llvm.org/B70998. Also there's the linux build failure, but that's not relevant for debugserver, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

This revision was automatically updated to reflect the committed changes. Closed by commit rG447ba60a224f: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG55dd731b291c: [debugserver] Extract function for default launch flavor (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D87633: [lldb] Reword CompilerType docstring to not say "generic type"

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG757ac4ccfb8b: [lldb] Reword CompilerType docstring to not say generic type (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D87633: [lldb] Reword CompilerType docstring to not say "generic type"

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Since "generic type" has a precise meaning in some

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione updated this revision to Diff 290581. kastiglione added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327 Files: lldb/tools/debugserver/source/debugserver.cpp Index:

[Lldb-commits] [PATCH] D87345: [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Fix references to LLDB_ENABLE_TESTS. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione added a comment. Follow up to 8aeb212887024a615ca02437cd12fa055bd54b6f Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87327/new/ https://reviews.llvm.org/D87327

[Lldb-commits] [PATCH] D87327: [debugserver] Extract function for default launch flavor

kastiglione created this revision. kastiglione added reviewers: jasonmolenda, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Extract a function for turning

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added inline comments. Comment at: lldb/source/lldb.cpp:22 #ifdef LLDB_REVISION return LLDB_REVISION; #else this won't expand to a string as is, does this indicate it's unused? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296578. kastiglione added a comment. Unbreak code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296579. kastiglione added a comment. switch NULL to "" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index: lldb/source/lldb.cpp

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296700. kastiglione added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index:

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione updated this revision to Diff 296695. kastiglione added a comment. Restore repository handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939 Files: lldb/source/lldb.cpp Index:

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

kastiglione added a comment. @teemperor I removed the comment and restored repository handling. It becomes much more of a useless diff :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88939/new/ https://reviews.llvm.org/D88939

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. > (and whether we should make this implicit a relative path vs for example some > kind of placeholder 'variable' or something like that). I'm not sure either, but if we do it could probably be as a `./` as prefix? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. For lldbinit files, and any file that gets `command source`'d, I think it would be useful if they could perform `command script import some/path/to/command.py`, where `some` is resolved relative to the dirname of the lldb file. For example, given an lldbinit file

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. In D89295#2327367 , @labath wrote: > That actually seems to work (if you add .py to the end). Yes that was my (poorly explained) point, I use this form regularly. Is it not better to require an explicit `~` instead of

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

kastiglione added inline comments. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:644 + // FIXME: Stop using this to control adding to the history and then replace + // this with m_command_source_dirs.size(). uint32_t m_command_source_depth;

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. > I don't think it's that unreasonable to do the same for `$HOME` to be able to > use imports relative to the `.lldbinit` file in both cases. In theory I agree, but in practice I think it's unnecessary because `~` can be used (and possibly should be explicit), and

[Lldb-commits] [PATCH] D89334: [lldb] Support Python imports relative the to the current file being sourced

kastiglione added a comment. Would you mind adding a couple tests for imports via a path to a python file, ex `command script import command.py`, maybe even a test that checks nested directories, ex: `command script import path/to/command.py`? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

kastiglione added a comment. About `-P`, the man page for `lldb` and the driver's `Options.td` say it: > Prints out the path to the lldb.py file for this version of lldb. Should it do just that? If so this can be simplified further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296215. kastiglione added a comment. Resyntax the isinstance asserts; Add expect() tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files:

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:2440-2441 +assert "patterns must be a collection of strings" and False +if isinstance(substrs, six.string_types): +assert "substrs must be a collection

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione updated this revision to Diff 296217. kastiglione added a comment. "missing a matcher" -> "missing a matcher argument" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/ https://reviews.llvm.org/D88792 Files:

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione added inline comments. Comment at: lldb/test/API/types/TestRecursiveTypes.py:54 +self.expect("print tpi") +self.expect("print *tpi") aprantl wrote: > I'm not not sure I understand this change? The second parameter, `msg`, is only

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

This revision was automatically updated to reflect the committed changes. Closed by commit rG010d7a388b14: [lldb/test] Catch invalid calls to expect() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88792/new/

[Lldb-commits] [PATCH] D88939: [lldb] Remove unused code in GetVersion (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08924b54debc: [lldb] Remove unused code in GetVersion (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D89273: [lldb] Handle alternative output in TestAbortExitCode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa52cc9b4be36: [lldb] Handle alternative output in TestAbortExitCode (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D89273: [lldb] Handle alternative output in TestAbortExitCode

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. This test On macOS, this test can instead return `status = 0 (0x) Terminated due

[Lldb-commits] [PATCH] D89295: [lldb] Add /Users/jonas to Python's sys.path

kastiglione added a comment. Could this have undesirable side effects? I wouldn't expect `command script import` to be searching my home dir. Second question: is there value in requiring the explicit use of `~`, for ex: `command script import ~/path`. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf16cecf3752a: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName() (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89589: [lldb] Implement ObjCExceptionThrowFrameRecognizer::GetName()

kastiglione created this revision. kastiglione added a reviewer: jingham. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Implement `GetName` for `ObjCExceptionThrowFrameRecognizer`.

[Lldb-commits] [PATCH] D89614: [lldb] Enable cmake policy CMP0077 for option()

This revision was automatically updated to reflect the committed changes. Closed by commit rGae4fe1984f0e: [lldb] Enable cmake policy CMP0077 for option() (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89614/new/

[Lldb-commits] [PATCH] D89614: [lldb] Enable cmake policy CMP0077 for option()

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. kastiglione requested review of this revision. In lldb, explicitly set the "option() honors normal variables" CMake policy. This applies

[Lldb-commits] [PATCH] D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime

kastiglione added a comment. In D86493#2236454 , @aprantl wrote: > Sometimes these odd leaf APIs are used by custom downstream variants of LLDB I wondered about other consumers, how often is it the case that mainline lldb has code used only downstream?

[Lldb-commits] [PATCH] D86493: [lldb][NFC] Remove unused/misnamed SetObjectModificationTime

This revision was automatically updated to reflect the committed changes. Closed by commit rG66c48802918d: Remove unused/misnamed SetObjectModificationTime (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86493/new/

[Lldb-commits] [PATCH] D86667: [lldb/Target] Add custom interpreter option to `platform shell`

kastiglione added inline comments. Comment at: lldb/source/API/SBPlatform.cpp:59 + +if (command_interpreter && command_interpreter[0]) { + full_command += command_interpreter; JDevlieghere wrote: > Given that this pattern repeats a few times in this

[Lldb-commits] [PATCH] D86493: Remove unused/misnamed SetObjectModificationTime

kastiglione created this revision. kastiglione added reviewers: clayborg, friss, JDevlieghere, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Remove `SetObjectModificationTime` which is not currently used, and assigns

[Lldb-commits] [PATCH] D86497: [lldb] Add reproducer verifier

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectReproducer.cpp:670 +auto error_callback = [&](llvm::StringRef error) { + result.AppendError(error); +}; Is this lambda missing an assignment to `errors`? Repository:

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d19eb542db4: [lldb/docs] Remove manual codesigning documentation (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D88119: [lldb] Remove lldb-perf remenant

This revision was automatically updated to reflect the committed changes. Closed by commit rG9abd1e8f4e5d: [lldb] Remove lldb-perf remenant (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88119/new/

[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor, aprantl. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Add missing declaration for `malloc_get_all_zones` in heap.py. Repository: rG

[Lldb-commits] [PATCH] D87868: [RFC] When calling the process mmap try to call all found instead of just the first one

kastiglione added a comment. Should lldb avoid calling asan (or any other sanitizer's) `mmap`? If so, maybe this function can be sanitizer aware and ignore those symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87868/new/

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione accepted this revision. kastiglione added a comment. This revision is now accepted and ready to land. Nice improvement! I think it's strange that `break delete DeleteMeNot` and `break delete --disabled DeleteMeNot ` behave differently. For the case that it supports, I would suggest

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88181: Utility: ignore OS version on non-Darwin targets in `ArchSpec`

kastiglione accepted this revision. kastiglione added a comment. sgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88181/new/ https://reviews.llvm.org/D88181 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, teemperor, friss. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. The `macos-setup-codesign.sh` script has been in place for over two years. If

[Lldb-commits] [PATCH] D88257: [lldb/docs] Remove manual codesigning documentation

kastiglione added a comment. I agree it's nice to have somewhere, but git history should be fine. I should elaborate on motivations, 1. ensure everyone is using the script so that any issues are surfaced, 2. prevent missteps in the manual process, which may also be bit rotting if everyone is

[Lldb-commits] [PATCH] D88119: [lldb] Remove lldb-perf remenant

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Delete a file remaining from the deletion of lldb-perf in D64362 .

[Lldb-commits] [PATCH] D88123: Add the ability to write 'target stop-hooks' in Python

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4625 + +def__init__(self, target, extra_args, dict): + missing space after `def` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b3b9ba1c7d8: [lldb/Commands] Fix outdated `breakpoint command

[Lldb-commits] [PATCH] D88792: [lldb/test] Catch invalid calls to expect()

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, teemperor. Herald added subscribers: lldb-commits, kbarton, nemanjai. Herald added a project: LLDB. kastiglione requested review of this revision. Add preconditions to `TestBase.expect()` that catch

[Lldb-commits] [PATCH] D88158: [lldb/examples] Add missing declaration in heap.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGada1e2ffa117: [lldb/examples] Add missing declaration in heap.py (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88158/new/

[Lldb-commits] [PATCH] D88129: Add "break delete --disabled" to delete all currently disabled breakpoints

kastiglione added inline comments. Comment at: lldb/source/Commands/Options.td:232 +Desc<"Delete all breakpoints which are currently disabled. When using the disabled option " +"any breakpoints listed on the command line are EXCLUDED from deletion.">; }

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Update the some examples in the help string for

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint command add -s python 1 -Enter your Python command(s). Type 'DONE' to end. -> def breakpoint_output (bp_no): -> out_string = "Hit breakpoint

[Lldb-commits] [PATCH] D87807: [lldb/Commands] Fix outdated `breakpoint command add` help string

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectBreakpointCommand.cpp:174-181 -(lldb) breakpoint command add -s python 1 -Enter your Python command(s). Type 'DONE' to end. -> def breakpoint_output (bp_no): -> out_string = "Hit breakpoint

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione created this revision. kastiglione added a reviewer: aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `is_variadic_ptr` is unused. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D92778

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG012fd0b17f30: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D92778: [lldb] Remove unused IsFunctionType is_variadic_ptr parameter (NFC)

kastiglione added a comment. Yes I plan to merge this manually (rather than automerge) to ensure it's not disruptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92778/new/ https://reviews.llvm.org/D92778

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione created this revision. kastiglione added reviewers: jingham, teemperor, aprantl, JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Restore ability to call `expect()` with a message and no matcher. After

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. That's much better. I'll change those callers can be changed to `runCmd`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. @teemperor maybe? Do you mean validation should go in `runCmd`? Or do you mean something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, teemperor. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. kastiglione requested review of this revision. Herald added a subscriber: JDevlieghere. Following discussion in D91193

[Lldb-commits] [PATCH] D91193: [lldb] Fine tune expect() validation

kastiglione added a comment. Thanks for pointing this in the right direction @labath, @teemperor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91193/new/ https://reviews.llvm.org/D91193 ___

[Lldb-commits] [PATCH] D91206: [lldb] Switch expect to runCmd in TestRecursiveTypes (NFC)

kastiglione updated this revision to Diff 304568. kastiglione added a comment. Remove bogus message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91206/new/ https://reviews.llvm.org/D91206 Files: lldb/test/API/types/TestRecursiveTypes.py

  1   2   3   4   5   6   7   8   >