[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

dmantipov created this revision. dmantipov added reviewers: labath, jankratochvil. dmantipov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere, aprantl. dmantipov requested review of this revision. Try to speedup collecting DWARF attribute values by using emplace_back()

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov updated this revision to Diff 291838. dmantipov added a comment. Minor style adjustments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87675/new/ https://reviews.llvm.org/D87675 Files: lldb/include/lldb/Symbol/Function.h

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov created this revision. dmantipov added reviewers: labath, jankratochvil, teemperor. dmantipov added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: shafik. dmantipov requested review of this revision. Prefer emplace_back() over push_back()

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

dmantipov abandoned this revision. dmantipov added a comment. Superseded with https://reviews.llvm.org/D87675. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov updated this revision to Diff 291894. dmantipov added a comment. OK let's reduce it to minimum minimorum. As for the profiling, l can see possible improvement around DWARFAttributes::Append() - inlining even at -O2 and eliminating extra constructor call makes 10.61% intern-state

[Lldb-commits] [PATCH] D87675: [lldb/DWARF] Refactor to prefer emplace_back() vs. push_back()

dmantipov updated this revision to Diff 291870. dmantipov added a comment. Use std::pair rather than an ad-hoc two-member trivial structures. Since std::pair provides the default constructor to initialize both members, no extra C++ glue is required for emplace_back()'ing the pairs into

[Lldb-commits] [PATCH] D87441: Speedup collecting DWARF attribute values

dmantipov updated this revision to Diff 291519. dmantipov added a comment. Drop prefixes and tweak the style to match clang-format requirements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87441/new/ https://reviews.llvm.org/D87441 Files:

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68358081585b: Add optimal thread strategy (authored by dmantipov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

dmantipov created this revision. dmantipov added a reviewer: labath. Herald added subscribers: llvm-commits, lldb-commits, arphaman. Herald added projects: LLDB, LLVM. dmantipov requested review of this revision. Herald added a subscriber: JDevlieghere. Add an optimal thread strategy to execute

[Lldb-commits] [PATCH] D87765: [llvm][lldb] Add optimal ThreadPool concurrency

dmantipov added a comment. Running on 48-core system, I was pretty surprised to see 48-threads pool when attempting to debug a toy C++ program. So here is a fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87765/new/