[Lldb-commits] [lldb] r248316 - On second thought, amend the previous patch to pass itself the ValueObject& for the static value instead of just its type

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 14:58:02 2015 New Revision: 248316 URL: http://llvm.org/viewvc/llvm-project?rev=248316=rev Log: On second thought, amend the previous patch to pass itself the ValueObject& for the static value instead of just its type Modified:

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Gotcha! My suggestion would be to add the DoesPrintValue() logic to SBTypeSummary. I can't recall if it's there already - but if not, it would be a fine thing to add. Then the MI could use SBValue and SBTypeSummary to make that determination as it sees fit.

Re: [Lldb-commits] [PATCH] D13058: LLDB-MI: Bug when evaluating strings containing characters from non-ascii range

2015-09-22 Thread Enrico Granata via lldb-commits
granata.enrico added a subscriber: granata.enrico. granata.enrico requested changes to this revision. granata.enrico added a reviewer: granata.enrico. granata.enrico added a comment. Is there a reason to explicitly add an API to get the concatenation of value and summary? We already have APIs

Re: [Lldb-commits] [PATCH] D13084: Fix covered-switch-default warning in FormatManager.

2015-09-22 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D13084 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r248363 - Allow CompilerType to express a vote on whether oneliner printing should happen

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 21:04:34 2015 New Revision: 248363 URL: http://llvm.org/viewvc/llvm-project?rev=248363=rev Log: Allow CompilerType to express a vote on whether oneliner printing should happen Modified: lldb/trunk/include/lldb/Symbol/CompilerType.h

[Lldb-commits] [lldb] r248359 - Add {TypeSystem|CompilerType}::GetTypeForFormatters()

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 20:39:46 2015 New Revision: 248359 URL: http://llvm.org/viewvc/llvm-project?rev=248359=rev Log: Add {TypeSystem|CompilerType}::GetTypeForFormatters() Different type system may have different notions of attributes of a type that do not matter for data formatters

[Lldb-commits] [lldb] r248338 - Move the "run" alias from process launch --shell to process launch --shell-expand-args when building on OS X

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 17:57:12 2015 New Revision: 248338 URL: http://llvm.org/viewvc/llvm-project?rev=248338=rev Log: Move the "run" alias from process launch --shell to process launch --shell-expand-args when building on OS X The argdumper-based launching is more friendly to System

[Lldb-commits] [lldb] r248339 - Fix a test case which was failing. There was no actual problem in the test logic, just a cosmetic issue with the presentation of the result by Foundation

2015-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 22 18:08:13 2015 New Revision: 248339 URL: http://llvm.org/viewvc/llvm-project?rev=248339=rev Log: Fix a test case which was failing. There was no actual problem in the test logic, just a cosmetic issue with the presentation of the result by Foundation Modified:

[Lldb-commits] [lldb] r248057 - On Linux, if you can't actually locate the libc++ install, do not attempt to use it

2015-09-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 18 17:26:34 2015 New Revision: 248057 URL: http://llvm.org/viewvc/llvm-project?rev=248057=rev Log: On Linux, if you can't actually locate the libc++ install, do not attempt to use it The failure mode when one gets this wrong is quite gnarly to then walk oneself out

Re: [Lldb-commits] [PATCH] D12929: Remove unused includes from clang in DataFormatters.

2015-09-17 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. I am assuming you built this successfully. If so, then yes please commit, it's a good change! http://reviews.llvm.org/D12929

[Lldb-commits] [lldb] r247957 - Make LanguageRuntime::GetDynamicTypeAndAddress return a ValueType

2015-09-17 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 17 17:56:38 2015 New Revision: 247957 URL: http://llvm.org/viewvc/llvm-project?rev=247957=rev Log: Make LanguageRuntime::GetDynamicTypeAndAddress return a ValueType For C++ and ObjC, dynamic values are always (at least somewhat) pointer-like in nature, so a

[Lldb-commits] [lldb] r247831 - Move hardcoded formatters from the FormatManager to the Language plugins

2015-09-16 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 16 13:28:11 2015 New Revision: 247831 URL: http://llvm.org/viewvc/llvm-project?rev=247831=rev Log: Move hardcoded formatters from the FormatManager to the Language plugins Modified: lldb/trunk/include/lldb/DataFormatters/FormatClasses.h

[Lldb-commits] [lldb] r247727 - Teach the ObjC data formatters to use the correct language when printing strings

2015-09-15 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 15 17:11:20 2015 New Revision: 247727 URL: http://llvm.org/viewvc/llvm-project?rev=247727=rev Log: Teach the ObjC data formatters to use the correct language when printing strings Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp Modified:

Re: [Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

2015-09-10 Thread Enrico Granata via lldb-commits
gle.com >> <mailto:rib...@google.com>> wrote: >> >> >> On Tue, Sep 8, 2015 at 3:10 PM Enrico Granata via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >> Author: enrico >> Date: Tue Sep 8 17:09:19 2015

[Lldb-commits] [lldb] r247195 - Remove Target::GetBasicType()

2015-09-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 9 17:00:18 2015 New Revision: 247195 URL: http://llvm.org/viewvc/llvm-project?rev=247195=rev Log: Remove Target::GetBasicType() I was experimenting with it briefly, and then settled on Target::GetTypeSystem + TypeSystem::GetBasicType, so this API is not necessary to

[Lldb-commits] [lldb] r247200 - Introduce the notion of an escape helper. Different languages have different notion of what to print in a string and how to escape non-printable things. The escape help

2015-09-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 9 17:30:24 2015 New Revision: 247200 URL: http://llvm.org/viewvc/llvm-project?rev=247200=rev Log: Introduce the notion of an escape helper. Different languages have different notion of what to print in a string and how to escape non-printable things. The escape

[Lldb-commits] [lldb] r247189 - Preparatory work for letting language plugins help the StringPrinter with formatting special characters

2015-09-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 9 15:59:49 2015 New Revision: 247189 URL: http://llvm.org/viewvc/llvm-project?rev=247189=rev Log: Preparatory work for letting language plugins help the StringPrinter with formatting special characters Modified:

Re: [Lldb-commits] TestFormattersBoolRefPtr.py on OSX

2015-09-09 Thread Enrico Granata via lldb-commits
> On Sep 9, 2015, at 5:10 AM, Tamas Berghammer wrote: > > Hi Enrico, > > TestFormattersBoolRefPtr.py started to fail on the OSX buildbot. I think the > first build where it is failed is > http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5522 >

[Lldb-commits] [lldb] r247082 - Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness

2015-09-08 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 8 17:09:19 2015 New Revision: 247082 URL: http://llvm.org/viewvc/llvm-project?rev=247082=rev Log: Implement a Target::GetTypeSystemForLanguage API, as well as provide helpers on the TypeSystem to get numeric types of specific sizes and signedness Modified:

Re: [Lldb-commits] [lldb] r246873 - Move the C++ data formatters to the C++ language plugin

2015-09-04 Thread Enrico Granata via lldb-commits
> On Sep 4, 2015, at 2:01 PM, Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Added: >lldb/trunk/include/lldb/DataFormatters/CXXFunctionPointer.h > - copied unchanged from r246859, > lldb/trunk/include/lldb/DataFormatters/CXXFun

[Lldb-commits] [lldb] r246884 - Add a --language (-l) option to type category {enable|disable} to allow people to turn on and off formatters for a given language

2015-09-04 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 4 17:07:48 2015 New Revision: 246884 URL: http://llvm.org/viewvc/llvm-project?rev=246884=rev Log: Add a --language (-l) option to type category {enable|disable} to allow people to turn on and off formatters for a given language Modified:

[Lldb-commits] [lldb] r246568 - Add support for language plugins to provide data formatters (second attempt)

2015-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 1 13:22:39 2015 New Revision: 246568 URL: http://llvm.org/viewvc/llvm-project?rev=246568=rev Log: Add support for language plugins to provide data formatters (second attempt) Historically, data formatters all exist in a global repository (the category map) On top

[Lldb-commits] [lldb] r246613 - Use Language::LanguageIsCPlusPlus instead of doing the same switch over language

2015-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 1 20:28:24 2015 New Revision: 246613 URL: http://llvm.org/viewvc/llvm-project?rev=246613=rev Log: Use Language::LanguageIsCPlusPlus instead of doing the same switch over language Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

[Lldb-commits] [lldb] r246614 - Add a Language::ForAllLanguages helper function

2015-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 1 20:31:10 2015 New Revision: 246614 URL: http://llvm.org/viewvc/llvm-project?rev=246614=rev Log: Add a Language::ForAllLanguages helper function Modified: lldb/trunk/include/lldb/Target/Language.h lldb/trunk/source/Target/Language.cpp Modified:

[Lldb-commits] [lldb] r246612 - Move the functions that FormatManager uses to actually load formatters into their own file

2015-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 1 20:21:31 2015 New Revision: 246612 URL: http://llvm.org/viewvc/llvm-project?rev=246612=rev Log: Move the functions that FormatManager uses to actually load formatters into their own file These are useful helpers over the low-level API of the FormattersContainer,

[Lldb-commits] [lldb] r246597 - std::initializer_list is not safe to return from a function, as copies are not guaranteed to extend the lifetime of the underlying storage

2015-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 1 17:24:35 2015 New Revision: 246597 URL: http://llvm.org/viewvc/llvm-project?rev=246597=rev Log: std::initializer_list is not safe to return from a function, as copies are not guaranteed to extend the lifetime of the underlying storage Modified:

[Lldb-commits] [lldb] r246512 - Make FormatEntity be a little bit smarter when printing function arguments

2015-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Aug 31 19:19:35 2015 New Revision: 246512 URL: http://llvm.org/viewvc/llvm-project?rev=246512=rev Log: Make FormatEntity be a little bit smarter when printing function arguments Modified: lldb/trunk/source/Core/FormatEntity.cpp Modified:

Re: [Lldb-commits] [lldb] r246518 - Attempt at fixing the CMake build

2015-08-31 Thread Enrico Granata via lldb-commits
> On Aug 31, 2015, at 6:23 PM, Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > Author: enrico > Date: Mon Aug 31 20:23:02 2015 > New Revision: 246518 > > URL: http://llvm.org/viewvc/llvm-project?rev=246518=rev > Log: > Attempt at

[Lldb-commits] [lldb] r246216 - Added a missing file to the CMakeLists

2015-08-27 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Aug 27 16:45:59 2015 New Revision: 246216 URL: http://llvm.org/viewvc/llvm-project?rev=246216view=rev Log: Added a missing file to the CMakeLists Modified: lldb/trunk/source/Target/CMakeLists.txt Modified: lldb/trunk/source/Target/CMakeLists.txt URL:

[Lldb-commits] [lldb] r246212 - Add a new type of plugin: Language plugin

2015-08-27 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Aug 27 16:33:50 2015 New Revision: 246212 URL: http://llvm.org/viewvc/llvm-project?rev=246212view=rev Log: Add a new type of plugin: Language plugin The Language plugin is menat to answer language-specific questions that are not bound to the existence of a process.

[Lldb-commits] [lldb] r246220 - Fixup one of the CMakeLists

2015-08-27 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Aug 27 16:55:55 2015 New Revision: 246220 URL: http://llvm.org/viewvc/llvm-project?rev=246220view=rev Log: Fixup one of the CMakeLists Modified: lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt Modified: lldb/trunk/source/Plugins/Language/ObjC/CMakeLists.txt

[Lldb-commits] [lldb] r246222 - Include mutex

2015-08-27 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Aug 27 17:14:06 2015 New Revision: 246222 URL: http://llvm.org/viewvc/llvm-project?rev=246222view=rev Log: Include mutex Modified: lldb/trunk/source/Target/Language.cpp Modified: lldb/trunk/source/Target/Language.cpp URL:

[Lldb-commits] [lldb] r246084 - Fix missing override warnings

2015-08-26 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 26 16:39:52 2015 New Revision: 246084 URL: http://llvm.org/viewvc/llvm-project?rev=246084view=rev Log: Fix missing override warnings Modified: lldb/trunk/source/Plugins/DynamicLoader/Hexagon-DYLD/DynamicLoaderHexagonDYLD.h

[Lldb-commits] [lldb] r245993 - Rename all functionalities/data-formatter test case with radar bug numbers in them to more meaningful names

2015-08-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 25 18:55:10 2015 New Revision: 245993 URL: http://llvm.org/viewvc/llvm-project?rev=245993view=rev Log: Rename all functionalities/data-formatter test case with radar bug numbers in them to more meaningful names Added:

Re: [Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration

2015-08-17 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Assuming it passes the test suite, LGTM http://reviews.llvm.org/D12092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

<    1   2   3   4