Author: gclayton
Date: Wed Jul 6 18:11:13 2016
New Revision: 274701
URL: http://llvm.org/viewvc/llvm-project?rev=274701&view=rev
Log:
LLDB reads incorrect memory ranges when displaying bitfields when reading bits
from file memory.
Bitfields were not correctly describing their offsets within th
Author: gclayton
Date: Wed Jul 6 18:16:24 2016
New Revision: 274703
URL: http://llvm.org/viewvc/llvm-project?rev=274703&view=rev
Log:
"frame variable" and "target variable" shouldn't allow us to get the address of
bitfields.
"frame variable" and "target variable" are trying to emulate the expre
Author: gclayton
Date: Thu Jul 7 14:44:14 2016
New Revision: 274788
URL: http://llvm.org/viewvc/llvm-project?rev=274788&view=rev
Log:
Fix DWARF 4 bitfield support in LLDB to support the DW_AT_data_bit_offset
attribute.
Modified:
lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFASTParserCl
Author: gclayton
Date: Thu Jul 7 18:57:39 2016
New Revision: 274809
URL: http://llvm.org/viewvc/llvm-project?rev=274809&view=rev
Log:
Fix it so that we only grab the typedef from the module DWARF file if the type
that is typedef'ed is a declaration. This fixes the following bugs:
[PR28156] Tes
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a few fixes and this will be ready.
Comment at: include/lldb/lldb-forward.h:147
@@ -146,2 +146,3 @@
class ObjectFileJITDelegate;
+class OCamlASTContext
Author: gclayton
Date: Fri Jul 8 18:06:38 2016
New Revision: 274948
URL: http://llvm.org/viewvc/llvm-project?rev=274948&view=rev
Log:
When calling "settings set target.source-map ", make sure
that exists before accepting it as a remapping.
We had some clients that had added old source paths r
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D22209
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D22218
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Looks good. Please pipe the GetName through the SBMemoryRegionInfo by modifying
the SBMemoryRegionInfo.h, SBMemoryRegionInfo.cpp, and SBMemoryRegionInfo.i
files. The signature sh
clayborg resigned from this revision.
clayborg edited reviewers, added: jingham; removed: clayborg.
clayborg added a comment.
Looks good to me, but for any thread plan stuff, I will defer to Jim Ingham.
http://reviews.llvm.org/D22230
___
lldb-commit
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
Jim Ingham should OK any changes. If Jim is happy, then I am OK.
http://reviews.llvm.org/D22231
___
lldb-commits mailing list
lldb-commits@lists.l
Author: gclayton
Date: Mon Jul 11 17:50:18 2016
New Revision: 275119
URL: http://llvm.org/viewvc/llvm-project?rev=275119&view=rev
Log:
Fixed a threading race condition where we could crash after calling
Debugger::Terminate().
The issue was we have two global variables: one that contains a Debugg
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Many issues. See inlined comments.
Comment at: include/lldb/lldb-private-types.h:57-58
@@ -56,1 +56,4 @@
// ax, ah, and al.
+
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
As Todd said, we already have a "DebugClang" configuration for this. We should
abandon this change.
http://reviews.llvm.org/D22235
___
Author: gclayton
Date: Tue Jul 12 18:06:28 2016
New Revision: 275225
URL: http://llvm.org/viewvc/llvm-project?rev=275225&view=rev
Log:
This doesn't compiler on Darwin. Skipping it.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcp
Author: gclayton
Date: Tue Jul 12 18:07:50 2016
New Revision: 275226
URL: http://llvm.org/viewvc/llvm-project?rev=275226&view=rev
Log:
Remove assert since it was crashing the mutli process driver tests. Made the
code behave correctly when indexes are out of range or the collection is empty
and i
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D22286
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should document this behavior somewhere in some help text, and run
clang-format.
Repository:
rL LLVM
http://reviews.llvm.org/D22284
Author: gclayton
Date: Wed Jul 13 12:12:24 2016
New Revision: 275281
URL: http://llvm.org/viewvc/llvm-project?rev=275281&view=rev
Log:
Centralize the way symbol and functions are looked up by making a
Module::LookupInfo class that does all of the heavy lifting.
Background: symbols and functions
Author: gclayton
Date: Wed Jul 13 12:25:55 2016
New Revision: 275285
URL: http://llvm.org/viewvc/llvm-project?rev=275285&view=rev
Log:
Remove comment that isn't needed anymore.
Modified:
lldb/trunk/include/lldb/Core/Module.h
Modified: lldb/trunk/include/lldb/Core/Module.h
URL:
http://llv
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
If you can't get this right when debug info is present then I would rather not
have this patch. We enabled debug info on your test and it will call the
putchar() in the current l
clayborg added a comment.
Adding a feature to the debugger that doesn't work with debug info seems like a
bad idea.
http://reviews.llvm.org/D22294
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
clayborg added a comment.
Adrian Prantl suggested that we modify clang to update the debug info for the
function. In the test case that was attached, the DWARF currently has a
"putchar" function which should get a linkage name attached to it with
"__my_putchar". Then the debug info can be corr
clayborg added a comment.
In http://reviews.llvm.org/D22294#483213, @sas wrote:
> @jingham, @clayborg, this is indeed a bit fragile as having to specify your
> rewrite maps manually when debugging is very error-prone. I have a patch that
> fetches the path to the rewrite map from the debug info
clayborg added a comment.
> I think some understanding of the rewrites from the debugger is still
> required because the user will still enter commands like `call putchar('a')`
> and expect the `putchar()` they wrote to be called. That `putchar()` they
> expect is now called `_my_putchar()` and
clayborg added a comment.
Note that during function lookup, we can find **both** "putchar" and
"__my_putchar" in the debug info, so you will be able to call both.
http://reviews.llvm.org/D22294
___
lldb-commits mailing list
lldb-commits@lists.llvm.
clayborg added a comment.
In http://reviews.llvm.org/D22294#483311, @sas wrote:
> In http://reviews.llvm.org/D22294#483264, @clayborg wrote:
>
> > Note that during function lookup, we can find **both** "putchar" and
> > "__my_putchar" in the debug info, so you will be able to call both.
>
>
> Co
Author: gclayton
Date: Wed Jul 13 17:38:54 2016
New Revision: 275336
URL: http://llvm.org/viewvc/llvm-project?rev=275336&view=rev
Log:
Added test for setting breakpoints by basename and fullname.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/namespace/TestNamespace.py
Mod
Author: gclayton
Date: Thu Jul 14 14:31:18 2016
New Revision: 275459
URL: http://llvm.org/viewvc/llvm-project?rev=275459&view=rev
Log:
Add support for Objective-C class properties.
Added test cases to exiting tests to cover the new functionality.
Modified:
lldb/trunk/packages/Python/lld
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22756
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22755
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few comments:
- we need the DWARF opcode length in RegisterInfo, but not in the structured
data (XML or JSON)
- all macros that initialize RegisterInfo structs must be expended
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22132
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few modifications to the SBAddress info
Comment at: include/lldb/API/SBAddress.h:32
@@ +31,3 @@
+/// target.
+///
+/// The individual Get*() functions grab ind
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
This provides a clearer implementation of our async code that grew over the
years and was bolted on, thanks for digging into this.
Looks good a few changes, see inlined comments.
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
You can't change the exiting public API (anything in include/lldb/API/*). If
you want to a add a new function, you must add a new version with the new
argument, but leave the old
Author: gclayton
Date: Wed Jul 27 15:47:49 2016
New Revision: 276914
URL: http://llvm.org/viewvc/llvm-project?rev=276914&view=rev
Log:
Fixed "void SBWatchpoint::SetEnabled (bool enabled)" to work properly and added
a test for it.
https://llvm.org/bugs/show_bug.cgi?id=28729
Modified:
lldb
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Add a test and this is good to go.
https://reviews.llvm.org/D22902
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I am fine with the llvm::StringRef until it causes a crash. So really look at
all the ways you construct a llvm::StringRef and make sure it won't assert ever
if you leave it as a llvm::Str
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
Comment at: source/API/SBCommandInterpreter.cpp:156
@@ -155,3 +155,3 @@
}
-lldb::SBCommandPluginInterface* m_backend;
+std::shared_ptr m_backend;
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D22923
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for all of the updates.
https://reviews.llvm.org/D20357
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://l
clayborg added a comment.
A few things that worry me:
- There are no sequence IDs on any packets so when receiving responses, I am
not sure how you are going to match up packets with their responses especially
when you are sending from multiple threads. I didn't look through your
implementatio
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
There should be a way to specify the lldb-mi binary. If there isn't feel free
to add one to the test suite.
https://reviews.llvm.org/D22902
I am fine with this. It is in MIPS only code so it shouldn't affect anything
else.
> On Aug 2, 2016, at 8:49 AM, Hans Wennborg wrote:
>
> While this all seems very MIPS-specific, so probably fine to merge if
> you want to, it does look more like new development than just bug
> fixing.
>
> I'm
I am fine with this going in, but this fix is for MIPS only.
> On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote:
>
> Looks like a pretty big change to merge at this stage.
>
> I'll let Clayton decide.
>
> Thanks,
> Hans
>
> On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote:
>> Hi Hans,
>>
clayborg added a comment.
I am back from vacation again.
I will place this in a stand alone file and I will use SelectInfo.h if there is
a "select.h" already in any "include" directories like "/usr/include" so we
don't run into problems including the right file. If there aren't any select.h
fi
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just a quick clarifications on file and load addresses to make things a bit
clearer.
Comment at: include/lldb/API/SBAddress.h:25-26
@@ +24,4 @@
+///
+/// SBAddr
clayborg added a comment.
I was out on vacation, sorry for the delay. I will get back to you later today.
https://reviews.llvm.org/D22914
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We can't currently do this because we have a dependency on having this be there
for existing customers. The problem is that the debug info always has the base
names of types in t
clayborg added a comment.
One thing that should be tested before we go farther, can you check the packet
speed test with and without this patch? We really need to make sure this
doesn't regress. Adding thread synchronization above and beyond taking a mutex
could really impact performance.
Just
Author: gclayton
Date: Mon Aug 8 17:15:35 2016
New Revision: 278060
URL: http://llvm.org/viewvc/llvm-project?rev=278060&view=rev
Log:
Fix RegisterInfo initializers to have all the required initializers after
recent changes. This quiets a few hundred warnings on MacOSX.
Modified:
lldb/trunk
Author: gclayton
Date: Mon Aug 8 17:16:03 2016
New Revision: 278061
URL: http://llvm.org/viewvc/llvm-project?rev=278061&view=rev
Log:
Fix printf warnings.
Modified:
lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCore.cpp
Modified: lldb/trunk/source/Plugins/Process/elf-core/ThreadElfCo
Author: gclayton
Date: Mon Aug 8 17:48:57 2016
New Revision: 278064
URL: http://llvm.org/viewvc/llvm-project?rev=278064&view=rev
Log:
Garbage collection is not around anymore, we can remove our support for it.
Modified:
lldb/trunk/source/Host/macosx/HostThreadMacOSX.mm
Modified: lldb/trunk
clayborg updated this revision to Diff 67253.
clayborg added a comment.
Updated with all comments taken into account. Zach, please try this out and let
me know if it compiles.
https://reviews.llvm.org/D22950
Files:
include/lldb/Utility/SelectHelper.h
lldb.xcodeproj/project.pbxproj
source
clayborg added a comment.
I used SelectHelper.h because there is a "/usr/include/select.h" header file
and case insensitive file systems would have issues if I used Select.h.
https://reviews.llvm.org/D22950
___
lldb-commits mailing list
lldb-commit
clayborg added a comment.
Let me know how things look on Mac. Our lock primitives are not as fast as
linux. If all looks good on Mac speed wise, we should be good to go.
https://reviews.llvm.org/D22914
___
lldb-commits mailing list
lldb-commits@lis
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good, thanks for the changes and the documentation.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
___
lldb-commits mailing lis
clayborg added a comment.
Can you explain the scenarios where you are going to use LLDB with pipes?
https://reviews.llvm.org/D23290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
OK. I can't complain if it doesn't affect performance and could allow multiple
packets to be in flight with threading, though I think solving this issue with
threading is a bit of a hack,
clayborg added a comment.
In https://reviews.llvm.org/D23290#511433, @joshimbriani wrote:
> In https://reviews.llvm.org/D23290#511275, @clayborg wrote:
>
> > Can you explain the scenarios where you are going to use LLDB with pipes?
>
>
> Sure! Essentially we are duplicating some of the functional
clayborg added a comment.
Is this something the user is typing in your IDE that you are forwarding to
LLDB via pipes? Again, why are you using the command and not the API. There are
API for everything you can do and no IDE should be doing code like:
void MyDebugger::ClearAllBreakpoints()
{
m
Author: gclayton
Date: Wed Aug 10 15:37:45 2016
New Revision: 278286
URL: http://llvm.org/viewvc/llvm-project?rev=278286&view=rev
Log:
Fix the lookup of dictionary values by name to not do a linear search.
Modified:
lldb/trunk/include/lldb/Core/StructuredData.h
Modified: lldb/trunk/include/
Author: gclayton
Date: Wed Aug 10 17:43:48 2016
New Revision: 278299
URL: http://llvm.org/viewvc/llvm-project?rev=278299&view=rev
Log:
Centralize all select() calls into one place so that we can take advantage of
system specific optimizations to deal with more file descriptors than
FD_SETSIZE on
clayborg accepted this revision.
clayborg added a reviewer: clayborg.
clayborg added a comment.
This revision is now accepted and ready to land.
This was committed with 278299. We can iterate on this as needed.
https://reviews.llvm.org/D22950
___
ll
Author: gclayton
Date: Wed Aug 10 17:55:26 2016
New Revision: 278302
URL: http://llvm.org/viewvc/llvm-project?rev=278302&view=rev
Log:
Make pascal debugging work again.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http
Author: gclayton
Date: Wed Aug 10 18:25:57 2016
New Revision: 278304
URL: http://llvm.org/viewvc/llvm-project?rev=278304&view=rev
Log:
Fix a problem where if a uint64_t value is placed into a python dictionary and
sent up to LLDB and converted to StructuredData, it would not be able to parse
the
clayborg added a comment.
My only issue with this patch is that is uses llvm::SmallVector. Although the
class is nice, we don't have visibility into this class when debugging like we
do when we use STL collections. I would rather not move to SmallVector if we
don't need to. Jim, thoughts?
htt
clayborg added a comment.
In https://reviews.llvm.org/D23290#512346, @labath wrote:
> I think I have understood the situation a bit more now, so let me try to
> explain what is going on.
>
> In https://reviews.llvm.org/D23290#511683, @clayborg wrote:
>
> > Is this something the user is typing in
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Ok. Jim says the patch is OK, so I will OK it also.
https://reviews.llvm.org/D23406
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: gclayton
Date: Fri Aug 12 11:46:18 2016
New Revision: 278524
URL: http://llvm.org/viewvc/llvm-project?rev=278524&view=rev
Log:
Switch over to using socketpair for local debugserver connections as they are
twice as fast as TCP sockets (on macOS at least).
This change opens a socket pair a
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. I know there are many other functions that we should port down into
the client code.
https://reviews.llvm.org/D23553
___
lldb-co
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D23604
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D23659
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg added a comment.
The old mutex was there so that you could send a packet and get a result
without worrying about other threads getting your response. It was recursive
for the case where we needed to send two packets as one (set thread ID, then
send packet), and for reading all register
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Maybe instead of "NoLock" on the functions we those functions take an extra
argument? Then someone can't accidentally run one of those without locking. We
need to somehow enforce
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D23802
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg added a comment.
Looks good to me.
https://reviews.llvm.org/D23830
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
Looking closer at the JSON parser llvm::StringRef isn't the right thing to use
when parsing JSON. The parser will often remove desensitizing characters from
say a string like:
"hello \"world\""
And when parsing a token in JSONParser::GetToken, we can't just hand out
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should probably move over to using llvm::StrringRef instead of "const char
*". It the JSON parser isn't using llvm::StringRef already it probably should.
https://reviews.llvm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Actually after looking at the JSON parser I see that it isn't using
llvm::StringRef throughout. So I vote to keep the "const char *" for now since
we need to guarantee that the JSON is nul
clayborg added a comment.
In https://reviews.llvm.org/D23884#526385, @zturner wrote:
> I'm not sure I follow. `StringRef` is literally just a wrapper around a
> `const char*`, so if `const char*` works, why doesn't `StringRef`?
"const char *" assumed null termination. StringRef can be a refer
clayborg added a comment.
In https://reviews.llvm.org/D23884#526390, @zturner wrote:
> Actually it looks like `JSONParser` constructor takes a `StringRef` and then
> converts it to a `std::string` internally. Why can't it just store the
> `StringRef` internally? It doesn't modify the buffer,
> On Aug 30, 2016, at 6:32 AM, Pavel Labath wrote:
>
> I think we should move the new file away from source/Utility. If it's
> supposed to be used by debugserver only, we probably should move it to
> tools/debugserver/source ? Right now, debugservers cmake file contains
> a hack to be able to in
clayborg added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:808
@@ -799,3 +807,3 @@
uint8_t *src, *dst;
init nullptr please.
https://reviews.llvm.org/D24124
_
clayborg requested changes to this revision.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:659-660
@@ -651,4 +658,4 @@
{
-uint8_t *dst;
+uint8_t *dst, byte_size;
uint64_t *src;
Please initialize the
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Jason Molenda already has a packet that does multiple module infos. Is this
change using his packet format? Look for "jGetLoadedDynamicLibrariesInfos". We
should try to use the s
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just add header doc and this is good to go.
Comment at: include/lldb/API/SBSection.h:74
@@ -73,1 +73,3 @@
+uint32_t
+GetPermissions () const;
-
clayborg added a comment.
Just take a look and see if there is anything worth re-using. If there is too
much mac specific stuff in there, then just use the one created, but be sure to
make it your new format completely agnostic to any platform so it can work for
anything. It is OK to include pl
clayborg requested changes to this revision.
clayborg added a comment.
Just switch to using CFLAGS_EXTRAS and LD_EXTRAS and this is good to go.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6-11
@@ +5,8 @@
+ifeq "$(ARCH)" "
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sounds good. As long as we know what is there (the XML and Jason's other
packet) and know that the desired functionalities do not overlap I am fine with
the approach that you suggest! Than
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
We need to carefully benchmark any changes in demangling if we are thinking
about switching to using llvm::itaniumDemangle() for everything. The demangler
that was built into libcxxabi was
clayborg added a comment.
In https://reviews.llvm.org/D24293#535928, @zturner wrote:
> AFAICT, this patch only changes the case where we were already not able to
> use the fast demangler. So nothing should change.
Yep, I saw that and that is why I OK'ed the patch. Someone else suggested
cutt
clayborg added a comment.
I like the idea of moving this down into LLVM. We should fully LLVM-ize the
code on the first pass though and take the LLDB style out of it.
https://reviews.llvm.org/D24369
___
lldb-commits mailing list
lldb-commits@lists.
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D24514
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg added a comment.
A few things about a the RegisterContext class in case it would change and
thing that you are submitting here. The entire register context defines a
buffer of bytes that can contain all register values. Each RegisterInfo
contains the offset for the value of this regist
clayborg requested changes to this revision.
clayborg added a comment.
Great fix. Just fix the testing so that it isn't ARM specific. There shouldn't
be any:
if self.getArchitecture() in ['arm']:
do arm stuff
else:
do non arm stuff
Also we will need to be able to test the set watch
Author: gclayton
Date: Fri Sep 16 15:10:02 2016
New Revision: 281770
URL: http://llvm.org/viewvc/llvm-project?rev=281770&view=rev
Log:
Fix compiler warnings where two values weren't being initialized.
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterInfos_i386.h
Modified: lldb/tru
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
A few naming requests.
Comment at: source/Core/Debugger.cpp:151
@@ +150,3 @@
+ "\"caret-only\" mode was selected."},
+ {eStopShowColumnAnsiOnly, "ansi-only",
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
So it seems like this can be fixed by doing a few things:
1 - just set the RegisterInfo.offset to the actual offset in the buffer and
don't use the offset as the ptrace key used t
501 - 600 of 2985 matches
Mail list logo
