clayborg accepted this revision.
clayborg added a comment.
Much better.
https://reviews.llvm.org/D24124
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg accepted this revision.
clayborg added a comment.
Looks good.
https://reviews.llvm.org/D20835
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This it the perfect example of why not to use a StringRef since the string
needs to be null terminated. Why did we change this? Now even if you call this
function:
RegularExpression r(...);
r.Execute("...", ...)
You will need to duplicate the string on the heap just to exec
Please submit a change requests when doing these kinds of things and let people
comment on the changes before committing such things.
We deleted functions that were correctly using "const char *" like:
bool Execute(llvm::StringRef string, Match *match = nullptr) const;
bool Execute(const cha
> On Sep 21, 2016, at 4:43 PM, Zachary Turner wrote:
>
> You need to duplicate something on the heap once when you execute the regex.
> And in turn you save tens or hundreds or copies on the way there because of
> inefficient string usage.
Where? please show this.
I see the following call
do it efficiently.
Greg
> On Sep 21, 2016, at 5:13 PM, Greg Clayton via lldb-commits
> wrote:
>
>>
>> On Sep 21, 2016, at 4:43 PM, Zachary Turner wrote:
>>
>> You need to duplicate something on the heap once when you execute the regex.
>> And in turn yo
ith that.
> We can just cut over to using llvm::Regex where it uses the start and end
> pointer. I would just like to avoid making string copies for no reason. I
> don't have anything against using StringRef as long as we do it efficiently.
>
> Greg
>
>
>> On Sep
> On Sep 21, 2016, at 5:14 PM, Zachary Turner wrote:
>
>
>
> On Wed, Sep 21, 2016 at 5:00 PM Greg Clayton wrote:
> Please submit a change requests when doing these kinds of things and let
> people comment on the changes before committing such things.
>
> We deleted functions that were corre
> To be clear: if we can make StringRef work efficiently, I am fine with
> > that. We can just cut over to using llvm::Regex where it uses the start and
> > end pointer. I would just like to avoid making string copies for no reason.
> > I don't have anything against
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We could avoid many of the copies in the printf statements by by doing
something like this in a common header file:
#define LLVM_STRINGREF_PRINTF_FORMAT "%*s"
#define LLVM_S
clayborg added a comment.
I am not saying we have to do the printf changes, I was just seeing what you
think. I would like to see the StringRef variants of functions put in as part
of this.
https://reviews.llvm.org/D24847
___
lldb-commits mailing
clayborg added a comment.
Yeah, don't do any calls that don't need to be converted. Just the ones you
need. Should just add 2 StringRef variant functions. Don't feel the need to
completely fix OptionValueString or OptionValueUInt64. We can do the full
change over in a future CL. See if you can
clayborg added a comment.
no printf fixes are fine. I don't mind if error cases have str().c_str() so
much.
https://reviews.llvm.org/D24847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lld
clayborg added a comment.
You can still leave the "const char *" versions in there for now until you get
to the cleanup. No spiral if you do that.
https://reviews.llvm.org/D24847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D24847
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Watch the buildbots for failures, but this looks fine. We aren't changing how
the strings for filename and directory are stored, just using StringRef to
deliver the arguments.
https://re
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Interpreter/Args.cpp:264-265
@@ -315,3 +263,4 @@
size_t Args::GetArgumentCount() const {
- if (m_argv.empty())
+ if (
clayborg added a comment.
Please comment why you are manually bit twiddling due to the size of the
register that can change. We don't want anyone else copying this kind of code.
Another solution would be to update the offset of the register when you change
the byte size so none of this would ne
clayborg added a comment.
Ok, so just add the boolean arg to Args::GetArgumentVector and we are good to
go.
Comment at: source/Interpreter/Args.cpp:270-272
@@ -321,5 +269,5 @@
const char *Args::GetArgumentAtIndex(size_t idx) const {
- if (idx < m_argv.size())
-return m_ar
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We need to send each flag individually. See inlined comments.
Comment at:
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1887
@@ -1885,1 +18
Author: gclayton
Date: Wed Sep 28 16:07:34 2016
New Revision: 282632
URL: http://llvm.org/viewvc/llvm-project?rev=282632&view=rev
Log:
Add the ability for the task port to change when a process execs.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py
l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Can we change DebugMacroEntry to contain a std::unique_ptr instead
of a shared pointer? This would save us one full pointer in each
DebugMacroEntry.
That is the only change I wo
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
In http://reviews.llvm.org/D15437#308839, @clayborg wrote:
> Can we change DebugMacroEntry to contain a std::unique_ptr
> instead of a shared pointer? This would save us one full pointer i
clayborg added a comment.
One area of concern is if you are not tracking file, how can you get the right
defines for a given source file line? If you have:
main.c:
#include
#define FOO printf
int main ()
{
return 0; // Stop here and run: FOO("hello world\n")
}
#undef FO
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:85-97
@@ -83,1 +84,15 @@
+namespace {
+void debugStringV
This looks like something that should be out of tree
>
> On Tue, Dec 15, 2015 at 3:06 PM Greg Clayton via lldb-commits
> wrote:
> Added:
> lldb/trunk/build/Debug/LLDB.framework/Versions/A/Resources/Python/lldb/macosx/crashlog.py
> URL:
> http://llvm.org/viewvc/ll
Author: gclayton
Date: Tue Dec 15 17:11:24 2015
New Revision: 255699
URL: http://llvm.org/viewvc/llvm-project?rev=255699&view=rev
Log:
Removing files that I didn't mean to checkin.
Removed:
lldb/trunk/build/
___
lldb-commits mailing list
lldb-comm
Author: gclayton
Date: Wed Dec 16 18:58:41 2015
New Revision: 255863
URL: http://llvm.org/viewvc/llvm-project?rev=255863&view=rev
Log:
Don't strip types of their typedefs when getting function types.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/Cl
Author: gclayton
Date: Wed Dec 16 19:00:50 2015
New Revision: 255864
URL: http://llvm.org/viewvc/llvm-project?rev=255864&view=rev
Log:
Don't demangle a name when Mangled::GetName() is called with ePreferMangled.
Only demangle if this isn't the the value for the "preference" argument
indicating t
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Man those options are complex. I really would like to see something more simple:
"--raw" dumps the line entries as you have mentioned
"--no-inlines" would omit any inline entries
clayborg added a comment.
Ok, so I talked with Jim on this and this is what we came up with. I would like
to see no changes made to the "target modules dump line-table" command. It is
dumping complete line tables. This command is not for "find any line entries
that match this file anywhere incl
clayborg added a comment.
I do want to apologize to Dawn and Jim for not having chimed in earlier and
causing Dawn some extra work.
Repository:
rL LLVM
http://reviews.llvm.org/D15593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
clayborg added a comment.
Dawn, if you don't understand what I asked you to do, let me know and I can go
and do the "source info" command for you, then you can modify this patch to
just use the command I added. But it should be simple to just revert and
changes to the original line table dumpin
clayborg added a comment.
Note that you won't need any of the options that you had added to the other
command becuase the "source info" command will do what you wanted in the first
place: find all line entries where a file and optional line is mentioned in any
line tables.
Repository:
rL LL
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Sean should OK this as well.
http://reviews.llvm.org/D15527
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://list
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15877
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
So I am going to let this through because you have done all we asked and I
really like the "source info" command!
But in the future when adding things for MI, please add an API in the lldb::SB
layer to do what you need. Text scraping is
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
Repository:
rL LLVM
http://reviews.llvm.org/D15886
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Seems like it would be better to mimic how @expectedFailureAndroid works. See
inlined comments.
Comment at:
packages/Python/lldbsuite/test/functionalities/watc
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I looked at this before, and resigned to let Sean Callanan comment on the fix
since this is in his area of expertise: the expression parser.
http://reviews.llvm.org/D12809
_
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D16046
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D16051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Actually, can you add a test?
Repository:
rL LLVM
http://reviews.llvm.org/D16049
___
lldb-commits mailing list
lldb-commits@list
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D15893
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
So does this mean any symbols whose byte size is zero will always have a byte
size of zero when parsed from a .dynsym section? What kinds of symbols have a
byte size of zero in the .dynsym? Seems like function symbols should always
have a valid byte size no? Why is the
clayborg added a comment.
We could just teach the standard decorators to detect the type of the "archs"
variable and do the right thing based off of the type. In the handler code you
could have:
retype = type(re.compile('hello, world'))
if isinstance(archs, list):
# Do what we do now
clayborg added a comment.
It would be interesting to see if there are any relocations or any other hints
to help make correct function bounds from a stripped (.dynsym only) ELF file.
In MachO we have a LC_FUNCTION_STARTS load command (kind of like an ELF note)
that contains all start addresses
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
In http://reviews.llvm.org/D16186#327081, @tberghammer wrote:
> I looked through the sections we have in a striped elf file and non of them
> have any information what would tell
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Comment at: source/Symbol/Symtab.cpp:974-978
@@ -973,5 +973,7 @@
Symbol &symbol = m_symbols[entry.data];
-
-
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Never mind, sorry, missed that this was in Symbol.cpp, I was still thinking of
the ObjectFileELF...
http://reviews.llvm.org/D16186
___
lldb-
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just factor the cool archs stuff into a function that others can use and this
is good to go.
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1040-1049
@@
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I just added PECOFF so I could make sure I had 3 clients for the ObjectFile
class when I was developing it and I already have the PECOFF support in the
previous tool I had written, so this
Author: gclayton
Date: Thu Jan 21 16:26:13 2016
New Revision: 258443
URL: http://llvm.org/viewvc/llvm-project?rev=258443&view=rev
Log:
Always try to read DW_TAG_typedef types from DWO files first if we can.
A lot of C code uses code like:
typedef struct
{
int a;
} FooType;
This c
clayborg added a comment.
This kind of stuff:
struct UserArea {
GPR gpr;
FPR fpr;
DBG dbg;
};
Was done on MacOSX systems because we have thread_get_state() and
thread_set_state() that take a flavor (enumeration) that specifies which
registers we should read
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine.
http://reviews.llvm.org/D16563
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Change over to use a "Thread &" as argument to "bool
ABISysV_arm::IsArmHardFloat(Thread *)" and this is good to go.
http://reviews.llvm.org/D16627
___
clayborg added a comment.
And fix all of the tberghammer's comments as well.
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: gclayton
Date: Wed Jan 27 18:16:11 2016
New Revision: 259003
URL: http://llvm.org/viewvc/llvm-project?rev=259003&view=rev
Log:
A while back in revison 244716 we added support for getting the host OS version
info from debugserver. We added keys to "qHostInfo" that were "osmajor",
"osminor
clayborg added a comment.
In http://reviews.llvm.org/D16508#338046, @krytarowski wrote:
> 1. I was trying to comment out `DBG` registers (as unsupported by NetBSD)
> from `RegisterInfos_x86_64.h` with the following patch:
>
> But I get this assert being triggered:
>
> In file included from
>
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16720
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. Zach: I don't believe that Mac supports the thread local keywords
correctly yet, but I can check on that. We would need to get the OK from
multiple people (MacOSX, Windows, Fre
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good to me, but Sean should be the one to OK this for real.
http://reviews.llvm.org/D16746
___
lldb-commits mailing list
lldb-commits@l
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16745
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
Repository:
rL LLVM
http://reviews.llvm.org/D16508
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine. A few things I don't like, but I can live with:
- Making constructors appear all on one line does save space, but it means you
can't debug very well as stepping into these cons
clayborg added a comment.
Looks good.
A related comment about IT instructions. You need to be careful when software
single stepping through instructions that are in the middle of an ITSTATE
block. You can NOT use a 16 bit instruction that isn't a BKPT otherwise you
change your instructions. Ar
clayborg added a comment.
See inlined comments.
Comment at: source/Target/Language.cpp:272
@@ -271,2 +271,3 @@
case eLanguageTypeC11:
+case eLanguageTypeExtRenderScript:
return true;
Why is this needed? Seems like this is incorrect.
Sorry for the delay. This is fine.
In general, feel free to accept any patches that are architecture specific for
architectures that aren't x86 or ARM (MIPS, hexagon for example), and for any
languages that aren't C/C++/ObjC or Swift (renderscript, go).
> On Feb 1, 2016, at 1:49 PM, Hans Wenn
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16627
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg added a comment.
In http://reviews.llvm.org/D16772#341629, @tberghammer wrote:
> In http://reviews.llvm.org/D16772#340950, @clayborg wrote:
>
> > Looks good.
> >
> > A related comment about IT instructions. You need to be careful when
> > software single stepping through instructions th
clayborg added a comment.
No need to revert anything as these classes are stable now and don't need
debugging. Just something to be aware of in other cases when you make future
changes.
http://reviews.llvm.org/D16769
___
lldb-commits mailing list
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Yes, the fix above in ClangASTContext.cpp was what I was looking for! Looks
good.
Repository:
rL LLVM
http://reviews.llvm.org/D16766
___
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
It would be nice to not pick UINT32_MAX for the unconditional condition and let
each emulator picks it desired values. See inlined comments. Let me know what
you think.
===
clayborg added a comment.
I like that llvm::Optional idea!
http://reviews.llvm.org/D16814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
There are immediate values you can play around with inside the BKPT instruction
of both ARM and Thumb versions so that the two least significant bytes are the
same:
static const
clayborg accepted this revision.
clayborg added a comment.
I believe we recently switched "archs" so that we auto detect the type so you
could use a regular expression. See above inlined comments.
Good to go unless you want to adopt any of my inlined suggestions.
Comment at:
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Yes, it was probably too complex. My main objection was the use of the
UINT32_MAX as a magic number. Your UnconditionalCondition solution clears this
up.
Comme
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Sounds reasonable.
Repository:
rL LLVM
http://reviews.llvm.org/D16916
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lis
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I am fine as long as tberghammer is happy.
http://reviews.llvm.org/D16975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Make sure we use a consistent naming scheme for symbols that don't have names
between all ObjectFile subclasses.
Comment at: source/Plugins/ObjectFile/ELF/Objec
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
We should use local variable and avoid calling accessors many times. See
inlined comments. I know the code was like this before, but we should fix these
things as we go.
==
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good. Most JTAG probes actually vend their own GDB server these days. If
so, we will used the Z packets in order to set breakpoints, so we will be
isolated from these issues. If we a
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D16996
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: gclayton
Date: Tue Feb 9 15:18:44 2016
New Revision: 260282
URL: http://llvm.org/viewvc/llvm-project?rev=260282&view=rev
Log:
Don't enable -flimit-debug-info by default for the LLDB Xcode builds. This was
put in back in 2011 when -flimit-debug-info did a lot less than it does now.
With
Author: gclayton
Date: Tue Feb 9 15:20:17 2016
New Revision: 260284
URL: http://llvm.org/viewvc/llvm-project?rev=260284&view=rev
Log:
If we set the DYLD_INSERT_LIBRARIES environment variable when launching
debugserver, for use with /usr/lib/libgmalloc.dylib, then make sure we don't
pass this en
Author: gclayton
Date: Tue Feb 9 16:09:26 2016
New Revision: 260299
URL: http://llvm.org/viewvc/llvm-project?rev=260299&view=rev
Log:
Don't complete a class type just to test if it is a class. Code in CompilerType
and in clang::QualType knows how to complete a type if it needs to.
Modified:
Author: gclayton
Date: Tue Feb 9 16:36:24 2016
New Revision: 260308
URL: http://llvm.org/viewvc/llvm-project?rev=260308&view=rev
Log:
Fixed many issues that were causing differing type definition issues to show up
when parsing expressions.
1) Turns out we weren't correctly uniquing types for C+
es to be
what is slowing down expressions, I will need to do something about it as it is
affecting our expression performance.
So stay tuned, I'll follow up with a test soon.
> On Feb 9, 2016, at 2:48 PM, Zachary Turner wrote:
>
> Any tests for this?
>
> On Tue, Fe
Author: gclayton
Date: Tue Feb 9 17:25:54 2016
New Revision: 260322
URL: http://llvm.org/viewvc/llvm-project?rev=260322&view=rev
Log:
Added code that was commented out during testing to stops template member
functions from being added to class definitions (see revision 260308 for
details).
clayborg requested changes to this revision.
clayborg added a comment.
As Zach said, you could add a function to ArchSpec like:
std::string
ArchSpec::GetClangTargetCPU();
and move your code from the large switch statement into there. It can return an
empty string for any architecture that d
Author: gclayton
Date: Wed Feb 10 15:28:13 2016
New Revision: 260434
URL: http://llvm.org/viewvc/llvm-project?rev=260434&view=rev
Log:
Now that SymbolFileDWARF supports having types in completely separate .pcm file
with "-fmodules -gmodules", each SymbolFileDWARF can reference module DWARF
info
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Don't assert in ArchSpec::GetClangTargetCPU () and always call this function.
See inlined comments.
Comment at: source/Core/ArchSpec.cpp:558
@@ +557,3 @@
+
Author: gclayton
Date: Thu Feb 11 17:36:57 2016
New Revision: 260618
URL: http://llvm.org/viewvc/llvm-project?rev=260618&view=rev
Log:
Removed a bad assertion:
assert(((SymbolFileDWARF*)m_ast.GetSymbolFile())->UserIDMatches(die.GetDIERef().GetUID())
&&
"Adding incorrect type to forward de
Author: gclayton
Date: Thu Feb 11 18:07:16 2016
New Revision: 260626
URL: http://llvm.org/viewvc/llvm-project?rev=260626&view=rev
Log:
Don't crash if we have a DIE that has a DW_AT_ranges attribute and yet the
SymbolFileDWARF doesn't have a DebugRanges. If this happens print a nice error
message
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will let Sean Callanan OK this one.
http://reviews.llvm.org/D17273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.o
clayborg accepted this revision.
clayborg added a comment.
Looks good to me.
http://reviews.llvm.org/D17295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg resigned from this revision.
clayborg removed a reviewer: clayborg.
clayborg added a comment.
I will defer to Sean Callanan.
Repository:
rL LLVM
http://reviews.llvm.org/D17167
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
601 - 700 of 2985 matches
Mail list logo
