Re: [Lldb-commits] [Diffusion] rL244866: [LLDB][MIPS] Use qfThreadID if qC packet is not supported by target

Fine to merge. > On Aug 13, 2015, at 9:33 AM, Hans Wennborg wrote: > > Greg: you're the owner here. OK for merging to 3.7? > > On Wed, Aug 12, 2015 at 10:22 PM, Jaydeep Patil > wrote: >> Hi Hans, >> >> Could you please merge it to release branch? >> >> Thanks, >> Jaydeep >> >> -Original

Re: [Lldb-commits] [Diffusion] rL244865: [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint

Yes, merging this is fine. > On Aug 13, 2015, at 9:33 AM, Hans Wennborg wrote: > > > Greg: you're the owner here. Approved for 3.7? > > On Wed, Aug 12, 2015 at 10:21 PM, Jaydeep Patil > wrote: >> Hi Hans, >> >> Could you please merge it to release branch? >> >> Thanks, >> Jaydeep >> >> ---

[Lldb-commits] [lldb] r244984 - Don't crash when we have a .a file that contains an object with a 16 character name. Any calls to std::string::erase must be bounds checked.

Author: gclayton Date: Thu Aug 13 18:16:15 2015 New Revision: 244984 URL: http://llvm.org/viewvc/llvm-project?rev=244984&view=rev Log: Don't crash when we have a .a file that contains an object with a 16 character name. Any calls to std::string::erase must be bounds checked. Modified: lld

[Lldb-commits] [lldb] r244992 - Add a better fix for searching for spaces in BSD archive object names where we only trim trailing spaces.

Author: gclayton Date: Thu Aug 13 19:18:52 2015 New Revision: 244992 URL: http://llvm.org/viewvc/llvm-project?rev=244992&view=rev Log: Add a better fix for searching for spaces in BSD archive object names where we only trim trailing spaces. I made an example where I had a file named "testtesttes

[Lldb-commits] [lldb] r245078 - Don't test the output of "target modules dump symfile a.out" as this isn't something we should be testing for. This makes this test pass again.

Author: gclayton Date: Fri Aug 14 13:18:07 2015 New Revision: 245078 URL: http://llvm.org/viewvc/llvm-project?rev=245078&view=rev Log: Don't test the output of "target modules dump symfile a.out" as this isn't something we should be testing for. This makes this test pass again. Modified: ll

Re: [Lldb-commits] [PATCH] D12043: Convert all use of pthreads in test executables to std threads

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] r245121 - Don't crash if we don't have a type system for a language.

Author: gclayton Date: Fri Aug 14 18:15:48 2015 New Revision: 245121 URL: http://llvm.org/viewvc/llvm-project?rev=245121&view=rev Log: Don't crash if we don't have a type system for a language. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified: lldb/trunk/sou

[Lldb-commits] [lldb] r245122 - Unbreak the windows and linux buildbots.

Author: gclayton Date: Fri Aug 14 18:16:12 2015 New Revision: 245122 URL: http://llvm.org/viewvc/llvm-project?rev=245122&view=rev Log: Unbreak the windows and linux buildbots. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h Modified: lldb/trunk/source/Plugins/SymbolFi

Re: [Lldb-commits] [PATCH] D12044: Fix resolution conflict between global and class static variables in C++.

clayborg added a comment. Please make sure that the following works after your changes: (lldb) r Process 35421 launched: '/private/tmp/a.out' (x86_64) Process 35421 stopped * thread #1: tid = 0xb659be, 0x00010f9d a.out main + 13, stop reason = breakpoint 1.1, queue = com.apple.ma

Re: [Lldb-commits] [PATCH] D12044: Fix resolution conflict between global and class static variables in C++.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:7389 @@ -7388,3 +7388,3 @@ { -

Re: [Lldb-commits] [PATCH] D12077: [MIPS] Move is 'or' instead of 'addu'.

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I don't think I am the right person to review this as this is in LLVM. http://reviews.llvm.org/D12077 ___ lldb-commits mailing list lldb-commits@l

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Many changes. See inlined comments. Comment at: source/Core/Disassembler.cpp:1169-1187 @@ +1168,21 @@ + +/* + * MIPS: + * The bit #0 of a

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg added a comment. The main thing is, we don't want to be like other debuggers that have all this code in many many places that check address bits by checking the Architecture and litter the code with bit strips and adding bits where needed. We want to support addresses correctly by know

Re: [Lldb-commits] [PATCH] D12083: [LLGS] Avoid misrepresenting log lines as inferior output

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

Ok to merge. > On Aug 17, 2015, at 1:26 PM, Hans Wennborg wrote: > > I'm OK with it if Greg approves. > > - Hans > > On Mon, Aug 17, 2015 at 7:07 AM, wrote: >> Hi Hans, >> >> Could you please also merge r245217 in the release branch. >> >> Thanks, >> Sagar >> >> -Original Message-

Re: [Lldb-commits] [lldb] r245216 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

Ok to merge. > On Aug 17, 2015, at 1:27 PM, Hans Wennborg wrote: > > +lldb-commits > > On Mon, Aug 17, 2015 at 1:25 PM, Hans Wennborg wrote: >> I'm OK with it if Greg approves. >> >> - Hans >> >> On Mon, Aug 17, 2015 at 7:06 AM, wrote: >>> Hi Hans, >>> >>> Could you please merge r245216 in

[Lldb-commits] [lldb] r245237 - Make sure to save the types we parse in our SymbolFile's type list so they don't get deleted.

Author: gclayton Date: Mon Aug 17 15:31:46 2015 New Revision: 245237 URL: http://llvm.org/viewvc/llvm-project?rev=245237&view=rev Log: Make sure to save the types we parse in our SymbolFile's type list so they don't get deleted. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFil

Re: [Lldb-commits] [PATCH] D12044: Fix resolution conflict between global and class static variables in C++.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12092: [ValueObjectSynthetic and ValueObjectDynamicValue] Override GetDeclaration

clayborg accepted this revision. clayborg added a comment. I'm good if the test suite is clean. http://reviews.llvm.org/D12092 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12100: [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12100 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

clayborg accepted this revision. clayborg added a comment. Please commit. http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

clayborg added a comment. No need to wait for Sean. http://reviews.llvm.org/D11962 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r245373 - Quiet build warnings on MacOSX.

Author: gclayton Date: Tue Aug 18 17:30:25 2015 New Revision: 245373 URL: http://llvm.org/viewvc/llvm-project?rev=245373&view=rev Log: Quiet build warnings on MacOSX. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachThread.cpp Modified: lldb/trunk/tools/debugserver/source/MacOSX/Mac

[Lldb-commits] [lldb] r245375 - Fix inconsistent use of override warnings.

Author: gclayton Date: Tue Aug 18 17:31:29 2015 New Revision: 245375 URL: http://llvm.org/viewvc/llvm-project?rev=245375&view=rev Log: Fix inconsistent use of override warnings. Modified: lldb/trunk/include/lldb/Core/ValueObjectCast.h lldb/trunk/include/lldb/Core/ValueObjectConstResultCa

[Lldb-commits] [lldb] r245376 - More abstraction to get almost all clang specific DWARF parsing code into ClangASTContext.

Author: gclayton Date: Tue Aug 18 17:32:36 2015 New Revision: 245376 URL: http://llvm.org/viewvc/llvm-project?rev=245376&view=rev Log: More abstraction to get almost all clang specific DWARF parsing code into ClangASTContext. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h ll

Re: [Lldb-commits] [PATCH] D12203: Fix some format strings in ProcessGDBRemote.cpp.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12203 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12204: Understand absolute base addresses in ProcessGDBRemote::GetLoadedModuleList.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12204 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12218: Implement handling of `library:` keys in thread stop replies.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12218 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [lldb] r245547 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

I agree that this change has caused many problems and is quite large to commit to a release branch with little testing. I do really want to get to a Scalar and RegisterValue that uses llvm::APInt and llvm::APFloat as soon as possible, but seeing as this patch has continually caused crashes it s

Re: [Lldb-commits] [PATCH] D12233: Add absolute load address support for the DynamicLoader plugins

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:179 @@ -178,3 +178,3 @@ bool prev_die_had_children = false; -cons

Re: [Lldb-commits] [PATCH] D12238: Add support for DW_FORM_GNU_[addr, str]_index

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looks good, a few changes needed. We might consider changing FormValue::AsCString() to take a "SymbolFileDWARF*" instead of the data extractor for .debug_str and .debug_str_offs

Re: [Lldb-commits] [PATCH] D12245: Implement basic DidAttach and DidLaunch for DynamicLoaderWindowsDYLD.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Fine for now. http://reviews.llvm.org/D12245 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [Lldb-commits] [PATCH] D12239: Fix buffer overflow for fixed_form_sizes

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12239 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12238: Add support for DW_FORM_GNU_[addr, str]_index

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12238 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12290: Handle DW_OP_GNU_addr_index in DWARF expressions

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. DWARFExpression is unique in that it is separate from the DWARF plug-in itself because DWARF expressions are in .eh_frame and other things that don't require the rest of DWARF

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I see the need for a lot of this, but I feel like there are way too many places where we do this: SymbolFileDWARFDwo* dwo_symbol_file = dwarf_cu->GetDwoSymbolFile(); if (dwo_

Re: [Lldb-commits] [PATCH] D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Unless you really know what you are doing, I don't want anyone playing with this code just to fix some random test case. What must remain true: we first try the currently selecte

Re: [Lldb-commits] [PATCH] D12184: [MIPS] Avoid breakpoint in delay slot

clayborg accepted this revision. clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12184 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. I also question why Symbo In http://reviews.llvm.org/D12291#231523, @tberghammer wrote: > In the current version of the patch the compile units in the main object file > hands out only the compile unit DIE with the information what is available in > the main object fi

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. For our DWARF in .o files, I have SymbolFileDWARFDebugMap which loads the DWARF from .o files. Each .o file is loaded in a completely unchanged version of SymbolFileDWARF. Any lldb::user_id_t that are generated use: lldb::user_id_t SymbolFileDWARF::MakeUserID (dw_o

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. Let me get the DWARFDIE abstraction in and we can see where we are after I get this in as we will see more of what is possible to abstract when this is done. http://reviews.llvm.org/D12291 ___ lldb-commits mailing list lld

Re: [Lldb-commits] [PATCH] D12327: Treat cleanup errors separately from test failures

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12327 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I'll defer to Jim since he added this option. http://reviews.llvm.org/D12158 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://list

Re: [Lldb-commits] [PATCH] D12303: Fix for dotest.py ERRORs on OSX caused by svn rev.237053.

clayborg added a comment. Isn't fixing this as simple as having the TestDisassemble_VST1_64.py restore the platform correctly? http://reviews.llvm.org/D12303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This test passes fine when running dosep.py so I would prefer to set this to expected failure Repository: rL LLVM http://reviews.llvm.org/D12329 __

Re: [Lldb-commits] [PATCH] D12328: Error checking correction in AArch64 hardware watchpoint code

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Fix the incorrect bool return values and this will be good to go. http://reviews.llvm.org/D12328 ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D12356: [MIPS64] Emulate MSA branch instructions

clayborg resigned from this revision. clayborg removed a reviewer: clayborg. clayborg added a comment. I will defer to MIPS experts here. You might thing about adding tberghammer as a reviewer. Repository: rL LLVM http://reviews.llvm.org/D12356

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good for now, but we should add a way so that plug-ins can extend the "breakpoint set", "breakpoint delete", and other breakpoint commands so we don't have a bunch of fragmented extr

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. In http://reviews.llvm.org/D12291#233274, @tberghammer wrote: > I though a bit more about the abstraction you plan to introduce (DWARFDIE) > and I started to believe we don't need it at all. If we use lldb::user_id_t > in the NameToDIE indexes where the first 4 byte is

Re: [Lldb-commits] [PATCH] D12329: Skip test which is causing ERRORs in dotest.py on OSX after r237053

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ah expected failing it won't help the tests pass. My bad. Check this in for now until we can fix it properly. Repository: rL LLVM http://reviews.llvm.org/D12329

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg added a comment. I got my DWARFDIE stuff in with: % svn commit Sendinginclude/lldb/Core/dwarf.h Sendinginclude/lldb/Symbol/ClangASTContext.h Sendinginclude/lldb/Symbol/TypeSystem.h Sendinglldb.xcodeproj/project.pbxproj Sending source/Pl

[Lldb-commits] [lldb] r246172 - More cleanup to make sure no one plays with DWARFDebugInfoEntry. Clients outside of DWARFDebugInfoEntry of DWARFCompileUnit should use DWARFDIE only.

Author: gclayton Date: Thu Aug 27 13:09:44 2015 New Revision: 246172 URL: http://llvm.org/viewvc/llvm-project?rev=246172&view=rev Log: More cleanup to make sure no one plays with DWARFDebugInfoEntry. Clients outside of DWARFDebugInfoEntry of DWARFCompileUnit should use DWARFDIE only. Modified:

Re: [Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

> On Aug 26, 2015, at 9:08 PM, Dawn Perchik via lldb-commits > wrote: > > dawn added a subscriber: dawn. > dawn added a comment. > > Hi Greg, > > While I really appreciate that you're making lldb less Clang specific (e.g. > renaming ClangASTType to CompilerType), I'm concerned about this com

Re: [Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

> > Our Delphi compiler generates an alternate debug format as well - it took me > all of yesterday to fix merge conflicts and I've still not got things working > properly. Greg, can you please move the DWARF dependencies back into the > SymbolFileDWARF plugin? Thanks! Sorry to not be clear

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

clayborg added a comment. Please wait for the OK from Jim and Sean. http://reviews.llvm.org/D11102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

clayborg added a subscriber: clayborg. clayborg accepted this revision. clayborg added a reviewer: clayborg. clayborg added a comment. This revision is now accepted and ready to land. Looks fine as long as the test suite tests are passing. http://reviews.llvm.org/D11102 __

Re: [Lldb-commits] [PATCH] D12304: Add scope tree for variable searching

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. This seems to be very variable specific. I would like to see if be able to ask a lldb_private::Block or a lldb_private::Compile and to provide a list of CompilerDeclContext objec

Re: [Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

to DWARF, and > there's no reason that other ASTContext classes shouldn't be able to reuse it. > > On Thu, Aug 27, 2015 at 2:08 PM via lldb-commits > wrote: > On Thu, Aug 27, 2015 at 12:56:57PM -0700, Greg Clayton via lldb-commits wrote: > > > > > > Our De

Re: [Lldb-commits] [Diffusion] rL245090: Move all clang type system DWARF type parsing into ClangASTContext.cpp.

Try this out: % svn commit Sendinginclude/lldb/Symbol/ClangASTContext.h Sendinginclude/lldb/Symbol/TypeSystem.h Sendinglldb.xcodeproj/project.pbxproj Sendingsource/Plugins/SymbolFile/DWARF/CMakeLists.txt Adding source/Plugins/SymbolFile/DWARF/DWARFASTParser.

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. I would like to see a few things as long as we are chaning things: - get rid of dosep.py and just put the functionality into dotest.py if possible, it can just spawn itself in di

Re: [Lldb-commits] [PATCH] D12416: Parse dotest.py/dosep.py output, providing general stats and skip reason breakdown by counts.

> On Aug 28, 2015, at 9:36 AM, Zachary Turner wrote: > > > > On Fri, Aug 28, 2015 at 8:41 AM Todd Fiala wrote: > tfiala added a comment. > > In http://reviews.llvm.org/D12416#235112, @labath wrote: > > > Same question as Zachary. This sounds like a very useful feature and it > > would be n

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

clayborg added a comment. We do want processes to have individual copies that are copied from the platform. Does this actually make a copy? I don't see the copy. http://reviews.llvm.org/D12420 ___ lldb-commits mailing list lldb-commits@lists.llvm.o

[Lldb-commits] [lldb] r246488 - Stop objects from keeping a strong reference to the process when they should have a weak reference.

Author: gclayton Date: Mon Aug 31 16:25:45 2015 New Revision: 246488 URL: http://llvm.org/viewvc/llvm-project?rev=246488&view=rev Log: Stop objects from keeping a strong reference to the process when they should have a weak reference. Modified: lldb/trunk/source/Plugins/InstrumentationRunt

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. See inlined comments. Main fix themes: - It would be great to try and avoid any manual function calls where we supply the compile unit and a DIE offset that we assume comes from

Re: [Lldb-commits] [PATCH] D12531: Fix tab completion for command arguments containing spaces

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12531 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. DWARF parser should be stripping bit #0 for all addresses from mips targets: line tables, all address ranges for functions and blocks and variables should have this bit #0 stripp

Re: [Lldb-commits] [PATCH] D12552: Fix deadlock while attaching to inferiors

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

clayborg added a comment. Changing all $d symbols to always say they are eAddressClassDataIntermixedCode is wrong because the symbols in the .data section now would be marked as eAddressClassDataIntermixedCode. To clarify a few things, lets say we have the following code: 0x1000: bx Non-tail

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Marking as needing changes due to above comments. http://reviews.llvm.org/D12556 ___ lldb-commits mailing list lldb-commits@lists.l

Re: [Lldb-commits] [PATCH] D12558: Fix rare failure in TestProcessIO

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12558 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

clayborg added a comment. I would leave everything as is (no eAddressClassDataIntermixedCode), but I would change the code to use: target->GetOpcodeLoadAddress (return_load_addr, eAddressClassCode); We don't need to lookup the address class type when determining return addresses. Then this s

Re: [Lldb-commits] [PATCH] D12556: Introduce new address class eAddressClassDataIntermixedCode

clayborg added a comment. So: target->GetOpcodeLoadAddress (return_load_addr, eAddressClassCode); Would get used in the stack backtracing code that is currently looking up the real address class of the return address... http://reviews.llvm.org/D12556 _

Re: [Lldb-commits] [PATCH] D12585: Add a TypeSystem for Go

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few cleanups to do mentioned in the inlined comments. Comment at: include/lldb/Core/Module.h:950 @@ -949,1 +949,3 @@ +GoASTContext &GetGoASTContext(

Re: [Lldb-commits] [PATCH] D12587: Roll dosep.py parallel test runner into dotest.py command line

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12587 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12589: SystemRuntime/MacOSX no longer need ObjCRuntime header.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good http://reviews.llvm.org/D12589 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. A few changes. I think this might create problems for DWARF in .o files on MacOSX. Are you able to test on MacOSX? We used to store the compile unit index in the upper 32 bits o

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Did you check who is all calling this? Is it only places that know that an address is code? It seems like we have might have different clients expecting different things out of t

Re: [Lldb-commits] [PATCH] D12599: Only export public symbols with the cmake build.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. http://reviews.llvm.org/D12599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12613: Lookup function using full name if one with mangled name is not found.

clayborg added a comment. I worry a bit about performance here, but we should find any regressions and address them if we run into any. http://reviews.llvm.org/D12613 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/c

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. We really do need to restrict this for single stepping purposes. If the thread plans that single step and set breakpoints for stepping think they should place a breakpoint on 0x1004 if the

Re: [Lldb-commits] [PATCH] D12585: Add a TypeSystem for Go

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Comment at: include/lldb/Symbol/ClangASTContext.h:484 @@ -483,3 +483,3 @@ //-- - +

[Lldb-commits] [lldb] r246887 - Check for null compile unit so we don't crash.

Author: gclayton Date: Fri Sep 4 17:29:46 2015 New Revision: 246887 URL: http://llvm.org/viewvc/llvm-project?rev=246887&view=rev Log: Check for null compile unit so we don't crash. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp Modified: lldb/trunk/source/Plugins/

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks fine. Zach, do you need to make some modifications for Windows? Or should we just check this in and you can fix windows with a separate patch? http://reviews.llvm.org/D12651

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

clayborg added a comment. I believe that python is also weird in that if you want to catch a CTRL+C it has to be executing python code (not in a python code the entered C/C++ code) otherwise the CTRL+C might not get to the python itself. This might be only a problem in the embedded python inter

Re: [Lldb-commits] [PATCH] D12651: Add ctrl-c support to parallel dotest.py.

clayborg added a comment. Were you running dosep.py on Windows before as the way to run your test suite? Or were you running dotest.py (no multi-threading)? http://reviews.llvm.org/D12651 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

Re: [Lldb-commits] [PATCH] D12291: Add split dwarf support to SymbolFileDWARF

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. One minor IsValid() fix in DWARFDIE to avoid crashes and this is good to go. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp:28-35 @@ -27,1 +27,10 @@

Re: [Lldb-commits] [PATCH] D12667: [cmake] Remove LLDB_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION.

clayborg added a comment. Looks good. Repository: rL LLVM http://reviews.llvm.org/D12667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D12683: Fix debugger shutdown when Python interpreter is loaded

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. http://reviews.llvm.org/D12683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Open issues: - In FormatEntity.cpp we probably don't need any changes to DumpAddress() - Remove MIPS comment from generic code and let the "Target::GetOpcodeLoadAddress (...) con

[Lldb-commits] [lldb] r247041 - Use LLVM casting for TypeSystem so you can cast it to subclasses.

Author: gclayton Date: Tue Sep 8 13:15:05 2015 New Revision: 247041 URL: http://llvm.org/viewvc/llvm-project?rev=247041&view=rev Log: Use LLVM casting for TypeSystem so you can cast it to subclasses. This will keep our code cleaner and it removes the need for intrusive additions to TypeSystem l

[Lldb-commits] [lldb] r247175 - Make sure to flush the stream to make sure the string is up to date when we query its size.

Author: gclayton Date: Wed Sep 9 13:41:50 2015 New Revision: 247175 URL: http://llvm.org/viewvc/llvm-project?rev=247175&view=rev Log: Make sure to flush the stream to make sure the string is up to date when we query its size. Modified: lldb/trunk/source/Plugins/Disassembler/llvm/Disassembl

[Lldb-commits] [lldb] r247193 - Remove a call to deleted function.

Author: gclayton Date: Wed Sep 9 16:34:32 2015 New Revision: 247193 URL: http://llvm.org/viewvc/llvm-project?rev=247193&view=rev Log: Remove a call to deleted function. Modified: lldb/trunk/source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp Modified: lldb/trunk/source/Plugins/Disassemb

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So DumpAddress() in FormatEntity.cpp is a generic "dump any address by describing it". You can't just change the code to suit your needs for MIPS. This address could be any addre

Re: [Lldb-commits] [PATCH] D12079: [MIPS] microMIPS breakpoints, disassembly and compressed addresses

clayborg added a comment. Actually not a new format type, but an extra arg will need to be passed to DumpAddress like "bool addr_is_callable". Can you explain something to me? In the following example: 0x8020067d <+0>: addiusp -16 0x8020067f <+2>: sw $fp, 12($sp) 0x80200681 <+4>: m

[Lldb-commits] [lldb] r247196 - Now that CompilerType uses a "TypeSystem *" and a "void *" instead of a "clang::ASTContext *" and a "void *", we need to know if anyone is trying to create a CompilerTy

Author: gclayton Date: Wed Sep 9 17:13:01 2015 New Revision: 247196 URL: http://llvm.org/viewvc/llvm-project?rev=247196&view=rev Log: Now that CompilerType uses a "TypeSystem *" and a "void *" instead of a "clang::ASTContext *" and a "void *", we need to know if anyone is trying to create a Com

[Lldb-commits] [lldb] r247197 - Remove unused function.

Author: gclayton Date: Wed Sep 9 17:13:36 2015 New Revision: 247197 URL: http://llvm.org/viewvc/llvm-project?rev=247197&view=rev Log: Remove unused function. Modified: lldb/trunk/include/lldb/Symbol/ClangASTContext.h lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/inc

[Lldb-commits] [lldb] r247202 - Fix the build-llvm.pl to not create one monster .a file from all of the llvm and clang .a files. We now just make a file list which we pass to the linker.

Author: gclayton Date: Wed Sep 9 17:35:25 2015 New Revision: 247202 URL: http://llvm.org/viewvc/llvm-project?rev=247202&view=rev Log: Fix the build-llvm.pl to not create one monster .a file from all of the llvm and clang .a files. We now just make a file list which we pass to the linker. Modif

[Lldb-commits] [lldb] r247224 - On MacOSX, revamp the way we link against the llvm/clang .a files by making a text file that contains all .a filenames and use that when linking in Xcode.

Author: gclayton Date: Wed Sep 9 19:48:44 2015 New Revision: 247224 URL: http://llvm.org/viewvc/llvm-project?rev=247224&view=rev Log: On MacOSX, revamp the way we link against the llvm/clang .a files by making a text file that contains all .a filenames and use that when linking in Xcode. Modif

[Lldb-commits] [lldb] r247227 - Removed debug prints that I accidentally left in.

Author: gclayton Date: Wed Sep 9 19:57:34 2015 New Revision: 247227 URL: http://llvm.org/viewvc/llvm-project?rev=247227&view=rev Log: Removed debug prints that I accidentally left in. Modified: lldb/trunk/scripts/build-llvm.pl Modified: lldb/trunk/scripts/build-llvm.pl URL: http://llvm.or

<    5   6   7   8   9   10   11   12   13   14   >