[Lldb-commits] [PATCH] D74579: Creating environment variable test for lldbd

2020-02-13 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244531. diazhector98 added a comment. Creating env tes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74579: Creating environment variable test for lldbd

2020-02-13 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 created this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74579 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240694. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 created this revision. diazhector98 added a reviewer: wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. diazhector98 planned changes to this revision. diazhector98 marked 5 inline comments as done. diazhector98 added inline comments.

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240700. diazhector98 added a comment. Added more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files:

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 planned changes to this revision. diazhector98 marked 5 inline comments as done. diazhector98 added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py:122 +self.verify_completions( +

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240693. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240715. diazhector98 edited the summary of this revision. diazhector98 added a comment. int32 to int Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files:

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240717. diazhector98 marked an inline comment as done. diazhector98 added a comment. changed int to size_t to avoid warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240683. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240687. diazhector98 added a comment. 1. Updating D73506 : Bug fix # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines as comment. # 4. If you intended

[Lldb-commits] [PATCH] D73506: Bug fix

2020-01-27 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240701. diazhector98 added a comment. Uncomment @skipIfDarwin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files:

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

2020-01-28 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240908. diazhector98 added a comment. Simplifying code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/ https://reviews.llvm.org/D73506 Files:

[Lldb-commits] [PATCH] D73506: Auto-completion bug fix for dot operator

2020-01-28 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 240916. diazhector98 marked an inline comment as done. diazhector98 added a comment. Added tests for spaces between member operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73506/new/

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244717. diazhector98 added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244719. diazhector98 added a comment. - Merge branch 'master' of https://github.com/llvm/llvm-project Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244701. diazhector98 added a comment. Working on comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244749. diazhector98 added a comment. Adding the test files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 created this revision. diazhector98 added a reviewer: wallace. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. . Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74636 Files: lldb/tools/lldb-vscode/package.json Index:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244779. diazhector98 added a comment. Adding test for priority Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244781. diazhector98 added a comment. Add Makefile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244782. diazhector98 added a comment. Removing print Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244767. diazhector98 added a comment. Continue repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244769. diazhector98 added a comment. Continue repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244770. diazhector98 added a comment. Continue repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244721. diazhector98 added a comment. - Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244748. diazhector98 added a comment. Add change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: lldb/tools/lldb-vscode/package.json Index:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244723. diazhector98 added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244763. diazhector98 added a comment. Continued repair Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [DO NOT REVIEW] Add inheritEnvironment option

2020-02-14 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244771. diazhector98 added a comment. Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74579: [don't review]Creating environment variable test for lldbd

2020-02-13 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 244547. diazhector98 added a comment. Squashing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74579/new/ https://reviews.llvm.org/D74579 Files:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

2020-03-10 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 249527. diazhector98 added a comment. Adding support for windows systems Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files:

[Lldb-commits] [PATCH] D74636: [lldb-vscode] Add inheritEnvironment option

2020-03-10 Thread Héctor Luis Díaz Aceves via Phabricator via lldb-commits
diazhector98 updated this revision to Diff 249536. diazhector98 added a comment. Adding remote process check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74636/new/ https://reviews.llvm.org/D74636 Files: