[Lldb-commits] [PATCH] D65362: [CMake] Move project() call to main CMake file

This revision was automatically updated to reflect the committed changes. Closed by commit rL367273: [CMake] Move project() call to main CMake file (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Host/windows/FileSystem.cpp

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The path defined in CMakeLists.txt doesn't match the path generated in our python script. This change fixes that. LLVM_LIBRARY_OUTPUT_INTDIR is defined as:

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220207. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220206. hhb added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files: lldb/scripts/CMakeLists.txt Index: lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb updated this revision to Diff 220392. hhb added a comment. Use CMAKE_HOST_SYSTEM_NAME instead. Since the python script is run on host. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583 Files:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. hhb added a reviewer: JDevlieghere. This way it can be overwritten when cross compiling. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67641 Files:

[Lldb-commits] [PATCH] D67583: Fix swig python package path

This revision was automatically updated to reflect the committed changes. Closed by commit rL372047: Fix swig python package path (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb added a comment. In D67641#1671881 , @JDevlieghere wrote: > Can we match what `FindPythonInterp ` and `FindPythonLibs` does? > > mark_as_advanced( > PYTHON_EXECUTABLE > PYTHON_DEBUG_LIBRARY > PYTHON_LIBRARY > PYTHON_INCLUDE_DIR >

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220410. hhb added a comment. Add mark_as_advanced. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220424. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220589. hhb added a comment. Add CACHE PATH again. I think this is the only way to go. With PARENT_SCOPE: Tthe local detected value is always used, even if a different value is set in cache. With no parameter: Always the value in cache is used. If a value is

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220594. hhb added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67641/new/ https://reviews.llvm.org/D67641 Files: lldb/cmake/modules/LLDBConfig.cmake Index:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL372194: Cache PYTHON_EXECUTABLE for windows (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67641: Cache PYTHON_EXECUTABLE for windows

hhb updated this revision to Diff 220584. hhb added a comment. Turns out I still need to change previous lines to remove PARENT_SCOPE. Otherwise local value will still be used even if a different value is set in the cache. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1674430 , @hhb wrote: > In D67583#1673356 , @ZeGentzy wrote: > > > Hello folks, > > > > These changes break running `ninja install` when building with `-D > > LLVM_LIBDIR_SUFFIX=32`.

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1673356 , @ZeGentzy wrote: > Hello folks, > > These changes break running `ninja install` when building with `-D > LLVM_LIBDIR_SUFFIX=32`. > > [...] > -- Up-to-date: >

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I don't have the right environment to try your command. But I didn't see anything obviously problematic. Can you try the following: cd /src/llvm-project/lldb/scripts/Python Then run the following python program: import sys

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. +deepak2427 since this behavior is introduced in https://github.com/llvm/llvm-project/commit/9b35cf52d2a88cda5167c9638696adce5b152720 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rL368125: Detect HAVE_SYS_TYPES_H in lldb (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65362: [CMake] Move project() call to main CMake file

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. The main CMake file don't have a project() call. In this case, cmake will run a dummy project(Project ) at the very beginning. Even before cmake_minimum_required. And a series of compiler

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:55 #define PATH_MAX MAX_PATH +#endif typedef int socklen_t; amccarth wrote: > Nothing in the rest of this .cpp file uses PATH_MAX, so just delete the > `#define` instead of

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213448. hhb marked 4 inline comments as done. hhb added a comment. Fix comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213689. hhb added a comment. Herald added a subscriber: mstorsjo. Add one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. After rL368069 I noticed that HAVE_SYS_TYPES_H is not defined in Platform.h, or anywhere else in lldb. This change fixes

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

This revision was automatically updated to reflect the committed changes. Closed by commit rL368069: Various build fixes for lldb on MinGW (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb added a comment. I'm not really know how this works before, given no one includes Config.h. Or maybe sys/types.h is never needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213688. hhb added a comment. Remove test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213687. hhb added a comment. Remove a test code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

hhb updated this revision to Diff 213505. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65691/new/ https://reviews.llvm.org/D65691 Files: lldb/include/lldb/Host/windows/PosixApi.h

[Lldb-commits] [PATCH] D65822: Detect HAVE_SYS_TYPES_H in lldb

hhb updated this revision to Diff 213726. hhb added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65822/new/ https://reviews.llvm.org/D65822 Files: lldb/cmake/modules/LLDBGenerateConfig.cmake

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

hhb created this revision. hhb added a reviewer: labath. hhb added a project: LLDB. Herald added a subscriber: lldb-commits. This test doesn't make sense. Change to be consistent with what we did in GDBRemoteCommunication.cpp. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

This revision was automatically updated to reflect the committed changes. Closed by commit rL368352: [lldb] Fix HAVE_LIBCOMPRESSION (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D65965: [lldb] Fix HAVE_LIBCOMPRESSION

hhb updated this revision to Diff 214212. hhb added a comment. And we should really include Config.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65965/new/ https://reviews.llvm.org/D65965 Files:

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

hhb created this revision. hhb added a reviewer: JDevlieghere. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. hhb added a subscriber: kongyi. This fixes lldb build on macOS SDK prior to 10.12. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66034 Files:

[Lldb-commits] [PATCH] D66034: Detects whether RESOURCE_TYPE_IO is defined.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368496: Detects whether RESOURCE_TYPE_IO is defined. (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675889 , @ZeGentzy wrote: > In D67583#1675714 , @hhb wrote: > > > My theory now is that your python has a different implementation of > > get_python_lib(). After all we should not

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1676531 , @labath wrote: > I could be off mark here, but I do recall some people trying to get this code > to work in environments where python and lldb(llvm) are configured with > different libdirs (so LLVM_LIBDIR_SUFFIX

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Before this change, the procedure of installing and loading python modules are as follow: 1. finishSwigPythonLLDB.py writes necessary files to

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb updated this revision to Diff 221123. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. Oh sorry my mistake. The current directory should be llvm-project/lldb/scripts. I.e. cd /src/llvm-project/lldb/scripts Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372493: Use _WIN32 instead of _MSC_VER (authored by hhb, committed by ). Herald added a project: LLVM. Herald added a

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

hhb created this revision. Herald added subscribers: lldb-commits, mstorsjo. Herald added a project: LLDB. This way it works better with MinGW. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67887 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. In D67583#1675697 , @ZeGentzy wrote: > In D67583#1675415 , @hhb wrote: > > > Oh sorry my mistake. The current directory should be > > llvm-project/lldb/scripts. I.e. > > > > cd

[Lldb-commits] [PATCH] D67583: Fix swig python package path

hhb added a comment. I'm making a change in finishSwigPythonLLDB.py to write directly to targetDir. This way we don't have the problem to guess where the files are written. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67583/new/ https://reviews.llvm.org/D67583

[Lldb-commits] [PATCH] D67781: Revert "Fix swig python package path"

hhb created this revision. hhb added reviewers: JDevlieghere, ZeGentzy. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This reverts commit 5a115e81cdd40c758b10c382aeffc0c8de6930e2 . Repository:

[Lldb-commits] [PATCH] D67781: Revert "Fix swig python package path"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372364: Revert Fix swig python package path (authored by hhb, committed by ). Herald added a project: LLVM. Herald added

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/CMakeLists.txt:45-50 + execute_process( +COMMAND ${PYTHON_EXECUTABLE} +-c "import distutils.sysconfig, sys; print(distutils.sysconfig.get_python_lib(True, False, sys.argv[1]))" +${CMAKE_BINARY_DIR} +

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added a comment. And thanks for this and it is definitely an improvement! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67890/new/ https://reviews.llvm.org/D67890 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > If we go this way,

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") hhb wrote: > mgorny wrote: > > hhb wrote: > > >

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > >

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Fix installing Python modules on systems using /usr/lib

hhb added inline comments. Comment at: lldb/scripts/get_relative_lib_dir.py:26 split_libdir = arch_specific_libdir.split(os.sep) -lib_re = re.compile(r"^lib.+$") +lib_re = re.compile(r"^lib.*$") mgorny wrote: > hhb wrote: > > mgorny wrote: > > >

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

hhb accepted this revision. hhb added a comment. This revision is now accepted and ready to land. Thanks! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67894/new/ https://reviews.llvm.org/D67894 ___ lldb-commits

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib Just bail out in this

[Lldb-commits] [PATCH] D67890: [lldb] [cmake] Unify and correct Python module installation paths

hhb added inline comments. Comment at: lldb/scripts/Python/prepare_binding_Python.py:284 +module_path = options.python_relative_path +if module_path is None: +from distutils.sysconfig import get_python_lib hhb wrote: > Just bail out

[Lldb-commits] [PATCH] D67910: [LLDB] Avoid warnings about redefining posix mode defines on MinGW

hhb accepted this revision. hhb added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Host/windows/PosixApi.h:39 #endif +#ifndef S_IRGRP #define S_IRGRP 0 /* read, group */ Maybe move these into the

[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb created this revision. hhb added a reviewer: mstorsjo. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Not sure whether this is a feature or bug... Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67942 Files: lldb/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D67942: Install python dll to bin

hhb marked an inline comment as done. hhb added a comment. Arguably a correct python installation in windows should already have python*.dll. But then why do we copy the file to build dir above. Comment at: lldb/CMakeLists.txt:233 COMMENT "Copying Python DLL to

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1731782 , @aadsm wrote: > I fixed this locally by doing this (this fix doesn't really feel good but not > sure what's the best way to do it): I found it confusing too. So finish_swig should depends on liblldb, because at

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. See D68370 . We probably need to do the same thing for darwin... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

hhb created this revision. hhb added a reviewer: aadsm. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Similar to D68370 but for darwin framework build. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69834

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. Alternatively we should not depends on install-liblldb to install python packages, but have a install command similar to what we did below for other platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. Sent D69834 . Haven't get a chance to test but you can see the idea... Also please add lldb-python-scripts to your LLVM_DISTRIBUTION_COMPONENTS when testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb added a comment. In D69589#1733567 , @aadsm wrote: > @hhb fwiw, I still get the same error with this diff (after applying it on > top of D69834 ). But D69834 > by itself works great!

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227974. hhb added a comment. Fix some naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227958. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69589/new/ https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a79e083a0d1: [lldb] Add a install target for lldb python on darwin (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69834/new/

[Lldb-commits] [PATCH] D69834: [lldb] Add a install target for lldb python on darwin

hhb updated this revision to Diff 227956. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69834/new/ https://reviews.llvm.org/D69834 Files: lldb/CMakeLists.txt Index: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb updated this revision to Diff 227145. hhb added a comment. Update one more place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This avoids config time dependencies on liblldb. And enables other refactoring. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69630 Files:

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb marked an inline comment as done. hhb added a comment. In D69589#1726812 , @labath wrote: > This looks reasonable to me. I'm just wondering, now that these are separate > targets, I guess that means they can be run in random order, right? Will that

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb updated this revision to Diff 227204. hhb added a comment. When creating symlink, make the target depends on relative target path. So that if the target file doesn't exist, the build will fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69630: [lldb] Record framework build path and use it everywhere

hhb updated this revision to Diff 227172. hhb added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69630/new/ https://reviews.llvm.org/D69630 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D69931: Add cmake variables to specify a python framework to ship with lldb

hhb added a comment. In D69931#1736607 , @labath wrote: > In principle, this looks pretty similar to D67942 > , and my opinion on it is the same -- I > don't think we should be in the business of trying to package the

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb added a comment. In D69019#1722063 , @labath wrote: > Right. I see what you mean. > > But... does this have to happen at build time? Since the list of files is > already known at configuration time, you should be able to generate the files > in the

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d4a40751ff3: [lldb] move more things from python to cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D69016?vs=225151=225270#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 225268. hhb added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 225266. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG208e9c01fc09: [lldb] Creates _liblldb symlink from cmake (authored by hhb). Changed prior to commit: https://reviews.llvm.org/D68858?vs=224955=225123#toc Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. Python 3.6.8 (default, Apr 30 2019, 13:27:23) [GCC] on linux Type "help", "copyright", "credits" or "license" for more information. >>> import distutils.sysconfig >>> print(distutils.sysconfig.get_python_lib(True, False, '')) lib64/python3.6/site-packages >>>

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb accepted this revision. hhb added a comment. In D68910#1710009 , @llunak wrote: > How about this one? This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the

[Lldb-commits] [PATCH] D68910: python path should be platform-dependent

hhb added a comment. One additional statement in openSUSE comparing to standard python: libdir = plat_specific and get_config_var("platlibdir") or "lib" Hmmm basically what does platform dependent mean... Anyway this change looks good to me. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D68910: use LLVM_LIBDIR_SUFFIX for python lib path

hhb requested changes to this revision. hhb added a comment. This revision now requires changes to proceed. Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change... Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked an inline comment as done. hhb added a comment. In D68858#1709458 , @tatyana-krasnukha wrote: > Build and installation completed successfully! LGTM, though it would be good > if anyone tests this with Xcode. I just tested Xcode. For xcode

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb created this revision. hhb added a project: LLDB. hhb planned changes to this revision. This is the last part. And we can remove the python script. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

hhb created this revision. hhb added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. Move the copy of six.py, lldb.py and macosx/heap Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69016 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb marked 3 inline comments as done. hhb added inline comments. Comment at: lldb/CMakeLists.txt:244 + else() +set(LIBLLDB_SYMLINK_DEST "${liblldb_build_dir}/liblldb${CMAKE_SHARED_LIBRARY_SUFFIX}") + endif() tatyana-krasnukha wrote: > This command still

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224955. hhb added a comment. Oops fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

hhb updated this revision to Diff 224954. hhb added a comment. Fix the build for multi-config generator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ https://reviews.llvm.org/D68858 Files: lldb/CMakeLists.txt

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

This revision was automatically updated to reflect the committed changes. Closed by commit rG99046b873f7f: [lldb] move package generation from python to cmake (authored by hhb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb updated this revision to Diff 226781. hhb added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69019/new/ https://reviews.llvm.org/D69019 Files: lldb/CMakeLists.txt lldb/scripts/Python/createPythonInit.py

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

hhb created this revision. Herald added subscribers: lldb-commits, mgorny. Herald added a project: LLDB. This makes all dependencies correct. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69589 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D69016: [lldb] move more things from python to cmake

hhb added a comment. In D69016#1710466 , @mgorny wrote: > I'm not sure if I like the usage of `POST_BUILD` stuff (it provides less > control than separate targets) but overall this seems a good change. > Replacing ~250 lines of reinventing the wheel

[Lldb-commits] [PATCH] D69019: [lldb] move package generation from python to cmake

hhb added a comment. In D69019#1721867 , @labath wrote: > I'm sorry, this dropped off my radar. The only question I have here is about > the createPythonInit.py script. If we're moving stuff to cmake, I am > wondering if we shouldn't move that thing

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This replaces the hard coded path. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67993 Files: lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D67988: [lldb] clean up lldb/scripts a little bit

hhb created this revision. hhb added reviewers: labath, mgorny. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. No functional change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67988 Files: lldb/scripts/Python/finishSwigPythonLLDB.py

[Lldb-commits] [PATCH] D67866: [lldb] Unify python site-packages path

hhb updated this revision to Diff 221251. hhb added a comment. Fix symbol linker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67866/new/ https://reviews.llvm.org/D67866 Files: lldb/CMakeLists.txt lldb/scripts/CMakeLists.txt

[Lldb-commits] [PATCH] D67993: [lldb] Calculate relative path for symbol links

hhb added a comment. In D67993#1681901 , @mgorny wrote: > Yep, that's a change in the right direction. Have you (at least mentally) > verified that it produces the correct path in all cases? I wouldn't trust the > inputs being entirely correct. So far

[Lldb-commits] [PATCH] D68007: [lldb] Move swig call from python code to cmake

hhb updated this revision to Diff 221664. hhb added a comment. Fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68007/new/ https://reviews.llvm.org/D68007 Files: lldb/scripts/CMakeLists.txt

  1   2   >