[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan updated this revision to Diff 272288. jackoalan marked an inline comment as done. jackoalan added a comment. Fix ternary to use corresponding float/double overloaded constructors of APFloat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan marked 4 inline comments as done. jackoalan added a comment. Thank you @teemperor, your comments and changes in D81471 are very informative. I didn't realise DWARF had similar issues with static const members. Curiously, I am able to resolve direct

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan updated this revision to Diff 272287. jackoalan added a comment. Review changes from @teemperor. Base on `TypeSystemClang::SetIntegerInitializerForVariable` from D81471 , and add associated `TypeSystemClang::SetFloatingInitializerForVariable`.

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan updated this revision to Diff 272297. jackoalan added a comment. Apply formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160 Files:

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan updated this revision to Diff 272597. jackoalan added a comment. - Added a test for scoped enums (works as-is but still worth testing). - Less frivolous use of `auto` - Made the floating point vars constexpr to maintain validity in clang's internals. - AstRestoreTest CLASS tests run

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan marked 4 inline comments as done. jackoalan added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:7324-7331 + // If the variable is an enum type, take the underlying integer type as + // the type of the integer literal. + if

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan added a comment. Thank you! I do not have commit access, so I will need some help with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82160/new/ https://reviews.llvm.org/D82160 ___

[Lldb-commits] [PATCH] D82160: [lldb][PDB] Constexpr static member values as AST literals

jackoalan created this revision. jackoalan added reviewers: aleksandr.urakov, jasonmolenda, zturner. jackoalan added a project: LLDB. Herald added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, lldb-commits, sstefan1. Herald added a project: LLVM. When evaluating an expression