[Lldb-commits] [lldb] r355170 - Update com.apple.diagnosticd.diagnostic entitlement

2019-02-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Feb 28 19:34:51 2019 New Revision: 355170 URL: http://llvm.org/viewvc/llvm-project?rev=355170=rev Log: Update com.apple.diagnosticd.diagnostic entitlement name to the newer com.apple.private.logging.diagnostic. Modified:

[Lldb-commits] [lldb] r355169 - Increase timeout in Symbols::DownloadObjectAndSymbolFile

2019-02-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Feb 28 19:24:59 2019 New Revision: 355169 URL: http://llvm.org/viewvc/llvm-project?rev=355169=rev Log: Increase timeout in Symbols::DownloadObjectAndSymbolFile from 30 seconds to 120 seconds. We've seen cases where this symbol lookup can exceed 30 seconds for people

[Lldb-commits] [lldb] r355155 - Symbols.cpp in unittest moved too.

2019-02-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Feb 28 15:37:28 2019 New Revision: 355155 URL: http://llvm.org/viewvc/llvm-project?rev=355155=rev Log: Symbols.cpp in unittest moved too. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r355063 - Move Symbols.cpp files.

2019-02-27 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Feb 27 17:26:01 2019 New Revision: 355063 URL: http://llvm.org/viewvc/llvm-project?rev=355063=rev Log: Move Symbols.cpp files. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r354289 - One more fix while I'm looking at this - remove the

2019-02-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Feb 18 14:18:11 2019 New Revision: 354289 URL: http://llvm.org/viewvc/llvm-project?rev=354289=rev Log: One more fix while I'm looking at this - remove the unused IsSBProcess method, and have IsFBSProcess return false if we don't have API that we can use to make that

[Lldb-commits] [lldb] r354288 - Ah, misunderstood Jonas' feedback - fix this so we'll

2019-02-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Feb 18 14:13:34 2019 New Revision: 354288 URL: http://llvm.org/viewvc/llvm-project?rev=354288=rev Log: Ah, misunderstood Jonas' feedback - fix this so we'll do the right thing when both API are available. We want to try both of them if the first one fails. Modified:

[Lldb-commits] [lldb] r354287 - Clean up an unused variable warning when building this for

2019-02-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Feb 18 14:10:23 2019 New Revision: 354287 URL: http://llvm.org/viewvc/llvm-project?rev=354287=rev Log: Clean up an unused variable warning when building this for mac native. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified:

[Lldb-commits] [lldb] r354181 - Add some unconditional logging on the failure points when attaching

2019-02-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Feb 15 14:39:30 2019 New Revision: 354181 URL: http://llvm.org/viewvc/llvm-project?rev=354181=rev Log: Add some unconditional logging on the failure points when attaching to a process so we'll always get messages in the console logs. Also make the "is frontboard

[Lldb-commits] [lldb] r353581 - Tiny fix spotted by static analyzer; GetPath() returns a std::string,

2019-02-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Feb 8 15:36:25 2019 New Revision: 353581 URL: http://llvm.org/viewvc/llvm-project?rev=353581=rev Log: Tiny fix spotted by static analyzer; GetPath() returns a std::string, we get a pointer to the c-string rep and then the temporary object is destructed and we still

[Lldb-commits] [lldb] r353269 - Add a warning to GDBRemoteRegisterContext (if packet logging enabled)

2019-02-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Feb 5 20:08:09 2019 New Revision: 353269 URL: http://llvm.org/viewvc/llvm-project?rev=353269=rev Log: Add a warning to GDBRemoteRegisterContext (if packet logging enabled) if the size of the g packet response was smaller than expected and is going to be ignored.

[Lldb-commits] [lldb] r352158 - Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress

2019-01-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jan 24 19:01:48 2019 New Revision: 352158 URL: http://llvm.org/viewvc/llvm-project?rev=352158=rev Log: Remove a warning in DynamicLoaderDarwin::UpdateImageLoadAddress when the binary loaded in memory has a section that we cannot find in the on-disk version. I added

[Lldb-commits] [lldb] r351490 - Don't run TestBreakpointThumbCodesection.py on darwin systems;

2019-01-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jan 17 14:26:25 2019 New Revision: 351490 URL: http://llvm.org/viewvc/llvm-project?rev=351490=rev Log: Don't run TestBreakpointThumbCodesection.py on darwin systems; we don't use a thumb code section. Don't run Test128BitsInteger.py on armv7k; it's not a supported type

[Lldb-commits] [lldb] r350990 - Add SymbolFileBreakpad.

2019-01-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jan 11 19:17:39 2019 New Revision: 350990 URL: http://llvm.org/viewvc/llvm-project?rev=350990=rev Log: Add SymbolFileBreakpad. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r350786 - A little cleanup / commenting on locating kernel binaries while I

2019-01-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jan 9 16:57:54 2019 New Revision: 350786 URL: http://llvm.org/viewvc/llvm-project?rev=350786=rev Log: A little cleanup / commenting on locating kernel binaries while I was working on something else. DynamicLoaderDarwinKernel::SearchForKernelNearPC should have had an

[Lldb-commits] [lldb] r349580 - Don't forget to free the libcompression scratch buffer in the dtor.

2018-12-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 18 15:45:45 2018 New Revision: 349580 URL: http://llvm.org/viewvc/llvm-project?rev=349580=rev Log: Don't forget to free the libcompression scratch buffer in the dtor. Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp Modified:

[Lldb-commits] [lldb] r349572 - Remove the zlib CFLAGS and LDFLAGS settings from the xcode project file.

2018-12-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 18 15:33:42 2018 New Revision: 349572 URL: http://llvm.org/viewvc/llvm-project?rev=349572=rev Log: Remove the zlib CFLAGS and LDFLAGS settings from the xcode project file. We're linking against libcompression all the time now, we don't need to fall back to zlib.

[Lldb-commits] [lldb] r349563 - Force libcompression calls to be enabled when building on Darwin

2018-12-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 18 15:02:50 2018 New Revision: 349563 URL: http://llvm.org/viewvc/llvm-project?rev=349563=rev Log: Force libcompression calls to be enabled when building on Darwin systems. It has been available in the OS over over three years now. If lldb doesn't link against

[Lldb-commits] [lldb] r349553 - Un-conditionalize use of libcompression. debugserver only builds

2018-12-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 18 14:21:48 2018 New Revision: 349553 URL: http://llvm.org/viewvc/llvm-project?rev=349553=rev Log: Un-conditionalize use of libcompression. debugserver only builds on Darwin systems and libcompression has been in the OS for over three years. Remove use of /

[Lldb-commits] [lldb] r349417 - A few small updates to the testsuite for running against an iOS device.

2018-12-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Dec 17 15:33:40 2018 New Revision: 349417 URL: http://llvm.org/viewvc/llvm-project?rev=349417=rev Log: A few small updates to the testsuite for running against an iOS device. Remove the expected-fails for 34538611; using an alternate platform implementation handles

[Lldb-commits] [lldb] r349409 - Document the DBGSourcePathRemapping dictionary that may be

2018-12-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Dec 17 14:25:54 2018 New Revision: 349409 URL: http://llvm.org/viewvc/llvm-project?rev=349409=rev Log: Document the DBGSourcePathRemapping dictionary that may be present in the dSYM per-uuid plist, its precedence order with the older DBGBuildSourcePath/DBGSourcePath,

[Lldb-commits] [lldb] r349406 - Add PdbAstBuilder.cpp.

2018-12-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Dec 17 14:07:39 2018 New Revision: 349406 URL: http://llvm.org/viewvc/llvm-project?rev=349406=rev Log: Add PdbAstBuilder.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r349316 - Add a description of the similar packets defined in the

2018-12-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Sun Dec 16 10:44:54 2018 New Revision: 349316 URL: http://llvm.org/viewvc/llvm-project?rev=349316=rev Log: Add a description of the similar packets defined in the gdb-remote serial protocol documentation, call out the incompatability of lldb's vFile:open: packet as it

[Lldb-commits] [lldb] r349313 - Clarify a few minor details.

2018-12-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Sun Dec 16 10:33:58 2018 New Revision: 349313 URL: http://llvm.org/viewvc/llvm-project?rev=349313=rev Log: Clarify a few minor details. Modified: lldb/trunk/docs/lldb-platform-packets.txt Modified: lldb/trunk/docs/lldb-platform-packets.txt URL:

[Lldb-commits] [lldb] r349282 - Update the vFile:open: description to note that the flags

2018-12-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Sat Dec 15 10:40:38 2018 New Revision: 349282 URL: http://llvm.org/viewvc/llvm-project?rev=349282=rev Log: Update the vFile:open: description to note that the flags in the packet are lldb enum values, not the open(2) oflags -- forgot about that wrinkle. Also added a

[Lldb-commits] [lldb] r349232 - Ah, forgot qModuleInfo. Need to look that one up

2018-12-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 14 18:51:01 2018 New Revision: 349232 URL: http://llvm.org/viewvc/llvm-project?rev=349232=rev Log: Ah, forgot qModuleInfo. Need to look that one up and finish filling this in. Modified: lldb/trunk/docs/lldb-platform-packets.txt Modified:

[Lldb-commits] [lldb] r349231 - A brief outline of the packets that need to be implemented

2018-12-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Dec 14 18:36:39 2018 New Revision: 349231 URL: http://llvm.org/viewvc/llvm-project?rev=349231=rev Log: A brief outline of the packets that need to be implemented to write an lldb platform server that doesn't link against LLDB.framework to be able to fully run the lldb

[Lldb-commits] [lldb] r348557 - Change the amount of data that Platform::PutFile will try to transfer

2018-12-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Dec 6 16:35:26 2018 New Revision: 348557 URL: http://llvm.org/viewvc/llvm-project?rev=348557=rev Log: Change the amount of data that Platform::PutFile will try to transfer in one packet from 1k bytes to 16k bytes. Sending a large file to an iOS device directly

Re: [Lldb-commits] [lldb] r348527 - [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

2018-12-06 Thread Jason Molenda via lldb-commits
Hi Aaron, this is failing to build on macOS systems -- > On Dec 6, 2018, at 1:36 PM, Aaron Smith via lldb-commits > wrote: > > +// At this moment we only have the base name of the DLL. The full path > can > +// only be seen after the dynamic loading. Our best guess is Try to get >

[Lldb-commits] [lldb] r348300 - Add SBInitializerOptions.cpp.

2018-12-04 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Dec 4 12:34:23 2018 New Revision: 348300 URL: http://llvm.org/viewvc/llvm-project?rev=348300=rev Log: Add SBInitializerOptions.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r348040 - Add a test to verify that lldb can load a kext binary.

2018-11-30 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 30 13:33:00 2018 New Revision: 348040 URL: http://llvm.org/viewvc/llvm-project?rev=348040=rev Log: Add a test to verify that lldb can load a kext binary. Added: lldb/trunk/packages/Python/lldbsuite/test/macosx/load-kext/

[Lldb-commits] [lldb] r347122 - add PdbSymUid.cpp

2018-11-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 16 17:08:01 2018 New Revision: 347122 URL: http://llvm.org/viewvc/llvm-project?rev=347122=rev Log: add PdbSymUid.cpp Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r346991 - A unit test file moved.

2018-11-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 15 12:28:55 2018 New Revision: 346991 URL: http://llvm.org/viewvc/llvm-project?rev=346991=rev Log: A unit test file moved. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r346900 - update xcode project file for reproducers.

2018-11-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Nov 14 14:14:07 2018 New Revision: 346900 URL: http://llvm.org/viewvc/llvm-project?rev=346900=rev Log: update xcode project file for reproducers. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r346573 - Unbreak the linux bot from the previous commit. Fred needed to use

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 16:25:45 2018 New Revision: 346573 URL: http://llvm.org/viewvc/llvm-project?rev=346573=rev Log: Unbreak the linux bot from the previous commit. Fred needed to use some of the macros from mach/exc_resource.h to decode EXC_RESOURCE, but that header doesn't exist

[Lldb-commits] [lldb] r346571 - Enable listening for EXC_RESOURCE events, and format mach

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 16:14:14 2018 New Revision: 346571 URL: http://llvm.org/viewvc/llvm-project?rev=346571=rev Log: Enable listening for EXC_RESOURCE events, and format mach event as a thread stop reason if we receive one, using some macros to decode the payload. Patch

[Lldb-commits] [lldb] r346561 - Work with a gdb-remote target that doesn't handle the

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 14:33:26 2018 New Revision: 346561 URL: http://llvm.org/viewvc/llvm-project?rev=346561=rev Log: Work with a gdb-remote target that doesn't handle the qWatchpointSupportInfo packet correctly. In GDBRemoteCommunicationClient::GetWatchpointSupportInfo, if the

[Lldb-commits] [lldb] r346553 - Remove llvm include from debugserver, change

2018-11-09 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Nov 9 12:31:41 2018 New Revision: 346553 URL: http://llvm.org/viewvc/llvm-project?rev=346553=rev Log: Remove llvm include from debugserver, change LLVM_FALLTHROUGH's to [[clang::fallthrough]] - debugserver is only ever compiled on darwin systems with clang. Modified:

[Lldb-commits] [lldb] r346443 - Change $CURRENT_ARCH settings in xcode project file to hardcoded

2018-11-08 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 8 14:41:19 2018 New Revision: 346443 URL: http://llvm.org/viewvc/llvm-project?rev=346443=rev Log: Change $CURRENT_ARCH settings in xcode project file to hardcoded "x86_64" - used for finding the llvm build directory. Newer Xcodes do not define CURRENT_ARCH.

[Lldb-commits] [lldb] r346347 - Re-commit regularization of the lldb-gtest-build target.

2018-11-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Nov 7 11:28:03 2018 New Revision: 346347 URL: http://llvm.org/viewvc/llvm-project?rev=346347=rev Log: Re-commit regularization of the lldb-gtest-build target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r346342 - Revert r346285 until I can make it work correctly

2018-11-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Nov 7 10:38:15 2018 New Revision: 346342 URL: http://llvm.org/viewvc/llvm-project?rev=346342=rev Log: Revert r346285 until I can make it work correctly the way the bots build lldb. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r346285 - Standardize the OTHER_LDFLAGS for the lldb-gtest-build target.

2018-11-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Nov 6 17:19:52 2018 New Revision: 346285 URL: http://llvm.org/viewvc/llvm-project?rev=346285=rev Log: Standardize the OTHER_LDFLAGS for the lldb-gtest-build target. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r346283 - Compiler warning pointed out a mistake - fix it.

2018-11-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Nov 6 16:25:02 2018 New Revision: 346283 URL: http://llvm.org/viewvc/llvm-project?rev=346283=rev Log: Compiler warning pointed out a mistake - fix it. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp Modified:

[Lldb-commits] [lldb] r346278 - Add MSVCUndecoratedNameParser.cpp.

2018-11-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Nov 6 15:01:42 2018 New Revision: 346278 URL: http://llvm.org/viewvc/llvm-project?rev=346278=rev Log: Add MSVCUndecoratedNameParser.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r345912 - When no FileCheck binary is specified, look in the llvm/clang bin

2018-11-01 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Nov 1 16:41:05 2018 New Revision: 345912 URL: http://llvm.org/viewvc/llvm-project?rev=345912=rev Log: When no FileCheck binary is specified, look in the llvm/clang bin dirs relative to the source directory (Xcode build style) to find one, use it if found. Modified:

[Lldb-commits] [lldb] r345422 - Remove an early-return from Driver::ParseArgs that

2018-10-26 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Oct 26 12:40:18 2018 New Revision: 345422 URL: http://llvm.org/viewvc/llvm-project?rev=345422=rev Log: Remove an early-return from Driver::ParseArgs that was added as a part of D52604 / r343348. If the lldb driver is run without any arguments, .lldbinit file reading

[Lldb-commits] [lldb] r345106 - Support nwere versions of the Segger J-Link jtag board software.

2018-10-23 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 23 16:45:56 2018 New Revision: 345106 URL: http://llvm.org/viewvc/llvm-project?rev=345106=rev Log: Support nwere versions of the Segger J-Link jtag board software. Add support in ProcessGDBRemote::GetGDBServerRegisterInfo for recognizing a generic "arm" architecture

[Lldb-commits] [lldb] r345069 - Add UdtRecordCompleter.cpp.

2018-10-23 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 23 12:03:52 2018 New Revision: 345069 URL: http://llvm.org/viewvc/llvm-project?rev=345069=rev Log: Add UdtRecordCompleter.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r344646 - Fixed an issue that a bot found with my changes

2018-10-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 16 14:49:31 2018 New Revision: 344646 URL: http://llvm.org/viewvc/llvm-project?rev=344646=rev Log: Fixed an issue that a bot found with my changes in r344626 & recommitting. Original commit msg: Simplify LocateDSYMInVincinityOfExecutable by moving some redundant

[Lldb-commits] [lldb] r344636 - Revert r344626 while I address a testsuite failure from a bot.

2018-10-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 16 11:25:46 2018 New Revision: 344636 URL: http://llvm.org/viewvc/llvm-project?rev=344636=rev Log: Revert r344626 while I address a testsuite failure from a bot. Modified: lldb/trunk/source/Host/common/Symbols.cpp Modified:

[Lldb-commits] [lldb] r344635 - Tiny testsuite tweaks. Don't run the apple simulator

2018-10-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 16 11:14:30 2018 New Revision: 344635 URL: http://llvm.org/viewvc/llvm-project?rev=344635=rev Log: Tiny testsuite tweaks. Don't run the apple simulator tests when targetting a device. Add an include to safe-to-call-func to work around a modules issue with a

[Lldb-commits] [lldb] r344633 - Don't run TestBreakpointIt.py on arm64 devices;

2018-10-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 16 11:11:17 2018 New Revision: 344633 URL: http://llvm.org/viewvc/llvm-project?rev=344633=rev Log: Don't run TestBreakpointIt.py on arm64 devices; it is armv7 specific. Modified: lldb/trunk/packages/Python/lldbsuite/test/arm/breakpoint-it/TestBreakpointIt.py

[Lldb-commits] [lldb] r344628 - For a built & test bot, add an environment variable PLATFORM_SDK_DIRECTORY,

2018-10-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 16 10:31:33 2018 New Revision: 344628 URL: http://llvm.org/viewvc/llvm-project?rev=344628=rev Log: For a built & test bot, add an environment variable PLATFORM_SDK_DIRECTORY, which PlatformRemoteDarwinDevice::UpdateSDKDirectoryInfosIfNeeded which examine for any

[Lldb-commits] [lldb] r344626 - Simplify LocateDSYMInVincinityOfExecutable by moving

2018-10-16 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Oct 16 10:26:04 2018 New Revision: 344626 URL: http://llvm.org/viewvc/llvm-project?rev=344626=rev Log: Simplify LocateDSYMInVincinityOfExecutable by moving some redundant code into a separate function, LookForDsymNextToExecutablePath, and having that function also look

Re: [Lldb-commits] [lldb] r344429 - Try to fix some failures on MacOSX with the NativePDB patch.

2018-10-12 Thread Jason Molenda via lldb-commits
Yep, thanks! % bin/lldb-test symbols ../f.obj Module: ../f.obj Module ../f.obj 0x7fb795587320: ObjectFileMachO64, file = '../f.obj', triple = x86_64-apple-macosx10.14.0 SectID Type File Address Perm File Off. File Size Flags Section Name

Re: [Lldb-commits] [lldb] r344409 - Resubmit "Add SymbolFileNativePDB plugin."

2018-10-12 Thread Jason Molenda via lldb-commits
Adrian suggests that parseFileHeaders is returning an error and that needs to be cleared? > On Oct 12, 2018, at 3:27 PM, Jason Molenda wrote: > > Ah, mystery solved. The lit test specifies REQUIRES Darwin. > >> On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote: >> >> >> >>> On Oct 12,

Re: [Lldb-commits] [lldb] r344409 - Resubmit "Add SymbolFileNativePDB plugin."

2018-10-12 Thread Jason Molenda via lldb-commits
Ah, mystery solved. The lit test specifies REQUIRES Darwin. > On Oct 12, 2018, at 3:22 PM, Jason Molenda wrote: > > > >> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits >> wrote: >> >> Resubmit "Add SymbolFileNativePDB plugin." >> >> This was originally reverted due to

Re: [Lldb-commits] [lldb] r344409 - Resubmit "Add SymbolFileNativePDB plugin."

2018-10-12 Thread Jason Molenda via lldb-commits
> On Oct 12, 2018, at 12:47 PM, Zachary Turner via lldb-commits > wrote: > > Resubmit "Add SymbolFileNativePDB plugin." > > This was originally reverted due to some test failures on > Linux. Those problems turned out to require several additional > patches to lld and clang in order to fix,

[Lldb-commits] [lldb] r344414 - Add NativePDB subdir again.

2018-10-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Oct 12 13:53:21 2018 New Revision: 344414 URL: http://llvm.org/viewvc/llvm-project?rev=344414=rev Log: Add NativePDB subdir again. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r344323 - Remove references to source/Plugins/SymbolFile/NativePDB.

2018-10-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 11 17:53:55 2018 New Revision: 344323 URL: http://llvm.org/viewvc/llvm-project?rev=344323=rev Log: Remove references to source/Plugins/SymbolFile/NativePDB. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r344277 - Fix this comment so it is consistent with all the others.

2018-10-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 11 11:41:34 2018 New Revision: 344277 URL: http://llvm.org/viewvc/llvm-project?rev=344277=rev Log: Fix this comment so it is consistent with all the others. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteAppleBridge.cpp Modified:

[Lldb-commits] [lldb] r344275 - Don't mark an LC_BUILD_VERSION as giving us a

2018-10-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Oct 11 11:37:53 2018 New Revision: 344275 URL: http://llvm.org/viewvc/llvm-project?rev=344275=rev Log: Don't mark an LC_BUILD_VERSION as giving us a correct version if it has a major verison 0. Modified:

[Lldb-commits] [lldb] r344209 - Upstreaming the BridgeOS device support and the

2018-10-10 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Oct 10 17:28:35 2018 New Revision: 344209 URL: http://llvm.org/viewvc/llvm-project?rev=344209=rev Log: Upstreaming the BridgeOS device support and the LC_BUILD_VERSION load command handling - this commit is a combination of patches by Adrian Prantl and myself.

[Lldb-commits] [lldb] r343029 - Change the unwinder to not use a hard-coded limit on the

2018-09-25 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Sep 25 14:01:54 2018 New Revision: 343029 URL: http://llvm.org/viewvc/llvm-project?rev=343029=rev Log: Change the unwinder to not use a hard-coded limit on the max number of stack frames to backtrace, make it a setting, target.process.thread.max-backtrace-depth. Add a

[Lldb-commits] [lldb] r342085 - Commit my attempt to test the change to ProcessGDBRemote

2018-09-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Sep 12 14:35:02 2018 New Revision: 342085 URL: http://llvm.org/viewvc/llvm-project?rev=342085=rev Log: Commit my attempt to test the change to ProcessGDBRemote in r336956. This test doesn't actually test the change that was submitted by Venkata, but it's a good one to

[Lldb-commits] [lldb] r342072 - If we fail to get an armv7em-- disassembler from llvm, skip the

2018-09-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Sep 12 12:30:03 2018 New Revision: 342072 URL: http://llvm.org/viewvc/llvm-project?rev=342072=rev Log: If we fail to get an armv7em-- disassembler from llvm, skip the tests and don't mark this as a failure. This happens when we've linked against an llvm without the ARM

[Lldb-commits] [lldb] r341696 - Add the Disassembler unit test dir.

2018-09-07 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Sep 7 11:51:10 2018 New Revision: 341696 URL: http://llvm.org/viewvc/llvm-project?rev=341696=rev Log: Add the Disassembler unit test dir. Modified: lldb/trunk/unittests/CMakeLists.txt Modified: lldb/trunk/unittests/CMakeLists.txt URL:

[Lldb-commits] [lldb] r341623 - Enable the fp-armv8 disassembler feature when disassembling Cortex-M

2018-09-06 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Sep 6 18:28:48 2018 New Revision: 341623 URL: http://llvm.org/viewvc/llvm-project?rev=341623=rev Log: Enable the fp-armv8 disassembler feature when disassembling Cortex-M code. This will enable disassembly of the optional subset of neon that some Cortex cores support.

[Lldb-commits] [lldb] r341511 - Re-instate a bit of code that was commented out in r188246 which

2018-09-05 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Sep 5 17:55:27 2018 New Revision: 341511 URL: http://llvm.org/viewvc/llvm-project?rev=341511=rev Log: Re-instate a bit of code that was commented out in r188246 which reads an ObjectFileMachO's string table in one chunk. Originally this was commented out because

[Lldb-commits] [lldb] r340877 - Remove unnecessary entitlement in debugserver for iOS.

2018-08-28 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Aug 28 15:28:34 2018 New Revision: 340877 URL: http://llvm.org/viewvc/llvm-project?rev=340877=rev Log: Remove unnecessary entitlement in debugserver for iOS. Modified: lldb/trunk/tools/debugserver/source/debugserver-entitlements.plist Modified:

[Lldb-commits] [lldb] r339615 - Update TestTargetXMLArch.py test for llvm triple change with unspecified

2018-08-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Aug 13 14:20:29 2018 New Revision: 339615 URL: http://llvm.org/viewvc/llvm-project?rev=339615=rev Log: Update TestTargetXMLArch.py test for llvm triple change with unspecified components in r339294. Modified:

[Lldb-commits] [lldb] r337865 - Add DumpRegisterValue.cpp.

2018-07-24 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jul 24 16:19:56 2018 New Revision: 337865 URL: http://llvm.org/viewvc/llvm-project?rev=337865=rev Log: Add DumpRegisterValue.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r337774 - Change sort-pbxproj.rb to find the project.pbxproj in the

2018-07-23 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jul 23 16:34:50 2018 New Revision: 337774 URL: http://llvm.org/viewvc/llvm-project?rev=337774=rev Log: Change sort-pbxproj.rb to find the project.pbxproj in the most likely locations. And have it overwrite the original file with the sorted output. Modified:

[Lldb-commits] [lldb] r337335 - Link the lldb driver ("lldb") against the llvm static

2018-07-17 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jul 17 16:44:09 2018 New Revision: 337335 URL: http://llvm.org/viewvc/llvm-project?rev=337335=rev Log: Link the lldb driver ("lldb") against the llvm static libraries because of the new prettystackprinter dependency. Modified:

Re: [Lldb-commits] [PATCH] D48868: [LLDB] In ProcessGDBRemote::UpdateThreadIDList(), the thread PCs should not be cleared after they are updated from the stop reply packet

2018-07-16 Thread Jason Molenda via lldb-commits
That's a good point Pavel. I tried to write one (below) but I never saw what the original failure mode was. Venkata, can you help to make a test case that fails before the patch and works after? Or explain what bug was being fixed exactly? I could see that the code was wrong from reading

[Lldb-commits] [lldb] r336956 - Remove incorrect thread-pc-values clearing

2018-07-12 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jul 12 15:45:41 2018 New Revision: 336956 URL: http://llvm.org/viewvc/llvm-project?rev=336956=rev Log: Remove incorrect thread-pc-values clearing from ProcessGDBRemote::UpdateThreadIDsFromStopReplyThreadsValue. Patch by Venkata Ramanaiah. Differential Revision:

[Lldb-commits] [lldb] r336158 - Re-sort the lldb.xcodeproj project file and commit the script

2018-07-02 Thread Jason Molenda via lldb-commits
Added: lldb/trunk/scripts/sort-pbxproj.rb URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/sort-pbxproj.rb?rev=336158=auto == --- lldb/trunk/scripts/sort-pbxproj.rb (added) +++

[Lldb-commits] [lldb] r336158 - Re-sort the lldb.xcodeproj project file and commit the script

2018-07-02 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jul 2 17:43:57 2018 New Revision: 336158 URL: http://llvm.org/viewvc/llvm-project?rev=336158=rev Log: Re-sort the lldb.xcodeproj project file and commit the script that I used to sort it to scripts/sort-pbxproj.rb. It turns out that Xcode will perturb the order of the

[Lldb-commits] [lldb] r335556 - A little cleanup in ObjectFileMachO::GetSDKVersion.

2018-06-25 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 25 16:45:39 2018 New Revision: 335556 URL: http://llvm.org/viewvc/llvm-project?rev=335556=rev Log: A little cleanup in ObjectFileMachO::GetSDKVersion. This method does one of two things: 1. finds a minimum os deployment version # in a Mach-O load command and

[Lldb-commits] [lldb] r335079 - Correct the pathname that PlatformDarwinKernel::ExamineKextForMatchingUUID

2018-06-19 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue Jun 19 14:39:10 2018 New Revision: 335079 URL: http://llvm.org/viewvc/llvm-project?rev=335079=rev Log: Correct the pathname that PlatformDarwinKernel::ExamineKextForMatchingUUID passes to the recursive search function so we only recursively search the kext bundle

[Lldb-commits] [lldb] r334995 - Some NFC changes to how we scan of kexts & kernels in memory in the

2018-06-18 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 18 16:30:03 2018 New Revision: 334995 URL: http://llvm.org/viewvc/llvm-project?rev=334995=rev Log: Some NFC changes to how we scan of kexts & kernels in memory in the DynamicLoaderDarwinKernel plugin. Created a new function ReadMachHeader and instead of reading

[Lldb-commits] [lldb] r334873 - Sort the files in the PBXBuildFile and PBXFileReference sections

2018-06-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jun 15 16:32:37 2018 New Revision: 334873 URL: http://llvm.org/viewvc/llvm-project?rev=334873=rev Log: Sort the files in the PBXBuildFile and PBXFileReference sections of debugserver's xcode project file to reduce automerger issues with the github swift repository of

[Lldb-commits] [lldb] r334872 - Sort the files in the PBXBuildFile and PBXFileReference

2018-06-15 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Jun 15 16:29:32 2018 New Revision: 334872 URL: http://llvm.org/viewvc/llvm-project?rev=334872=rev Log: Sort the files in the PBXBuildFile and PBXFileReference sections of lldb's xcode project file to reduce automerger issues with the github swift repository of lldb

[Lldb-commits] [lldb] r334783 - Change TestExec.py from creating an i386+x86_64 fat binary

2018-06-14 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu Jun 14 17:55:53 2018 New Revision: 334783 URL: http://llvm.org/viewvc/llvm-project?rev=334783=rev Log: Change TestExec.py from creating an i386+x86_64 fat binary on darwin systems and re-execing itself, to creating two separate test programs; lldb runs the first program

[Lldb-commits] [lldb] r334680 - fix cmake include path.

2018-06-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jun 13 18:29:18 2018 New Revision: 334680 URL: http://llvm.org/viewvc/llvm-project?rev=334680=rev Log: fix cmake include path. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/objcxx/CMakeLists.txt Modified:

[Lldb-commits] [lldb] r334667 - Move the header file to be in the same new place as the .mm file.

2018-06-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jun 13 15:37:01 2018 New Revision: 334667 URL: http://llvm.org/viewvc/llvm-project?rev=334667=rev Log: Move the header file to be in the same new place as the .mm file. Added:

[Lldb-commits] [lldb] r334666 - Fix group entry.

2018-06-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jun 13 15:33:27 2018 New Revision: 334666 URL: http://llvm.org/viewvc/llvm-project?rev=334666=rev Log: Fix group entry. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r334662 - Fix macos xcode build.

2018-06-13 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Wed Jun 13 15:05:38 2018 New Revision: 334662 URL: http://llvm.org/viewvc/llvm-project?rev=334662=rev Log: Fix macos xcode build. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj lldb/trunk/source/Host/macosx/objcxx/Host.mm Modified:

[Lldb-commits] [lldb] r334442 - Document how lldb uses the DBGSourcePathRemapping

2018-06-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 11 14:36:40 2018 New Revision: 334442 URL: http://llvm.org/viewvc/llvm-project?rev=334442=rev Log: Document how lldb uses the DBGSourcePathRemapping source path remapping src/dest path pairs with respect to the DBGVersion number in the plist. Modified:

[Lldb-commits] [lldb] r334441 - Add DebugNamesDWARFIndex.cpp.

2018-06-11 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Jun 11 14:35:36 2018 New Revision: 334441 URL: http://llvm.org/viewvc/llvm-project?rev=334441=rev Log: Add DebugNamesDWARFIndex.cpp. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r333690 - Set m_struct_valid to initial value in ctor.

2018-05-31 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu May 31 13:01:15 2018 New Revision: 333690 URL: http://llvm.org/viewvc/llvm-project?rev=333690=rev Log: Set m_struct_valid to initial value in ctor. Patch from Tom Tromey . Differential Revision: https://reviews.llvm.org/D47481 Modified:

[Lldb-commits] [lldb] r331497 - The on-ios-device command line lldb has an optimization where

2018-05-03 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Thu May 3 17:59:37 2018 New Revision: 331497 URL: http://llvm.org/viewvc/llvm-project?rev=331497=rev Log: The on-ios-device command line lldb has an optimization where when it and the inferior process both have the same shared cache (a conglomeration of all libraries at

Re: [Lldb-commits] [lldb] r331415 - [NSDictionary] Simplify the formatter. NFCI.

2018-05-02 Thread Jason Molenda via lldb-commits
> On May 2, 2018, at 4:58 PM, Davide Italiano <dccitali...@gmail.com> wrote: > > On Wed, May 2, 2018 at 4:56 PM, Davide Italiano <dccitali...@gmail.com> wrote: >> On Wed, May 2, 2018 at 4:51 PM, Jason Molenda via lldb-commits >> <lldb-commits@lists.llvm.or

Re: [Lldb-commits] [lldb] r331415 - [NSDictionary] Simplify the formatter. NFCI.

2018-05-02 Thread Jason Molenda via lldb-commits
Is this really simpler? We could write it if (name == g_zero) return 0; else return UINT32_MAX; or we could do it that way, or it could be done the way it was originally written. tbh it seems like a style choice, and whoever wrote it originally may have preferred it being expressed that

[Lldb-commits] [lldb] r331315 - Fix the .experimental. settings feature so that we don't return an error

2018-05-01 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Tue May 1 15:49:01 2018 New Revision: 331315 URL: http://llvm.org/viewvc/llvm-project?rev=331315=rev Log: Fix the .experimental. settings feature so that we don't return an error if an experimental setting has been removed/is missing. Add tests for the .experimental.

[Lldb-commits] [lldb] r331239 - Log to the process channel, not target twice.

2018-04-30 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Apr 30 17:42:17 2018 New Revision: 331239 URL: http://llvm.org/viewvc/llvm-project?rev=331239=rev Log: Log to the process channel, not target twice. Modified: lldb/trunk/source/Utility/ArchSpec.cpp Modified: lldb/trunk/source/Utility/ArchSpec.cpp URL:

Re: [Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

2018-04-30 Thread Jason Molenda via lldb-commits
> On Apr 30, 2018, at 5:23 PM, Davide Italiano <dccitali...@gmail.com> wrote: > > On Mon, Apr 30, 2018 at 5:05 PM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> >> fAnyCategoriesSet(LIBLLDB_LOG_TARGET | LIBLLDB_LOG_TARGET | >

[Lldb-commits] [lldb] r331236 - Add logging when ArchSpec::SetArchitecture is given a cputype and

2018-04-30 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Apr 30 17:05:54 2018 New Revision: 331236 URL: http://llvm.org/viewvc/llvm-project?rev=331236=rev Log: Add logging when ArchSpec::SetArchitecture is given a cputype and cpusubtype that don't map to any known core definition. Modified:

Re: [Lldb-commits] [PATCH] D45348: Don't return error for settings set .experimental. settings that are absent

2018-04-06 Thread Jason Molenda via lldb-commits
> On Apr 6, 2018, at 2:07 AM, Pavel Labath via Phabricator > wrote: > > labath added inline comments. > > > > Comment at: packages/Python/lldbsuite/test/settings/TestSettings.py:544-545 > +# the actual name and via .experimental. > +

[Lldb-commits] [lldb] r328591 - Add the same new entitlement from r326399 to

2018-03-26 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Mon Mar 26 16:13:17 2018 New Revision: 328591 URL: http://llvm.org/viewvc/llvm-project?rev=328591=rev Log: Add the same new entitlement from r326399 to the macos entitlement list. Modified: lldb/trunk/tools/debugserver/source/debugserver-macosx-entitlements.plist

[Lldb-commits] [lldb] r328383 - Remove CommandObjectStats.cpp & CleanUpTest.cpp from

2018-03-23 Thread Jason Molenda via lldb-commits
Author: jmolenda Date: Fri Mar 23 16:32:16 2018 New Revision: 328383 URL: http://llvm.org/viewvc/llvm-project?rev=328383=rev Log: Remove CommandObjectStats.cpp & CleanUpTest.cpp from installing in the man page directory. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

<    3   4   5   6   7   8   9   10   11   12   >