[Lldb-commits] [lldb] r258289 - Some 32-bit arm corefiles on darwin may have their general purpose

Author: jmolenda Date: Tue Jan 19 23:17:13 2016 New Revision: 258289 URL: http://llvm.org/viewvc/llvm-project?rev=258289=rev Log: Some 32-bit arm corefiles on darwin may have their general purpose register set indicated by ARM_THREAD_STATE32 (value 9) instead of the old ARM_THREAD_STATE (value

[Lldb-commits] [lldb] r260930 - Add -Wimplicit-fallthrough command line option to clang in

Author: jmolenda Date: Mon Feb 15 22:14:33 2016 New Revision: 260930 URL: http://llvm.org/viewvc/llvm-project?rev=260930=rev Log: Add -Wimplicit-fallthrough command line option to clang in the xcode project file to catch switch statements that have a case that falls through unintentionally.

[Lldb-commits] [lldb] r260932 - Fix buildbot failure because I got an include path wrong.

Author: jmolenda Date: Mon Feb 15 22:20:56 2016 New Revision: 260932 URL: http://llvm.org/viewvc/llvm-project?rev=260932=rev Log: Fix buildbot failure because I got an include path wrong. Modified: lldb/trunk/source/Commands/CommandObjectMemory.cpp Modified:

[Lldb-commits] [lldb] r261280 - This patch stops lldb from loading a .lldbinit file from the current

Author: jmolenda Date: Thu Feb 18 18:05:17 2016 New Revision: 261280 URL: http://llvm.org/viewvc/llvm-project?rev=261280=rev Log: This patch stops lldb from loading a .lldbinit file from the current working directory by default -- a typical security problem that we need to be more conservative

[Lldb-commits] [PATCH] D17750: arm ios doesn't have elf.h, sys/procfs.h, need to avoid including them on apple systems

jasonmolenda created this revision. jasonmolenda added reviewers: tberghammer, omjavaid. jasonmolenda added a subscriber: lldb-commits. jasonmolenda set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. I'm getting lldb to build for ios again and had build

Re: [Lldb-commits] [PATCH] D17750: arm ios doesn't have elf.h, sys/procfs.h, need to avoid including them on apple systems

jasonmolenda added a comment. Good point. Let me play with the xcode project file (which I was using to do the build) tomorrow; your solution may be the correct one, we might have some files being built unnecessarily. Repository: rL LLVM http://reviews.llvm.org/D17750

[Lldb-commits] [lldb] r263529 - Bump the lldb version # in the xcode project files from

Author: jmolenda Date: Mon Mar 14 23:36:11 2016 New Revision: 263529 URL: http://llvm.org/viewvc/llvm-project?rev=263529=rev Log: Bump the lldb version # in the xcode project files from 350.99.0 to 360.99.0. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r265732 - In GDBRemoteCommunicationClient::GetHostInfo, don't set the

Author: jmolenda Date: Thu Apr 7 17:00:55 2016 New Revision: 265732 URL: http://llvm.org/viewvc/llvm-project?rev=265732=rev Log: In GDBRemoteCommunicationClient::GetHostInfo, don't set the os to "ios" or "macosx" if it is unspecified. For environments where there genuinely is no os, we don't

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

jasonmolenda added a comment. Thanks for doing this work Ulrich, the assumption that SP==CFA was mine, I should have put this in the ABI from the start. I worry a little about the change to RegisterContextLLDB::SavedLocationForRegister() where you've moved the ABI is-volatile check into

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

jasonmolenda added a comment. Just to be clear, my concern is we get an register location which is "undefined" (I've never seen it, I don't know what it means) and now SavedLocationForRegister() will say "this register is volatile, not looking any further" when it used to say "register not

[Lldb-commits] [lldb] r266165 - Update Symtab::InitAddressIndexes so that computed symbol sizes

Author: jmolenda Date: Tue Apr 12 23:32:49 2016 New Revision: 266165 URL: http://llvm.org/viewvc/llvm-project?rev=266165=rev Log: Update Symtab::InitAddressIndexes so that computed symbol sizes will not exceed the bounds of their Section. This is addressing a problem where a file had a large

[Lldb-commits] [PATCH] D19004: Use the section sizes to determine symbols sizes in the Symtab instead of just using the following symbol's address

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. jasonmolenda added a subscriber: lldb-commits. jasonmolenda set the repository for this revision to rL LLVM. The Symtab has an array of symbol file addresses and sizes for address-to-symbol lookups, created in

Re: [Lldb-commits] [PATCH] D18807: Add missing qRegisterInfo option to gdbremote testcase

jasonmolenda added a comment. Yes, good idea to add that. ProcessGDBRemote will need to accept "gcc" for at least a few years while old debugservers etc are floating around. http://reviews.llvm.org/D18807 ___ lldb-commits mailing list

[Lldb-commits] [lldb] r264353 - Update the INFOPLIST_FILE setting in the xcode project file

Author: jmolenda Date: Thu Mar 24 17:27:52 2016 New Revision: 264353 URL: http://llvm.org/viewvc/llvm-project?rev=264353=rev Log: Update the INFOPLIST_FILE setting in the xcode project file so that the lldb command line binary's version #'s are updated correctly. Modified:

[Lldb-commits] [lldb] r264380 - Add the same host logging that I added to PlatformRemoteiOS a few

Author: jmolenda Date: Thu Mar 24 21:17:27 2016 New Revision: 264380 URL: http://llvm.org/viewvc/llvm-project?rev=264380=rev Log: Add the same host logging that I added to PlatformRemoteiOS a few months back to PlatformRemoteAppleTV and PlatformRemoteAppleWatch to help understand what's happening

Re: [Lldb-commits] [lldb] r264379 - Use Clang's FixItHints to correct expressions with "trivial" mistakes (e.g. "." for "->".)

The specific example Jim gave (./->) is a very common complaint of people coming from gdb. gdb's hand-rolled parser would realize that when you -> on an object, that doesn't make sense and silently correct it to . for you. In practice, when you're examining local variables, you often don't

[Lldb-commits] [lldb] r262904 - Unbreak linux build broken by r262901

Author: jmolenda Date: Mon Mar 7 21:24:13 2016 New Revision: 262904 URL: http://llvm.org/viewvc/llvm-project?rev=262904=rev Log: Unbreak linux build broken by r262901 Modified: lldb/trunk/source/Interpreter/CommandInterpreter.cpp Modified:

[Lldb-commits] [lldb] r262543 - Add SymbolFilePDB to xcode project file to keep it

Author: jmolenda Date: Wed Mar 2 17:39:59 2016 New Revision: 262543 URL: http://llvm.org/viewvc/llvm-project?rev=262543=rev Log: Add SymbolFilePDB to xcode project file to keep it up to date after 4262528. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r262566 - Don't build source/Plugins/Process/Linux in the Xcode project file.

Author: jmolenda Date: Wed Mar 2 18:21:32 2016 New Revision: 262566 URL: http://llvm.org/viewvc/llvm-project?rev=262566=rev Log: Don't build source/Plugins/Process/Linux in the Xcode project file. These files won't build for ios etc arm builds of lldb and aren't used for macosx native lldb's.

[Lldb-commits] [lldb] r262816 - Move SBLanguageRuntime.cpp from the lldb-core group to the LLDB

Author: jmolenda Date: Mon Mar 7 02:04:49 2016 New Revision: 262816 URL: http://llvm.org/viewvc/llvm-project?rev=262816=rev Log: Move SBLanguageRuntime.cpp from the lldb-core group to the LLDB group to fix a build time issue. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r265377 - Consolidate the knowledge of what arm cores are always executing

Author: jmolenda Date: Tue Apr 5 00:01:30 2016 New Revision: 265377 URL: http://llvm.org/viewvc/llvm-project?rev=265377=rev Log: Consolidate the knowledge of what arm cores are always executing in thumb mode into one method in ArchSpec, replace checks for specific cores in the disassembler with

Re: [Lldb-commits] [PATCH] D19545: Use ClangASTContext for compilation units with DW_LANG_RUST

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Looks good to me. Should I commit this for you, or do you have/want to set up commit access? Repository: rL LLVM http://reviews.llvm.org/D19545

Re: [Lldb-commits] [PATCH] D19545: Use ClangASTContext for compilation units with DW_LANG_RUST

jasonmolenda closed this revision. jasonmolenda added a comment. Committed in r267667. Repository: rL LLVM http://reviews.llvm.org/D19545 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D19604: Allow ObjectFilePECOFF to initialize with ARM binaries.

jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. fwiw, there are ARM cores that only support thumb - the Cortex M series. I doubt a windows phone is running one of those low-power chips though. The importance of the triple used will come in to play when you try to

[Lldb-commits] [lldb] r268475 - Add a way for an ObjectFile to indicate that assembly emulation

Author: jmolenda Date: Tue May 3 22:09:40 2016 New Revision: 268475 URL: http://llvm.org/viewvc/llvm-project?rev=268475=rev Log: Add a way for an ObjectFile to indicate that assembly emulation should not be used for this module -- for use when an ObjectFile knows that it does not have meaningful

Re: [Lldb-commits] [PATCH] D20041: File path comparisons should be case-insensitive on OS X

jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. I don't know if this is a safe change. Mac OS X filesystems like HFS Plus may be case-insensitive (but case preserving) or they may be case sensitive. Network filesystems mounted on a Mac may be case sensitive.

Re: [Lldb-commits] [PATCH] D19305: Use Process Plugin register indices when communicating with remote

jasonmolenda added a comment. This looks good to me. Do you think the ReadRegister decl in GDBRemoteCommunicationClient.h should have a comment noting that the reg_num is a number in the remote register numbering scheme (eRegisterKindProcessPlugin)? When lldb passes around register numbers

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

jasonmolenda added a subscriber: jasonmolenda. jasonmolenda added a comment. These look like good changes to me, especially the SBThread fix - I'm surprised that hasn't caused a problem. The DynamicLoader change should be unnecessary but I don't have a problem with that. Tamas might want to

Re: [Lldb-commits] [PATCH] D18977: Add new ABI callback to provide fallback unwind register locations

jasonmolenda accepted this revision. jasonmolenda added a comment. Hi Tamas & Ulrich. I'm good with this patch, thanks for double checking that detail for me. http://reviews.llvm.org/D18977 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D19004: Use the section sizes to determine symbols sizes in the Symtab instead of just using the following symbol's address

jasonmolenda closed this revision. jasonmolenda added a comment. Committed in r266165. Repository: rL LLVM http://reviews.llvm.org/D19004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r270620 - Ach, editing too many files at once. Make this file compile again.

Author: jmolenda Date: Tue May 24 17:05:22 2016 New Revision: 270620 URL: http://llvm.org/viewvc/llvm-project?rev=270620=rev Log: Ach, editing too many files at once. Make this file compile again. Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Modified:

[Lldb-commits] [lldb] r270618 - In r268475 I made a change to ObjectFileMachO so that if it is

Author: jmolenda Date: Tue May 24 16:46:23 2016 New Revision: 270618 URL: http://llvm.org/viewvc/llvm-project?rev=270618=rev Log: In r268475 I made a change to ObjectFileMachO so that if it is missing an LC_FUNCTION_STARTS section, we assume it has been aggressively stripped (it is *very* unusual

[Lldb-commits] [lldb] r276721 - DynamicLoaderDarwinKernel will look in four addresses for the kernel

Author: jmolenda Date: Mon Jul 25 22:10:15 2016 New Revision: 276721 URL: http://llvm.org/viewvc/llvm-project?rev=276721=rev Log: DynamicLoaderDarwinKernel will look in four addresses for the kernel load address on 64-bit devices; it only needs to look in three. Modified:

[Lldb-commits] [lldb] r276729 - Add support for an additional dictionary in the per-arch plists

Author: jmolenda Date: Tue Jul 26 01:33:07 2016 New Revision: 276729 URL: http://llvm.org/viewvc/llvm-project?rev=276729=rev Log: Add support for an additional dictionary in the per-arch plists that may be embedded in the Contents/Resources subdir of a dSYM bundle. These allow for the

[Lldb-commits] [lldb] r276485 - Remove some tab characters that snuck in to my mnost recent edits.

Author: jmolenda Date: Fri Jul 22 17:26:26 2016 New Revision: 276485 URL: http://llvm.org/viewvc/llvm-project?rev=276485=rev Log: Remove some tab characters that snuck in to my mnost recent edits. Modified: lldb/trunk/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderDarwin.cpp

[Lldb-commits] [lldb] r276369 - Add support to get the shared cache information from the new

Author: jmolenda Date: Thu Jul 21 19:17:55 2016 New Revision: 276369 URL: http://llvm.org/viewvc/llvm-project?rev=276369=rev Log: Add support to get the shared cache information from the new debugserver jGetSharedCacheInfo packet instead of reading the dyld internal data structures directly.

[Lldb-commits] [lldb] r277065 - Small refinement on the memory segment support in core files that

Author: jmolenda Date: Thu Jul 28 17:43:10 2016 New Revision: 277065 URL: http://llvm.org/viewvc/llvm-project?rev=277065=rev Log: Small refinement on the memory segment support in core files that Greg added in r272276 -- when working with a non-user-process mach-o core file, force the permissions

[Lldb-commits] [lldb] r277123 - PlatformDarwinKernel maintains a list of kexts and kernels

Author: jmolenda Date: Fri Jul 29 01:24:03 2016 New Revision: 277123 URL: http://llvm.org/viewvc/llvm-project?rev=277123=rev Log: PlatformDarwinKernel maintains a list of kexts and kernels that it finds on the local computer in "well known" locations when we start up the darwin-kernel platform.

[Lldb-commits] [lldb] r276954 - Add some logging to the kernel dynamicloader plugin when we fail to read

Author: jmolenda Date: Wed Jul 27 23:18:44 2016 New Revision: 276954 URL: http://llvm.org/viewvc/llvm-project?rev=276954=rev Log: Add some logging to the kernel dynamicloader plugin when we fail to read a kext binary from memory. Modified:

Re: [Lldb-commits] [PATCH] D22266: Add "support" for DW_CFA_GNU_args_size to the unwinder

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This is fine - is there a binary using this? I'd love to see the assembly code and a dump of the eh_frame CFI. I googled around and didn't find much about DW_CFA_GNU_args_size

[Lldb-commits] [lldb] r276254 - Add a new DynamicLoader plugin that uses SPI that are in development

Author: jmolenda Date: Thu Jul 21 03:30:55 2016 New Revision: 276254 URL: http://llvm.org/viewvc/llvm-project?rev=276254=rev Log: Add a new DynamicLoader plugin that uses SPI that are in development for the fall (northern hemisphere) 2016 Darwin platforms to learn about loaded images, instead of

[Lldb-commits] [lldb] r275731 - Initialize the "is_loaded" local in LoadModuleAtAddress in

Author: jmolenda Date: Sun Jul 17 15:01:54 2016 New Revision: 275731 URL: http://llvm.org/viewvc/llvm-project?rev=275731=rev Log: Initialize the "is_loaded" local in LoadModuleAtAddress in case Process::GetFileLoadAddress fails to set it to a real value. (fixing "conditional use of garbage

[Lldb-commits] [lldb] r275729 - Add missing break stmt to DW_CFA_GNU_args_size case.

Author: jmolenda Date: Sun Jul 17 14:57:49 2016 New Revision: 275729 URL: http://llvm.org/viewvc/llvm-project?rev=275729=rev Log: Add missing break stmt to DW_CFA_GNU_args_size case. Modified: lldb/trunk/source/Symbol/DWARFCallFrameInfo.cpp Modified:

[Lldb-commits] [lldb] r275944 - Ignore clang-module-cache directories that may be created

Author: jmolenda Date: Mon Jul 18 21:37:07 2016 New Revision: 275944 URL: http://llvm.org/viewvc/llvm-project?rev=275944=rev Log: Ignore clang-module-cache directories that may be created in the testsuite directory while it runs. Modified: lldb/trunk/.gitignore Modified:

[Lldb-commits] [lldb] r276079 - Add a default-value bool flag pretty_print to the StructuredData Dump methods.

Author: jmolenda Date: Tue Jul 19 22:49:02 2016 New Revision: 276079 URL: http://llvm.org/viewvc/llvm-project?rev=276079=rev Log: Add a default-value bool flag pretty_print to the StructuredData Dump methods. They will dump pretty-print (indentation, extra whitepsace) by default. I'll make a

[Lldb-commits] [lldb] r275151 - Add some safety checks to Platform::GetRemoteSharedModule so if it

Author: jmolenda Date: Mon Jul 11 22:25:22 2016 New Revision: 275151 URL: http://llvm.org/viewvc/llvm-project?rev=275151=rev Log: Add some safety checks to Platform::GetRemoteSharedModule so if it is passed a ModuleSpec with a UUID, it won't accept a file it finds with a matching FileSpec &

[Lldb-commits] [lldb] r274718 - Add support to debugserver for some new ways to interact with dyld

Author: jmolenda Date: Wed Jul 6 20:09:23 2016 New Revision: 274718 URL: http://llvm.org/viewvc/llvm-project?rev=274718=rev Log: Add support to debugserver for some new ways to interact with dyld to find the solibs loaded in a process. Support two new ways of sending the

[Lldb-commits] [lldb] r274700 - Enhance FuncUnwinders::GetUnwindPlanAtNonCallSite to detect when we

Author: jmolenda Date: Wed Jul 6 18:06:19 2016 New Revision: 274700 URL: http://llvm.org/viewvc/llvm-project?rev=274700=rev Log: Enhance FuncUnwinders::GetUnwindPlanAtNonCallSite to detect when we may be in a function that is non-ABI conformant, and the eh_frame instructions correctly describe

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Ravitheja and I had some discussions over email about a possible alternate approach to this issue - I've committed that approach as r274700 after testing help from Ravi. This

[Lldb-commits] [lldb] r274725 - debugserver will now report the minimum version load command

Author: jmolenda Date: Wed Jul 6 22:12:01 2016 New Revision: 274725 URL: http://llvm.org/viewvc/llvm-project?rev=274725=rev Log: debugserver will now report the minimum version load command os name and version # from the mach-o binary as it scans the header/load commands from memory and sends

[Lldb-commits] [lldb] r277789 - Change the indexing done for kernel/kext directories to be recursive.

Author: jmolenda Date: Thu Aug 4 19:44:34 2016 New Revision: 277789 URL: http://llvm.org/viewvc/llvm-project?rev=277789=rev Log: Change the indexing done for kernel/kext directories to be recursive. Also re-write how most of the directory indexing is done - as it has grown over the years, it

[Lldb-commits] [lldb] r276351 - Stop printing double { characters on Dictionary StructuredData objects

Author: jmolenda Date: Thu Jul 21 17:50:01 2016 New Revision: 276351 URL: http://llvm.org/viewvc/llvm-project?rev=276351=rev Log: Stop printing double { characters on Dictionary StructuredData objects when Dumping, thanks to Devin to catching the edit mistake I made in r276079. Modified:

[Lldb-commits] [lldb] r278901 - Fix the RangeMapVector::FindEntryThatContainsOrFollows method to

Author: jmolenda Date: Tue Aug 16 22:56:04 2016 New Revision: 278901 URL: http://llvm.org/viewvc/llvm-project?rev=278901=rev Log: Fix the RangeMapVector::FindEntryThatContainsOrFollows method to back up the iterator, as long as it still contains the address. std::lower_bound will point us to the

Re: [Lldb-commits] [PATCH] D29427: Move some classes from Core -> Utility

You need some break;s. -const char *lldb_private::GetVoteAsCString(Vote vote) { - switch (vote) { - case eVoteNo: -return "no"; - case eVoteNoOpinion: -return "no opinion"; - case eVoteYes: -return "yes"; - } - return "invalid"; -} +template <> struct format_provider { +

[Lldb-commits] [lldb] r293858 - Add logging to SBThread::GetInfoItemByPathAsString to

Author: jmolenda Date: Wed Feb 1 21:02:51 2017 New Revision: 293858 URL: http://llvm.org/viewvc/llvm-project?rev=293858=rev Log: Add logging to SBThread::GetInfoItemByPathAsString to print the path being requested. Change the GetInfoItemByPathAsString docuemtnation in the .i file to use

[Lldb-commits] [lldb] r293742 - When I added the use of the new compression framework (present in

Author: jmolenda Date: Tue Jan 31 22:23:15 2017 New Revision: 293742 URL: http://llvm.org/viewvc/llvm-project?rev=293742=rev Log: When I added the use of the new compression framework (present in Mac OS X 10.11, El Capitan, released c. Oct 2015) I conditionalized the use of the framework on "if

[Lldb-commits] [lldb] r292880 - weak-link debugserver against the LoggingSupport framework;

Author: jmolenda Date: Mon Jan 23 22:16:03 2017 New Revision: 292880 URL: http://llvm.org/viewvc/llvm-project?rev=292880=rev Log: weak-link debugserver against the LoggingSupport framework; systems without this framework will not get a link error. Modified:

[Lldb-commits] [lldb] r292890 - Fix the last commit; compression was being enabled on mac native

Author: jmolenda Date: Tue Jan 24 00:09:06 2017 New Revision: 292890 URL: http://llvm.org/viewvc/llvm-project?rev=292890=rev Log: Fix the last commit; compression was being enabled on mac native which led to ERROR: test_auxv_chunked_reads_work_debugserver

[Lldb-commits] [lldb] r292882 - Enable compression capability in debugserver for all of ios/watchos/tvos

Author: jmolenda Date: Mon Jan 23 22:43:40 2017 New Revision: 292882 URL: http://llvm.org/viewvc/llvm-project?rev=292882=rev Log: Enable compression capability in debugserver for all of ios/watchos/tvos environments. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified:

[Lldb-commits] [lldb] r292884 - Prefer lzfse if it is an available compression method (this was

Author: jmolenda Date: Mon Jan 23 23:06:14 2017 New Revision: 292884 URL: http://llvm.org/viewvc/llvm-project?rev=292884=rev Log: Prefer lzfse if it is an available compression method (this was defaulting to zlib previously). Modified:

[Lldb-commits] [lldb] r293366 - One of the changes Jim made in r286288 (cleaning up the stop print

Author: jmolenda Date: Fri Jan 27 20:54:10 2017 New Revision: 293366 URL: http://llvm.org/viewvc/llvm-project?rev=293366=rev Log: One of the changes Jim made in r286288 (cleaning up the stop print header line, backtrace output) was to remove the current pc value from frames where we have source

[Lldb-commits] [lldb] r293135 - Instead of weak-linking against LoggingSupport framework (which

Author: jmolenda Date: Wed Jan 25 20:13:43 2017 New Revision: 293135 URL: http://llvm.org/viewvc/llvm-project?rev=293135=rev Log: Instead of weak-linking against LoggingSupport framework (which requires that this private framework be available - and it is not available earlier than macOS 10.12 -

[Lldb-commits] [lldb] r293140 - Add Foundation to the debugserver-mini dependencies;

Author: jmolenda Date: Wed Jan 25 20:27:35 2017 New Revision: 293140 URL: http://llvm.org/viewvc/llvm-project?rev=293140=rev Log: Add Foundation to the debugserver-mini dependencies; debugserver-mini can use Foundation. Modified:

[Lldb-commits] [lldb] r292696 - Add a catch-all line for detecting dyld in the inferior process

Author: jmolenda Date: Fri Jan 20 19:17:36 2017 New Revision: 292696 URL: http://llvm.org/viewvc/llvm-project?rev=292696=rev Log: Add a catch-all line for detecting dyld in the inferior process shlibs so we don't miss dyld. Modified:

[Lldb-commits] [lldb] r293002 - Jim unintentionally had the gdb-format specifiers falling through

Author: jmolenda Date: Tue Jan 24 19:41:48 2017 New Revision: 293002 URL: http://llvm.org/viewvc/llvm-project?rev=293002=rev Log: Jim unintentionally had the gdb-format specifiers falling through after r276132 so that 'x/4b' would print out a series of 4 8-byte quantities. Fix that, add a test

[Lldb-commits] [lldb] r295804 - Mark TestDarwinLogBasic.py as an xfail because the logging is

Author: jmolenda Date: Tue Feb 21 20:10:00 2017 New Revision: 295804 URL: http://llvm.org/viewvc/llvm-project?rev=295804=rev Log: Mark TestDarwinLogBasic.py as an xfail because the logging is not being picked up; filed to track the work to investigate this. Modified:

[Lldb-commits] [lldb] r295530 - Update the location of ModuleCacheTest.cpp from

Author: jmolenda Date: Fri Feb 17 19:51:11 2017 New Revision: 295530 URL: http://llvm.org/viewvc/llvm-project?rev=295530=rev Log: Update the location of ModuleCacheTest.cpp from unittest/Utility to unittest/Target so the unit tests can be run from xcode again. The diff is enormous - I think

[Lldb-commits] [lldb] r296084 - Fix a race condition in FuncUnwinders where the mutex was being

Author: jmolenda Date: Thu Feb 23 21:35:46 2017 New Revision: 296084 URL: http://llvm.org/viewvc/llvm-project?rev=296084=rev Log: Fix a race condition in FuncUnwinders where the mutex was being acquired only after checking if the ivar shared pointer was already filled in. But when I assign an

[Lldb-commits] [lldb] r296243 - Three LoadLibCxxFormatters formatters were given a regex string to

Author: jmolenda Date: Fri Feb 24 23:43:51 2017 New Revision: 296243 URL: http://llvm.org/viewvc/llvm-project?rev=296243=rev Log: Three LoadLibCxxFormatters formatters were given a regex string to match but the 'is_regex' argument was not passed as true. Not sure this is causing a bug, but

[Lldb-commits] [lldb] r296238 - DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build.

Author: jmolenda Date: Fri Feb 24 22:06:09 2017 New Revision: 296238 URL: http://llvm.org/viewvc/llvm-project?rev=296238=rev Log: DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r295694 - Fix spelling mistake.

Author: jmolenda Date: Mon Feb 20 23:09:26 2017 New Revision: 295694 URL: http://llvm.org/viewvc/llvm-project?rev=295694=rev Log: Fix spelling mistake. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [lldb] r295025 - Before returning a pc value for a stack frame,

Author: jmolenda Date: Mon Feb 13 22:55:03 2017 New Revision: 295025 URL: http://llvm.org/viewvc/llvm-project?rev=295025=rev Log: Before returning a pc value for a stack frame, run it through the ABI's FixCodeAddress method. Modified:

[Lldb-commits] [lldb] r295271 - Fix a bug introduced in r235737 where code with important side

Author: jmolenda Date: Wed Feb 15 20:08:33 2017 New Revision: 295271 URL: http://llvm.org/viewvc/llvm-project?rev=295271=rev Log: Fix a bug introduced in r235737 where code with important side effects was passed as an expression to assert() calls. If lldb is built without asserts, the expression

[Lldb-commits] [lldb] r292454 - Fix a problem with the new dyld interface code -- when a new process

Author: jmolenda Date: Wed Jan 18 18:20:29 2017 New Revision: 292454 URL: http://llvm.org/viewvc/llvm-project?rev=292454=rev Log: Fix a problem with the new dyld interface code -- when a new process starts up, we need to clear the target's image list and only add the binaries into the target that

[Lldb-commits] [lldb] r296531 - Add additional areas I'm responsible for in the lldb codebase.

Author: jmolenda Date: Tue Feb 28 16:31:18 2017 New Revision: 296531 URL: http://llvm.org/viewvc/llvm-project?rev=296531=rev Log: Add additional areas I'm responsible for in the lldb codebase. Modified: lldb/trunk/CODE_OWNERS.txt Modified: lldb/trunk/CODE_OWNERS.txt URL:

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

Writing SB API tests for the disassembler is easy, as Jim notes there is an SBFrame::Disassemble() method that maps directly on to this call. I've written unit tests that create a disassembler -- I do it for the unwind tests. It's easy when you have an array of bytes to feed directly into the

[Lldb-commits] [lldb] r296548 - Greg Clayton is no longer working at Apple, he will continue to

Author: jmolenda Date: Tue Feb 28 18:00:45 2017 New Revision: 296548 URL: http://llvm.org/viewvc/llvm-project?rev=296548=rev Log: Greg Clayton is no longer working at Apple, he will continue to review patches etc from his clayborg email address. Modified: lldb/trunk/CODE_OWNERS.txt

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

It makes me uncomfortable to have these whole-project-ranging change sets going into the source, one example being const char * -> StringRef) for such small benefit. Yes there were a few methods where we were doing string parsing and tokenizing which became much smaller and easier to

[Lldb-commits] [lldb] r296733 - x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite could access

Author: jmolenda Date: Wed Mar 1 23:08:10 2017 New Revision: 296733 URL: http://llvm.org/viewvc/llvm-project?rev=296733=rev Log: x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite could access the byte past the end of the buffer it had been given. ASAN catch. Modified:

[Lldb-commits] [lldb] r296412 - Ah, this was an early exit to leave built products around, it wasn't meant to

Author: jmolenda Date: Mon Feb 27 17:31:29 2017 New Revision: 296412 URL: http://llvm.org/viewvc/llvm-project?rev=296412=rev Log: Ah, this was an early exit to leave built products around, it wasn't meant to be checked in. Modified:

[Lldb-commits] [lldb] r279688 - Rewrite the GetFileInSDK methods in PlatformRemoteiOS,

Author: jmolenda Date: Wed Aug 24 18:46:48 2016 New Revision: 279688 URL: http://llvm.org/viewvc/llvm-project?rev=279688=rev Log: Rewrite the GetFileInSDK methods in PlatformRemoteiOS, PlatformRemoteAppleWatch, PlatformRemoteAppleTV and remove the GetFileInSDKRoot method from those classes. The

[Lldb-commits] [lldb] r279704 - If the user has specified target.memory-module-load-level 'minimal'

Author: jmolenda Date: Wed Aug 24 21:33:09 2016 New Revision: 279704 URL: http://llvm.org/viewvc/llvm-project?rev=279704=rev Log: If the user has specified target.memory-module-load-level 'minimal' and we couldn't find a dyld binary on the debug system, override that setting and read dyld out of

[Lldb-commits] [lldb] r280906 - I'm experimenting with changing how the mixed source & assembly

Author: jmolenda Date: Thu Sep 8 00:12:41 2016 New Revision: 280906 URL: http://llvm.org/viewvc/llvm-project?rev=280906=rev Log: I'm experimenting with changing how the mixed source & assembly mode in lldb works. I've been discussing this with Jim Ingham, Greg Clayton, and Kate Stone for the

[Lldb-commits] [lldb] r280879 - Remove CxaDemangle.cpp / .h from xcode project file.

Author: jmolenda Date: Wed Sep 7 18:08:36 2016 New Revision: 280879 URL: http://llvm.org/viewvc/llvm-project?rev=280879=rev Log: Remove CxaDemangle.cpp / .h from xcode project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r280902 - Force the initialization of the m_type ivar in

Author: jmolenda Date: Wed Sep 7 21:26:58 2016 New Revision: 280902 URL: http://llvm.org/viewvc/llvm-project?rev=280902=rev Log: Force the initialization of the m_type ivar in Function::GetStartLineSourceInfo before we try to return the start line information about a function; this function

[Lldb-commits] [lldb] r280903 - I had a problem with one SDK where dispatch_release was actually a

Author: jmolenda Date: Wed Sep 7 21:29:40 2016 New Revision: 280903 URL: http://llvm.org/viewvc/llvm-project?rev=280903=rev Log: I had a problem with one SDK where dispatch_release was actually a macro, so writing ::dispatch_release did not work as expected. Remove the global anon namespace ::

[Lldb-commits] [lldb] r280039 - Update debugserver project to pull in StdStringExtractor.cpp instead of the new

Author: jmolenda Date: Mon Aug 29 19:58:23 2016 New Revision: 280039 URL: http://llvm.org/viewvc/llvm-project?rev=280039=rev Log: Update debugserver project to pull in StdStringExtractor.cpp instead of the new llvm-using StringExtractor.cpp in the xcode project file settings. Modified:

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

I have to concur with Jim's point -- writing & maintaining the gdb testsuite for years, which was based on commands & expected output like these lit tests, was a huge drag on everyone's productivity as the debugger changed over time. This style of test looks wonderfully easy to read & write &

[Lldb-commits] [lldb] r281418 - TestQueues could error out because the one second sleep main.c was

Author: jmolenda Date: Tue Sep 13 18:29:46 2016 New Revision: 281418 URL: http://llvm.org/viewvc/llvm-project?rev=281418=rev Log: TestQueues could error out because the one second sleep main.c was using to enqueue all the jobs wasn't enough time on a slow/overloaded system. Instead use a global

[Lldb-commits] [lldb] r281291 - Reduce the number of simultaneous debug sessions to 10 and remove

Author: jmolenda Date: Mon Sep 12 21:45:45 2016 New Revision: 281291 URL: http://llvm.org/viewvc/llvm-project?rev=281291=rev Log: Reduce the number of simultaneous debug sessions to 10 and remove the expectedFlakeyDarwin annotation. I've been running this test in isolation on my macOS Sierra

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

> On Sep 15, 2016, at 8:02 AM, Zachary Turner wrote: > > > It sounds like your goal is also "tests have to use the SB API and no other > API", which if so I think that's counterproductive. More productive, IMO, > would be being open to any alternative that addresses the

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20099 > > Dimitar > > > On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > Good suggestions, thanks. I'll fix those when I commit the 32-bit v

[Lldb-commits] [lldb] r282790 - Add a quick note about how to build lldb with debug info using

Author: jmolenda Date: Thu Sep 29 16:47:15 2016 New Revision: 282790 URL: http://llvm.org/viewvc/llvm-project?rev=282790=rev Log: Add a quick note about how to build lldb with debug info using cmake/ninja on linux/bsd systems. Modified: lldb/trunk/www/build.html Modified:

[Lldb-commits] [lldb] r283404 - Add i386/x86_64 tests of the eh_frame augmentation code in the x86

Author: jmolenda Date: Wed Oct 5 17:37:01 2016 New Revision: 283404 URL: http://llvm.org/viewvc/llvm-project?rev=283404=rev Log: Add i386/x86_64 tests of the eh_frame augmentation code in the x86 insturction profiling. Add a test that verifies that we reject a 32-bit only instruction in 64-bit

[Lldb-commits] [lldb] r283295 - Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec

Author: jmolenda Date: Tue Oct 4 21:29:13 2016 New Revision: 283295 URL: http://llvm.org/viewvc/llvm-project?rev=283295=rev Log: Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec which specifies a file path and UUID but not an architecture, open the file at that path and try

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

On Sep 14, 2016, at 5:13 PM, Zachary Turner wrote: > I don't blame you for being scared of command tests. I don't support their > use in the current LLDB test suite either, for exactly the same reasons you > and Jason have expressed. But I do think it's possible to come

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

If we want to add a testsuite runner which takes a source file, a place to put a breakpoint, the name of a variable to examine, and it runs through those in SB API, I'm all in favor. I don't know if that's going to add a lot of test coverage to lldb, but I have no problem with such a thing.

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

I thought about this more overnight and I'm more convinced that lit and lldb-mi make a great pair. lldb-mi is a programmatic text format that isn't subject to the whims of command-line UI design over the years; well tests written in terms of MI will be resilient and stable. lldb-mi MUCH more

[Lldb-commits] [lldb] r279611 - Add api logging for SBDebugger::SetCurrentPlatformSDKRoot.

Author: jmolenda Date: Wed Aug 24 00:25:32 2016 New Revision: 279611 URL: http://llvm.org/viewvc/llvm-project?rev=279611=rev Log: Add api logging for SBDebugger::SetCurrentPlatformSDKRoot. Modified: lldb/trunk/source/API/SBDebugger.cpp Modified: lldb/trunk/source/API/SBDebugger.cpp URL:

[Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

Author: jmolenda Date: Wed Sep 28 23:01:43 2016 New Revision: 282683 URL: http://llvm.org/viewvc/llvm-project?rev=282683=rev Log: Add a unit test for an x86_64 assembly inspection of a large stack frame with lots of spilled registers. While writing the i386 version of this test, it looks like I

<    1   2   3   4   5   6   7   8   9   10   >