[Lldb-commits] [lldb] r266092 - 'int' is reported as an exception on OS X not as a signal. I don't think

Author: jingham Date: Tue Apr 12 12:04:12 2016 New Revision: 266092 URL: http://llvm.org/viewvc/llvm-project?rev=266092&view=rev Log: 'int' is reported as an exception on OS X not as a signal. I don't think this test ever succeeded on OS X. Modified: lldb/trunk/packages/Python/lldbsuite/tes

[Lldb-commits] [lldb] r266093 - Breakpoint conditions were making result variables, which they should not do.

Author: jingham Date: Tue Apr 12 12:17:35 2016 New Revision: 266093 URL: http://llvm.org/viewvc/llvm-project?rev=266093&view=rev Log: Breakpoint conditions were making result variables, which they should not do. The result variables aren't useful, and if you have a breakpoint on a common functi

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. This revision now requires changes to proceed. Comment at: source/API/SBThread.cpp:926 @@ -925,3 +925,3 @@ Thread *thread = exe_ctx.GetThreadPtr(); -

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

jingham added a subscriber: jingham. jingham added a comment. Why is this necessary? stdout is a local variable defined in this scope. Why would the android g++ have problems with this? Anyway, if you have to avoid using stdout as a name, maybe name it std_out as that better reflects its mean

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

At the Command & SB API level, we restrict access to the process from multiple threads with the run lock. But internally it is currently more of a gentleman's agreement not to do this. I don't think it would ever be useful to try to make calling functions in the target (which is the job of R

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

jingham added a subscriber: jingham. jingham added a comment. At the Command & SB API level, we restrict access to the process from multiple threads with the run lock. But internally it is currently more of a gentleman's agreement not to do this. I don't think it would ever be useful to try to

[Lldb-commits] [lldb] r266407 - Add the PDBParser.{cpp, h} files to the Xcode project.

Author: jingham Date: Thu Apr 14 20:42:30 2016 New Revision: 266407 URL: http://llvm.org/viewvc/llvm-project?rev=266407&view=rev Log: Add the PDBParser.{cpp,h} files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

Done in r266407. It built for me after this. Jim > On Apr 14, 2016, at 6:34 PM, Zachary Turner via lldb-commits > wrote: > > zturner added a comment. > > A new file was added, Greg or someone else at Apple may need to add it to > the Xcode workspace > > > http://reviews.llvm.org/D18848 >

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

jingham added a subscriber: jingham. jingham added a comment. Done in r266407. It built for me after this. Jim http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

IIRC, python will generate byte-compiled ".pyc" versions of the ".py" files automatically (and helpfully leave them in the CWD...) We turned that off for the testsuite through some Python magic I don't think I ever knew, but if I did I've certainly forgotten it... Anyway, sounds like that got

Re: [Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

That I don't know. But we really shouldn't be generating the .pyc files, they just litter the test directories and I don't think they are much help. Jim > On Apr 18, 2016, at 11:29 AM, Zachary Turner wrote: > > That's normal, but why would that cause an issue for the test suite? What is > l

[Lldb-commits] [lldb] r266944 - Expressions can run without a process.

Author: jingham Date: Wed Apr 20 20:46:11 2016 New Revision: 266944 URL: http://llvm.org/viewvc/llvm-project?rev=266944&view=rev Log: Expressions can run without a process. Code was added in ClangExpressionParser::ClangExpressionParser that was calling through the process w/o checking that it wa

[Lldb-commits] [lldb] r267500 - When building the list of variables we're going to write "using $_lldb_local_vars"

Author: jingham Date: Mon Apr 25 19:29:59 2016 New Revision: 267500 URL: http://llvm.org/viewvc/llvm-project?rev=267500&view=rev Log: When building the list of variables we're going to write "using $_lldb_local_vars" statements for, be sure not to include variables that have no locations. We w

Re: [Lldb-commits] [lldb] r267478 - Fix StackFrame::GetVariables(...) function that was broken by 261858 when lambda functions were added to Block::AppendBlockVariables(). The Stackframe::GetVariables

Debug mode doesn't mean no optimization, but -O0 SHOULD... OTOH, long experience has shown that it is very hard to convince compilers to be as dumb at -O0 as you would like them to be. That's why in all our test cases, we initialize variables, and generally do something dumb like printf the va

Re: [Lldb-commits] [PATCH] D11672: [MIPS] Handle false positives for MIPS hardware watchpoints

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Yes, this looks fine. Repository: rL LLVM http://reviews.llvm.org/D11672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://li

[Lldb-commits] [lldb] r244999 - I was assuming that when a bit of inlined code was followed by code from the inlining site, it was going to execute to the inlining site code, but apparently that's not

Author: jingham Date: Thu Aug 13 20:38:21 2015 New Revision: 244999 URL: http://llvm.org/viewvc/llvm-project?rev=244999&view=rev Log: I was assuming that when a bit of inlined code was followed by code from the inlining site, it was going to execute to the inlining site code, but apparently that

Re: [Lldb-commits] [PATCH] D12184: [MIPS] Avoid breakpoint in delay slot

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. I wish we had a better abstraction for machine-specific behaviors than ArchSpec, since it seems sad to put th

Re: [Lldb-commits] [PATCH] D12184: [MIPS] Avoid breakpoint in delay slot

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks, that looks good to me too. Repository: rL LLVM http://reviews.llvm.org/D12184 ___ lldb-commits mailing list lldb-commits@lists.llvm.

Re: [Lldb-commits] [PATCH] D12158: Fix typo in lldb --help

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This is fine. This is an obvious grammar fix, those don't really need reviewing. http://reviews.llvm.org/D12158 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. So there are two issues I see here. The first is that you seem to have invented a parallel mechanism to the breakpoint resolver mechanism to handle re-resolving breakpoints on shar

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This seems fine. The only things you should fix (see inline comments) are the name of GetDefaultExpressionLanguage and the comment on why the upgrading is necessary. If you do th

[Lldb-commits] [lldb] r246601 - Fix ProcessKDP.cpp for the change in r246578.

Author: jingham Date: Tue Sep 1 17:56:59 2015 New Revision: 246601 URL: http://llvm.org/viewvc/llvm-project?rev=246601&view=rev Log: Fix ProcessKDP.cpp for the change in r246578. Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp lldb/trunk/source/Plugins/Process/Ma

Re: [Lldb-commits] [lldb] r246601 - Fix ProcessKDP.cpp for the change in r246578.

> On Tue, Sep 1, 2015 at 3:58 PM Jim Ingham via lldb-commits > wrote: > Author: jingham > Date: Tue Sep 1 17:56:59 2015 > New Revision: 246601 > > URL: http://llvm.org/viewvc/llvm-project?rev=246601&view=rev > Log: > Fix ProcessKDP.cpp for the change in r246578

[Lldb-commits] [lldb] r246611 - Move things from the LanguageRuntime that obviously belong in the new Language plugin instead.

Author: jingham Date: Tue Sep 1 20:06:46 2015 New Revision: 246611 URL: http://llvm.org/viewvc/llvm-project?rev=246611&view=rev Log: Move things from the LanguageRuntime that obviously belong in the new Language plugin instead. Modified: lldb/trunk/include/lldb/Target/Language.h lldb/tr

[Lldb-commits] [lldb] r246616 - Move more functionality from the LanguageRuntimes to the Languages.

Author: jingham Date: Tue Sep 1 20:59:14 2015 New Revision: 246616 URL: http://llvm.org/viewvc/llvm-project?rev=246616&view=rev Log: Move more functionality from the LanguageRuntimes to the Languages. Modified: lldb/trunk/include/lldb/Target/CPPLanguageRuntime.h lldb/trunk/include/lldb/T

Re: [Lldb-commits] [lldb] r246616 - Move more functionality from the LanguageRuntimes to the Languages.

_lldb-2Dx86-5F64-2Ddarwin-2D13.4_builds_5349&d=BQIBaQ&c=eEvniauFctOgLOKGJOplqw&r=aTCVT7yw0RLKhx7ZXY2faboS3m1dhXpYF-Av4XoSGMU&m=wb98JDzVjz0xrLUTQEpW0b9s0U2kYaqvkcd5ZtHmqjo&s=oGbbSOKsgY6RYSz8f7VUe5NFZPkqXU_emnvwB1LXP8U&e= > >. > > On 2 September 2015 at 02:59, Jim Ingh

Re: [Lldb-commits] [lldb] r246644 - XFAIL new tests in TestCompletion on windows due to missing pexpect

I think - at least for completions - using the SBInterpreter API's would be better than unit tests. You should be able to do all this through the SB API. If you can't we should fix this since any UI that provides a console will need to use those API's. So adding tests for them is a good thin

[Lldb-commits] [lldb] r246736 - Fix ObjCLanguage::MethodName::GetCategory after r246616; I was just moving things around too fast...

Author: jingham Date: Wed Sep 2 19:03:13 2015 New Revision: 246736 URL: http://llvm.org/viewvc/llvm-project?rev=246736&view=rev Log: Fix ObjCLanguage::MethodName::GetCategory after r246616; I was just moving things around too fast... Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLan

[Lldb-commits] [lldb] r246740 - Remove the list of all languages in the help for "help language" since

Author: jingham Date: Wed Sep 2 20:13:26 2015 New Revision: 246740 URL: http://llvm.org/viewvc/llvm-project?rev=246740&view=rev Log: Remove the list of all languages in the help for "help language" since almost all the elements on the list can't actually be passed to the language command and all

[Lldb-commits] [lldb] r246744 - Purge a few places where *LanguageRuntime.h was being used when it

Author: jingham Date: Wed Sep 2 20:40:51 2015 New Revision: 246744 URL: http://llvm.org/viewvc/llvm-project?rev=246744&view=rev Log: Purge a few places where *LanguageRuntime.h was being used when it wasn't needed. Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp lldb/tr

Re: [Lldb-commits] [PATCH] D12360: RenderScript pending kernel breakpoints.

jingham added a comment. That looks great. Here are some comments that are not requirements for getting this in but just for you to consider: If you think you are ever likely to add different ways to specify the name (e.g. if passing a regex might be useful) it might be good to pass the name a

Re: [Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. In general this looks good. It seems to me that in almost all the uses of ClangExpressionVariable::CreateVariableInList, you actually only want the ClangExpressionVariable *, sinc

Re: [Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Is there any reason ClangExpression::FindVariableInList doesn't work the same way as CreateVariableInList. It seems like for that one you also usually want the ClangExpressionVari

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

It isn't technically necessary, but on OS X it is very common for people to want to examine global app state from wherever and that is always ObjC, so we'd tick off our users if we forced them to explicitly dial up ObjC in other contexts. For other platforms it would be fine to choose just C++.

Re: [Lldb-commits] [PATCH] D11102: Set the default language to use when evaluating to that of the frame's CU.

jingham added a subscriber: jingham. jingham added a comment. It isn't technically necessary, but on OS X it is very common for people to want to examine global app state from wherever and that is always ObjC, so we'd tick off our users if we forced them to explicitly dial up ObjC in other cont

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

jingham added a subscriber: jingham. jingham added a comment. If the user says "break set -a " I have no problem with our setting the breakpoint there even if we don't think it is a terribly good idea. But if lldb is converting any other specification to an address, it should always move past

Re: [Lldb-commits] [PATCH] D12556: Use eAddressClassCode for address lookup for opcodes

If the user says "break set -a " I have no problem with our setting the breakpoint there even if we don't think it is a terribly good idea. But if lldb is converting any other specification to an address, it should always move past data in text. The failure modes if you aren't careful about t

Re: [Lldb-commits] [PATCH] D12602: Separate ClangExpressionVariable from ExpressionVariable

jingham added a comment. That look good. There's one place (noted inline) where you are missing a newline at the end of a file. Fix that and it's good to go. Comment at: source/Expression/ExpressionVariable.cpp:32-33 @@ +31,2 @@ +return NULL; +} \ No newline at end of fil

Re: [Lldb-commits] [Diffusion] rL246794: Roll dosep.py parallel test runner into dotest.py command line

I agree with Zachary that we shouldn't mess around with options piecemeal, but let Todd get done with this first round of fixes then go take a hatchet to the options that dotest has, hopefully removing all the ones that nobody needs and rationalizing the others. Jim > On Sep 4, 2015, at 1:31 P

[Lldb-commits] [lldb] r247046 - SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed

Author: jingham Date: Tue Sep 8 13:40:59 2015 New Revision: 247046 URL: http://llvm.org/viewvc/llvm-project?rev=247046&view=rev Log: SBThread::StepOutOfFrame should check that the SBStackFrame it gets passed is valid, and that its thread is the same as this SBThread. Modified: lldb/trunk/sou

Re: [Lldb-commits] [PATCH] D12658: Search variables based on clang::DeclContext and clang::Decl tree

jingham added a subscriber: jingham. jingham added a reviewer: spyffe. jingham added a comment. Sean should take a look at this as well, since it directly affects how the expression parser lookup works. http://reviews.llvm.org/D12658 ___ lldb-commi

Re: [Lldb-commits] [PATCH] D12728: New RenderScript command to break on all kernels

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. This looks fine to me. You might want to add LIBLLDB_LOG_BREAKPOINT to your log creation, you can them together, and if I was tracking breakpoints with "log enable lldb breakpoint" I'd expe

[Lldb-commits] [lldb] r247589 - Remove a debugging printf that got left in SymbolFileDWARFDebugMap.

Author: jingham Date: Mon Sep 14 13:28:28 2015 New Revision: 247589 URL: http://llvm.org/viewvc/llvm-project?rev=247589&view=rev Log: Remove a debugging printf that got left in SymbolFileDWARFDebugMap. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp Modified:

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. This change means that the two cases "no debug info" and "couldn't find your sources" end up looking very sim

[Lldb-commits] [lldb] r247709 - Make the source-map help grammatical.

Author: jingham Date: Tue Sep 15 13:03:00 2015 New Revision: 247709 URL: http://llvm.org/viewvc/llvm-project?rev=247709&view=rev Log: Make the source-map help grammatical. Modified: lldb/trunk/source/Target/Target.cpp Modified: lldb/trunk/source/Target/Target.cpp URL: http://llvm.org/viewvc

Re: [Lldb-commits] [PATCH] D12877: [LLDB] Switch to assembly view if source is moved

> On Sep 15, 2015, at 2:27 PM, Greg Clayton wrote: > > clayborg accepted this revision. > clayborg added a comment. > > I would rather not see a warning. If you don't have sources I don't really > want to see: > > warning: couldn't find foo.c > 0x1000: add r1, r2, r3 > > > Why not? T

Re: [Lldb-commits] [PATCH] D12757: Fix prologue end handling when code compiled by gcc

jingham added a subscriber: jingham. jingham added a comment. The point of the file name check is to catch the case where you had nested inlines that share the same address, and the compiler (errantly, but...) decided to emit duplicate entries at the same address for the two levels of inlining.

[Lldb-commits] [lldb] a7816c8 - git add a test file from a previous commit.

Author: Jim Ingham Date: 2024-07-15T16:02:10-07:00 New Revision: a7816c8e0086c1ae9b8ea15a6c252ca97f0405d1 URL: https://github.com/llvm/llvm-project/commit/a7816c8e0086c1ae9b8ea15a6c252ca97f0405d1 DIFF: https://github.com/llvm/llvm-project/commit/a7816c8e0086c1ae9b8ea15a6c252ca97f0405d1.diff LO

[Lldb-commits] [lldb] 37b8e5f - Revert "[lldb][DWARF] Delay struct/class/union definition DIE searching when parsing declaration DIEs. (#90663)"

Author: Jim Ingham Date: 2024-05-13T17:47:49-07:00 New Revision: 37b8e5feb1d065a7c474e6595bac6d2f65faeb51 URL: https://github.com/llvm/llvm-project/commit/37b8e5feb1d065a7c474e6595bac6d2f65faeb51 DIFF: https://github.com/llvm/llvm-project/commit/37b8e5feb1d065a7c474e6595bac6d2f65faeb51.diff LO

[Lldb-commits] [lldb] 70de9b2 - Revert "[lldb][DWARF] Do not complete type from declaration die. (#91799)"

Author: Jim Ingham Date: 2024-05-13T17:47:49-07:00 New Revision: 70de9b21cbdeb1297108c4ee520b8f6dbd6496a7 URL: https://github.com/llvm/llvm-project/commit/70de9b21cbdeb1297108c4ee520b8f6dbd6496a7 DIFF: https://github.com/llvm/llvm-project/commit/70de9b21cbdeb1297108c4ee520b8f6dbd6496a7.diff LO

[Lldb-commits] [lldb] e6b2197 - Revert a test that was failing after a previous reversion.

Author: Jim Ingham Date: 2024-05-13T18:18:40-07:00 New Revision: e6b2197a89f5d6d0f56a03c03b8afda561eee899 URL: https://github.com/llvm/llvm-project/commit/e6b2197a89f5d6d0f56a03c03b8afda561eee899 DIFF: https://github.com/llvm/llvm-project/commit/e6b2197a89f5d6d0f56a03c03b8afda561eee899.diff LO

[Lldb-commits] [lldb] 0380044 - Fix the EditLine unittest build on Darwin after PR 92865

Author: Jim Ingham Date: 2024-05-28T17:47:08-07:00 New Revision: 0380044e16a1c016e001a56c0ca7f4db649a6cae URL: https://github.com/llvm/llvm-project/commit/0380044e16a1c016e001a56c0ca7f4db649a6cae DIFF: https://github.com/llvm/llvm-project/commit/0380044e16a1c016e001a56c0ca7f4db649a6cae.diff LO

[Lldb-commits] [lldb] 6abc387 - Revert "Fix the EditLine unittest build on Darwin after PR 92865"

Author: Jim Ingham Date: 2024-05-28T18:16:13-07:00 New Revision: 6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6 URL: https://github.com/llvm/llvm-project/commit/6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6 DIFF: https://github.com/llvm/llvm-project/commit/6abc3876c35bbe8fb5dd6435dc60f2c816b97ef6.diff LO

[Lldb-commits] [lldb] 2b0c886 - Refine the reporting mechanism for interruption.

Author: Jim Ingham Date: 2023-07-06T16:19:19-07:00 New Revision: 2b0c8865421287a30ddda0f459f17f76bfeb1358 URL: https://github.com/llvm/llvm-project/commit/2b0c8865421287a30ddda0f459f17f76bfeb1358 DIFF: https://github.com/llvm/llvm-project/commit/2b0c8865421287a30ddda0f459f17f76bfeb1358.diff LO

[Lldb-commits] [lldb] 01e3393 - Split up the runCmd trace printing to print the command before running.

Author: Jim Ingham Date: 2023-07-07T19:09:18-07:00 New Revision: 01e3393b94d194ee99e57f23f9c08160cef94753 URL: https://github.com/llvm/llvm-project/commit/01e3393b94d194ee99e57f23f9c08160cef94753 DIFF: https://github.com/llvm/llvm-project/commit/01e3393b94d194ee99e57f23f9c08160cef94753.diff LO

[Lldb-commits] [lldb] c1885d2 - "settings set -g target.load-script-from-symbol-file" shouldn't crash.

Author: Jim Ingham Date: 2023-07-10T14:40:18-07:00 New Revision: c1885d2dfa950d0f78978546f92be15bc6cca474 URL: https://github.com/llvm/llvm-project/commit/c1885d2dfa950d0f78978546f92be15bc6cca474 DIFF: https://github.com/llvm/llvm-project/commit/c1885d2dfa950d0f78978546f92be15bc6cca474.diff LO

[Lldb-commits] [lldb] 8402ad2 - Add a generic Process method to dump plugin history.

Author: Jim Ingham Date: 2023-07-11T12:33:22-07:00 New Revision: 8402ad23104b6b20f07596738b02a4ab101a8af9 URL: https://github.com/llvm/llvm-project/commit/8402ad23104b6b20f07596738b02a4ab101a8af9 DIFF: https://github.com/llvm/llvm-project/commit/8402ad23104b6b20f07596738b02a4ab101a8af9.diff LO

[Lldb-commits] [lldb] b9541b6 - Fix the root directory completion test.

Author: Jim Ingham Date: 2023-07-17T10:52:29-07:00 New Revision: b9541b6707715b8ea07b47f453f001e698195b3e URL: https://github.com/llvm/llvm-project/commit/b9541b6707715b8ea07b47f453f001e698195b3e DIFF: https://github.com/llvm/llvm-project/commit/b9541b6707715b8ea07b47f453f001e698195b3e.diff LO

Re: [Lldb-commits] [PATCH] D149213: [lldb] Add basic support for Rust enums in TypeSystemClang

> On Jul 21, 2023, at 9:52 AM, J. Ryan Stinnett via Phabricator via > lldb-commits wrote: > > jryans added a comment. > > In D149213#4491889 , > @VladimirMakaev wrote: > >> I think there was an attempt in the past to build TypeSystemRust. Rust >> P

[Lldb-commits] [lldb] 4185656 - Fix the NSIndexSet data formatter for changes in macOS Sonoma.

Author: Jim Ingham Date: 2023-08-04T09:55:59-07:00 New Revision: 4185656625a249832ff67f628bd00e5278721c96 URL: https://github.com/llvm/llvm-project/commit/4185656625a249832ff67f628bd00e5278721c96 DIFF: https://github.com/llvm/llvm-project/commit/4185656625a249832ff67f628bd00e5278721c96.diff LO

[Lldb-commits] [lldb] 2e7aa2e - Replace the singleton "ShadowListener" with a primary and N secondary Listeners

Author: Jim Ingham Date: 2023-08-16T10:35:32-07:00 New Revision: 2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45 URL: https://github.com/llvm/llvm-project/commit/2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45 DIFF: https://github.com/llvm/llvm-project/commit/2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45.diff LO

[Lldb-commits] [lldb] d268ba3 - Test follow-up to 2e7aa2ee34eb53347396731dc8a3b2dbc6a3df45

Author: Jim Ingham Date: 2023-08-16T12:19:07-07:00 New Revision: d268ba38083cd7c9c4f55cb0792d4a0db1d4768b URL: https://github.com/llvm/llvm-project/commit/d268ba38083cd7c9c4f55cb0792d4a0db1d4768b DIFF: https://github.com/llvm/llvm-project/commit/d268ba38083cd7c9c4f55cb0792d4a0db1d4768b.diff LO

Re: [Lldb-commits] [lldb] [lldb] Format Python files in scripts and utils (PR #66053)

Is there any chance we can use something other than black. I would never never write Python code that ugly. Jim > On Sep 12, 2023, at 8:47 AM, Adrian Prantl via lldb-commits > wrote: > > > adrian-prantl wrote: > > Have (should we) we documented that we format all python code with black >

Re: [Lldb-commits] [lldb] Add `target modules dump separate-debug-info` (PR #66035)

Not necessary for this review, but it might be nice to have a --missing or similar flag to this command that filters the output to only the ones that are missing. Seems like a lot of the time I would want to use this command it would be to find missing dwo or oso files. Jim > On Sep 11, 2023

Re: [Lldb-commits] [lldb] [lldb] Add a setting to customize the prompt color (PR #66218)

We actually have several requests for this internally, and I think that's a good idea. However, some of the format tokens can return arbitrary text, including newlines, for instance "thread.completed-expression", and all the "script." ones. Do we want to try to support prompts with new-lines

[Lldb-commits] [lldb] 74338bf - A test was changing directory and then incorrectly restoring the directory

Author: Jim Ingham Date: 2023-09-19T16:46:08-07:00 New Revision: 74338bfe0cfec8b8db24af131cdeb664e346a1b5 URL: https://github.com/llvm/llvm-project/commit/74338bfe0cfec8b8db24af131cdeb664e346a1b5 DIFF: https://github.com/llvm/llvm-project/commit/74338bfe0cfec8b8db24af131cdeb664e346a1b5.diff LO

[Lldb-commits] [lldb] df93c4f - Remove some raciness from the TestProcessAttach.test_run_then_attach_wait_interrupt

Author: Jim Ingham Date: 2023-09-20T13:08:40-07:00 New Revision: df93c4ffdf220630ecceba5c9a7822c0aca7deaa URL: https://github.com/llvm/llvm-project/commit/df93c4ffdf220630ecceba5c9a7822c0aca7deaa DIFF: https://github.com/llvm/llvm-project/commit/df93c4ffdf220630ecceba5c9a7822c0aca7deaa.diff LO

[Lldb-commits] [lldb] de94c10 - The test: test_run_then_attach_wait_interrupt was flakey on Linux & Windows.

Author: Jim Ingham Date: 2023-09-20T17:38:27-07:00 New Revision: de94c109b64d098c52ffc6f60daadb3eaa8fb944 URL: https://github.com/llvm/llvm-project/commit/de94c109b64d098c52ffc6f60daadb3eaa8fb944 DIFF: https://github.com/llvm/llvm-project/commit/de94c109b64d098c52ffc6f60daadb3eaa8fb944.diff LO

[Lldb-commits] [lldb] 3c61e4b - Copy and paste error in a file header.

Author: Jim Ingham Date: 2023-09-20T17:43:44-07:00 New Revision: 3c61e4bf28538f5f267b073634e394dd5000af85 URL: https://github.com/llvm/llvm-project/commit/3c61e4bf28538f5f267b073634e394dd5000af85 DIFF: https://github.com/llvm/llvm-project/commit/3c61e4bf28538f5f267b073634e394dd5000af85.diff LO

[Lldb-commits] [lldb] b9e08cb - I can't make this test fail locally, but it is failing on the macOS

Author: Jim Ingham Date: 2023-09-21T13:30:45-07:00 New Revision: b9e08cbf3037e03bdb2da700db3b02ed32e49b78 URL: https://github.com/llvm/llvm-project/commit/b9e08cbf3037e03bdb2da700db3b02ed32e49b78 DIFF: https://github.com/llvm/llvm-project/commit/b9e08cbf3037e03bdb2da700db3b02ed32e49b78.diff LO

[Lldb-commits] [lldb] 0f339e6 - Fix a bug in handling ^C at the "y/n/a" completion prompt.

Author: Jim Ingham Date: 2023-09-27T17:20:48-07:00 New Revision: 0f339e6567bffb290e409ef5de272fb75ce70234 URL: https://github.com/llvm/llvm-project/commit/0f339e6567bffb290e409ef5de272fb75ce70234 DIFF: https://github.com/llvm/llvm-project/commit/0f339e6567bffb290e409ef5de272fb75ce70234.diff LO

[Lldb-commits] [lldb] f758859 - Fix error reporting for "process load" and add a test for it.

Author: Jim Ingham Date: 2021-12-07T15:08:05-08:00 New Revision: f75885977cefe4d5ebbe51f85b353bb9989dd777 URL: https://github.com/llvm/llvm-project/commit/f75885977cefe4d5ebbe51f85b353bb9989dd777 DIFF: https://github.com/llvm/llvm-project/commit/f75885977cefe4d5ebbe51f85b353bb9989dd777.diff LO

Re: [Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

I agree that if we are going to start putting in errors for not finding listed arguments to “frame var” we should do it consistently, and Greg’s list seems good - along with the error “No debug info” when “frame var” is run in a frame w/o debug info or recognizers. The one thing that bothers me

Re: [Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

Indeed not. Since you can get everything you would need straightforwardly using SBFrame::FindVariables, there’s no pressing need to give another way to do it using HandleCommand. Jim > On Jan 11, 2022, at 2:02 PM, Dave Lee via Phabricator > wrote: > > kastiglione added a comment. > >> if I

Re: [Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

Ah, I think your confusion is that you missed the “Remote” part of all the classes in lldb that start with “GDB”. They are so called because they use the “gdb remote serial protocol” to communicate with the debug monitor, not because they have anything to do with gdb the debugger. That’s a pr

[Lldb-commits] [lldb] 635f03f - Add a repeat command option for "thread backtrace --count N".

Author: Jim Ingham Date: 2022-02-14T15:48:06-08:00 New Revision: 635f03fe976e250cc64999663f47716412dfa029 URL: https://github.com/llvm/llvm-project/commit/635f03fe976e250cc64999663f47716412dfa029 DIFF: https://github.com/llvm/llvm-project/commit/635f03fe976e250cc64999663f47716412dfa029.diff LO

[Lldb-commits] [lldb] 793924d - Fix an incorrect assumption in "thread until": code with debug info is not always in a function.

Author: Jim Ingham Date: 2022-02-14T15:53:24-08:00 New Revision: 793924dd5f2ad0663f77a09f09d11adaa4ce2b91 URL: https://github.com/llvm/llvm-project/commit/793924dd5f2ad0663f77a09f09d11adaa4ce2b91 DIFF: https://github.com/llvm/llvm-project/commit/793924dd5f2ad0663f77a09f09d11adaa4ce2b91.diff LO

[Lldb-commits] [lldb] 0e0e381 - This test seems to pass on Linux, remove the x-fail.

Author: Jim Ingham Date: 2022-02-14T16:58:57-08:00 New Revision: 0e0e381a1547c641a54b2131665d8a38855371b4 URL: https://github.com/llvm/llvm-project/commit/0e0e381a1547c641a54b2131665d8a38855371b4 DIFF: https://github.com/llvm/llvm-project/commit/0e0e381a1547c641a54b2131665d8a38855371b4.diff LO

[Lldb-commits] [lldb] dd8490d - Add a test for breaking on overloaded functions by name.

Author: Jim Ingham Date: 2022-02-16T18:12:00-08:00 New Revision: dd8490d207d3a1612091abbea04bf660f133a89f URL: https://github.com/llvm/llvm-project/commit/dd8490d207d3a1612091abbea04bf660f133a89f DIFF: https://github.com/llvm/llvm-project/commit/dd8490d207d3a1612091abbea04bf660f133a89f.diff LO

[Lldb-commits] [lldb] 05f10ae - On Windows, the function name contains the return parameter, so

Author: Jim Ingham Date: 2022-02-16T19:10:03-08:00 New Revision: 05f10ae0d8548e65130475730a1565203da8726d URL: https://github.com/llvm/llvm-project/commit/05f10ae0d8548e65130475730a1565203da8726d DIFF: https://github.com/llvm/llvm-project/commit/05f10ae0d8548e65130475730a1565203da8726d.diff LO

Re: [Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

There was a question on the dev list a while ago about to print out all the valid ranges of a variable. That's a useful bit of info if you're trying to figure out where you could break to actually see or change a variable's value in an optimized function. I think that's the motivation for the

Re: [Lldb-commits] [lldb] 6b3b3ef - [lldb] Correct case in description of breakpoint --on-catch/throw

This was on purpose - I do it whenever the short option isn't the first letter of the long option as an aid to memorization. Some people catch this and it helps, others correct the spelling in checkins without noticing what they are for. I thought it was helpful, but maybe it only annoys peopl

[Lldb-commits] [lldb] 3f43818 - Fix up the "lldb log break" channel output.

Author: Jim Ingham Date: 2022-03-03T12:10:39-08:00 New Revision: 3f438185a68af4ca99d018d94f4732fd53433674 URL: https://github.com/llvm/llvm-project/commit/3f438185a68af4ca99d018d94f4732fd53433674 DIFF: https://github.com/llvm/llvm-project/commit/3f438185a68af4ca99d018d94f4732fd53433674.diff LO

[Lldb-commits] [lldb] c697a1f - Fix the order of modules-loaded event and the resultant breakpoint-changed event.

Author: Jim Ingham Date: 2022-03-03T12:10:54-08:00 New Revision: c697a1f06b6240d62eec8890ac1314728906d707 URL: https://github.com/llvm/llvm-project/commit/c697a1f06b6240d62eec8890ac1314728906d707 DIFF: https://github.com/llvm/llvm-project/commit/c697a1f06b6240d62eec8890ac1314728906d707.diff LO

[Lldb-commits] [lldb] 94ec0b6 - Change "target.save-jit-objects" to "target.save-jit-objects-dir".

Author: Jim Ingham Date: 2022-03-07T17:44:51-08:00 New Revision: 94ec0b6c5ab8b5cd2f418f872ae2bbb2be3c550e URL: https://github.com/llvm/llvm-project/commit/94ec0b6c5ab8b5cd2f418f872ae2bbb2be3c550e DIFF: https://github.com/llvm/llvm-project/commit/94ec0b6c5ab8b5cd2f418f872ae2bbb2be3c550e.diff LO

Re: [Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

That's certainly good enough for users. If you were the developer of another client, I think you'd want to keep people from inadvertently turning this back on. But that's probably a minor concern. And there isn't an equivalent good way to turn off the stop description from being printed if

[Lldb-commits] [lldb] 33f9fc7 - Don't report memory return values on MacOS_arm64 of SysV_arm64 ABI's.

Author: Jim Ingham Date: 2022-03-14T15:25:40-07:00 New Revision: 33f9fc77d1ffe7d6c86b6c7a692ff9f2b99cf82e URL: https://github.com/llvm/llvm-project/commit/33f9fc77d1ffe7d6c86b6c7a692ff9f2b99cf82e DIFF: https://github.com/llvm/llvm-project/commit/33f9fc77d1ffe7d6c86b6c7a692ff9f2b99cf82e.diff LO

Re: [Lldb-commits] [PATCH] D128504: debugserver: spawn process in its own process group

Why is it desirable to have the debugger not see signals sent to the process? Jim > On Jun 24, 2022, at 1:06 AM, Alessandro Arzilli via Phabricator via > lldb-commits wrote: > > aarzilli created this revision. > aarzilli added reviewers: jasonmolenda, clayborg. > aarzilli added a project: LLD

[Lldb-commits] [lldb] c1b07d6 - Have CommandObjectParsed check for "commands that take no arguments".

Author: Jim Ingham Date: 2022-06-27T15:14:41-07:00 New Revision: c1b07d617705dfdb3aabbdda51c1a40d99f7cc1a URL: https://github.com/llvm/llvm-project/commit/c1b07d617705dfdb3aabbdda51c1a40d99f7cc1a DIFF: https://github.com/llvm/llvm-project/commit/c1b07d617705dfdb3aabbdda51c1a40d99f7cc1a.diff LO

[Lldb-commits] [lldb] f7bf9d1 - TestIgnoredExceptions.py needs support from debugserver, so it

Author: Jim Ingham Date: 2022-06-28T11:49:55-07:00 New Revision: f7bf9d13d50d785889952deb18cc93de0176cb96 URL: https://github.com/llvm/llvm-project/commit/f7bf9d13d50d785889952deb18cc93de0176cb96 DIFF: https://github.com/llvm/llvm-project/commit/f7bf9d13d50d785889952deb18cc93de0176cb96.diff LO

[Lldb-commits] [lldb] b8e0b5a - Threads which hit a breakpoint but fail the condition are considered

Author: Jim Ingham Date: 2022-06-30T11:43:59-07:00 New Revision: b8e0b5a071600cb39d938470bd20d845013384ce URL: https://github.com/llvm/llvm-project/commit/b8e0b5a071600cb39d938470bd20d845013384ce DIFF: https://github.com/llvm/llvm-project/commit/b8e0b5a071600cb39d938470bd20d845013384ce.diff LO

[Lldb-commits] [lldb] 38ca754 - Apparently you need a special makefile flag to use threads on Linux.

Author: Jim Ingham Date: 2022-06-30T12:10:17-07:00 New Revision: 38ca754eb08b0741511c74bbac123e551f54125b URL: https://github.com/llvm/llvm-project/commit/38ca754eb08b0741511c74bbac123e551f54125b DIFF: https://github.com/llvm/llvm-project/commit/38ca754eb08b0741511c74bbac123e551f54125b.diff LO

[Lldb-commits] [lldb] 5778ada - Make hit point counts reliable for architectures that stop before evaluation.

Author: Jim Ingham Date: 2022-07-18T14:36:32-07:00 New Revision: 5778ada8e54edb2bc2869505b88a959d1915c02f URL: https://github.com/llvm/llvm-project/commit/5778ada8e54edb2bc2869505b88a959d1915c02f DIFF: https://github.com/llvm/llvm-project/commit/5778ada8e54edb2bc2869505b88a959d1915c02f.diff LO

[Lldb-commits] [lldb] e83d47f - When the module path for `command script import` is invalid, echo the path.

Author: Jim Ingham Date: 2022-07-18T14:49:07-07:00 New Revision: e83d47f6b7bd2f8dcf419e03b3a00d5db5bd61c4 URL: https://github.com/llvm/llvm-project/commit/e83d47f6b7bd2f8dcf419e03b3a00d5db5bd61c4 DIFF: https://github.com/llvm/llvm-project/commit/e83d47f6b7bd2f8dcf419e03b3a00d5db5bd61c4.diff LO

[Lldb-commits] [lldb] 555ae5b - This is a followup to https://reviews.llvm.org/D129814

Author: Jim Ingham Date: 2022-07-18T16:24:31-07:00 New Revision: 555ae5b8f5aa93ab090af853a8b7a83f815b3f20 URL: https://github.com/llvm/llvm-project/commit/555ae5b8f5aa93ab090af853a8b7a83f815b3f20 DIFF: https://github.com/llvm/llvm-project/commit/555ae5b8f5aa93ab090af853a8b7a83f815b3f20.diff LO

[Lldb-commits] [lldb] 4f5707e - Revert "This is a followup to https://reviews.llvm.org/D129814"

Author: Jim Ingham Date: 2022-07-18T17:37:13-07:00 New Revision: 4f5707e743528a0d40ac154e2e07705a03fd7ad3 URL: https://github.com/llvm/llvm-project/commit/4f5707e743528a0d40ac154e2e07705a03fd7ad3 DIFF: https://github.com/llvm/llvm-project/commit/4f5707e743528a0d40ac154e2e07705a03fd7ad3.diff LO

[Lldb-commits] [lldb] 83fab8c - Revert "Make hit point counts reliable for architectures that stop before evaluation."

Author: Jim Ingham Date: 2022-07-18T17:38:43-07:00 New Revision: 83fab8cee9d6b9fa911195c20325b4512a7a22ef URL: https://github.com/llvm/llvm-project/commit/83fab8cee9d6b9fa911195c20325b4512a7a22ef DIFF: https://github.com/llvm/llvm-project/commit/83fab8cee9d6b9fa911195c20325b4512a7a22ef.diff LO

[Lldb-commits] [lldb] 8b7775a - StackFrame::GetValueObjectForFrameVariable holds the StackFrame lock too long.

Author: Jim Ingham Date: 2022-07-26T10:13:19-07:00 New Revision: 8b7775a472e3665dc0a9e5953f84c43da295eddd URL: https://github.com/llvm/llvm-project/commit/8b7775a472e3665dc0a9e5953f84c43da295eddd DIFF: https://github.com/llvm/llvm-project/commit/8b7775a472e3665dc0a9e5953f84c43da295eddd.diff LO

Re: [Lldb-commits] [PATCH] D130660: [LLDB] Fix missing return value in SBBreakpointLocation::GetQueueName()

So far as I can tell, we don't have any significant tests for the "queue specific breakpoint or breakpoint location" feature. There's a pretty extensive test for identifying queues & getting more detail from them in test/API/macosx/queues/TestQueues.py, but it doesn't test the breakpoint featu

[Lldb-commits] [lldb] 27893ff - Call WatchpointList::RemoveAll in Target::Destroy.

Author: Jim Ingham Date: 2022-07-27T15:15:05-07:00 New Revision: 27893ff1ad750d9828ca3a774ba9f0029c16149f URL: https://github.com/llvm/llvm-project/commit/27893ff1ad750d9828ca3a774ba9f0029c16149f DIFF: https://github.com/llvm/llvm-project/commit/27893ff1ad750d9828ca3a774ba9f0029c16149f.diff LO

<    4   5   6   7   8   9   10   11   12   13   >