[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna added a comment. @labath > (Please add lldb-commits to future reviews, so that people are aware of > what's going on.) ok > Couldn't we just change the File::Read/Write functions to call these directly Like I said to @zturner , this is possible, but it can't work with the

[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna added inline comments. Comment at: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1075-1096 +static int readfn(void *ctx, char *buffer, int n) +{ + auto state = PyGILState_Ensure(); + auto *file = (PyObject *) ctx; + int result = -1;

[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna added inline comments. Comment at: lldb/trunk/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1075-1096 +static int readfn(void *ctx, char *buffer, int n) +{ + auto state = PyGILState_Ensure(); + auto *file = (PyObject *) ctx; + int result = -1;

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 221113. lawrence_danna added a comment. added some tests, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna updated this revision to Diff 221082. lawrence_danna added a comment. Herald added a subscriber: mgorny. added a unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 Files:

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

lawrence_danna updated this revision to Diff 221093. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. removed SetOptions() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67792/new/ https://reviews.llvm.org/D67792

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath So what do you think? Update all the lldb_private::File clients to use shared_ptr instead? Or do it this way, with sharing handled inside of File? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. If the file has m_stream, it may not have a m_descriptor. GetWaitableHandle() should call GetDescriptor(), which will call fileno(), so it will get waitable descriptor

[Lldb-commits] [PATCH] D67791: dotest.py: bugfix: test filters with -f do not work on Python3

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. `dotest -f` does not work on Python3. The name types.UnboundMethodType was an alias for types.MethodType in 2.7, but it does not exist in python3. MethodType works in

[Lldb-commits] [PATCH] D67786: support for arbitrary python file objects

lawrence_danna abandoned this revision. lawrence_danna added a comment. will re-submit as individual patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67786/new/ https://reviews.llvm.org/D67786

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, zturner, jingham. Herald added a subscriber: mgorny. Herald added a project: LLDB. SBFile is a scripting API wrapper for lldb_private::File This is the first step in a rework of

[Lldb-commits] [PATCH] D38829: Python: SetOutputFileHandle doesn't work with IOBase

lawrence_danna abandoned this revision. lawrence_danna added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I've reworked this -- finally -- as zturner suggested. I'll be posting it as a bunch of individual commits, so i'm abandoning this one. Repository:

[Lldb-commits] [PATCH] D67790: prepare_binding_Python: print readable errors if SWIG fails

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. When swig fails, all the errors are squished onto one line with `\n` quoting. It's very hard to read. This will print them out in a more reasonable format.

[Lldb-commits] [PATCH] D67792: bugfix: llvm_private::File::GetStream() can fail if m_options == 0

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda. Herald added a project: LLDB. It's not clear from the header a File created with a descriptor will be not be usable by LLDB unless SetOptions is also called, but it is. This is because some parts of

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. This patch adds SWIG typemaps that can convert arbitrary python file objects into lldb_private::File. A SBFile may be initialized from a python file using the

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222516. lawrence_danna marked 7 inline comments as done. lawrence_danna added a comment. fixed according to reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222522. lawrence_danna added a comment. flush fix for python2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222520. lawrence_danna added a comment. propagated updates from parent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files:

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222528. lawrence_danna added a comment. add reproducer instrumentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222537. lawrence_danna added a comment. pushed validity checks out to the SB layer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1687532 , @labath wrote: > It seems to be that instead of subclassing a fully-functional File class, it > would be better to create an abstract class, that both `File` and the new > python thingy could

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222538. lawrence_danna added a comment. assertions instead of exceptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files:

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/scripts/Python/python-typemaps.swig:464 } + +// These two pybuffer macros are copied out of swig/Lib/python/pybuffer.i, `swig/LICENSE` says the following, so

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

This revision was automatically updated to reflect the committed changes. lawrence_danna marked an inline comment as done. Closed by commit rL373285: File::Clear() - File::TakeStreamAndClear() (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBFile.h:16-21 +/* These tags make no difference at the c++ level, but + * when the constructors are called from python they control + * how python files are

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222168. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. style fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files:

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. fixed style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373090: remove File::SetStream(), make new files instead. (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222165. lawrence_danna added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 222170. lawrence_danna added a comment. updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna added a comment. done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna updated this revision to Diff 221985. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixed the remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

This revision was automatically updated to reflect the committed changes. Closed by commit rL373003: Convert FileSystem::Open() to return ExpectedFileUP (authored by lawrence_danna, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D68152: refactor: move IOObject::m_should_close_fd into subclasses

This revision was automatically updated to reflect the committed changes. Closed by commit rG117512715d66: refactor: move IOObject::m_should_close_fd into subclasses (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222190. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. rebased, and converted Set* methods into constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. @labath, OK sets are now constructors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793

[Lldb-commits] [PATCH] D68152: refactor: move IOObject::m_should_close_fd into subclasses

lawrence_danna created this revision. lawrence_danna added reviewers: labath, JDevlieghere, jasonmolenda. Herald added a project: LLDB. m_should_close_fd doesn't need to be in IOObject. It will be useful for my next change to move it down into File and Socket. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. @labath how's this one looking? need any changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 64. lawrence_danna added a comment. rebased, removed duplicate test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. File::Clear() is an ugly function. It's only used in one place, which is the swig typemaps for FILE*. This patch refactors and renames that function to make

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. In D67891#1678933 , @labath wrote: > The first option would require making the File class movable I don't think making File movable will work. I'll be wanting a PythonFile subclass, which overrides virtual

[Lldb-commits] [PATCH] D67792: File::SetDescriptor() should require options

lawrence_danna updated this revision to Diff 221390. lawrence_danna added a comment. added unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67792/new/ https://reviews.llvm.org/D67792 Files: lldb/include/lldb/Host/File.h

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna updated this revision to Diff 221383. lawrence_danna added a comment. nits fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 Files: lldb/source/Host/common/File.cpp

[Lldb-commits] [PATCH] D67789: bugfix: File::GetWaitableHandle() should call fileno()

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. nits fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67789/new/ https://reviews.llvm.org/D67789 ___ lldb-commits

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna added a comment. @labath How's it look now? I made FileSystem::Open return a unique_ptr, and only convert that over to a shared_ptr where necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221431. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. converted many uses of shared_ptr into unique_ptr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. lawrence_danna added a parent revision: D68181: SBDebugger::SetInputFile, SetOutputFile, etc.. lawrence_danna added a child revision: D68188: allow arbitrary

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/API/SBFile.h:16-21 +/* These tags make no difference at the c++ level, but + * when the constructors are called from python they control + * how python files are

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222750. lawrence_danna added a comment. rename LLDBPythonFile -> OwnedPythonFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1689544 , @labath wrote: > This way the decision whether to "own" something is decoupled from the > decision what api do you use to actually write to the file, and I _think_ it > would make things clearer. What

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222753. lawrence_danna added a comment. use a python helper instead of funny tag structs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222749. lawrence_danna added a comment. updated based on an abstract base clase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files:

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222751. lawrence_danna added a comment. style fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna added a comment. In D68188#1691129 , @labath wrote: > Hmm... I like your solution of the typemap problem, but this CRTP class seems > to be way more complicated than needed. There shouldn't be any need for CRTP > as we already have

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna added a comment. @labath any more comments on this one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222853. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68317: factor out an abstract base class for File

lawrence_danna added inline comments. Comment at: lldb/include/lldb/Host/File.h:377-381 + template + static std::shared_ptr make_shared(Args... args) { +return std::static_pointer_cast( +std::make_shared(args...)); + } labath wrote: > Please

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

lawrence_danna updated this revision to Diff 222883. lawrence_danna added a comment. get rid of CRTP gobbledygook Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68188/new/ https://reviews.llvm.org/D68188 Files: lldb/include/lldb/API/SBFile.h

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna updated this revision to Diff 222459. lawrence_danna added a comment. review fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68160/new/ https://reviews.llvm.org/D68160 Files: lldb/include/lldb/Host/File.h

[Lldb-commits] [PATCH] D68160: File::Clear() -> File::TakeStreamAndClear()

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/source/Host/common/File.cpp:166-167 +FILE *File::TakeStreamAndClear() { + GetStream(); + FILE *stream = m_stream; + m_stream = NULL; labath wrote: > `FILE

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, zturner, jingham, labath. Herald added a project: LLDB. This patch removes File::SetStream() and File::SetDescriptor(), and replaces most direct uses of File with std::shared_ptr. Instead of calling

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221222. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. updated description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna updated this revision to Diff 221864. lawrence_danna added a comment. got rid of StreamFile::SetFile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67996/new/ https://reviews.llvm.org/D67996 Files:

[Lldb-commits] [PATCH] D67996: Convert FileSystem::Open() to return Expected

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/include/lldb/Core/StreamFile.h:48-53 + void SetFile(std::shared_ptr file) { +if (file) + m_file_sp = file; +else + m_file_sp = std::make_shared(); + }

[Lldb-commits] [PATCH] D67891: remove File::SetStream(), make new files instead.

lawrence_danna updated this revision to Diff 221866. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67891/new/ https://reviews.llvm.org/D67891 Files: lldb/include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D67943: documentation: update test.rst

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. The testing documentation appears to be from an era when the only kind of tests were the lldbsuite python tests. This patch adds a short description of the

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna created this revision. lawrence_danna added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: LLDB. Add new methods to SBDebugger to set IO files as SBFiles instead of as FILE* streams. In future commits, the FILE* methods will be deprecated and these will

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 85. lawrence_danna added a comment. clang-format fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181 Files: lldb/include/lldb/API/SBDebugger.h

[Lldb-commits] [PATCH] D68181: SBDebugger::SetInputFile, SetOutputFile, etc.

lawrence_danna updated this revision to Diff 222664. lawrence_danna marked an inline comment as done. lawrence_danna added a comment. no inlines in the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68181/new/ https://reviews.llvm.org/D68181

[Lldb-commits] [PATCH] D67793: new api class: SBFile

lawrence_danna updated this revision to Diff 222661. lawrence_danna added a comment. no inlines in the API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67793/new/ https://reviews.llvm.org/D67793 Files: lldb/include/lldb/API/LLDB.h

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna updated this revision to Diff 223143. lawrence_danna added a comment. deserializer hijinks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68434/new/ https://reviews.llvm.org/D68434 Files:

[Lldb-commits] [PATCH] D68434: SBFile support in SBCommandReturnObject

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Utility/ReproducerInstrumentation.cpp:38 +template <> lldb::SBFile Deserializer::Deserialize() { +//@JDevlieghere I'm pretty sure this is not the right thing to

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny, JDevlieghere. Herald added a project: LLDB. This patch updates the last user of ArgInfo::count and deletes it. I also delete `GetNumInitArguments()` and `GetInitArgInfo()`. Classess are callables and

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

This revision was automatically updated to reflect the committed changes. Closed by commit rGadbf64ccc9e1: [LLDB][Python] remove ArgInfo::count (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69742/new/

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added a comment. In D69742#1732608 , @labath wrote: > At this point, should we just delete the ArgInfo struct altogether, and > replace it with a plain `unsigned`? Sounds like a good idea

[Lldb-commits] [PATCH] D69742: [LLDB][Python] remove ArgInfo::count

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/PythonDataObjectsTests.cpp:764 } #if PY_MAJOR_VERSION >= 3 && PY_MINOR_VERSION >= 3 JDevlieghere wrote: > Should we

[Lldb-commits] [PATCH] D69532: [LLDB][PythonFile] fix dangerous borrow semantics on python2

This revision was automatically updated to reflect the committed changes. Closed by commit rG3071ebf7b383: [LLDB][PythonFile] fix dangerous borrow semantics on python2 (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225745. lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133 Files:

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225746. lawrence_danna added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D69133: eliminate nontrivial Reset(...) from TypedPythonObject

lawrence_danna updated this revision to Diff 225758. lawrence_danna added a comment. comment on NullTerminated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69133/new/ https://reviews.llvm.org/D69133 Files:

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp:1057 + + // global is protected by the GIL + static PythonScript read_exception(read_exception_script,

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225800. lawrence_danna added a comment. oops Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna updated this revision to Diff 225799. lawrence_danna marked 3 inline comments as done. lawrence_danna added a comment. fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 Files:

[Lldb-commits] [PATCH] D69214: remove multi-argument form of PythonObject::Reset()

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69214/new/ https://reviews.llvm.org/D69214 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D69468: [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/scripts/Python/python-wrapper.swig:64 +unsigned max_positional_args = PythonCallable::ArgInfo::UNBOUNDED; +if (auto arg_info = pfunc.GetArgInfo()) {

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added a comment. In D68737#1722255 , @mgorny wrote: > However, I think this is only a symptom of a more generic problem. I don't > think we should really be creating a second system of file objects outside > Python, and injecting it into

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna created this revision. lawrence_danna added reviewers: labath, mgorny. Herald added a subscriber: krytarowski. Herald added a project: LLDB. Here's another instance where we were calling fflush on an input stream, which is illegal on NetBSD. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226599. lawrence_danna added a comment. and another Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226595. lawrence_danna added a comment. py2_const_cast shouldn't be static as a free function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226597. lawrence_danna added a comment. found another one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488 Files:

[Lldb-commits] [PATCH] D69469: [LLDB][formatters] ArgInfo::count -> ArgInfo::max_positional_args

This revision was automatically updated to reflect the committed changes. Closed by commit rG40b0fa7ef212: [LLDB][formatters] ArgInfo::count - ArgInfo::max_positional_args (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D68737: SBFile::GetFile: convert SBFile back into python native files.

lawrence_danna added a comment. In D68737#1722620 , @mgorny wrote: > In D68737#1722575 , @lawrence_danna > wrote: > > > In D68737#1722255 , @mgorny wrote: > > > > >

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna added a comment. There, I think that fixes the issue with borrow semantics and the NetBSD issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna marked 2 inline comments as done. lawrence_danna added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854 files = list(i(sbf)) +# delete them in reverse order, again because each

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna marked an inline comment as done. lawrence_danna added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/python_api/file_handle/TestFileHandle.py:854 files = list(i(sbf)) +# delete them in reverse order, again because each

[Lldb-commits] [PATCH] D69488: [LLDB][Python] fix another fflush issue on NetBSD

lawrence_danna updated this revision to Diff 226618. lawrence_danna added a comment. protect python from being exposed to C++ reference borrowing semantics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69488/new/ https://reviews.llvm.org/D69488

[Lldb-commits] [PATCH] D68995: clean up the implementation of PythonCallable::GetNumArguments

lawrence_danna updated this revision to Diff 225316. lawrence_danna added a comment. fixup: VAR_KEYWORD Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68995/new/ https://reviews.llvm.org/D68995 Files:

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna added a comment. fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D69014: [LLDB] bugfix: command script add -f doesn't work for some callables

lawrence_danna updated this revision to Diff 225297. lawrence_danna added a comment. comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69014/new/ https://reviews.llvm.org/D69014 Files:

  1   2   3   4   5   >