[Lldb-commits] [lldb] 8dc7b98 - [NFC] Fixes -Wrange-loop-analysis warnings

Author: Mark de Wever Date: 2020-01-01T20:01:37+01:00 New Revision: 8dc7b982b4556c243e0502e6e230bdd53ddd65ff URL: https://github.com/llvm/llvm-project/commit/8dc7b982b4556c243e0502e6e230bdd53ddd65ff DIFF: https://github.com/llvm/llvm-project/commit/8dc7b982b4556c243e0502e6e230bdd53ddd65ff.diff

[Lldb-commits] [lldb] a2c319f - [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

Author: Alfonso Gregory Date: 2021-09-16T18:29:57+02:00 New Revision: a2c319fdc6b35ae6d8578459f07c89042775e5ec URL: https://github.com/llvm/llvm-project/commit/a2c319fdc6b35ae6d8578459f07c89042775e5ec DIFF:

[Lldb-commits] [lldb] 0e4264a - [lldb][libc++] Adds chrono data formatters.

Author: Mark de Wever Date: 2023-10-25T19:36:47+02:00 New Revision: 0e4264ab1e7a3d82a32d0d096d014afade1e2fae URL: https://github.com/llvm/llvm-project/commit/0e4264ab1e7a3d82a32d0d096d014afade1e2fae DIFF: https://github.com/llvm/llvm-project/commit/0e4264ab1e7a3d82a32d0d096d014afade1e2fae.diff

[Lldb-commits] [lldb] d40dc41 - [CMake] Warn when the version is older than 3.20.0.

Author: Mark de Wever Date: 2022-12-11T20:19:46+01:00 New Revision: d40dc417389e09b26dd4177f50a06cf9889caf2f URL: https://github.com/llvm/llvm-project/commit/d40dc417389e09b26dd4177f50a06cf9889caf2f DIFF: https://github.com/llvm/llvm-project/commit/d40dc417389e09b26dd4177f50a06cf9889caf2f.diff

[Lldb-commits] [lldb] 898b5c9 - [NFC] Fix "form/from" typos

Author: Piotr Fusik Date: 2023-01-22T20:05:51+01:00 New Revision: 898b5c9f5e7715f3ea4bb0ca2a8f23c301efa9c2 URL: https://github.com/llvm/llvm-project/commit/898b5c9f5e7715f3ea4bb0ca2a8f23c301efa9c2 DIFF: https://github.com/llvm/llvm-project/commit/898b5c9f5e7715f3ea4bb0ca2a8f23c301efa9c2.diff

[Lldb-commits] [lldb] 44d3802 - Revert "Revert "Revert "[CMake] Bumps minimum version to 3.20.0."""

Author: Mark de Wever Date: 2023-04-15T20:12:24+02:00 New Revision: 44d38022ab29a3156349602733b3459df5beef93 URL: https://github.com/llvm/llvm-project/commit/44d38022ab29a3156349602733b3459df5beef93 DIFF: https://github.com/llvm/llvm-project/commit/44d38022ab29a3156349602733b3459df5beef93.diff

[Lldb-commits] [lldb] e8e8707 - Revert "Reland "[CMake] Bumps minimum version to 3.20.0.""

Author: Mark de Wever Date: 2023-05-06T17:03:56+02:00 New Revision: e8e8707b4aa6e4cc04c0cffb2de01d2de71165fc URL: https://github.com/llvm/llvm-project/commit/e8e8707b4aa6e4cc04c0cffb2de01d2de71165fc DIFF: https://github.com/llvm/llvm-project/commit/e8e8707b4aa6e4cc04c0cffb2de01d2de71165fc.diff

[Lldb-commits] [clang] [libc] [flang] [openmp] [lld] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1267,7 +1267,11 @@ def add_version_header(tc): }, { "name": "__cpp_lib_variant", -"values": {"c++17": 202102}, +"values": { +"c++17": 202102, # std::visit for classes derived from std::variant +

[Lldb-commits] [openmp] [clang] [lld] [libc] [lldb] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [flang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -0,0 +1,357 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [compiler-rt] [clang] [lld] [openmp] [libc] [llvm] [lldb] [libcxx] [flang] [clang-tools-extra] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1130,6 +1137,19 @@ using __best_match_t = typename invoke_result_t<_MakeOverloads<_Types...>, _Tp, } // namespace __variant_detail +template < class _Visitor, class... _Vs, typename = void_t()))...> > +_LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_THROW_BAD_VARIANT_ACCESS

[Lldb-commits] [libc] [lld] [compiler-rt] [libcxx] [lldb] [clang-tools-extra] [flang] [llvm] [openmp] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1273,6 +1293,24 @@ public: __impl_.__swap(__that.__impl_); } +# if _LIBCPP_STD_VER >= 26 && defined(_LIBCPP_HAS_EXPLICIT_THIS_PARAMETER) + struct __variant_visit_barrier_tag { // unnamable when using standard library modules mordante wrote: I'm

[Lldb-commits] [llvm] [clang] [libcxx] [compiler-rt] [libc] [lldb] [lld] [clang-tools-extra] [flang] [openmp] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -0,0 +1,48 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [llvm] [compiler-rt] [flang] [openmp] [clang] [clang-tools-extra] [lld] [libcxx] [libc] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [openmp] [libcxx] [flang] [lld] [clang-tools-extra] [llvm] [compiler-rt] [lldb] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante requested changes to this pull request. Mostly LGTM, I like to see it again for a quick look. https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [clang-tools-extra] [flang] [openmp] [llvm] [compiler-rt] [libc] [libcxx] [clang] [lld] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1130,6 +1137,19 @@ using __best_match_t = typename invoke_result_t<_MakeOverloads<_Types...>, _Tp, } // namespace __variant_detail +template < class _Visitor, class... _Vs, typename = void_t()))...> > +_LIBCPP_HIDE_FROM_ABI _LIBCPP_AVAILABILITY_THROW_BAD_VARIANT_ACCESS

[Lldb-commits] [lld] [clang] [llvm] [compiler-rt] [openmp] [lldb] [clang-tools-extra] [flang] [libc] [libcxx] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1130,6 +1137,19 @@ using __best_match_t = typename invoke_result_t<_MakeOverloads<_Types...>, _Tp, } // namespace __variant_detail +template < class _Visitor, class... _Vs, typename = void_t()))...> > mordante wrote: Clang-format needs to be

[Lldb-commits] [compiler-rt] [lld] [libcxx] [openmp] [llvm] [clang-tools-extra] [flang] [clang] [mlir] [libc] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante approved this pull request. Still LGTM! https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [clang] [lld] [libc] [lldb] [llvm] [libcxx] [clang-tools-extra] [compiler-rt] [mlir] [flang] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [clang] [mlir] [llvm] [openmp] [compiler-rt] [libcxx] [lld] [flang] [libc] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -470,4 +470,9 @@ inline Tp const& DoNotOptimize(Tp const& value) { # define TEST_IF_AIX(arg_true, arg_false) arg_false #endif +// Clang-18 has support for deducing this, but it does not set the FTM. +#if defined(__cpp_explicit_this_parameter) ||

[Lldb-commits] [flang] [clang] [mlir] [llvm] [libcxx] [libc] [lld] [lldb] [compiler-rt] [clang-tools-extra] [openmp] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante approved this pull request. Thanks LGTM modulo a few minor comment. https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [compiler-rt] [libc] [flang] [mlir] [libcxx] [lldb] [clang-tools-extra] [openmp] [clang] [llvm] [lld] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lld] [lldb] [flang] [mlir] [llvm] [libcxx] [libc] [openmp] [compiler-rt] [clang-tools-extra] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -7,7 +7,8 @@ // UNSUPPORTED: c++03, c++11, c++14, c++17, c++20, c++23 // UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME -// XFAIL: clang-16 || clang-17 +// The tested functionality needs deducing this. +// UNSUPPORTED: clang-16 || clang-17 || apple-clang mordante

[Lldb-commits] [openmp] [llvm] [mlir] [lldb] [clang] [compiler-rt] [lld] [libc] [libcxx] [flang] [clang-tools-extra] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -1513,6 +1519,11 @@ __sanitizer_verify_double_ended_contiguous_container(const void*, const void*, c #define _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK # endif +// Clang-18 has support for deducing this, but it does not set the FTM. +#if

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

@@ -32,6 +32,106 @@ def test_with_run_command(self): self.expect("frame variable m", substrs=["m = 4321 months"]) self.expect("frame variable y", substrs=["y = 321 years"]) +self.expect( +"frame variable ss_tp", +substrs=["ss_tp

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/78609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

@@ -1073,18 +1073,79 @@ bool lldb_private::formatters::LibcxxWStringViewSummaryProvider( bool success; ValueObjectSP dataobj; size_t size; - std::tie( success, dataobj, size ) = LibcxxExtractStringViewData(valobj); + std::tie(success, dataobj, size) =

[Lldb-commits] [lldb] [lldb][libc++] Adds system_clock data formatters. (PR #78609)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/78609 >From 31a7604f872116521558dcb9f1b4c2c4f5f9d439 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Thu, 18 Jan 2024 19:21:09 +0100 Subject: [PATCH 1/2] [lldb][libc++] Adds system_clock data formatters. ---

[Lldb-commits] [lldb] [polly] [libunwind] [libc] [llvm] [clang-tools-extra] [libcxx] [libcxxabi] [compiler-rt] [openmp] [lld] [flang] [mlir] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [flang] [compiler-rt] [lld] [clang] [polly] [mlir] [libcxx] [clang-tools-extra] [libcxxabi] [lldb] [llvm] [libunwind] [libc] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante requested changes to this pull request. > I did some re-imagining of the tests, there is a some redundancy but it is > cleared that nothing was missed. The tests are formatted in tabular form > manually to make them easier to read. Redundant code in tests when if

[Lldb-commits] [clang] [mlir] [libunwind] [llvm] [libcxx] [lldb] [openmp] [polly] [lld] [libc] [compiler-rt] [clang-tools-extra] [flang] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,172 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [clang-tools-extra] [compiler-rt] [libunwind] [openmp] [lldb] [llvm] [libc] [libcxx] [mlir] [clang] [polly] [libcxxabi] [lld] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,458 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [mlir] [openmp] [llvm] [clang] [libcxx] [libc] [lldb] [clang-tools-extra] [lld] [libunwind] [flang] [polly] [libcxxabi] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,172 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [polly] [clang] [lldb] [libcxx] [clang-tools-extra] [libcxxabi] [libc] [libunwind] [openmp] [lld] [llvm] [mlir] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,458 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Fix printf formatting of std::time_t seconds (PR #81078)

mordante wrote: Thanks for the fix! https://github.com/llvm/llvm-project/pull/81078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

@@ -0,0 +1,140 @@ +//===-- LibCxxValarray.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

@@ -750,6 +750,11 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { lldb_private::formatters::LibcxxStdVectorSyntheticFrontEndCreator, "libc++ std::vector synthetic children", "^std::__[[:alnum:]]+::vector<.+>$",

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

https://github.com/mordante closed https://github.com/llvm/llvm-project/pull/80609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds valarray data formatters. (PR #80609)

https://github.com/mordante updated https://github.com/llvm/llvm-project/pull/80609 >From 661f43e0aa40b29ca8bde6c643ee1f3241ecfb17 Mon Sep 17 00:00:00 2001 From: Mark de Wever Date: Sun, 4 Feb 2024 18:46:50 +0100 Subject: [PATCH] [lldb][libc++] Adds valarray data formatters. The code is

[Lldb-commits] [mlir] [lldb] [openmp] [libc] [llvm] [clang] [flang] [libcxx] [clang-tools-extra] [compiler-rt] [libc++][span] P2821R5: span.at() (PR #74994)

https://github.com/mordante approved this pull request. Thanks for the fixes, LGTM! https://github.com/llvm/llvm-project/pull/74994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [openmp] [llvm] [mlir] [lldb] [libc] [libcxx] [flang] [compiler-rt] [libc++][span] P2821R5: span.at() (PR #74994)

@@ -0,0 +1,170 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang] [clang-tools-extra] [llvm] [libcxx] [libc] [lldb] [flang] [openmp] [mlir] [compiler-rt] [libc++][span] P2821R5: span.at() (PR #74994)

https://github.com/mordante requested changes to this pull request. Mostly looks good, a few comments. https://github.com/llvm/llvm-project/pull/74994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [clang-tools-extra] [mlir] [libcxx] [compiler-rt] [clang] [llvm] [lldb] [openmp] [libc] [flang] [libc++][span] P2821R5: span.at() (PR #74994)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/74994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [clang-tools-extra] [clang] [flang] [mlir] [lldb] [libcxx] [llvm] [openmp] [libc] [libc++][span] P2821R5: span.at() (PR #74994)

mordante wrote: What is this submodule? I assume it's not intended to be here. https://github.com/llvm/llvm-project/pull/74994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [clang] [clang-tools-extra] [llvm] [libcxx] [libc] [lldb] [flang] [openmp] [mlir] [compiler-rt] [libc++][span] P2821R5: span.at() (PR #74994)

@@ -343,6 +347,15 @@ public: return __data_[__idx]; } +# if _LIBCPP_STD_VER >= 26 +_LIBCPP_HIDE_FROM_ABI constexpr reference at(size_type __idx) const { mordante wrote: Nevermind this only applies to non-member functions and classes

[Lldb-commits] [clang] [lld] [compiler-rt] [clang-tools-extra] [llvm] [lldb] [mlir] [libcxx] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [libcxx] [clang] [lld] [clang-tools-extra] [lldb] [mlir] [compiler-rt] [llvm] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

https://github.com/mordante commented: Thanks for your patch! I mainly glossed over the patch, and left some comments. https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lld] [clang] [llvm] [compiler-rt] [clang-tools-extra] [lldb] [libcxx] [mlir] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/66963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [compiler-rt] [lld] [clang] [libcxx] [mlir] [lldb] [llvm] [libc++][ranges] Implement ranges::contains_subrange (PR #66963)

@@ -0,0 +1,145 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang] [libcxx] [flang] [lldb] [mlir] [llvm] [openmp] [clang-tools-extra] [compiler-rt] [libc] [libc++][span] P2821R5: span.at() (PR #74994)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/74994 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [compiler-rt] [flang] [libcxx] [lldb] [libc] [llvm] [openmp] [mlir] [clang-tools-extra] [libc++][span] P2821R5: span.at() (PR #74994)

@@ -0,0 +1,168 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [llvm] [flang] [mlir] [lldb] [libcxx] [compiler-rt] [clang-tools-extra] [libc] [openmp] [clang] [libc++][span] P2821R5: span.at() (PR #74994)

https://github.com/mordante commented: A few more comments, I overlooked parts of them yesterday. Please make sure to apply the suggestions to all similar places in the code. https://github.com/llvm/llvm-project/pull/74994 ___ lldb-commits mailing

[Lldb-commits] [compiler-rt] [llvm] [clang] [flang] [openmp] [libcxx] [mlir] [libc] [lldb] [clang-tools-extra] [libc++][span] P2821R5: span.at() (PR #74994)

@@ -0,0 +1,168 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [llvm] [clang-tools-extra] [libcxx] [flang] [compiler-rt] [libc] [clang] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [clang] [clang-tools-extra] [libcxx] [compiler-rt] [lldb] [llvm] [flang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -69,6 +69,12 @@ namespace std { // 20.7.2.6, swap void swap(variant&) noexcept(see below); + +// [variant.visit], visitation +template + constexpr decltype(auto) visit(this Self&&, Visitor&&); +template + constexpr R visit(this Self&&,

[Lldb-commits] [llvm] [compiler-rt] [libc] [clang] [libcxx] [flang] [clang-tools-extra] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -17,27 +17,28 @@ #include "test_macros.h" struct Incomplete; -template struct Holder { T t; }; mordante wrote: For this file too. https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list

[Lldb-commits] [libc] [llvm] [libcxx] [clang-tools-extra] [flang] [clang] [lldb] [compiler-rt] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -0,0 +1,268 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [llvm] [lldb] [compiler-rt] [clang-tools-extra] [libc] [clang] [libcxx] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -1273,6 +1280,15 @@ public: __impl_.__swap(__that.__impl_); } +# if _LIBCPP_STD_VER >= 26 + // [variant.visit], visitation + template + constexpr decltype(auto) visit(this _Self&& __self, _Visitor&& __visitor); mordante wrote: nowadays we

[Lldb-commits] [flang] [clang] [lldb] [libc] [libcxx] [llvm] [compiler-rt] [clang-tools-extra] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -0,0 +1,268 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [llvm] [clang-tools-extra] [libcxx] [compiler-rt] [libc] [flang] [lldb] [clang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -40,6 +40,8 @@ Paper Status .. note:: .. [#note-P2510R3] This paper is applied as DR against C++20. (MSVC STL and libstdc++ will do the same.) + .. [#note-P2637R3] P2637R3: Implemented `variant` member `visit` mordante wrote: Since we have both

[Lldb-commits] [libcxx] [llvm] [libc] [lldb] [compiler-rt] [clang-tools-extra] [clang] [flang] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -26,7 +26,7 @@ template void test_call_operator_forwarding() { using Fn = ForwardingCallObject; Fn obj{}; - const Fn = obj; mordante wrote: Please undo the formatting changes to this file. It's hard to see what really changed.

[Lldb-commits] [llvm] [clang] [compiler-rt] [clang-tools-extra] [flang] [libc] [libcxx] [lldb] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

https://github.com/mordante requested changes to this pull request. Thanks for working on this! https://github.com/llvm/llvm-project/pull/76447 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [compiler-rt] [clang-tools-extra] [flang] [libc] [lldb] [clang] [llvm] [libcxx] [libc++][variant] P2637R3: Member `visit` (`std::variant`) (PR #76447)

@@ -26,7 +26,7 @@ template void test_call_operator_forwarding() { using Fn = ForwardingCallObject; Fn obj{}; - const Fn = obj; mordante wrote: Thanks! We still need to reformat all our tests like we did with the headers. The main problem with mixing

[Lldb-commits] [compiler-rt] [libc] [mlir] [clang-tools-extra] [lldb] [lld] [openmp] [flang] [clang] [libcxx] [llvm] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

@@ -0,0 +1,97 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [libc] [llvm] [openmp] [mlir] [lldb] [flang] [lld] [clang] [libcxx] [compiler-rt] [clang-tools-extra] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

https://github.com/mordante approved this pull request. Thanks LGTM! https://github.com/llvm/llvm-project/pull/76632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [openmp] [lld] [llvm] [libcxx] [lldb] [clang-tools-extra] [mlir] [flang] [compiler-rt] [libc] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][libc++] Adds some C++20 calendar data formatters. (PR #76983)

https://github.com/mordante created https://github.com/llvm/llvm-project/pull/76983 This adds a subset of the C++20 calendar data formatters: - day, - month, - year, - month_day, - month_day_last, and - year_month_day. A followup patch will add the missing calendar data formatters: - weekday,

[Lldb-commits] [lldb] [lldb][libc++] Adds some C++20 calendar data formatters. (PR #76983)

mordante wrote: Note: I'd be happy to add the missing calendar data formatters to this review. I just want to make sure we're happy with the proposed output before adding them. https://github.com/llvm/llvm-project/pull/76983 ___ lldb-commits mailing

[Lldb-commits] [openmp] [clang-tools-extra] [flang] [mlir] [llvm] [lld] [compiler-rt] [libc] [lldb] [clang] [libcxx] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

mordante wrote: > > I did a full review. There are a number of comments, once these are > > addressed the patch is ready. > > Thank you for the detailed review and patience! > > I believe the failing tests are unrelated to this patch: > > > Failed Tests (2): > >

[Lldb-commits] [lld] [llvm] [openmp] [clang-tools-extra] [flang] [libcxx] [compiler-rt] [mlir] [lldb] [clang] [libc] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

@@ -0,0 +1,101 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang-tools-extra] [clang] [llvm] [mlir] [libc] [libcxx] [flang] [openmp] [lldb] [compiler-rt] [lld] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

@@ -0,0 +1,58 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [mlir] [openmp] [lldb] [libc] [compiler-rt] [libcxx] [llvm] [lld] [clang-tools-extra] [flang] [clang] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

@@ -0,0 +1,30 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [libcxx] [lld] [llvm] [openmp] [libc] [lldb] [mlir] [compiler-rt] [flang] [clang] [clang-tools-extra] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

@@ -24,6 +24,10 @@ #include "test_macros.h" +#if _LIBCPP_STD_VER >= 26 mordante wrote: This is the way to test for versions in the test suite. ```suggestion #if TEST_STD_VER >= 26 ``` The same for other places. Also since we can no longer use

[Lldb-commits] [flang] [clang] [openmp] [libcxx] [lld] [lldb] [clang-tools-extra] [llvm] [mlir] [compiler-rt] [libc] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

https://github.com/mordante requested changes to this pull request. LGTM modulo some nits. I like to have a quick look at the final version before approving. https://github.com/llvm/llvm-project/pull/76632 ___ lldb-commits mailing list

[Lldb-commits] [openmp] [clang-tools-extra] [flang] [mlir] [llvm] [lld] [compiler-rt] [libc] [lldb] [clang] [libcxx] [libc++][streams] P1759R6: Native handles and file streams (PR #76632)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [libcxx] [mlir] [clang-tools-extra] [compiler-rt] [lld] [flang] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[Lldb-commits] [clang] [libcxx] [mlir] [llvm] [lld] [compiler-rt] [clang-tools-extra] [flang] [lldb] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[Lldb-commits] [libc] [lldb] [libunwind] [libcxx] [clang-tools-extra] [libcxxabi] [llvm] [compiler-rt] [lld] [clang] [flang] [mlir] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[Lldb-commits] [libc] [llvm] [lld] [flang] [libcxx] [libunwind] [mlir] [clang] [compiler-rt] [lldb] [libcxxabi] [clang-tools-extra] [libc++][numeric] P0543R3: Saturation arithmetic (PR #77967)

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[Lldb-commits] [clang-tools-extra] [clang] [lldb] [polly] [libcxx] [llvm] [mlir] [compiler-rt] [libunwind] [libc] [libcxxabi] [flang] [libc++][any] LWG3305: `any_cast` (PR #78215)

mordante wrote: > > I see you implemented this code only for C++26. In general we retroactively > > apply LWG issues to all previous standard versions. Is there a reason why > > you only applied this to C++26? > > I am not familiar with this process. I'm happy to do what's needed to be >

[Lldb-commits] [clang-tools-extra] [lldb] [libc] [llvm] [clang] [libcxxabi] [libunwind] [libcxx] [flang] [compiler-rt] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

https://github.com/mordante approved this pull request. > Thanks. The documentation build fails due to some CMake error consistently > otherwise I believe I addressed all comments. I think I fixed this a few days ago. LGTM modulo 1 nit. https://github.com/llvm/llvm-project/pull/78157

[Lldb-commits] [libunwind] [libcxxabi] [llvm] [flang] [libc] [libcxx] [lldb] [clang] [clang-tools-extra] [compiler-rt] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/78157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libc] [compiler-rt] [libcxxabi] [lldb] [llvm] [clang] [flang] [clang-tools-extra] [libunwind] [libcxx] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang] [llvm] [libcxx] [flang] [lldb] [libcxxabi] [libunwind] [compiler-rt] [libc] [clang-tools-extra] [libc++][span] P2447R4: `std::span` over an initializer list (PR #78157)

@@ -5,39 +5,134 @@ // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===--===// + // UNSUPPORTED: c++03, c++11, c++14, c++17 // -#include +// constexpr explicit(extent != dynamic_extent)

[Lldb-commits] [clang-tools-extra] [libcxxabi] [lld] [clang] [libc] [libcxx] [lldb] [polly] [libunwind] [flang] [openmp] [mlir] [llvm] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,157 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang-tools-extra] [libcxxabi] [mlir] [clang] [polly] [openmp] [lldb] [flang] [libunwind] [compiler-rt] [libc] [llvm] [lld] [libcxx] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,281 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [mlir] [lld] [openmp] [polly] [flang] [llvm] [lldb] [clang] [clang-tools-extra] [libcxxabi] [libc] [libunwind] [compiler-rt] [libcxx] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,267 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang-tools-extra] [lld] [libcxxabi] [lldb] [libunwind] [llvm] [libcxx] [openmp] [libc] [clang] [mlir] [flang] [polly] [compiler-rt] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,267 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lld] [lldb] [polly] [flang] [llvm] [libunwind] [mlir] [clang-tools-extra] [libc] [openmp] [libcxxabi] [clang] [compiler-rt] [libcxx] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,76 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang-tools-extra] [lldb] [compiler-rt] [mlir] [libcxx] [openmp] [llvm] [libcxxabi] [lld] [clang] [libc] [libunwind] [polly] [flang] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,75 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [libc] [polly] [openmp] [clang-tools-extra] [compiler-rt] [libunwind] [flang] [lldb] [clang] [libcxx] [mlir] [lld] [llvm] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [llvm] [libcxx] [libunwind] [lld] [clang] [mlir] [libc] [clang-tools-extra] [compiler-rt] [lldb] [libcxxabi] [openmp] [polly] [libc++][numeric] P0543R3: Saturation arithmetic (P

https://github.com/mordante requested changes to this pull request. Thanks I think this is getting close, I would like to see it again after addressing the comments. https://github.com/llvm/llvm-project/pull/77967 ___ lldb-commits mailing list

[Lldb-commits] [libunwind] [flang] [mlir] [openmp] [clang-tools-extra] [lldb] [polly] [compiler-rt] [clang] [lld] [llvm] [libcxx] [libc] [libcxxabi] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,281 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [clang] [llvm] [mlir] [libc] [openmp] [libcxx] [polly] [compiler-rt] [lldb] [flang] [clang-tools-extra] [libunwind] [libcxxabi] [lld] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,267 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [libcxxabi] [clang-tools-extra] [libunwind] [openmp] [lldb] [mlir] [flang] [libcxx] [lld] [libc] [compiler-rt] [polly] [llvm] [clang] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,119 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[Lldb-commits] [polly] [clang-tools-extra] [libc] [libcxxabi] [lld] [libunwind] [flang] [mlir] [llvm] [compiler-rt] [libcxx] [clang] [openmp] [lldb] [libc++][numeric] P0543R3: Saturation arithmetic (P

@@ -0,0 +1,281 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [flang] [lld] [compiler-rt] [clang] [clang-tools-extra] [mlir] [libcxx] [libc] [llvm] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante edited https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [mlir] [lldb] [libc] [clang] [flang] [compiler-rt] [clang-tools-extra] [lld] [llvm] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

https://github.com/mordante requested changes to this pull request. In general this looks good. I'd like to have another look after addressing the comments. https://github.com/llvm/llvm-project/pull/76449 ___ lldb-commits mailing list

[Lldb-commits] [compiler-rt] [lldb] [libc] [clang-tools-extra] [mlir] [llvm] [clang] [flang] [lld] [libcxx] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -19,19 +19,25 @@ #include "test_macros.h" #include "make_string.h" +#if _LIBCPP_STD_VER >= 26 +TEST_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations") +#endif + template void test(From value) { auto store = std::make_format_args(value); const

[Lldb-commits] [libcxx] [clang-tools-extra] [mlir] [clang] [libc] [llvm] [flang] [lld] [compiler-rt] [lldb] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -19,19 +19,25 @@ #include "test_macros.h" #include "make_string.h" +#if _LIBCPP_STD_VER >= 26 +TEST_CLANG_DIAGNOSTIC_IGNORED("-Wdeprecated-declarations") +#endif + template void test(From value) { auto store = std::make_format_args(value); const

[Lldb-commits] [lld] [libc] [llvm] [libcxx] [clang-tools-extra] [lldb] [clang] [mlir] [compiler-rt] [flang] [libc++][format] P2637R3: Member `visit` (`std::basic_format_arg`) (PR #76449)

@@ -267,7 +366,8 @@ class _LIBCPP_TEMPLATE_VIS basic_format_arg<_Context>::handle { // This function is user facing, so it must wrap the non-standard types of // the "variant" in a handle to stay conforming. See __arg_t for more details. template -_LIBCPP_HIDE_FROM_ABI

  1   2   >