[Lldb-commits] [PATCH] D67895: [LLDB] Avoid a warning about an unused static variable

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. The variable is unused on windows. Repository: rLLDB LLDB https://reviews.llvm.org/D67895 Files:

[Lldb-commits] [PATCH] D67894: [LLDB] Rework a MinGW build fix from D65691

mstorsjo created this revision. mstorsjo added a reviewer: hhb. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. That change didn't contain any explanation for this bit. There shouldn't be any need for a check for MinGW ifdefs here, as long as the include uses

[Lldb-commits] [PATCH] D67893: [LLDB] Check for _WIN32 instead of _MSC_VER for code specific to windows in general

mstorsjo created this revision. mstorsjo added reviewers: hhb, compnerd, amccarth. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. These ifdefs contain code that isn't specific to MSVC but useful for any windows target, like MinGW. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D67892: [LLDB] Fix typo in RegisterContextDarwin_arm64

mstorsjo created this revision. mstorsjo added reviewers: jasonmolenda, jingham. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: LLDB. In these cases, the register number should be calculated from `fpu_d0`, not `fpu_s0`. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo added a comment. @hhb - This is the only change left for builds of lldb on mingw to succeed for me (for x86), but I have a whole bunch of more changes lined up that fix warnings and other issues I've found. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo abandoned this revision. mstorsjo added a comment. D67887 was committed with the same change. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67857/new/ https://reviews.llvm.org/D67857

[Lldb-commits] [PATCH] D67887: Use _WIN32 instead of _MSC_VER

mstorsjo added a comment. Just FTR, this was identical to D67857 that I posted a few days ago. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67887/new/ https://reviews.llvm.org/D67887

[Lldb-commits] [PATCH] D67885: [LLDB] Add a missing specification of linking against dbghelp

mstorsjo created this revision. mstorsjo added reviewers: amccarth, compnerd, hhb. Herald added subscribers: JDevlieghere, abidh, mgorny. Herald added a project: LLDB. The PECOFF object file plugin uses the dbghelp API, but doesn't specify that it has to be linked in anywhere. Current MSVC

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372486: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL372485: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL372484: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

This revision was automatically updated to reflect the committed changes. Closed by commit rL372482: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

This revision was automatically updated to reflect the committed changes. Closed by commit rL372483: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition… (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo updated this revision to Diff 221122. mstorsjo added a comment. Use static_cast. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67863/new/ https://reviews.llvm.org/D67863 Files: lldb/source/Host/common/Socket.cpp lldb/tools/lldb-vscode/lldb-vscode.cpp Index:

[Lldb-commits] [PATCH] D67863: [LLDB] Cast -1 (as invalid socket) to the socket type before comparing

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, compnerd. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This silences warnings about comparison of integers between unsigned long long (which is what the Windows SOCKET type is) and signed int

[Lldb-commits] [PATCH] D67862: [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style format strings

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath, compnerd. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. SetErrorStringWithFormat only supports normal printf style format strings. Repository: rLLDB LLDB https://reviews.llvm.org/D67862

[Lldb-commits] [PATCH] D67861: [LLDB] Check for the __MINGW32__ define instead of __MINGW64

mstorsjo created this revision. mstorsjo added reviewers: hhb, xen2, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. `__MINGW64__` is only defined for 64 bit targets, and the define without trailing underscores is never defined automatically (neither by clang

[Lldb-commits] [PATCH] D67860: [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment

mstorsjo created this revision. mstorsjo added reviewers: asmith, hhb, labath. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes a warning when built with Clang instead of MSVC. Repository: rLLDB LLDB https://reviews.llvm.org/D67860 Files:

[Lldb-commits] [PATCH] D67859: [LLDB] Use the Windows SOCKET type on all windows targets, not only MSVC

mstorsjo created this revision. mstorsjo added reviewers: hhb, labath, amccarth. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. Repository: rLLDB LLDB https://reviews.llvm.org/D67859 Files: lldb/include/lldb/Host/Socket.h Index: lldb/include/lldb/Host/Socket.h

[Lldb-commits] [PATCH] D67858: [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in addition to MSVC defines

mstorsjo created this revision. mstorsjo added reviewers: compnerd, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This matches how it is done in all other similar ifdefs throughout lldb (modulo inconsistencies between `_M_AMD64` and `_M_X64`); both

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo added a comment. In D67856#1677356 , @davide wrote: > If this doesn't break clang and gcc, fine. FWIW, it was with clang that I ran into it, haven't tested building lldb with gcc. But the issue can be tested with a snippet like this: class

[Lldb-commits] [PATCH] D67857: [LLDB] Include lldb/Host/windows/windows.h on any windows target

mstorsjo created this revision. mstorsjo added reviewers: lanza, hhb, labath. Herald added subscribers: JDevlieghere, abidh. Herald added a project: LLDB. This fixes MinGW builds, that otherwise fail due to use of undeclared `GetLastError()` and `ERROR_OPERATION_ABORTED`. The use of

[Lldb-commits] [PATCH] D67856: [LLDB] Fix compilation for MinGW, remove redundant class name on inline member

mstorsjo created this revision. mstorsjo added reviewers: asmith, labath, hhb. Herald added a subscriber: JDevlieghere. Herald added a project: LLDB. This fixes build errors like these: NativeRegisterContextWindows.h:22:33: error: extra qualification on member 'NativeRegisterContextWindows'

[Lldb-commits] [PATCH] D65691: Various build fixes for lldb on MinGW

mstorsjo added a reviewer: zturner. mstorsjo added a comment. As context (I haven't followed lldb almost at all), what's the general status of lldb on windows - generally working, or still a work in progress? Does it work with dwarf debug info in COFF (as commonly used in mingw environments),

<    1   2   3   4   5