[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

[Michael Forster via Phabricator via lldb-commits]

MForster added a comment.

> The backtrace is pretty much useless

Yes, sorry, that's all I had. Just added some evidence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120284/new/

https://reviews.llvm.org/D120284

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

[Michael Forster via Phabricator via lldb-commits]

MForster added a comment.

This fails under MSAN:

  ==3096==WARNING: MemorySanitizer: use-of-uninitialized-value
  #0 0x7f0e7899ce18  
(/build/work/73ffa3b6f1cbc2218b7b71e21a3dd1e2e53b/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/@0x3a0b9000+0x2e3e18)
 (BuildId: 4c3940d9ff00226e685dcfb93f4b4753)
  #1 0x7f0e7898fcc8  
(/build/work/73ffa3b6f1cbc2218b7b71e21a3dd1e2e53b/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/@0x3a0b9000+0x2d6cc8)
 (BuildId: 4c3940d9ff00226e685dcfb93f4b4753)
  #2 0x7f0e78973001  
(/build/work/73ffa3b6f1cbc2218b7b71e21a3dd1e2e53b/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/@0x3a0b9000+0x2ba001)
 (BuildId: 4c3940d9ff00226e685dcfb93f4b4753)
  #3 0x7f0e78cd1f10  
(/build/work/73ffa3b6f1cbc2218b7b71e21a3dd1e2e53b/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/@0x3a0b9000+0x618f10)
 (BuildId: 4c3940d9ff00226e685dcfb93f4b4753)
  #4 0x558eaf3ecc70 in cfunction_call_varargs 
third_party/python_runtime/v3_7/Objects/call.c:770:18
  #5 0x558eaf3ecc70 in PyCFunction_Call 
third_party/python_runtime/v3_7/Objects/call.c:786:16
  #6 0x558eaf685ff8 in do_call_core 
third_party/python_runtime/v3_7/Python/ceval.c:4641:9
  #7 0x558eaf685ff8 in _PyEval_EvalFrameDefault 
third_party/python_runtime/v3_7/Python/ceval.c:3191:22
  #8 0x558eaf6a0691 in PyEval_EvalFrameEx 
third_party/python_runtime/v3_7/Python/ceval.c:547:12
  #9 0x558eaf6a0691 in _PyEval_EvalCodeWithName 
third_party/python_runtime/v3_7/Python/ceval.c:3930:14
  #10 0x558eaf3ebaa3 in _PyFunction_FastCallKeywords 
third_party/python_runtime/v3_7/Objects/call.c:433:12
  #11 0x558eaf69db2d in call_function 
third_party/python_runtime/v3_7/Python/ceval.c:4616:17
  #12 0x558eaf685844 in _PyEval_EvalFrameDefault 
third_party/python_runtime/v3_7/Python/ceval.c:3093:23
  #13 0x558eaf67d594 in PyEval_EvalFrameEx 
third_party/python_runtime/v3_7/Python/ceval.c:547:12
  #14 0x558eaf3ed230 in function_code_fastcall 
third_party/python_runtime/v3_7/Objects/call.c:283:14
  #15 0x558eaf3ea160 in _PyFunction_FastCallDict 
third_party/python_runtime/v3_7/Objects/call.c
  #16 0x558eaf3e99a4 in _PyObject_FastCallDict 
third_party/python_runtime/v3_7/Objects/call.c:98:16
  #17 0x558eaf3ef739 in _PyObject_Call_Prepend 
third_party/python_runtime/v3_7/Objects/call.c:906:14
  #18 0x558eaf3f462b in method_call 
third_party/python_runtime/v3_7/Objects/classobject.c:309:12
  #19 0x558eaf3ec51d in PyObject_Call 
third_party/python_runtime/v3_7/Objects/call.c:245:18
  #20 0x558eaf685d63 in do_call_core 
third_party/python_runtime/v3_7/Python/ceval.c:4645:16
  #21 0x558eaf685d63 in _PyEval_EvalFrameDefault 
third_party/python_runtime/v3_7/Python/ceval.c:3191:22
  #22 0x558eaf67d594 in PyEval_EvalFrameEx 
third_party/python_runtime/v3_7/Python/ceval.c:547:12
  #23 0x558eaf3ed230 in function_code_fastcall 
third_party/python_runtime/v3_7/Objects/call.c:283:14
  #24 0x558eaf3ebb23 in _PyFunction_FastCallKeywords 
third_party/python_runtime/v3_7/Objects/call.c
  #25 0x558eaf69db2d in call_function 
third_party/python_runtime/v3_7/Python/ceval.c:4616:17
  #26 0x558eaf685808 in _PyEval_EvalFrameDefault 
third_party/python_runtime/v3_7/Python/ceval.c:3110:23
  #27 0x558eaf67d594 in PyEval_EvalFrameEx 
third_party/python_runtime/v3_7/Python/ceval.c:547:12
  #28 0x558eaf3ed230 in function_code_fastcall 
third_party/python_runtime/v3_7/Objects/call.c:283:14
  #29 0x558eaf3ebb23 in _PyFunction_FastCallKeywords 
third_party/python_runtime/v3_7/Objects/call.c
  #30 0x558eaf69db2d in call_function 
third_party/python_runtime/v3_7/Python/ceval.c:4616:17
  #31 0x558eaf685808 in _PyEval_EvalFrameDefault 
third_party/python_runtime/v3_7/Python/ceval.c:3110:23
  #32 0x558eaf67d594 in PyEval_EvalFrameEx 
third_party/python_runtime/v3_7/Python/ceval.c:547:12
  #33 0x558eaf3ed230 in function_code_fastcall 
third_party/python_runtime/v3_7/Objects/call.c:283:14
  #34 0x558eaf3ea160 in _PyFunction_FastCallDict 
third_party/python_runtime/v3_7/Objects/call.c
  #35 0x558eaf3e99a4 in _PyObject_FastCallDict 
third_party/python_runtime/v3_7/Objects/call.c:98:16
  #36 0x558eaf3ef739 in _PyObject_Call_Prepend 
third_party/python_runtime/v3_7/Objects/call.c:906:14
  #37 0x558eaf3f462b in method_call 
third_party/python_runtime/v3_7/Objects/classobject.c:309:12
  #38 0x558eaf3ec51d in PyObject_Call 
third_party/python_runtime/v3_7/Objects/call.c:245:18
  #39 0x558eaecfdc9a in t_bootstrap 
third_party/python_runtime/v3_7/Modules/_threadmodule.c:994:11
  #40 0x558eaf77ac94 in pythread_wrapper 
third_party/python_runtime/v3_7/Python/thread_pthread.h:174:5
  #41 0x7f0e7bf0eb54 in start_thread 
(/usr/grte/v5/lib64/libpthread.so.0+0xbb54) (BuildId: 
64752de50ebd1a108f4b3f8d0d7e1a13)
  #42 0x7f0e7be43f7e in clone (/usr/grte/v5/lib64/libc.so.6+0x13cf7e) 
(BuildId: 

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

[Michael Forster via Phabricator via lldb-commits]

MForster added a comment.

Reverts of a few follow-up changes were necessary as well:

- 79fcd35c688b94becadd162a6c37e9b95df5c084 

- 23f29b2fcc5668c51f15809067a1c3503b422c64 

- f67f9e86e86e68d4cbc05ef8d6ffd0cb33246d45 

- 0f1195a58648998d21bcfa1575a78a4706eaa52c 

- 8214eff467f583309e9fbb971862d3c1cdcc65e4 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80150/new/

https://reviews.llvm.org/D80150



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

[Michael Forster via Phabricator via lldb-commits]

MForster added subscribers: gribozavr2, MForster.
MForster added a comment.

In D80150#2045632 , @omjavaid wrote:

> This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot.
>
> http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697


It also breaks our internal build bots with an "Illegal instruction". Here is 
the stacktrace:

  0  libsupport.so0x7f8c5f6d87ba 
llvm::sys::PrintStackTrace(llvm::raw_ostream&) + 58
  1  libsupport.so0x7f8c5f6d8c79
  2  libsupport.so0x7f8c5f6d71bb 
llvm::sys::RunSignalHandlers() + 123
  3  libsupport.so0x7f8c5f6d92fb
  4  libpthread.so.00x7f8c5e7509a0
  5  libcore.so   0x7f8c764820b1 
lldb_private::formatters::NSDate::FormatDateValue(double, 
lldb_private::Stream&) + 129
  6  unittests_Sliblanguage_Utests.so 0x7f8c771c29b5
  7  unittests_Sliblanguage_Utests.so 0x7f8c771c24d8 
DataFormatterMockTest_NSDate_Test::TestBody() + 248
  8  libgtest.so  0x7f8c5f85ce44 void 
testing::internal::HandleSehExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*) + 132
  9  libgtest.so  0x7f8c5f84b532 void 
testing::internal::HandleExceptionsInMethodIfSupported(testing::Test*, void (testing::Test::*)(), char const*) + 114
  10 libgtest.so  0x7f8c5f840866 
testing::Test::Run() + 182
  11 libgtest.so  0x7f8c5f840eb5 
testing::TestInfo::Run() + 213
  12 libgtest.so  0x7f8c5f8413e4 
testing::TestCase::Run() + 228
  13 libgtest.so  0x7f8c5f8461db 
testing::internal::UnitTestImpl::RunAllTests() + 731
  14 libgtest.so  0x7f8c5f861a24 bool 
testing::internal::HandleSehExceptionsInMethodIfSupported(testing::internal::UnitTestImpl*, bool 
(testing::internal::UnitTestImpl::*)(), char const*) + 132
  15 libgtest.so  0x7f8c5f84cf42 bool 
testing::internal::HandleExceptionsInMethodIfSupported(testing::internal::UnitTestImpl*, bool 
(testing::internal::UnitTestImpl::*)(), char const*) + 114
  16 libgtest.so  0x7f8c5f845eda 
testing::UnitTest::Run() + 186
  17 libgtest_Umain.so0x7f8c5f8b7ce1 
RUN_ALL_TESTS() + 17
  18 libgtest_Umain.so0x7f8c5f8b7c6a main + 186
  19 libc.so.6  0x7f8c5e5bebbd 
__libc_start_main + 253
  20 language_tests 0x556b0f40dd09
  Illegal instruction

@gribozavr2 is preparing a revert of this commit and the two follow-up changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80150/new/

https://reviews.llvm.org/D80150



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

[Michael Forster via Phabricator via lldb-commits]

MForster added a subscriber: echristo.
MForster added inline comments.



Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:797
+
+  if (date_value > std::numeric_limits::max() ||
+  date_value < std::numeric_limits::min())

This is the line where the "Illegal instruction" happens. Actually [[ 
https://github.com/llvm/llvm-project/blob/82dbf4aca84ec889d0dc390674ff44e30441bcfd/lldb/source/Plugins/Language/ObjC/Cocoa.cpp#L797
 | here ]], exactly (as there has been a follow-up change by @echristo) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80150/new/

https://reviews.llvm.org/D80150



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits