[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thakis added a comment. aprantl might be a good reviewer for this. The motivation here is that we set `_LIBCPP_ABI_VERSION` for chromium, which then confuses lldb. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

thakis added a comment. labath, was that an lg? :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. echristo's comments on the mail thread for this didn't make it to phab. I apologize for repeating more or less everything he said, I had looked on phab before reading email. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. This breaking both debug info in thinlto builds and fmodules-debuginfo is probably enough to revert and go back to the drawing board. I suppose we don't have any debug info quality tests that use thinlto? Repository: rL LLVM CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. For posterity, https://bugs.chromium.org/p/chromium/issues/detail?id=960881#c31 has the explanation for what exactly was happening in the Chromium/Android build. It's a bit different from rnk's example since no cross-TU imports are happening. It likely explains why rnk

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. Add a test that fails without the code change and that passes with it. I don't know under which conditions this change is needed, so I apologize that I can't make a more concrete suggestion. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. That problem only seems to happen when (thin) lto is enabled. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54747/new/ https://reviews.llvm.org/D54747 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

thakis added a comment. Hello, in a bit of a https://xkcd.com/1172/ moment this breaks the chromium/android build. We have a list of "resources" (strings, bitmaps, etc) that we list in an XML file which then generates a header with lots of "IDR_foo" constants. As it turns out, now all of these

[Lldb-commits] [PATCH] D55376: Generate LLDB website/documentation from rst with Sphinx

thakis added a comment. Herald added a subscriber: ormris. This (I'm guessing) broke https://lldb.llvm.org/lldb-gdb.html which is still present in many search indices. Could we make that page redirect to whatever is the new replacement? (https://www.w3.org/Provider/Style/URI etc) Repository:

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added a comment. test? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60963/new/ https://reviews.llvm.org/D60963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D60963: Fix dereferencing null pointer

thakis added inline comments. Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:737 TagTypeNode *Demangler::parseTagUniqueName(StringView ) { + if (!MangledName.consumeFront(".?A")) { kwk wrote: > Why not change the return type to `llvm::Expected`? Then

[Lldb-commits] [PATCH] D65534: [clang] Change FileManager to use llvm::ErrorOr instead of null on failure

thakis added a comment. Nice! This makes https://bugs.llvm.org/show_bug.cgi?id=42524#c3 easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65534/new/ https://reviews.llvm.org/D65534 ___

[Lldb-commits] [PATCH] D68134: [LLDB] Use the llvm microsoft demangler instead of the windows dbghelp api

thakis added a comment. We can add flags for omitting access specifiers etc if it's critical for lldb. Or maybe we can just change the test that caused the revert. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68134/new/ https://reviews.llvm.org/D68134

[Lldb-commits] [PATCH] D65677: [VirtualFileSystem] Make the RedirectingFileSystem hold on to its own working directory.

thakis added a comment. This fails on Windows: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-win-fast/builds/5779/steps/test-check-llvm-unit-check-clang-unit/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65677/new/

[Lldb-commits] [PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

thakis added a comment. There's still one failing test on Windows after the fix attempt: http://45.33.8.238/win/3052/step_6.txt Please take a look and revert if it's not an easy fix. (And please watch bots after committing stuff.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

thakis added a comment. A very late follow-up to my question in D37272 :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72855/new/ https://reviews.llvm.org/D72855 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

thakis created this revision. thakis added a reviewer: rnk. Herald added a subscriber: mgorny. Herald added a project: LLVM. thakis added a comment. A very late follow-up to my question in D37272 :) When LLVM_APPEND_VC_REV=OFF is set, the current git hash is

[Lldb-commits] [PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. This makes clang crash, repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c4 I'll revert for now. I'm also seeing timeouts and use-after-frees on other bots; maybe they're related (or maybe not). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

thakis added a comment. Reduced repro at https://bugs.chromium.org/p/chromium/issues/detail?id=1061533#c7 Scrolling up, it looks like this was reverted yesterday already. I'm confused why this wasn't reverted yesterday; all work I did in bisecting and creducing was a duplicate of what

[Lldb-commits] [PATCH] D80173: Give microsoftDemangle() an outparam for how many input bytes were consumed.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbc1c3655bfd6: Give microsoftDemangle() an outparam for how many input bytes were consumed. (authored by thakis). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

thakis added inline comments. Comment at: lldb/lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# RUN: %build %p/Inputs/dummy-target.c -o %t.out +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' Did you mean to

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

thakis added a comment. In both gcc and clang, -Wmisleading-indentation is part of -Wall as far as I can tell: https://godbolt.org/z/Msaz6Kb6T In which build configuration does this change have an effect? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

thakis added a comment. In D102092#2771746 , @kastiglione wrote: > @thakis thanks for pointing that out. I had tried `-Wall` using the clang > included with the latest version of Xcode, and that does not enable > `-Wmisleading-indentation`. I see from

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

thakis added a comment. The new tests here fall for me on macOS: [4303/4304] Running lldb shell test suite llvm-lit: /Users/thakis/src/llvm-project/lldb/test/Shell/helper/toolchain.py:126: note: using SDKROOT: '/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk' llvm-lit:

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis added a comment. (Please watch http://45.33.8.238/ when landing this :) ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109463/new/ https://reviews.llvm.org/D109463 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Very cool. LG with top-level BUILD.gn comment addressed :) Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test",

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

thakis added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109464/new/ https://reviews.llvm.org/D109464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", pcc wrote: > thakis wrote: > > Does this build fine on windows? > > > > Generally this only depends on the test targets which in

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

thakis added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", pcc wrote: > thakis wrote: > > pcc wrote: > > > thakis wrote: > > > > Does this build fine on windows? > > > > > > > > Generally

[Lldb-commits] [PATCH] D109185: [gn build] Add build files for LLDB

thakis added a comment. In D109185#2988837 , @teemperor wrote: > Thanks! Out of curiosity, is there a public GN bot that is testing this? The GN bots at http://45.33.8.238/ do the compile step. They don't yet run lldb tests. Maybe I'll add that, but

[Lldb-commits] [PATCH] D109832: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash

thakis created this revision. thakis added a reviewer: amccarth. Herald added a subscriber: pengfei. thakis requested review of this revision. lit.util.which('link') picks up the wrong link.exe in git bash, leading to this error: 1. command stderr: /usr/bin/link: extra operand

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis created this revision. thakis added a reviewer: amccarth. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Before this change, running check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO would fail ~25 tests. This change adds a lit

[Lldb-commits] [PATCH] D109185: [gn build] Add build files for LLDB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe02847496b: [gn build] Add build files for LLDB (authored by thakis). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D109367: [lldb] Alphabetize some CMake files a bit better

This revision was automatically updated to reflect the committed changes. Closed by commit rGea04bf302cf8: [lldb] Alphabetize some CMake files a bit better (authored by thakis). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis added a comment. In D109834#3003250 , @labath wrote: > I fear this is going to be an endless whack-a-mole. There's no way every > contributor will remember to (correctly) add this feature. I think that's ok. 10/250 shell tests need it and there

[Lldb-commits] [PATCH] D109832: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash

This revision was automatically updated to reflect the committed changes. Closed by commit rG99ece01a0f57: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107255: [lldb] Get rid of HAVE_SIGACTION

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG82dc463bb356: [lldb] Get rid of HAVE_SIGACTION (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

thakis updated this revision to Diff 363685. thakis added a comment. Remove Config.h include from driver/Platform.h. Platform.h only gets included in 5 files, and I checked that none of those need Config.h. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

thakis created this revision. thakis added a reviewer: JDevlieghere. thakis added a project: LLDB. Herald added a subscriber: mgorny. thakis requested review of this revision. LLVM includes this header unconditionally on all platforms (including Windows), so this define should no longer be

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

thakis added a comment. In LLVM, this was removed in 37f69de11b8c1810e29851430da317db5c1350a9. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/ https://reviews.llvm.org/D107338 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

thakis created this revision. thakis added a reviewer: JDevlieghere. thakis added a project: LLDB. Herald added subscribers: arphaman, mgorny. thakis requested review of this revision. The comment was originally added in 34769d80d. Then D44526 removed the flag

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

This revision was automatically updated to reflect the committed changes. Closed by commit rGe71fdc1acf05: [lldb] Stop referencing host_lib in cmake files (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107446/new/

[Lldb-commits] [PATCH] D107444: [lldb] Remove a few unused .exports files

This revision was automatically updated to reflect the committed changes. Closed by commit rG11565320fd55: [lldb] Remove a few unused .exports files (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107444/new/

[Lldb-commits] [PATCH] D107255: [lldb] Get rid of HAVE_SIGACTION

thakis created this revision. thakis added a reviewer: JDevlieghere. thakis added a project: LLDB. Herald added a subscriber: mgorny. thakis requested review of this revision. The .cpp file uses SIGNAL_POLLING_UNSUPPORTED to guard the call to sigaction, so use it in the .h file too. (LLVM also

[Lldb-commits] [PATCH] D107446: [lldb] Stop referencing "host_lib" in cmake files

thakis created this revision. thakis added reviewers: teemperor, JDevlieghere. thakis added a project: LLDB. Herald added a subscriber: mgorny. thakis requested review of this revision. lldb/tools/driver/CMakeLists.txt used to set host_lib to something until https://reviews.llvm.org/rG7b968969db

[Lldb-commits] [PATCH] D107444: [lldb] Remove a few unused .exports files

thakis created this revision. thakis added reviewers: teemperor, JDevlieghere. thakis added a project: LLDB. thakis requested review of this revision. They used to be referenced from the .xcodeproj files, but those are long gone. No behavior change. https://reviews.llvm.org/D107444 Files:

[Lldb-commits] [PATCH] D107341: [lldb] Move comment about noindex next to line it refers to

This revision was automatically updated to reflect the committed changes. Closed by commit rG4367cbab4cf2: [lldb] Move comment about noindex next to line it refers to (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107341/new/

[Lldb-commits] [PATCH] D107338: [lldb] Get rid of HAVE_SYS_TYPES_H

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf3383501fef: [lldb] Get rid of HAVE_SYS_TYPES_H (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107338/new/

[Lldb-commits] [PATCH] D111816: [lldb] Remove logging from Platform::~Platform

thakis added a comment. http://45.33.8.238/mac/37050/step_4.txt In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9: In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h:12: In file included from

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

thakis added a comment. I don't have an opinion on this change and I don't mind the demangler change, but isn't the type information helpful? The mangled itanium name doesn't include type information which is why it's not printed, but the mangled ms name does include it. But as I said, I

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis added a comment. Oh, that's a good idea. But even if I force on the native PDB reader if LLVM_ENABLE_DIA_SDK is false [1], I still get 15 failures. That's better than 27, but it's more than 0. Maybe LLDB_USE_NATIVE_PDB_READER doesn't hit all uses of DIA in lldb? Failed Tests (15):

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

thakis created this revision. thakis added reviewers: labath, amccarth. thakis added a project: LLDB. Herald added a subscriber: JDevlieghere. thakis requested review of this revision. Trying to use the DIA SDK reader only to fail with "DIA SDK wasn't enabled" isn't very useful. The native PDB

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis added a comment. Well, it's a start, so let's land that part (D110172 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109834/new/ https://reviews.llvm.org/D109834 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

thakis updated this revision to Diff 373910. thakis added a comment. slightly nicer preprocessor goop in more correct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110172/new/ https://reviews.llvm.org/D110172 Files: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Index:

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

thakis updated this revision to Diff 373909. thakis added a comment. slightly simpler preprocessor goop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110172/new/ https://reviews.llvm.org/D110172 Files: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Index:

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

This revision was automatically updated to reflect the committed changes. Closed by commit rG908c11544212: [lldb/win] Default to native PDB reader when LLVM_ENABLE_DIA_SDK=NO (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp:397 + +error.SetErrorStringWithFormat("LoadLibrary Error: %lu", error_code); +return LLDB_INVALID_IMAGE_TOKEN; ```

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

thakis added a comment. > So, some notes: > > - We should probably also do an AKA on the type diff. > - Chromium should use a clearer name for that typedef perhaps? Though calling > the first template parameter of span as `T` is common, maybe a better name > here would be `element_type`. > >

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

thakis added a comment. Herald added a subscriber: JDevlieghere. This causes lots of warnings on Windows, where TERMIOS is false: http://45.33.8.238/win/47744/step_4.txt (look for "Terminal.cpp"). Could you take a look? It looks like return statements are genuinely missing there. Repository:

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

thakis added a comment. In D111890#3090653 , @mgorny wrote: > In D111890#3090632 , @thakis wrote: > >> This causes lots of warnings on Windows, where TERMIOS is false: >> http://45.33.8.238/win/47744/step_4.txt

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

thakis added a comment. Looks like this breaks the build on Windows: http://45.33.8.238/win/48210/step_4.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757

[Lldb-commits] [PATCH] D112632: [lldb] [Host/Terminal] Fix warnings with termios disabled

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Comment at: lldb/source/Host/common/Terminal.cpp:39 + llvm::Expected Terminal::GetData() { if (!FileDescriptorIsValid()) nit: should GetData()

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

thakis added inline comments. Comment at: lldb/source/CMakeLists.txt:4 -set(lldbBase_SOURCES -lldb.cpp - ) thakis wrote: > should lldb.cpp be deleted too? fixed in D115438 Comment at: lldb/source/Version/Version.cpp:18 +#else + return

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

thakis added a comment. Thanks for this change! I always wondered why this strange lldbBase target existed in lldb/source instead of what's now done in this patch. Comment at: lldb/source/CMakeLists.txt:4 -set(lldbBase_SOURCES -lldb.cpp - ) should

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

thakis added a comment. Not sure what happened here but this change added back a whole bunch of old code. I reverted this in 085f078307bac264301b07f6e47e2a04e90a6f1d . Please carefully check `git diff origin/main` before

[Lldb-commits] [PATCH] D120972: [lldb] Show progress events in the command line driver

thakis added a comment. This breaks building on Windows where GetMessage is defined to GetMessageW: http://45.33.8.238/win/54664/step_4.txt Please fix (just rename to something else), or revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/gdb-server/CMakeLists.txt:10 lldbPluginProcessUtility +lldbPluginProcessGDBRemote ) It doesn't seem like lldb cares about this kind of thing, but this adds a dependency cycle:

[Lldb-commits] [PATCH] D120425: [lldb/host] Remove monitor_signals argument from process monitoring functions

thakis added a comment. Breaks Mac build: http://45.33.8.238/macm1/28811/step_4.txt Ptal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120425/new/ https://reviews.llvm.org/D120425 ___ lldb-commits

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

thakis added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120321/new/ https://reviews.llvm.org/D120321 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D120195: Cleanup llvm/DebugInfo/PDB headers

thakis added a comment. Breaks building on win: http://45.33.8.238/win/53749/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120195/new/ https://reviews.llvm.org/D120195

[Lldb-commits] [PATCH] D120321: [lldb] Modernize ThreadLauncher

thakis added a comment. Looks like this breaks building on Windows: http://45.33.8.238/win/53761/step_4.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120321/new/ https://reviews.llvm.org/D120321

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. > The background here is that I found this patch in one of my old WIP branches. > The next patch in the series was going to define LLDB_API to > `__attribute__((visibility("default")))` on the non-windows path (and make > everything else hidden), but I have no idea why

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. Before this change, it was very easy to build liblldb as a static library (just don't define IMPORT_LIBLLDB and EXPORT_LIBLLDB). After this change, this is no longer possible on Windows (but it still works fine everywhere else). Is this intentional? Repository: rG

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

thakis added a comment. > So what happens now if you define LLDB_IN_LIBLLDB? Does dllexport explode if > used in a static library? Do you mean define it for all targets, instead of for just liblldb? If just for liblldb, then the link fails because (e.g.) driver tries to dllimport the symbols

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

thakis added a comment. Looks like this doesn't build on Mac: http://45.33.8.238/macm1/26315/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

thakis added a comment. And e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

thakis added a comment. And even less on windows: http://45.33.8.238/win/53319/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc46ae6df5f7: [lldb] Add support to load object files from thin archives (authored by PRESIDENT810, committed by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

thakis added a comment. Done. Thanks for the fix! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

thakis added a comment. What `--author` flag should I use for you when landing this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

thakis added a comment. Here too: https://lab.llvm.org/buildbot#builders/83/builds/20210 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/ https://reviews.llvm.org/D127702 ___ lldb-commits

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

thakis added a comment. Looks like this might not build: http://45.33.8.238/linux/79194/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127702/new/

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. It'd be nice if this was landed opt-in behind some cmake variable at first, so that folks could try it out on their bots and see how well things work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130689/new/

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

thakis added a comment. Reverted in 1b4b12a34022b13b35755d9c941f7f13753e5e96 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D130309

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

thakis added a comment. This doesn't build, as far as I can tell: http://45.33.8.238/linux/82002/step_4.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/

[Lldb-commits] [PATCH] D130309: [NFC] Improve FileSpec internal APIs and usage in preparation for adding caching of resolved/absolute.

thakis added a comment. Still broken on windows for me: http://45.33.8.238/win/62911/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130309/new/ https://reviews.llvm.org/D130309 ___

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. In D130689#3686716 , @thieta wrote: > You can already test this with `-DCMAKE_CXX_STANDARD=17` afaik. I wonder how > many bot owners would actually test this if we made another flag available. Thanks, that works. Our linux and

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. I fixed up the gn build after this in 804d4594cbe217ae817b6786b0e9965283f78aa2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/

[Lldb-commits] [PATCH] D132300: [clang][lldb][cmake] Use new `*_INSTALL_LIBDIR_BASENAME` CPP macro

thakis added a comment. (ie if you revert that, it'd be appreciated if you could revert that in the same commit) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132300/new/ https://reviews.llvm.org/D132300

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

thakis added a comment. This breaks building everywhere: http://45.33.8.238/linux/87654/step_4.txt http://45.33.8.238/macm1/45381/step_4.txt http://45.33.8.238/win/67047/step_4.txt ../../lldb/tools/lldb-vscode/lldb-vscode.cpp(2963,7): error: unknown type name 'SBError'; did you mean

[Lldb-commits] [PATCH] D134844: [lldb] Fix deprecation warning for using std::iterator

thakis created this revision. thakis added a reviewer: labath. Herald added a project: All. thakis requested review of this revision. std::iterator was deprecated in C++17. https://reviews.llvm.org/D134844 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.cpp Index:

[Lldb-commits] [PATCH] D134333: When there are variable errors, display an error in VS Code's local variables view.

thakis added a comment. Reverted in dcb94010eb8f0110c593a41e90b01365b45795e6 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134333/new/ https://reviews.llvm.org/D134333 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D135983: [lldb] Fix a -Wdeprecated-declarations warning

This revision was automatically updated to reflect the committed changes. Closed by commit rG0af7280a5ee0: [lldb] Fix a -Wdeprecated-declarations warning (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135983/new/

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset This causes a dependency cycle:

[Lldb-commits] [PATCH] D133534: Complete support of loading a darwin kernel over a live gdb-remote connection given the address of a mach-o fileset

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/CMakeLists.txt:47 lldbUtility +lldbPluginDynamicLoaderDarwinKernel +lldbPluginObjectContainerMachOFileset jasonmolenda wrote: > jasonmolenda wrote: > > thakis wrote: > > >

[Lldb-commits] [PATCH] D135983: [lldb] Fix a -Wdeprecated-declarations warning

thakis created this revision. thakis added a reviewer: JDevlieghere. Herald added a project: All. thakis requested review of this revision. Fixes: ../../lldb/source/Symbol/LocateSymbolFileMacOSX.cpp:633:26: warning: 'CFPropertyListCreateFromXMLData' is deprecated: first

[Lldb-commits] [PATCH] D134844: [lldb] Fix deprecation warning for using std::iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGa314a36aaa1d: [lldb] Fix deprecation warning for using std::iterator (authored by thakis). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D130689: [LLVM] Update C++ standard to 17

thakis added a comment. Re rollout: I suggested further up to put this behind an opt-in variable. That would've allowed people to test this on their setups. I still think that's a good suggestion, and it would've identified the MSVC issue at least. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D130342: [LLDB][RISCV] Add riscv register definition and read/write

thakis added a comment. This breaks building on windows: http://45.33.8.238/win/64255/step_4.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130342/new/

  1   2   >