[Lldb-commits] [PATCH] D49866: Fix duplicate suggestions after an ambiguous command

This revision was automatically updated to reflect the committed changes. Closed by commit rL338043: Fix duplicate suggestions after an ambiguous command (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor updated this revision to Diff 157370. teemperor added a comment. (Added small refactoring I forgot to add to the diff). https://reviews.llvm.org/D49322 Files: include/lldb/Utility/CompletionRequest.h source/Commands/CommandCompletions.cpp

[Lldb-commits] [PATCH] D49831: Don't print two errors for unknown commands.

teemperor created this revision. We always print two error messages when we hit an unknown command. As the function with one error message unconditionally calls the other, we can just remove that error message. Fixes https://bugs.llvm.org/show_bug.cgi?id=38312 https://reviews.llvm.org/D49831

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: source/Core/Highlighter.cpp:34 + // Calculate how many bytes we have written. + return m_prefix.size() + value.size() + m_suffix.size(); +} labath wrote: > teemperor

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor updated this revision to Diff 157702. teemperor added a comment. - Removed extra semicolons that slipped in somehow. https://reviews.llvm.org/D49334 Files: include/lldb/Core/Debugger.h include/lldb/Core/Highlighter.h include/lldb/Target/Language.h

[Lldb-commits] [PATCH] D50027: Added initial unit test for LLDB's Stream class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338488: Added initial unit test for LLDBs Stream class. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50027: Added initial unit test for LLDB's Stream class.

teemperor updated this revision to Diff 158411. teemperor marked an inline comment as done. teemperor added a comment. - Addressed Pavel's comments. Will merge once I have time to watch the build bots afterwards. https://reviews.llvm.org/D50027 Files: unittests/Utility/CMakeLists.txt

[Lldb-commits] [PATCH] D50027: Added initial unit test for LLDB's Stream class.

teemperor added inline comments. Comment at: unittests/Utility/StreamTest.cpp:38-41 +TEST_F(StreamTest, ChangingByteOrder) { + s.SetByteOrder(lldb::eByteOrderPDP); + EXPECT_EQ(lldb::eByteOrderPDP, s.GetByteOrder()); +} labath wrote: > I've been wondering for

[Lldb-commits] [PATCH] D50162: Replace LLDB's LEB128 implementation with the one from LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL338920: Replace LLDBs LEB128 implementation with the one from LLVM (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

teemperor added a comment. > CompletionRequest - this sounds like it could go next to the command > interpreter Yeah, makes sense. Even though Utility classes then can either not offer completion methods (currently only ArchSpec is doing that) or work around that with a forward decl. But I

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

teemperor added a comment. StreamTee is copying it, which is expected to be copyable when we copy CommandObjectResult around. And then I just added the copy-constructor as CommandObjectResult refactoring sound time-expensive. Repository: rL LLVM https://reviews.llvm.org/D50161

[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

teemperor created this revision. teemperor added a reviewer: labath. Herald added a subscriber: mgorny. Repository: rLLDB LLDB https://reviews.llvm.org/D50298 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StringLexerTest.cpp Index: unittests/Utility/StringLexerTest.cpp

[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

teemperor updated this revision to Diff 159193. teemperor added a comment. - Fixed typo (Thanks Joe!) https://reviews.llvm.org/D50298 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StringLexerTest.cpp Index: unittests/Utility/StringLexerTest.cpp

[Lldb-commits] [PATCH] D50293: Added unit test for StringList

This revision was automatically updated to reflect the committed changes. Closed by commit rL338961: Added unit test for StringList (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50293?vs=159165=159185#toc

[Lldb-commits] [PATCH] D50317: Remove duplicated code in CommandObjectQuit

teemperor created this revision. We already have the same check directly before, so this code can never be reached (as seen in the test coverage). Repository: rLLDB LLDB https://reviews.llvm.org/D50317 Files: source/Commands/CommandObjectQuit.cpp Index:

[Lldb-commits] [PATCH] D50025: Don't ignore byte_order in Stream::PutMaxHex64

This revision was automatically updated to reflect the committed changes. Closed by commit rL338591: Dont ignore byte_order in Stream::PutMaxHex64 (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50025: Don't ignore byte_order in Stream::PutMaxHex64

teemperor updated this revision to Diff 158563. teemperor added a comment. - Updated patch to reflect code changes in the parent commit. https://reviews.llvm.org/D50025 Files: source/Utility/Stream.cpp unittests/Utility/StreamTest.cpp Index: unittests/Utility/StreamTest.cpp

[Lldb-commits] [PATCH] D50149: Fix out-of-bounds read in Stream::PutCStringAsRawHex8

teemperor created this revision. When I added the Stream unit test (r338488), the build bots failed due to an out-of- bound reads when passing an empty string to the PutCStringAsRawHex8 method. In r338491 I removed the test case to fix the bots. This patch fixes this in PutCStringAsRawHex8 by

[Lldb-commits] [PATCH] D50159: Add byte counting mechanism to LLDB's Stream class.

teemperor updated this revision to Diff 158642. teemperor edited the summary of this revision. teemperor added a comment. - Added some more documentation. https://reviews.llvm.org/D50159 Files: include/lldb/Core/StreamAsynchronousIO.h include/lldb/Core/StreamBuffer.h

[Lldb-commits] [PATCH] D50162: Replace LLDB's LEB128 implementation with the one from LLVM

teemperor created this revision. https://reviews.llvm.org/D50162 Files: source/Utility/Stream.cpp Index: source/Utility/Stream.cpp === --- source/Utility/Stream.cpp +++ source/Utility/Stream.cpp @@ -12,6 +12,7 @@ #include

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

This revision was automatically updated to reflect the committed changes. Closed by commit rL338662: [LLDB] Added syntax highlighting support (authored by teemperor, committed by ). Changed prior to commit: https://reviews.llvm.org/D49334?vs=157702=158671#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D50161: Add raw_ostream wrapper to the Stream class

teemperor created this revision. This wrapper will allow us in the future to reuse LLVM methods from within the Stream class. Currently no test as this is intended to be an internal class that shouldn't have any NFC. The test for this change will be the follow up patch that migrates LLDB's

[Lldb-commits] [PATCH] D50149: Fix out-of-bounds read in Stream::PutCStringAsRawHex8

This revision was automatically updated to reflect the committed changes. Closed by commit rL338637: Fix out-of-bounds read in Stream::PutCStringAsRawHex8 (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50159: Add byte counting mechanism to stream.

teemperor created this revision. teemperor added a reviewer: labath. This patch allows LLDB's Stream class to count the bytes it has written to so far. There are two major motivations for this patch: The first one is that this will allow us to get rid of all the handwritten byte counting code

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

This revision was automatically updated to reflect the committed changes. Closed by commit rL338151: Narrow the CompletionRequest API to being append-only. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor updated this revision to Diff 157710. teemperor added a comment. - Rebased and fixed merge conflicts. - Applied Pavel's suggestion for the duplicate filter (thanks!). https://reviews.llvm.org/D49322 Files: include/lldb/Utility/CompletionRequest.h

[Lldb-commits] [PATCH] D49943: Fix whitespace in the python test suite.

teemperor created this revision. Herald added subscribers: christof, JDevlieghere, ki.stfu. The test suite has often unnecessary trailing whitespace, and sometimes unnecessary trailing lines or a missing final new line. This patch just strips trailing whitespace/lines and adds missing newlines at

[Lldb-commits] [PATCH] D49943: Fix whitespace in the python test suite.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL338171: Fix whitespace in the python test suite. (authored by teemperor, committed by ). Herald added a subscriber:

[Lldb-commits] [PATCH] D49740: Move RegisterValue, Scalar, State from Core to Utility

teemperor added a comment. Sounds reasonable. It seems both arcanist and patch can't handle the patch file, so let's just see how it goes post-commit. https://reviews.llvm.org/D49740 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor updated this revision to Diff 157320. teemperor marked 8 inline comments as done. teemperor added a comment. - Addressed Pavel's comments. Also cleaned up some more includes. Yes, knowing the language we currently display would be nice, but I didn't see a good way to reliably get this

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor added inline comments. Comment at: source/Core/Highlighter.cpp:34 + // Calculate how many bytes we have written. + return m_prefix.size() + value.size() + m_suffix.size(); +} labath wrote: > This isn't correct, as you're not writing m_prefix, but

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor updated this revision to Diff 157368. teemperor added a comment. - Addressed Davide's comments. https://reviews.llvm.org/D49322 Files: include/lldb/Utility/CompletionRequest.h source/Commands/CommandCompletions.cpp source/Commands/CommandObjectCommands.cpp

[Lldb-commits] [PATCH] D49322: Narrow the CompletionRequest API to being append-only.

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: source/Commands/CommandObjectMultiword.cpp:378 return proxy_command->HandleArgumentCompletion(request, opt_element_vector); - request.GetMatches().Clear(); return 0;

[Lldb-commits] [PATCH] D50317: Remove duplicated code in CommandObjectQuit

This revision was automatically updated to reflect the committed changes. Closed by commit rL338976: Remove duplicated code in CommandObjectQuit (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50481: Fix broken builtin functions in the expression command

teemperor added a reviewer: jingham. teemperor added a comment. I didn't disable Windows on the test as it shouldn't call any function in the target process. Just because I don't want to x-fail every test on Windows. Repository: rLLDB LLDB https://reviews.llvm.org/D50481

[Lldb-commits] [PATCH] D50481: Fix broken builtin functions in the expression command

teemperor created this revision. Calling any non-libc builtin function in the expression command currently just causes Clang to state that the function is not known. The reason for this is that we actually never initialize the list of builtin functions in the Builtin::Context. This patch just

[Lldb-commits] [PATCH] D50492: Also display the output and error output of a failed command

teemperor created this revision. Instead of just printing the current "False is not True, ..." message when we fail to run a certain command, this patch also adds the actual command output or error output that we received to the assertion message. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D50492: Also display the output and error output of a failed command

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339351: Also display the output and error output of a failed command (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D50492 Files:

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

teemperor updated this revision to Diff 160214. teemperor added a comment. Herald added a subscriber: mgrang. - Replaced m_functions and instead copy the map to a temporary sorted vector and iterate over that. https://reviews.llvm.org/D50225 Files: include/lldb/Symbol/CompileUnit.h

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

This revision was automatically updated to reflect the committed changes. Closed by commit rL339504: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50225: Use a DenseMap for looking up functions by UID in CompileUnit::FindFunctionByUID

teemperor updated this revision to Diff 160245. teemperor added a comment. - Passing shared_ptr to lambda now as const-ref. https://reviews.llvm.org/D50225 Files: include/lldb/Symbol/CompileUnit.h source/Core/Module.cpp source/Symbol/CompileUnit.cpp Index: source/Symbol/CompileUnit.cpp

[Lldb-commits] [PATCH] D48465: Added initial code completion support for the `expr` command

teemperor updated this revision to Diff 159426. teemperor added a comment. - Resolved merge conflicts. https://reviews.llvm.org/D48465 Files: include/lldb/Expression/ExpressionParser.h include/lldb/Expression/UserExpression.h

[Lldb-commits] [PATCH] D50293: Added unit test for StringList

teemperor created this revision. Herald added a subscriber: mgorny. Repository: rLLDB LLDB https://reviews.llvm.org/D50293 Files: unittests/Utility/CMakeLists.txt unittests/Utility/StringListTest.cpp Index: unittests/Utility/StringListTest.cpp

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

teemperor updated this revision to Diff 160439. teemperor added a comment. - Addressed Vedant's comments (thanks!) https://reviews.llvm.org/D50620 Files: unittests/Core/CMakeLists.txt unittests/Core/RangeTest.cpp Index: unittests/Core/RangeTest.cpp

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339611: Added test for Core/Range class. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50620?vs=160439=160441#toc

[Lldb-commits] [PATCH] D50802: Expression autocompletion with variables and symbols

teemperor added a comment. I think https://reviews.llvm.org/D48465 is doing the same thing (and more). Repository: rLLDB LLDB https://reviews.llvm.org/D50802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50676: Remove manual byte counting from Highlighter code.

teemperor created this revision. This removes the manual byte counting mechanism from the syntax highlighting code. This is no longer necessary as the Stream class now has built-in support for automatically counting the bytes that were written to it so far. The advantage of automatic byte

[Lldb-commits] [PATCH] D50677: Remove manual byte counting from Opcode::Dump

teemperor created this revision. teemperor added a reviewer: clayborg. Stream now has byte-counting functionality, so let's use this instead of manual byte counting. Repository: rLLDB LLDB https://reviews.llvm.org/D50677 Files: source/Core/Opcode.cpp Index: source/Core/Opcode.cpp

[Lldb-commits] [PATCH] D50681: Remove manual byte counting from internal Stream methods.

teemperor created this revision. This patch removes the manual byte counting in all internal Stream methods. This is now done by the automatic byte counting provided by calling `GetWrittenBytes()` before and after writing the data (which is automatically done for us by the `ByteDelta` utility

[Lldb-commits] [PATCH] D50722: Stability improvements for CompletionTest

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a subscriber: jfb. CompletionTest.DirCompletionAbsolute had a random failure on a CI node (in the failure, the completion count was 0, while we expected it to be 1), but there seems no good reason for it to fail.

[Lldb-commits] [PATCH] D50676: Remove manual byte counting from Highlighter code.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339695: Remove manual byte counting from Highlighter code. (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D50676 Files: include/lldb/Core/Highlighter.h

[Lldb-commits] [PATCH] D50722: Stability improvements for CompletionTest

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB339715: Stability improvements for CompletionTest (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D50722 Files: unittests/Interpreter/TestCompletion.cpp

[Lldb-commits] [PATCH] D50681: Remove manual byte counting from internal Stream methods.

teemperor updated this revision to Diff 160697. teemperor added a comment. - Made ByteDelta public. - Minor fixes. @labath It sounds reasonable to make ByteDelta public. It certainly improves the byte-counting code outside of Stream, even though it hopefully doesn't encourage anyone to do even

[Lldb-commits] [PATCH] D49980: [PDB] Parse UDT symbols and pointers to members (combined patch)

teemperor added a comment. @aleksandr.urakov Not sure if you are already working of this, but just FYI this patch introduced a few compiler warnings: /Users/teemperor/llvm/sidestuff/llvm/tools/lldb/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp:55:3: warning: default label in switch which

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

teemperor updated this revision to Diff 160286. teemperor added a comment. - Fixed typo in CMakeLists https://reviews.llvm.org/D50620 Files: unittests/Core/CMakeLists.txt unittests/Core/RangeTest.cpp Index: unittests/Core/RangeTest.cpp

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

teemperor created this revision. teemperor added a reviewer: vsk. Herald added a subscriber: mgorny. We can optimize and refactor some of the classes in RangeMap.h, but first we should have some tests for all the data structures in there. This adds a first batch of tests for the Range class

[Lldb-commits] [PATCH] D50620: Added test for Core/Range class.

teemperor added a comment. (Also we maybe might want to merge the functionalities of Range and VMRange in the future). Repository: rLLDB LLDB https://reviews.llvm.org/D50620 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50677: Remove manual byte counting from Opcode::Dump

This revision was automatically updated to reflect the committed changes. Closed by commit rL340179: Remove manual byte counting from Opcode::Dump (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push the ProcessIO handler.

teemperor created this revision. teemperor added a reviewer: jingham. Herald added a subscriber: abidh. https://reviews.llvm.org/D48465 is currently blocked by the fact that tab-completing the first expression is deadlocking LLDB. The reason for this deadlock is that when we push the ProcessIO

[Lldb-commits] [PATCH] D48463: Prevent dead locking when calling PrintAsync

teemperor abandoned this revision. teemperor marked 2 inline comments as done. teemperor added a comment. Abandon in favor of https://reviews.llvm.org/D50912 https://reviews.llvm.org/D48463 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor updated this revision to Diff 162227. teemperor added a comment. Herald added a subscriber: emaste. I added an flag for this to the evaluation options. I also set this flag for all utility calls I found. https://reviews.llvm.org/D50912 Files: include/lldb/Core/Debugger.h

[Lldb-commits] [PATCH] D51175: Add support for descriptions with command completions.

teemperor created this revision. teemperor added a reviewer: LLDB. This patch adds a framework for adding descriptions to the command completions we provide. It also adds descriptions for completed top-level commands so that we can test this code. Completions are in general supposed to be

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor updated this revision to Diff 162238. teemperor added a comment. - Add an assert against underflow checking. - Fixed a (serious) typo that broke the test. https://reviews.llvm.org/D50912 Files: include/lldb/Core/Debugger.h include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor added inline comments. Comment at: source/Target/Process.cpp:4696-4697 +// the IOHandler for Editline). +bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction(); +GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler); return

[Lldb-commits] [PATCH] D50481: Fix broken builtin functions in the expression command

teemperor updated this revision to Diff 162255. teemperor added a comment. This revision is now accepted and ready to land. - Removed unrelated comments in the test. - No longer using self.expect. - Small refactoring in the parsing code. https://reviews.llvm.org/D50481 Files:

[Lldb-commits] [PATCH] D50481: Fix broken builtin functions in the expression command

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340571: Fix broken builtin functions in the expression command (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D50481 Files:

[Lldb-commits] [PATCH] D51185: Reuse the SelectorTable from Clang's Preprocessor

teemperor added a comment. Yeah, but the FIXME has been around for like a decade, so I think that bug has survived long enough to be promoted to a feature :). Repository: rLLDB LLDB https://reviews.llvm.org/D51185 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D51185: Reuse the SelectorTable from Clang's Preprocessor

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340585: Reuse the SelectorTable from Clangs Preprocessor (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D51185 Files:

[Lldb-commits] [PATCH] D51227: [vscode] Skip the vscode tests on Linux

teemperor added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-vscode/attach/TestVSCode_attach.py:50 @skipIfDarwin # Skip this test for now until we can figure out why tings aren't working on build bots +@skipIfLinux # This test is timing out

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor updated this revision to Diff 161829. teemperor retitled this revision from "Don't cancel the current IOHandler when we push the ProcessIO handler." to "Don't cancel the current IOHandler when we push a handler for an utility function run.". teemperor edited the summary of this

[Lldb-commits] [PATCH] D50912: Don't cancel the current IOHandler when we push a handler for an utility function run.

teemperor added inline comments. Comment at: include/lldb/Target/Process.h:435 + bool IsRunningUtilityFunction() const { +return m_last_natural_stop_id != m_stop_id; + } @jingham That might be wrong, but I'm not sure what exactly each member variable is

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

teemperor created this revision. teemperor added a reviewer: aprantl. Herald added a reviewer: javed.absar. Herald added subscribers: lldb-commits, abidh, kristof.beyls. LLDB currently only checks the output terminal for color support by looking at the `TERM` environment variable and comparing it

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

teemperor added inline comments. Comment at: source/Core/Debugger.cpp:805 const char *term = getenv("TERM"); if (term && !strcmp(term, "dumb")) SetUseColor(false); teemperor wrote: > aprantl wrote: > > aprantl wrote: > > > Shouldn't this check be

[Lldb-commits] [PATCH] D51253: Let the CompilerInstance create our clang ASTContext

teemperor created this revision. teemperor added reviewers: vsk, aprantl. Herald added a subscriber: lldb-commits. Now that we moved the BuiltinContext and SelectorTable to the CompilerInstance, we can also get rid of manually creating our own ASTContext, but just use the one from the

[Lldb-commits] [PATCH] D51253: Let the CompilerInstance create our clang ASTContext

teemperor updated this revision to Diff 162538. teemperor added a comment. - clang-format. https://reviews.llvm.org/D51253 Files: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Index: source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

teemperor added inline comments. Comment at: source/Core/Debugger.cpp:805 const char *term = getenv("TERM"); if (term && !strcmp(term, "dumb")) SetUseColor(false); aprantl wrote: > aprantl wrote: > > Shouldn't this check be obsolete now? > You can

[Lldb-commits] [PATCH] D51319: Use a RAII guard to control access to DisassemblerLLVMC.

teemperor added inline comments. Comment at: source/Plugins/Disassembler/llvm/DisassemblerLLVMC.cpp:176 bool got_op = false; -std::shared_ptr disasm_sp(GetDisassembler()); -if (disasm_sp) { - const ArchSpec = disasm_sp->GetArchitecture(); +

[Lldb-commits] [PATCH] D51319: Use a RAII guard to control access to DisassemblerLLVMC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340835: Use a RAII guard to control access to DisassemblerLLVMC. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D31275: [lldb] Fix lldb build on musl

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340876: [lldb] Fix lldb build on musl (authored by teemperor, committed by ). Herald added subscribers: lldb-commits, abidh. Changed prior to commit:

[Lldb-commits] [PATCH] D50751: Allow use of self.filecheck in LLDB tests (c.f self.expect)

teemperor requested changes to this revision. teemperor added inline comments. This revision now requires changes to proceed. Comment at: lldb/packages/Python/lldbsuite/test/configuration.py:194 +# of the test build dir is the LLVM build dir. +llvm_build_dir =

[Lldb-commits] [PATCH] D51319: Use a RAII guard to lock/unlock DisassemblerLLVMC [NFC]

teemperor created this revision. teemperor added a reviewer: LLDB. Herald added a subscriber: lldb-commits. The manual lock/unlock calls make my LazyBool refactoring tricky (because now `return` potentially cause deadlocks), so this patch just replaces them with a much safer lock guard that is

[Lldb-commits] [PATCH] D51243: Disable use-color if the output stream is not a terminal with color support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL340747: Disable use-color if the output stream is not a terminal with color support. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D51253: Let the CompilerInstance create our clang ASTContext

This revision was automatically updated to reflect the committed changes. Closed by commit rL340748: Let the CompilerInstance create our clang ASTContext (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D51319: Use a RAII guard to control access to DisassemblerLLVMC.

teemperor updated this revision to Diff 162775. teemperor retitled this revision from "Use a RAII guard to lock/unlock DisassemblerLLVMC [NFC]" to "Use a RAII guard to control access to DisassemblerLLVMC.". teemperor edited the summary of this revision. teemperor added a comment. - Got rid of

[Lldb-commits] [PATCH] D50481: Fix broken builtin functions in the expression command

teemperor edited reviewers, added: LLDB; removed: jingham. teemperor added a comment. (Adding the team as a reviewer, because the code this patch touches doesn't seem to have a dedicated code owner). Repository: rLLDB LLDB https://reviews.llvm.org/D50481

[Lldb-commits] [PATCH] D50298: Add unit test for StringLexer

This revision was automatically updated to reflect the committed changes. Closed by commit rL340448: Add unit test for StringLexer (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50298?vs=159193=162038#toc

[Lldb-commits] [PATCH] D50481: Fix broken builtin functions in the expression command

teemperor planned changes to this revision. teemperor added a comment. @clayborg Thanks, getting rid of pexpect sounds good. TODO: - Get rid of pexpect. - Fix some of the comments in the test that are still referring to the test I copied this from. - Reuse `builtin_context` instead of calling

[Lldb-commits] [PATCH] D49435: Added unit tests for Flags

teemperor created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D49435 Files: unittests/Utility/CMakeLists.txt unittests/Utility/FlagsTest.cpp Index: unittests/Utility/FlagsTest.cpp === ---

[Lldb-commits] [PATCH] D49415: Add unit tests for VMRange

teemperor updated this revision to Diff 155899. teemperor added a comment. - ASSERT_ -> EXPECT_ - Now using gtest's comparison macros where possible. - Added a PrintTo function as otherwise the gtest comparison macros won't compile. https://reviews.llvm.org/D49415 Files:

[Lldb-commits] [PATCH] D49411: Move from StringRef to std::string in the ScriptInterpreter API

teemperor added a comment. @clayborg Seems reasonable, even though the Python docs say that we should use Py_ssize_t instead of int. I'll update the patch. https://reviews.llvm.org/D49411 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D49307: Fix some crashes and deadlocks in FormatAnsiTerminalCodes

teemperor updated this revision to Diff 155706. teemperor added a comment. - Removed temp string variables. https://reviews.llvm.org/D49307 Files: include/lldb/Utility/AnsiTerminal.h unittests/Utility/AnsiTerminalTest.cpp unittests/Utility/CMakeLists.txt Index:

[Lldb-commits] [PATCH] D49307: Fix some crashes and deadlocks in FormatAnsiTerminalCodes

This revision was automatically updated to reflect the committed changes. Closed by commit rL337189: Fix some crashes and deadlocks in FormatAnsiTerminalCodes (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D49334: [LLDB} Added syntax highlighting support

teemperor added a comment. @zturner We can migrate the existing AnsiTerminal.h to reuse the LLVM coloring backend. This way we fix also the code that already uses this convenient interface. @labath I think we can add to the Language class the option to add its related syntax highlighting

[Lldb-commits] [PATCH] D49334: Added syntax highlighting support

teemperor added a comment. Also: This patch doesn't answer the question how the user will be able to configure the specific colors used for each token (i.e. there is only one style available at the moment). The reason for this is that there seems to be a lot of opinions about whether we want

[Lldb-commits] [PATCH] D49334: Added syntax highlighting support

teemperor created this revision. Herald added a subscriber: mgorny. This patch adds syntax highlighting support to LLDB. When enabled (and lldb is allowed to use colors), printed source code is annotated with the ANSI color escape sequences. So far we have only one highlighter which is based

[Lldb-commits] [PATCH] D49411: Move from StringRef to std::string in the ScriptInterpreter API

teemperor created this revision. teemperor added a reviewer: dblaikie. After https://reviews.llvm.org/D49309 it became clear that we always need a null-terminated string (for the Python API), so we might as well change the API to accept an std::string& instead of taking a StringRef and then

[Lldb-commits] [PATCH] D49415: Add unit tests for VMRange

teemperor created this revision. Herald added a subscriber: mgorny. https://reviews.llvm.org/D49415 Files: unittests/Utility/CMakeLists.txt unittests/Utility/VMRangeTest.cpp Index: unittests/Utility/VMRangeTest.cpp === ---

[Lldb-commits] [PATCH] D49695: [cmake] Remove unused ${LLDB_PLUGINS} dependency from our Objective-C++ CMake config

teemperor created this revision. Herald added a subscriber: mgorny. LLDB_PLUGINS doesn't exist as a variable, so this line doesn't add any dependencies and is just confusing. It seems this slipped in from the gdb-remote CMake I was using as a CMake template. The gdb-remote CMake itself is

[Lldb-commits] [PATCH] D49696: [NFC] Minor code refactoring.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337737: [NFC] Minor code refactoring. (authored by teemperor, committed by ). Herald added a subscriber: llvm-commits.

[Lldb-commits] [PATCH] D49696: [NFC] Minor code refactoring.

teemperor created this revision. https://reviews.llvm.org/D49696 Files: source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp Index: source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp === ---

<    1   2   3   4   5   6   7   8   9   10   >