[Lldb-commits] [PATCH] D25217: Fix test when using remote debugging.

2016-10-03 Thread Andrew Ford via lldb-commits 
andrewford created this revision.
andrewford added a reviewer: labath.
andrewford added a subscriber: lldb-commits.

Use os.getcwd() instead of get_process_working_directory() as prefix for
souce file.


https://reviews.llvm.org/D25217

Files:
  
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py


Index: 
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
===
--- 
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
+++ 
packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
@@ -46,7 +46,7 @@
 # Create a target by the debugger.
 self.target = self.dbg.CreateTarget(exe)
 self.assertTrue(self.target, VALID_TARGET)
-cwd = self.get_process_working_directory()
+cwd = os.getcwd()
 
 # try both BreakpointCreateByLocation and BreakpointCreateBySourceRegex
 for regex in [False, True]:


Index: packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
===
--- packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
+++ packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_case_sensitivity/TestBreakpointCaseSensitivity.py
@@ -46,7 +46,7 @@
 # Create a target by the debugger.
 self.target = self.dbg.CreateTarget(exe)
 self.assertTrue(self.target, VALID_TARGET)
-cwd = self.get_process_working_directory()
+cwd = os.getcwd()
 
 # try both BreakpointCreateByLocation and BreakpointCreateBySourceRegex
 for regex in [False, True]:
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D24853: Fix windows build.It does not like mixed 'enum' and 'enum class'.

2016-09-22 Thread Andrew Ford via lldb-commits 
andrewford added a comment.

BTW, I don't have commit access, would appreciate if someone could submit for 
me assuming this is acceptable :)


https://reviews.llvm.org/D24853



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D24853: Fix windows build.It does not like mixed 'enum' and 'enum class'.

2016-09-22 Thread Andrew Ford via lldb-commits 
andrewford created this revision.
andrewford added a reviewer: jingham.
andrewford added a subscriber: lldb-commits.

Change-Id: I611460cf4df58073bda64e16847e5358c3361aa7

https://reviews.llvm.org/D24853

Files:
  include/lldb/Breakpoint/BreakpointOptions.h

Index: include/lldb/Breakpoint/BreakpointOptions.h
===
--- include/lldb/Breakpoint/BreakpointOptions.h
+++ include/lldb/Breakpoint/BreakpointOptions.h
@@ -368,7 +368,7 @@
   };
   static const char *g_option_names[(size_t) OptionNames::LastOptionName];
 
-  static const char *GetKey(enum OptionNames enum_value) {
+  static const char *GetKey(OptionNames enum_value) {
 return g_option_names[(size_t) enum_value];
   }
 


Index: include/lldb/Breakpoint/BreakpointOptions.h
===
--- include/lldb/Breakpoint/BreakpointOptions.h
+++ include/lldb/Breakpoint/BreakpointOptions.h
@@ -368,7 +368,7 @@
   };
   static const char *g_option_names[(size_t) OptionNames::LastOptionName];
 
-  static const char *GetKey(enum OptionNames enum_value) {
+  static const char *GetKey(OptionNames enum_value) {
 return g_option_names[(size_t) enum_value];
   }
 
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D20875: Fix JavaArraySyntheticFrontEnd for non-reference ValueObject.

2016-06-01 Thread Andrew Ford via lldb-commits 
andrewford created this revision.
andrewford added reviewers: clayborg, tberghammer.
andrewford added a subscriber: lldb-commits.

Fix missing return after checking that m_backend is not a pointer or reference 
type.

http://reviews.llvm.org/D20875

Files:
  source/Plugins/Language/Java/JavaFormatterFunctions.cpp

Index: source/Plugins/Language/Java/JavaFormatterFunctions.cpp
===
--- source/Plugins/Language/Java/JavaFormatterFunctions.cpp
+++ source/Plugins/Language/Java/JavaFormatterFunctions.cpp
@@ -99,7 +99,7 @@
 GetDereferencedValueObject()
 {
 if (!m_backend.IsPointerOrReferenceType())
-m_backend.GetSP();
+return m_backend.GetSP();
 
 Error error;
 return m_backend.Dereference(error);


Index: source/Plugins/Language/Java/JavaFormatterFunctions.cpp
===
--- source/Plugins/Language/Java/JavaFormatterFunctions.cpp
+++ source/Plugins/Language/Java/JavaFormatterFunctions.cpp
@@ -99,7 +99,7 @@
 GetDereferencedValueObject()
 {
 if (!m_backend.IsPointerOrReferenceType())
-m_backend.GetSP();
+return m_backend.GetSP();
 
 Error error;
 return m_backend.Dereference(error);
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits