Re: [Lldb-commits] [PATCH] D24293: Use llvm's demangler

chaoren added a comment. Cool. Would it be a good idea to only use LLVM's demangler? We can get rid of all the messy ifdef business, and I assume the LLVM demangler would be better maintained and more up to date than any system demangler. https://reviews.llvm.org/D24293

[Lldb-commits] [lldb] r275914 - Add missing headers after header cleanup in r275882.

Author: chaoren Date: Mon Jul 18 16:11:43 2016 New Revision: 275914 URL: http://llvm.org/viewvc/llvm-project?rev=275914=rev Log: Add missing headers after header cleanup in r275882. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp Modified:

Re: [Lldb-commits] [PATCH] D20540: Make sure TestRedefinitionsInInlines.py actually inlines.

This revision was automatically updated to reflect the committed changes. Closed by commit rL270493: Make sure TestRedefinitionsInInlines.py actually inlines. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D20540?vs=58153=58156#toc Repository: rL LLVM

[Lldb-commits] [lldb] r270493 - Make sure TestRedefinitionsInInlines.py actually inlines.

Author: chaoren Date: Mon May 23 16:44:34 2016 New Revision: 270493 URL: http://llvm.org/viewvc/llvm-project?rev=270493=rev Log: Make sure TestRedefinitionsInInlines.py actually inlines. Reviewers: spyffe Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D20540

[Lldb-commits] [PATCH] D20540: Make sure TestRedefinitionsInInlines.py always actually inlines.

chaoren created this revision. chaoren added a reviewer: spyffe. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D20540 Files: packages/Python/lldbsuite/test/lang/c/inlines/main.c Index: packages/Python/lldbsuite/test/lang/c/inlines/main.c

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

We don't test host-only Windows. It's passing Windows to Android though. What's the reason that it fails on Windows? On Wed, May 4, 2016 at 2:31 PM, Adrian McCarthy wrote: > amccarth added a subscriber: amccarth. > amccarth added a comment. > > Chaoren: Did this completely

[Lldb-commits] [lldb] r268135 - Fix TestEnumTypes.py for 32 bit platforms.

Author: chaoren Date: Fri Apr 29 18:34:44 2016 New Revision: 268135 URL: http://llvm.org/viewvc/llvm-project?rev=268135=rev Log: Fix TestEnumTypes.py for 32 bit platforms. Reviewers: clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D19751 Modified:

Re: [Lldb-commits] [PATCH] D19751: Fix TestEnumTypes.py for 32 bit platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rL268135: Fix TestEnumTypes.py for 32 bit platforms. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D19751?vs=55685=55686#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r268098 - Make sure LLDB can deal with forward declarations to enums without crashing or asserting.

+self.expect('frame variable f.op', DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ['ops *', 'f.op', '*0x*']) +self.expect('frame variable *f.op', DATA_TYPES_DISPLAYED_CORRECTLY, substrs = ['ops', '*f.op', '']) +self.expect('expr f.op',

[Lldb-commits] [lldb] r267923 - XFail TestBitfields.py Python API tests.

Author: chaoren Date: Thu Apr 28 14:40:19 2016 New Revision: 267923 URL: http://llvm.org/viewvc/llvm-project?rev=267923=rev Log: XFail TestBitfields.py Python API tests. Summary: Started failing after rL267895. Possibly related to http://llvm.org/pr27510. Reviewers: labath, tfiala Subscribers:

Re: [Lldb-commits] [lldb] r267478 - Fix StackFrame::GetVariables(...) function that was broken by 261858 when lambda functions were added to Block::AppendBlockVariables(). The Stackframe::GetVariables

g_static_var, say as "return > >> g_static_var - 123;", fixes for me. > >> > >> On Mon, Apr 25, 2016 at 3:50 PM, Chaoren Lin via lldb-commits > >> <lldb-commits@lists.llvm.org> wrote: > >> > Is g_global_var necessarily static? > >> &

Re: [Lldb-commits] [PATCH] D19511: Fix TestGetVariables.py.

This revision was automatically updated to reflect the committed changes. Closed by commit rL267492: Fix TestGetVariables.py. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D19511?vs=54940=54944#toc Repository: rL LLVM http://reviews.llvm.org/D19511 Files:

[Lldb-commits] [lldb] r267492 - Fix TestGetVariables.py.

Author: chaoren Date: Mon Apr 25 18:29:53 2016 New Revision: 267492 URL: http://llvm.org/viewvc/llvm-project?rev=267492=rev Log: Fix TestGetVariables.py. Reviewers: sivachandra, clayborg Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D19511 Modified:

[Lldb-commits] [PATCH] D19511: Fix TestGetVariables.py.

chaoren created this revision. chaoren added reviewers: sivachandra, clayborg. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D19511 Files: packages/Python/lldbsuite/test/python_api/frame/get-variables/TestGetVariables.py

Re: [Lldb-commits] [lldb] r267478 - Fix StackFrame::GetVariables(...) function that was broken by 261858 when lambda functions were added to Block::AppendBlockVariables(). The Stackframe::GetVariables

Ah, I see. Is that a known clang bug? On Mon, Apr 25, 2016 at 4:07 PM, Siva Chandra <sivachan...@google.com> wrote: > AFAICT, happens only with Clang; Using g_static_var, say as "return > g_static_var - 123;", fixes for me. > > On Mon, Apr 25, 2016 at 3:50 PM,

Re: [Lldb-commits] [lldb] r267478 - Fix StackFrame::GetVariables(...) function that was broken by 261858 when lambda functions were added to Block::AppendBlockVariables(). The Stackframe::GetVariables

Is g_global_var necessarily static? On Linux, we're only seeing 2 static variables when your test expects 3. > static_names = ['static_var', 'g_global_var', 'static_var'] I'm guessing g_global_var isn't treated as static. On Mon, Apr 25, 2016 at 2:54 PM, Greg Clayton via lldb-commits <

[Lldb-commits] [lldb] r266702 - Fix Windows build.

Author: chaoren Date: Mon Apr 18 20:09:37 2016 New Revision: 266702 URL: http://llvm.org/viewvc/llvm-project?rev=266702=rev Log: Fix Windows build. Modified: lldb/trunk/source/Host/windows/Windows.cpp Modified: lldb/trunk/source/Host/windows/Windows.cpp URL:

Re: [Lldb-commits] [PATCH] D18481: Add argument to expectedFailureAll decorator to xfail for environment variables, and xfail tests for hard float abi and -mthumb on android arm

chaoren added a comment. In http://reviews.llvm.org/D18481#383694, @zturner wrote: > This seems very strange to me. What if someone specifies those flags on the > command line in the makefile instead of via some environment variables? I don't think there's anything we can do about that

Re: [Lldb-commits] [PATCH] D17402: Shuffle an #undef to avoid a warning on FreeBSD

chaoren accepted this revision. chaoren added a comment. This revision is now accepted and ready to land. Seems legit. http://reviews.llvm.org/D17402 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

t;> earning that with a minor Xcode breakage just shortly before this issue >>> showed up. However, that bot as been broken since this change went in. >>> >>> I reverted it in r262156. >>> >>> Feel free to reapply if you have a suggested fix for th

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

is change went in. > > I reverted it in r262156. > > Feel free to reapply if you have a suggested fix for the test failure > introduced. > > Thanks! > > -Todd > > On Fri, Feb 26, 2016 at 12:08 PM, Chaoren Lin via lldb-commits < > lldb-commits@lists.llvm.org> wrot

Re: [Lldb-commits] [PATCH] D17658: Register value is not necessarily scalar.

This revision was automatically updated to reflect the committed changes. Closed by commit rL262081: Register value is not necessarily scalar. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17658?vs=49237=49238#toc Repository: rL LLVM

[Lldb-commits] [lldb] r262081 - Register value is not necessarily scalar.

Author: chaoren Date: Fri Feb 26 16:12:35 2016 New Revision: 262081 URL: http://llvm.org/viewvc/llvm-project?rev=262081=rev Log: Register value is not necessarily scalar. Reviewers: aidan.dodds, mamai Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D17658 Modified:

Re: [Lldb-commits] [PATCH] D17658: Register value is not necessarily scalar.

chaoren updated this revision to Diff 49237. chaoren added a comment. Check return value of GetScalarValue directly. http://reviews.llvm.org/D17658 Files: source/Expression/Materializer.cpp Index: source/Expression/Materializer.cpp

Re: [Lldb-commits] [lldb] r262041 - Fix bug with register values byte order in expression evaluation.

Hmm. Weird. That assert is failing on Linux: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11833 On Fri, Feb 26, 2016 at 9:40 AM, Aidan Dodds via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: aidandodds > Date: Fri Feb 26 11:40:50 2016 > New Revision:

Re: [Lldb-commits] [lldb] r261953 - Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function

t; On Feb 25, 2016, at 6:51 PM, Chaoren Lin via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > > > Hi Jim, > > > > This broke a lot of our tests on Linux. E.g., "p foo" doesn't work. > > > http://lab.llvm.org:8011/builders/lldb-x86_64-ubun

Re: [Lldb-commits] [PATCH] D17634: Clear alias argument vector for 'p' alias.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261969: Clear alias argument vector for 'p' alias. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17634?vs=49147=49148#toc Repository: rL LLVM

[Lldb-commits] [lldb] r261969 - Clear alias argument vector for 'p' alias.

Author: chaoren Date: Thu Feb 25 21:36:27 2016 New Revision: 261969 URL: http://llvm.org/viewvc/llvm-project?rev=261969=rev Log: Clear alias argument vector for 'p' alias. Summary: This fixes the 'p' command which should be aliased to 'expresion --'. Reviewers: jingham Subscribers:

[Lldb-commits] [PATCH] D17634: Clear alias argument vector for 'p' alias.

chaoren created this revision. chaoren added a reviewer: jingham. chaoren added a subscriber: lldb-commits. This fixes the 'p' command which should be aliased to 'expresion --'. http://reviews.llvm.org/D17634 Files: source/Interpreter/CommandInterpreter.cpp Index:

Re: [Lldb-commits] [lldb] r261953 - Add the "block" keyword to "thread step-in -e", and an alias that uses it: "sif " - i.e. step-into-function

Hi Jim, This broke a lot of our tests on Linux. E.g., "p foo" doesn't work. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/11803 Since the breakage is pretty severe, mind if I revert this first until the problem can be fixed? On Thu, Feb 25, 2016 at 5:42 PM Jim Ingham

[Lldb-commits] [lldb] r261718 - Fix TestCStrings for Linux with i386 inferiors.

Author: chaoren Date: Tue Feb 23 21:15:21 2016 New Revision: 261718 URL: http://llvm.org/viewvc/llvm-project?rev=261718=rev Log: Fix TestCStrings for Linux with i386 inferiors. Summary: Temporarily revert part of r261704. Reviewers: spyffe Subscribers: lldb-commits Differential Revision:

Re: [Lldb-commits] [PATCH] D17557: Fix TestCStrings for Linux with i386 inferiors.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261718: Fix TestCStrings for Linux with i386 inferiors. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17557?vs=48867=48878#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D17557: Fix TestCStrings for Linux with i386 inferiors.

chaoren updated this revision to Diff 48867. chaoren added a comment. Use target instead of sc.target_sp.get(). http://reviews.llvm.org/D17557 Files: source/Expression/IRExecutionUnit.cpp Index: source/Expression/IRExecutionUnit.cpp

[Lldb-commits] [PATCH] D17557: Fix TestCStrings for Linux with i386 inferiors.

chaoren created this revision. chaoren added a reviewer: spyffe. chaoren added a subscriber: lldb-commits. Temporarily revert part of r261704. http://reviews.llvm.org/D17557 Files: source/Expression/IRExecutionUnit.cpp Index: source/Expression/IRExecutionUnit.cpp

Re: [Lldb-commits] [lldb] r261704 - When looking for symbols, find load addresses in a more robust way.

Hi Sean, On Linux with i386 inferiors, range.GetBaseAddress().GetCallableLoadAddress(target); returns the wrong load address for strlen, while candidate_sc.symbol->ResolveCallableAddress(*target); returns the correct load address. This is causing TestCStrings to fail on our bot:

[Lldb-commits] [lldb] r259086 - Fix build after rL259070.

Author: chaoren Date: Thu Jan 28 14:25:46 2016 New Revision: 259086 URL: http://llvm.org/viewvc/llvm-project?rev=259086=rev Log: Fix build after rL259070. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp Modified:

[Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

chaoren created this revision. chaoren added a reviewer: granata.enrico. chaoren added a subscriber: lldb-commits. m_function_name will contain a dummy name for the auto-generated function from the python script on Linux. Check for script name first. http://reviews.llvm.org/D16703 Files:

[Lldb-commits] [lldb] r259153 - Fix TestDataFormatterScript for Linux.

Author: chaoren Date: Thu Jan 28 21:48:08 2016 New Revision: 259153 URL: http://llvm.org/viewvc/llvm-project?rev=259153=rev Log: Fix TestDataFormatterScript for Linux. Summary: m_function_name will contain a dummy name for the auto-generated function from the python script on Linux. Check for

Re: [Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

This revision was automatically updated to reflect the committed changes. Closed by commit rL259153: Fix TestDataFormatterScript for Linux. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D16703?vs=46330=46340#toc Repository: rL LLVM http://reviews.llvm.org/D16703

[Lldb-commits] [PATCH] D14472: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355.

chaoren created this revision. chaoren added reviewers: sivachandra, jingham. chaoren added a subscriber: lldb-commits. On Linux, if a thread-specific conditional breakpoint was hit, it won't necessarily be the thread that hit the breakpoint itself that evaluates the conditional expression, so

[Lldb-commits] [lldb] r252353 - Fix Linux tests after r252348.

Author: chaoren Date: Fri Nov 6 16:30:30 2015 New Revision: 252353 URL: http://llvm.org/viewvc/llvm-project?rev=252353=rev Log: Fix Linux tests after r252348. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py URL:

[Lldb-commits] [lldb] r252391 - Fix TestThreadSpecificBreakpoint.py on Linux after rL252355.

Author: chaoren Date: Fri Nov 6 20:16:31 2015 New Revision: 252391 URL: http://llvm.org/viewvc/llvm-project?rev=252391=rev Log: Fix TestThreadSpecificBreakpoint.py on Linux after rL252355. Summary: On Linux, if a thread-specific conditional breakpoint was hit, it won't necessarily be the thread

Re: [Lldb-commits] [PATCH] D14389: Completely avoid building Apple simulator on non-Darwin platforms.

chaoren added a comment. It's not actually CMake complaining but the LLVM cmake scripts. http://reviews.llvm.org/D14389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r252182 - Revert "Do not build any of the simulator material on non-Darwin"

Author: chaoren Date: Thu Nov 5 12:49:02 2015 New Revision: 252182 URL: http://llvm.org/viewvc/llvm-project?rev=252182=rev Log: Revert "Do not build any of the simulator material on non-Darwin" This breaks the cmake build on all non-darwin platforms. This reverts commit

Re: [Lldb-commits] [PATCH] D14389: Completely avoid building Apple simulator on non-Darwin platforms.

chaoren added a comment. LLVM_OPTIONAL_SOURCES should avoid that. http://reviews.llvm.org/D14389 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D14388: Use lldb::pid_t instead of pid_t.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252183: Use lldb::pid_t instead of pid_t. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D14388?vs=39384=39387#toc Repository: rL LLVM http://reviews.llvm.org/D14388

[Lldb-commits] [lldb] r252183 - Use lldb::pid_t instead of pid_t.

Author: chaoren Date: Thu Nov 5 12:49:03 2015 New Revision: 252183 URL: http://llvm.org/viewvc/llvm-project?rev=252183=rev Log: Use lldb::pid_t instead of pid_t. Reviewers: granata.enrico Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D14388 Modified:

[Lldb-commits] [PATCH] D14389: Completely avoid building Apple simulator on non-Darwin platforms.

chaoren created this revision. chaoren added reviewers: granata.enrico, tberghammer, zturner, jingham. chaoren added a subscriber: lldb-commits. This is a resubmission of r252179, but correctly ignores the source files for other platforms. http://reviews.llvm.org/D14389 Files:

[Lldb-commits] [PATCH] D14388: Use lldb::pid_t instead of pid_t.

chaoren created this revision. chaoren added a reviewer: granata.enrico. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D14388 Files: source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.h

[Lldb-commits] [lldb] r252230 - Another import fix for OS X.

Author: chaoren Date: Thu Nov 5 17:19:27 2015 New Revision: 252230 URL: http://llvm.org/viewvc/llvm-project?rev=252230=rev Log: Another import fix for OS X. Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py Modified: lldb/trunk/packages/Python/lldbsuite/test/dotest.py URL:

Re: [Lldb-commits] [lldb] r252191 - Python 3 - Turn on absolute imports, and fix existing imports.

Hi, I think this changed caused all of the OS X tests to fail: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/6969/steps/test1/logs/stdio with this error: Traceback (most recent call last): File "/Users/lldb_build/lldbSlave/buildDir/scripts/../lldb/test/dotest.py", line 7,

Re: [Lldb-commits] [PATCH] D14389: Completely avoid building Apple simulator on non-Darwin platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252205: Completely avoid building Apple simulator on non-Darwin platforms. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D14389?vs=39394=39402#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D14389: Completely avoid building Apple simulator on non-Darwin platforms.

chaoren added a comment. I haven't seen anything else that uses LLVM_OPTIONAL_SOURCES, but it's conceivable that there might be items in the list already, and I would like to avoid doing anything to it besides just appending. http://reviews.llvm.org/D14389

Re: [Lldb-commits] [lldb] r252191 - Python 3 - Turn on absolute imports, and fix existing imports.

rL252218 should hopefully fix it. On Thu, Nov 5, 2015 at 1:53 PM, Chaoren Lin wrote: > Hi, I think this changed caused all of the OS X tests to fail: > > > http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/6969/steps/test1/logs/stdio > > with this error: > >

[Lldb-commits] [lldb] r252133 - Fix TestGoFormatters.py.

Author: chaoren Date: Wed Nov 4 20:17:21 2015 New Revision: 252133 URL: http://llvm.org/viewvc/llvm-project?rev=252133=rev Log: Fix TestGoFormatters.py. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/go/formatters/TestGoFormatters.py Modified:

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

ific libraries. > >>> > >>> > >>>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >>>> > >>>> Why are we trying to build this at all on Linux? Seems odd to build > an

[Lldb-commits] [lldb] r252124 - Fix build on Linux.

Author: chaoren Date: Wed Nov 4 19:23:19 2015 New Revision: 252124 URL: http://llvm.org/viewvc/llvm-project?rev=252124=rev Log: Fix build on Linux. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Modified:

Re: [Lldb-commits] [lldb] r252124 - Fix build on Linux.

cOSX platform files where they > depend on Apple specific libraries. > > >>> > > >>> > > >>>> On Nov 4, 2015, at 5:39 PM, Jim Ingham via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > > >>>> > > >>>&g

Re: [Lldb-commits] [PATCH] D14365: Fix build for platforms without ObjC++.

This revision was automatically updated to reflect the committed changes. Closed by commit rL252143: Fix build for platforms without ObjC++. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D14365?vs=39305=39309#toc Repository: rL LLVM http://reviews.llvm.org/D14365

[Lldb-commits] [lldb] r252143 - Fix build for platforms without ObjC++.

Author: chaoren Date: Wed Nov 4 21:30:45 2015 New Revision: 252143 URL: http://llvm.org/viewvc/llvm-project?rev=252143=rev Log: Fix build for platforms without ObjC++. Reviewers: jingham, jasonmolenda Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D14365 Modified:

[Lldb-commits] [PATCH] D14365: Fix build for platforms without ObjC++.

chaoren created this revision. chaoren added reviewers: jingham, jasonmolenda. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D14365 Files: source/Plugins/Platform/MacOSX/CMakeLists.txt source/Plugins/Platform/MacOSX/PlatformiOSSimulatorCoreSimulatorSupport.mm Index:

[Lldb-commits] [PATCH] D14166: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR.

chaoren created this revision. chaoren added reviewers: sas, ovyalov. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D14166 Files: cmake/modules/LLDBConfig.cmake Index: cmake/modules/LLDBConfig.cmake === ---

Re: [Lldb-commits] [PATCH] D14166: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR.

This revision was automatically updated to reflect the committed changes. Closed by commit rL251589: Correctly include LLVM_EXTERNAL_CLANG_SOURCE_DIR. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D14166?vs=38700=38702#toc Repository: rL LLVM

Re: [Lldb-commits] [lldb] r248846 - Skipping TestAttachDenied.py on Linux as it is hanging on a buildbot after r248834.

Does timeout not work? On Tue, Sep 29, 2015 at 4:06 PM, Todd Fiala via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: tfiala > Date: Tue Sep 29 18:06:56 2015 > New Revision: 248846 > > URL: http://llvm.org/viewvc/llvm-project?rev=248846=rev > Log: > Skipping TestAttachDenied.py on

[Lldb-commits] [lldb] r248301 - Update TestChangeProcessGroup to remove obsolete workaround.

Author: chaoren Date: Tue Sep 22 12:37:34 2015 New Revision: 248301 URL: http://llvm.org/viewvc/llvm-project?rev=248301=rev Log: Update TestChangeProcessGroup to remove obsolete workaround. Expression evaluation in syscalls should work now. Reviewers: labath Subscribers: lldb-commits

Re: [Lldb-commits] [PATCH] D12976: Update TestChangeProcessGroup to remove obsolete workaround.

This revision was automatically updated to reflect the committed changes. Closed by commit rL248301: Update TestChangeProcessGroup to remove obsolete workaround. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12976?vs=35304=35391#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

chaoren added a comment. Do we still need the original stepInstruction? http://reviews.llvm.org/D12976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r248075 - Fix Linux bot.

Author: chaoren Date: Fri Sep 18 19:57:11 2015 New Revision: 248075 URL: http://llvm.org/viewvc/llvm-project?rev=248075=rev Log: Fix Linux bot. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL:

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

chaoren updated this revision to Diff 35113. chaoren added a comment. Remove old line. http://reviews.llvm.org/D12976 Files: test/functionalities/process_group/TestChangeProcessGroup.py Index: test/functionalities/process_group/TestChangeProcessGroup.py

Re: [Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

chaoren added a comment. I thought this was supposed to be fixed, but TestChangeProcessGroup, TestExpressionInSyscall, and TestRegisters just started failing for me recently because of this. http://reviews.llvm.org/D12976 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D12976: Fix TestChangeProcessGroup to properly step out of sleep.

chaoren created this revision. chaoren added a reviewer: labath. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D12976 Files: test/functionalities/process_group/TestChangeProcessGroup.py Index: test/functionalities/process_group/TestChangeProcessGroup.py

[Lldb-commits] [lldb] r247914 - Fix TestMiSymbol for gcc-4.9 test.

Author: chaoren Date: Thu Sep 17 13:38:55 2015 New Revision: 247914 URL: http://llvm.org/viewvc/llvm-project?rev=247914=rev Log: Fix TestMiSymbol for gcc-4.9 test. Modified: lldb/trunk/test/tools/lldb-mi/symbol/TestMiSymbol.py Modified: lldb/trunk/test/tools/lldb-mi/symbol/TestMiSymbol.py

[Lldb-commits] [PATCH] D12909: Fix Makefile for Windows to Android tests.

chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. Herald added subscribers: danalbert, tberghammer. http://reviews.llvm.org/D12909 Files: test/make/Makefile.rules Index: test/make/Makefile.rules

[Lldb-commits] [lldb] r247855 - XFAIL TestCppNsImport for gcc-4.9.

Author: chaoren Date: Wed Sep 16 16:32:48 2015 New Revision: 247855 URL: http://llvm.org/viewvc/llvm-project?rev=247855=rev Log: XFAIL TestCppNsImport for gcc-4.9. Works for gcc-4.8. A bug in gcc perhaps. Modified: lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py Modified:

[Lldb-commits] [lldb] r247766 - Fix off-by-one size check.

Author: chaoren Date: Tue Sep 15 20:20:34 2015 New Revision: 247766 URL: http://llvm.org/viewvc/llvm-project?rev=247766=rev Log: Fix off-by-one size check. Modified: lldb/trunk/source/Expression/IRInterpreter.cpp Modified: lldb/trunk/source/Expression/IRInterpreter.cpp URL:

[Lldb-commits] [lldb] r247628 - Fix CMake build.

Author: chaoren Date: Mon Sep 14 17:39:34 2015 New Revision: 247628 URL: http://llvm.org/viewvc/llvm-project?rev=247628=rev Log: Fix CMake build. - Typo: Coca.cpp -> Cocoa.cpp - Missing include. Added: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp - copied, changed from r247627,

[Lldb-commits] [PATCH] D12868: Revert "Fixup XFAIL marking on TestConstVariables for clang version"

chaoren created this revision. chaoren added a reviewer: tfiala. chaoren added a subscriber: lldb-commits. Linux with ToT clang (3.8) fails. This reverts commit r247633. http://reviews.llvm.org/D12868 Files: test/lang/c/const_variables/TestConstVariables.py Index:

[Lldb-commits] [lldb] r247648 - Revert "Fixup XFAIL marking on TestConstVariables for clang version"

Author: chaoren Date: Mon Sep 14 19:52:00 2015 New Revision: 247648 URL: http://llvm.org/viewvc/llvm-project?rev=247648=rev Log: Revert "Fixup XFAIL marking on TestConstVariables for clang version" Summary: Linux with ToT clang (3.8) fails. This reverts commit r247633. Reviewers: tfiala

Re: [Lldb-commits] [PATCH] D12868: Revert "Fixup XFAIL marking on TestConstVariables for clang version"

This revision was automatically updated to reflect the committed changes. Closed by commit rL247648: Revert "Fixup XFAIL marking on TestConstVariables for clang version" (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12868?vs=34764=34766#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246557: Make ProcessGDBRemote get a //copy// of platform Unix signals. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12420?vs=33485=33707#toc Repository: rL LLVM

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

chaoren added inline comments. Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:2910 @@ +2909,3 @@ +{ +Process::SetUnixSignals(std::make_shared(signals_sp)); +} Here's the copy. http://reviews.llvm.org/D12420

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

chaoren updated this revision to Diff 33485. chaoren added a comment. - ProcessGDBRemote should automatically get a copy of GDBRemoteSignals. http://reviews.llvm.org/D12420 Files: include/lldb/Target/Process.h source/Plugins/Process/elf-core/ProcessElfCore.cpp

Re: [Lldb-commits] [PATCH] D12420: Make ProcessGDBRemote get a //copy// of platform Unix signals.

chaoren updated this revision to Diff 33460. chaoren added a comment. - Force client side copy. http://reviews.llvm.org/D12420 Files: include/lldb/Target/Process.h source/Plugins/Process/elf-core/ProcessElfCore.cpp source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Re: [Lldb-commits] [PATCH] D12206: Inline fake snprintf to avoid linkage issues on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245610: Inline fake snprintf to avoid linkage issues on Windows. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D12206?vs=32722id=32740#toc Repository: rL LLVM

[Lldb-commits] [lldb] r245610 - Inline fake snprintf to avoid linkage issues on Windows.

Author: chaoren Date: Thu Aug 20 15:53:15 2015 New Revision: 245610 URL: http://llvm.org/viewvc/llvm-project?rev=245610view=rev Log: Inline fake snprintf to avoid linkage issues on Windows. Summary: dllexport doesn't work if linking against a static library with its own copy of snprintf.

[Lldb-commits] [PATCH] D12206: Inline fake snprintf to avoid linkage issues on Windows.

chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. dllexport doesn't work if linking against a static library with its own copy of snprintf. http://reviews.llvm.org/D12206 Files: include/lldb/Host/windows/win32.h

[Lldb-commits] [lldb] r245464 - XTIMEOUT TestEvents and TestThreadStates for Windows to Android.

Author: chaoren Date: Wed Aug 19 12:22:12 2015 New Revision: 245464 URL: http://llvm.org/viewvc/llvm-project?rev=245464view=rev Log: XTIMEOUT TestEvents and TestThreadStates for Windows to Android. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL:

Re: [Lldb-commits] [PATCH] D12165: Improve tests regarding imported namespaces and chained calls in C++

chaoren added a subscriber: chaoren. chaoren requested changes to this revision. chaoren added a reviewer: chaoren. This revision now requires changes to proceed. Comment at: test/lang/cpp/chained-calls/TestCppChainedCalls.py:45 @@ -45,3 +44,3 @@ env = None

[Lldb-commits] [lldb] r245477 - XTIMEOUT TestChangeProcessGroup for Linux.

Author: chaoren Date: Wed Aug 19 13:39:25 2015 New Revision: 245477 URL: http://llvm.org/viewvc/llvm-project?rev=245477view=rev Log: XTIMEOUT TestChangeProcessGroup for Linux. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL:

[Lldb-commits] [lldb] r245532 - XTIMEOUT TestIntegerTypesExpr for Darwin.

Author: chaoren Date: Wed Aug 19 20:26:57 2015 New Revision: 245532 URL: http://llvm.org/viewvc/llvm-project?rev=245532view=rev Log: XTIMEOUT TestIntegerTypesExpr for Darwin. Modified: lldb/trunk/test/dosep.py Modified: lldb/trunk/test/dosep.py URL:

Re: [Lldb-commits] [PATCH] D11962: Mark TestCModules as XFAIL on OSX

chaoren added a subscriber: chaoren. chaoren added a comment. Ping? It's been a week, and the buildbot is still red because of this: http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/4923 http://reviews.llvm.org/D11962 ___

[Lldb-commits] [lldb] r245407 - XFAIL TestCppChainedCalls for GCC.

Author: chaoren Date: Tue Aug 18 21:55:33 2015 New Revision: 245407 URL: http://llvm.org/viewvc/llvm-project?rev=245407view=rev Log: XFAIL TestCppChainedCalls for GCC. Modified: lldb/trunk/test/lang/cpp/chained-calls/TestCppChainedCalls.py Modified:

[Lldb-commits] [lldb] r245412 - Fix TestCppNsImport and TestCppScope for remote tests.

Author: chaoren Date: Tue Aug 18 23:08:56 2015 New Revision: 245412 URL: http://llvm.org/viewvc/llvm-project?rev=245412view=rev Log: Fix TestCppNsImport and TestCppScope for remote tests. Modified: lldb/trunk/test/lang/cpp/nsimport/TestCppNsImport.py

Re: [Lldb-commits] [PATCH] D11543: Fix evaluation of global operators in C++

chaoren added a subscriber: chaoren. Comment at: test/lang/cpp/global_operators/TestCppGlobalOperators.py:9 @@ +8,3 @@ +class TestCppGlobalOperators(TestBase): + +mydir = TestBase.compute_mydir(__file__) Please be careful of trailing whitespaces.

[Lldb-commits] [lldb] r245398 - Update to r245397.

Author: chaoren Date: Tue Aug 18 20:24:57 2015 New Revision: 245398 URL: http://llvm.org/viewvc/llvm-project?rev=245398view=rev Log: Update to r245397. `ast_transformer` could be null, in which case we should initialize `m_code_generator` with the ASTContext. Modified:

[Lldb-commits] [lldb] r244782 - Don't print number of failures and percentage if no tests ran.

Author: chaoren Date: Wed Aug 12 13:02:51 2015 New Revision: 244782 URL: http://llvm.org/viewvc/llvm-project?rev=244782view=rev Log: Don't print number of failures and percentage if no tests ran. Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D11909

Re: [Lldb-commits] [PATCH] D11910: Refactor dosep to use list comprehension. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL244783: Refactor dosep to use list comprehension. NFC. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D11910?vs=31708id=31963#toc Repository: rL LLVM

[Lldb-commits] [PATCH] D11967: Export snprintf to avoid linking error with liblldb on Windows.

chaoren created this revision. chaoren added reviewers: zturner, ovyalov. chaoren added a subscriber: lldb-commits. http://reviews.llvm.org/D11967 Files: include/lldb/Host/windows/win32.h Index: include/lldb/Host/windows/win32.h

Re: [Lldb-commits] [PATCH] D11910: Refactor dosep to use list comprehension. NFC.

chaoren updated this revision to Diff 31708. chaoren added a comment. Accidentally removed timed_out tests from failed tests. http://reviews.llvm.org/D11910 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.py +++

[Lldb-commits] [PATCH] D11846: Make dosep.py PEP8 compliant. NFC.

chaoren created this revision. chaoren added a reviewer: zturner. chaoren added a subscriber: lldb-commits. Update to D11843. http://reviews.llvm.org/D11846 Files: test/dosep.py Index: test/dosep.py === --- test/dosep.py +++

  1   2   >