[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL366912: [AIX][lit] Dont depend on psutil on AIX (authored by daltenty, committed by ). Changed prior to commit:

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 211104. daltenty added a comment. - Fix typo in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files: libcxx/utils/libcxx/util.py lldb/lit/lit.cfg.py

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 209621. daltenty added a comment. - Add a space to warning in LLDB lit config Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files: libcxx/utils/libcxx/util.py

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 209619. daltenty marked an inline comment as done. daltenty added a comment. - Address review comments round 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files:

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty marked 6 inline comments as done. daltenty added inline comments. Comment at: llvm/utils/lit/lit/util.py:426 +def killProcessAndChildrenIsSupported(llvm_config): +""" delcypher wrote: > I don't really like how we're now coupling this function with

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 209409. daltenty added a comment. - Address review comments round 2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64251/new/ https://reviews.llvm.org/D64251 Files: libcxx/utils/libcxx/util.py

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty added a comment. In D64251#1577374 , @davide wrote: > This is adding a fair amount of complexity on something that just works fine > on basically every platform but AIX. > If AIX has issue with `psutil`, maybe the fix should be submitted to >

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty updated this revision to Diff 208805. daltenty added a comment. - Use subprocess.call instead of importing it - Create killProcessAndChildrenIsSupported check and rewrite things to use it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D64251: Don't depend on psutil on AIX

daltenty created this revision. Herald added subscribers: llvm-commits, libcxx-commits, lldb-commits, christof, delcypher. Herald added projects: LLDB, libc++, LLVM. On AIX psutil can run into problems with permissions to read the process tree, which causes problems for python tests. This patch