Author: dperchik
Date: Wed Nov 2 15:57:34 2016
New Revision: 285858
URL: http://llvm.org/viewvc/llvm-project?rev=285858=rev
Log:
Fix typo which broke debugging on older OSX systems after r285172.
Reviewed by: jasonmolenda
Subscribers: lldb-commits
Differential Revision:
dawn created this revision.
dawn added a reviewer: jasonmolenda.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Clearly ">=" was meant to be ">". :)
Repository:
rL LLVM
https://reviews.llvm.org/D26260
Files:
Author: dperchik
Date: Sat Oct 1 05:37:56 2016
New Revision: 283031
URL: http://llvm.org/viewvc/llvm-project?rev=283031=rev
Log:
[lldb-mi] Fix prompt which can get inserted in the middle of program output in
lldb-mi
Summary: The code added in svn r264332 causes "(lldb) " to be printed in the
dawn created this revision.
dawn added reviewers: ted, zturner, clayborg.
dawn added subscribers: amccarth, lldb-commits.
dawn set the repository for this revision to rL LLVM.
The code added in svn trunk 264332 causes "(lldb)" to be printed in the middle
of program console output. This fix
Author: dperchik
Date: Fri Sep 30 15:38:33 2016
New Revision: 282941
URL: http://llvm.org/viewvc/llvm-project?rev=282941=rev
Log:
Fix comment - Module::PrepareForFunctionNameLookup should be
Module::LookupInfo::LookupInfo.
Modified:
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
lgtm other than nitpick on formatting. And sorry for delayed review - been
sick.
Comment at:
source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:559-560
@@ -558,5
dawn added a comment.
@spyffe I think this review is waiting on you since you had previously rejected
it. Can you please have a look? It continues to show up on my "Blocking
Others" list and there's nothing more I can do on my side. Please review or
resign out of curtesy to sivachandra???
dawn added a reviewer: clayborg.
dawn added a subscriber: clayborg.
dawn added a comment.
Adding Greg - he is an excellent reviewer and quite responsive (poor guy - ends
up with way more than his fair share of reviews as a result :( ).
@clayborg would you be willing to be a 2nd pair of eyes
dawn added a comment.
In http://reviews.llvm.org/D15593#319670, @clayborg wrote:
> ... in the future when adding things for MI, please add an API in the
> lldb::SB layer to do what you need.
Thanks for not asking me to do that as part of this patch.
> Text scraping is really not the solution
dawn created this revision.
dawn added a reviewer: lldb-commits.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch includes missed changes that should have gone in with r256863, but I
can't get to svn at lldb.org at the moment (is it down?),
dawn added a comment.
Amended patch was posted to http://reviews.llvm.org/D15593 - hopefully someone
who can get to llvm.org will commit.
Repository:
rL LLVM
http://reviews.llvm.org/D15593
___
lldb-commits mailing list
dawn added a comment.
I forgot to commit updated changes to the tests:
MiSymbolTestCase.test_lldbmi_symbol_list_lines_file
HelpCommandTestCase.test_help_image_du_line_should_work
so they are failing now, but svn at llvm.org appears to be down at the moment.
I'll commit those changes as soon
Author: dperchik
Date: Tue Jan 5 18:03:43 2016
New Revision: 256877
URL: http://llvm.org/viewvc/llvm-project?rev=256877=rev
Log:
Apply missed changes from svn r256863 "Add support for "source info" and use it
to fix MI's -symbol-list-lines.".
Patch is part of Differential Revision:
dawn added a comment.
Amended patch was committed in svn r256877 (svn at lldb.org is back up now)
Repository:
rL LLVM
http://reviews.llvm.org/D15593
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: dperchik
Date: Tue Jan 5 13:51:51 2016
New Revision: 256863
URL: http://llvm.org/viewvc/llvm-project?rev=256863=rev
Log:
Add support for "source info" and use it to fix MI's -symbol-list-lines.
This patch adds support the command 'source info' as follows:
(lldb) help source info
dawn added a comment.
In http://reviews.llvm.org/D15593#313342, @clayborg wrote:
> Dawn, if you don't understand what I asked you to do,
Sorry for late reply - been recovering from minor surgery. I have a new patch,
but I've not yet gone through all of Ilia's additional comments - will
dawn marked 4 inline comments as done.
dawn added a comment.
Replies to Ilia's comments...
Comment at: source/Commands/CommandObjectTarget.cpp:1543
@@ +1542,3 @@
+continue;
+CompileUnit *cu = cu_sp.get();
+const FileSpecList
dawn updated this revision to Diff 43152.
dawn marked an inline comment as done.
dawn added a comment.
Updated patch with suggestions from Ilia's review (thanks Ilia!).
Repository:
rL LLVM
http://reviews.llvm.org/D15593
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
dawn marked 6 inline comments as done.
dawn added a comment.
> clang-format your changes please (there are many deviations from the coding
> style)
I've made some fixes even though the code is no longer consistent with the rest
of the file. Alas. I would love to run all of lldb through
dawn updated this revision to Diff 43076.
dawn added a comment.
Updated patch to include changes to TestHelp.py.
Repository:
rL LLVM
http://reviews.llvm.org/D15593
Files:
packages/Python/lldbsuite/test/help/TestHelp.py
packages/Python/lldbsuite/test/tools/lldb-mi/symbol/TestMiSymbol.py
dawn created this revision.
dawn added reviewers: clayborg, ki.stfu, abidh.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This adds support for the new command:
target modules dump line-entries
which dumps the line entries found for 'file' for
dawn retitled this revision from "Add "target modules dump line-entries "
command and use it to fix MI's -symbol-list-lines." to "Enhance "target modules
dump line " and use it to fix MI's -symbol-list-lines.".
dawn updated the summary for this revision.
dawn updated this revision to Diff 43103.
dawn added a comment.
I'm only going to support the combinations:
--compile-unit-only true --only-explicit-matches false --show-raw true
--compile-unit-only false --only-explicit-matches true --show-raw false
OK?
Repository:
rL LLVM
http://reviews.llvm.org/D15593
dawn added a comment.
In http://reviews.llvm.org/D15593#312665, @jingham wrote:
> So it seems like your change is adding three flags
>
> --compile-unit-only --only-explicit-matches --show-raw
>
> or something. The current behavior is:
>
> --compile-unit-only true --only-explicit-matches
Author: dperchik
Date: Sat Dec 12 14:44:08 2015
New Revision: 255440
URL: http://llvm.org/viewvc/llvm-project?rev=255440=rev
Log:
Test case for "Fix scope-based lookup when more than one function is found."
Missed commit in r255439.
Differential Revision: http://reviews.llvm.org/D15312
Added:
Author: dperchik
Date: Sat Dec 12 13:31:41 2015
New Revision: 255439
URL: http://llvm.org/viewvc/llvm-project?rev=255439=rev
Log:
Fix scope-based lookup when more than one function is found.
When multiple functions are found by name, lldb removes duplicate entries of
functions with the same
dawn updated this revision to Diff 42476.
dawn added a comment.
Updated Clang-specific version of patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
Files:
include/lldb/Symbol/ClangASTContext.h
packages/Python/lldbsuite/test/lang/cpp/namespace/Makefile
dawn added a comment.
ping?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn updated this revision to Diff 42385.
dawn added a comment.
This version of the patch is the API "generic" version of the patch. Please
choose to review which ever is preferred, and I will submit another patch based
on that version if needed.
BTW Greg, thanks for the suggestion of
dawn marked 3 inline comments as done.
dawn added a comment.
> It seems like you combined "find this decl instance within a decl context"
> with "find a decl by name in the CompilerDeclContext and optionally get the
> type".
It it exactly "find this decl instance within a decl context".
> I
dawn marked 6 inline comments as done.
dawn added a comment.
Hi Greg, I'm working on a new revision to change the patch as you suggest
(thanks for your review - you had some great suggestions!).
Sorry, if I'm missing something obviously here, but there's still some things I
don't understand:
dawn added a comment.
bloodbath:~% exit
Thanks Greg! To address your main point:
> So either make it generic, or clang specific.
DeclContextCountDeclLevels's interface follows DeclContextFindDeclByName
(authored by Paul Herman). If DeclContextCountDeclLevels is to change, then
dawn added a comment.
> Greg: But going forward I would like to see more of "find a struct named 'X'
in CompilerDeclContext 'Y'" queries, instead of ...
I think lldb should have both, a "search for anything named foo in my scope
context" (for when a user does "p foo"), and a "search for a
dawn added a reviewer: clayborg.
dawn added a comment.
(Added Greg - he wrote Mangled::GetLanguage - now GuessLanguage).
This patch removes the dependence on determining language from the name
mangling for 99% of cases (there's still the much less common problem for
symbols since Symbol 's
dawn marked an inline comment as done.
dawn added a comment.
Thanks Greg. Will fix comment in commit.
@Jim, can you accept please?
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn requested a review of this revision.
dawn added a comment.
Please reconsider. Thanks.
Repository:
rL LLVM
http://reviews.llvm.org/D15326
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn created this revision.
dawn added a reviewer: jingham.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch reworks the breakpoint filter-by-language patch to use the symbol
context instead of trying to guess the language solely from the
dawn created this revision.
dawn added reviewers: paulherman, clayborg, granata.enrico.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
When multiple functions are found by name, lldb removes duplicate entries of
functions with the same type, so the
dawn updated this revision to Diff 42115.
dawn added a comment.
Updated patch to removed change related to Pascal language - it should be part
of a separate patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15312
Files:
include/lldb/Symbol/ClangASTContext.h
dawn added a comment.
In http://reviews.llvm.org/D12809#301752, @sivachandra wrote:
> @dawn: Thanks for accepting the patch. I guess I still need to wait for
> sign-off/comments from a CODE_OWNER.
Yeah. Maybe add more proactive reviewers? And definitely be a squeaky wheel
about it. Keep
Author: dperchik
Date: Fri Dec 4 13:34:00 2015
New Revision: 254753
URL: http://llvm.org/viewvc/llvm-project?rev=254753=rev
Log:
Fix breakpoint language filtering for other C variants (like C99) and Pascal.
This patch fixes setting breakpoints on symbol for variants of C and
Pascal where the
dawn added a comment.
Jim, this patch doesn't attempt to fix the issue I raised in my comment - it
just fixes the oversight of other C variants (clang picks C99 for example) and
renames your function to a more meaningful name (and matches
Mangled::GuessLanguage which is also uses the name to
dawn accepted this revision.
dawn added a comment.
lgtm. Patch was applied locally and tested with no regressions. Thanks for
fixing the patch.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn created this revision.
dawn added a reviewer: jingham.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This patch fixes setting breakpoints on symbol for variants of C and Pascal
where the language is "unknown" within the filtering process added
dawn accepted this commit.
dawn added a comment.
Not really an acceptance, but the test that started failing as a result of this
commit (LaunchInTerminalTestCase.test_launch_in_terminal) has been XFAILed o
OSX in svn.252699 thanks to Todd Fiala. None the less, it would be a good idea
to
dawn added a comment.
In http://reviews.llvm.org/D14631#289917, @tberghammer wrote:
> How you end up in calling DWARFFormValue::Address() with a value what have a
> form type other then DW_FORM_addr and DW_FORM_GNU_addr_index? What is the
> attribute tag and the form type used? Can you post a
dawn abandoned this revision.
dawn added a comment.
> If you have a compiler that is actually emitting addresses incorrectly using
> DW_FORM_data* when the values are not offsets, the compiler should be fixed.
Thanks Greg! In this case it indeed appears to be a compiler bug (we are
getting
dawn added a comment.
See inline comment.
Comment at: source/Symbol/ClangASTContext.cpp:9191
@@ -9189,2 +9190,3 @@
+continue;
searched.insert(it->second);
symbol_file->ParseDeclsForContext(CompilerDeclContext(this,
dawn created this revision.
dawn added reviewers: tberghammer, clayborg, tfiala.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Other compilers (and older Clang compilers) use data4/data8 forms to specify
addresses in DWARF. This patch fixes lldb to
dawn added a subscriber: dawn.
dawn accepted this revision.
dawn added a reviewer: dawn.
dawn added a comment.
Patch is correct - without it we loop through the same decl context again.
I've tested it locally - there are no new regressions.
http://reviews.llvm.org/D14542
Author: dperchik
Date: Wed Nov 11 18:43:22 2015
New Revision: 252831
URL: http://llvm.org/viewvc/llvm-project?rev=252831=rev
Log:
[test] Fix comment.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/expression_command/options/TestExprOptions.py
Modified:
dawn added a subscriber: dawn.
dawn added a reviewer: evgeny777.
dawn added a comment.
Eugene has been doing some work in this area - perhaps he can accept this patch
for you.
http://reviews.llvm.org/D12809
___
lldb-commits mailing list
dawn added a subscriber: dawn.
dawn closed this revision.
dawn added a comment.
This was committed in svn r251820.
Repository:
rL LLVM
http://reviews.llvm.org/D13073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn requested changes to this revision.
dawn added a reviewer: dawn.
dawn added a comment.
This revision now requires changes to proceed.
1. Please rebase again - this patch no longer applies cleanly, and fails to
build after fixing merge conflicts.
2. Please add tests.
Author: dperchik
Date: Fri Oct 23 20:24:00 2015
New Revision: 251169
URL: http://llvm.org/viewvc/llvm-project?rev=251169=rev
Log:
[debugserver] Fix indentation in RNBRemote.cpp.
Modified:
lldb/trunk/tools/debugserver/source/RNBRemote.cpp
Modified:
Author: dperchik
Date: Fri Oct 23 20:31:12 2015
New Revision: 251172
URL: http://llvm.org/viewvc/llvm-project?rev=251172=rev
Log:
[debugserver] Fix OSX build for older XCode versions after r251091.
This fixes the OSX build for XCode versions older than 7 by skipping
references to
dawn created this revision.
dawn added reviewers: brucem, sas, krytarowski, enlight, labath.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
Older versions of cmake don't support the -E env option which was added in
r250335, causing the build to fail
Author: dperchik
Date: Thu Oct 22 19:23:53 2015
New Revision: 251082
URL: http://llvm.org/viewvc/llvm-project?rev=251082=rev
Log:
[lldb-mi] display summary for simple types + refactor (use lldb formatting for
all cases)
Previously, lldb did not use type summaries for simple types with no
Author: dperchik
Date: Thu Oct 22 17:48:52 2015
New Revision: 251073
URL: http://llvm.org/viewvc/llvm-project?rev=251073=rev
Log:
[cmake] Fix cmake build on OSX after r250335 for older versions of cmake
Reviewed by: sas
Subscribers: lldb-commits
Differential Revision:
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
First, sorry for my delay in reviewing your patch, but I've been on vacation
and now am at the C++ ANSI meeting in Kona for this week. But...
This broke the build of cmake on OSX. We get:
[...]
dawn added a subscriber: lldb-commits.
Users:
sas (Author)
http://reviews.llvm.org/rL250335
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
brucem wrote:
> Why is this needed?
You get undefined symbol otherwise (if you
dawn added inline comments.
Comment at: tools/lldb-server/CMakeLists.txt:42
@@ +41,3 @@
+ if (LLDB_VERS_GENERATED_FILE)
+add_dependencies(lldb-server swig_wrapper)
+ endif()
dawn wrote:
> brucem wrote:
> > Why is this needed?
> You get undefined symbol
dawn added a comment.
In http://reviews.llvm.org/D13535#262672, @brucem wrote:
> I don't know what's broken for you. My build hasn't had any issues on Mac OS
> X using cmake.
In a clean workspace, cmake would fail because LLDB_vers.c hadn't been created
yet. You get the error:
CMake
dawn added a comment.
I went ahead and committed this since the build was completely broken - I'd be
happy to apply any suggestions folks make here in subsequent commits.
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits
dawn added a comment.
FYI - our Jenkins master build just picked up the change and is finally
building again - yay!! :)
Repository:
rL LLVM
http://reviews.llvm.org/D13535
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: dperchik
Date: Thu Oct 8 07:35:21 2015
New Revision: 249684
URL: http://llvm.org/viewvc/llvm-project?rev=249684=rev
Log:
[cmake] Fix cmake build on OSX after r249434.
Reviewed by: zturner
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D13535
Modified:
dawn accepted this commit.
dawn added a comment.
Build fixed in svn r249684.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn accepted this revision.
dawn added a comment.
This revision is now accepted and ready to land.
Works great! Please commit. (Sorry for delay - I ran into problems with clang
crashing on me for unknown reasons - finally got the build working again so I
could test).
dawn added a subscriber: lldb-commits.
Users:
sas (Author)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke the lldb build on OSX using cmake. After this commit, we get:
CMake Error at cmake/modules/AddLLVM.cmake:401 (add_library):
Cannot find source file:
dawn added a comment.
See http://reviews.llvm.org/D13535 for a workaround.
Users:
sas (Author)
dawn (Auditor)
http://reviews.llvm.org/rL249434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn created this revision.
dawn added reviewers: sas, clayborg, zturner.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This fixes the cmake build on OSX when building in a new workspace. It
reverts r249434 and instead fixes the issue as proposed
Author: dperchik
Date: Wed Oct 7 17:01:12 2015
New Revision: 249624
URL: http://llvm.org/viewvc/llvm-project?rev=249624=rev
Log:
Decide on the expression language inside UserExpression
When the target settings are consulted to decide the expression language
is decided in
Author: dperchik
Date: Wed Oct 7 14:55:33 2015
New Revision: 249597
URL: http://llvm.org/viewvc/llvm-project?rev=249597=rev
Log:
[lldb-mi] Fix evaluation of strings containing characters from non-ascii range
If a string contained characters outside the ASCII range, lldb-mi would
print them as
dawn added a comment.
In http://reviews.llvm.org/D13535#262225, @zturner wrote:
> I can't verify that this works on MacOSX at the moment. Did you verify that
> this works on other platforms as well?
I've confirmed it works on MacOSX - I'll try to test Linux later today if no
one beats me to
dawn added a comment.
What other details are you looking for?
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn added a comment.
This test is still failing. Can you please have a look? Thanks.
Users:
jaydeep (Author)
dawn (Auditor)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn added a comment.
This patch is good to commit now right? It's not marked "accepted" for some
reason.
http://reviews.llvm.org/D13058
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn added a comment.
> You can use clang-format to follow the LLDB coding style, or just do the
> following:
So we've been telling folks to use clang-format, but it's not working correctly
(my version is clang-format version 3.6.0 (217927)). It's turns:
bool
DoesPrintValue
Author: dperchik
Date: Thu Oct 1 16:15:43 2015
New Revision: 249072
URL: http://llvm.org/viewvc/llvm-project?rev=249072=rev
Log:
[lldb-mi] Add support for StopAtEntry in MI via "-exec-run --start".
This patch adds a --start option to the lldb-mi -exec-run command for
getting process stopped at
dawn added a comment.
Was this patch run on the entire set of lldb tests? Were there any regressions?
http://reviews.llvm.org/D13350
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn accepted this commit.
dawn added a comment.
> Clang (the LLDB compiler) does not ask for the value ScNSpacGl in the global
> namespace, but just for a value named ScNSpacGl.
Ok, I've opened a separate bug for this then,
https://llvm.org/bugs/show_bug.cgi?id=24994.
Users:
paulherman
dawn added a subscriber: dawn.
dawn added a comment.
Bug https://llvm.org/bugs/show_bug.cgi?id=24995 opened for "regressions" after
this commit.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247836
___
lldb-commits mailing list
dawn added a subscriber: lldb-commits.
Users:
paulherman (Author)
http://reviews.llvm.org/rL247746
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn accepted this revision.
dawn added a comment.
lgtm. Much improved.
Comment at: tools/lldb-mi/MICmdCmdSupportList.cpp:78
@@ +77,3 @@
+CMICmnMIValueList miValueList(true);
+// Some of features may depend on host or/and target, decide what to add
below
+
Author: dperchik
Date: Fri Sep 25 13:08:45 2015
New Revision: 248597
URL: http://llvm.org/viewvc/llvm-project?rev=248597=rev
Log:
[lldb-mi] Fix assignment operator in CMIUtilString
Fix assignment operator in CMIUtilString to not crash the debugger if it
is passed a NULL pointer, which can happen
Author: dperchik
Date: Fri Sep 25 13:23:50 2015
New Revision: 248601
URL: http://llvm.org/viewvc/llvm-project?rev=248601=rev
Log:
Add comment in StringExtractor::GetHexU8
Modified:
lldb/trunk/source/Utility/StringExtractor.cpp
Modified: lldb/trunk/source/Utility/StringExtractor.cpp
URL:
dawn added a comment.
Is there a workaround for this? Ok to revert this commit until it is fixed?
It's blocker for me. Thanks.
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dawn accepted this commit.
dawn added a comment.
Fixed by Todd in r248545. Todd rocks!!! :)
Users:
dawn (Auditor)
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
Author: dperchik
Date: Thu Sep 24 21:16:52 2015
New Revision: 248555
URL: http://llvm.org/viewvc/llvm-project?rev=248555=rev
Log:
Fix evaluation of unicode character arrays (char16_t[] and char32_t[])
Suppose we have the UTF-16 string:
char16_t[] s = u"hello";
Before this patch, evaluating
dawn added a subscriber: lldb-commits.
http://reviews.llvm.org/rL248338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Jim,
This test has been failing on OSX ever since this commit:
./dotest.py -f RegisterCommandsTestCase.test_register_expressions
dawn added a subscriber: lldb-commits.
Users:
jaydeep (Author)
http://reviews.llvm.org/rL247968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Enrico,
This commit has caused catasrophic test failures on OSX. The failure count went
up by 512.
lldb is built with cmake/ninja, and tests are run in the test dir as follows:
cd ~/llvm
mkdir
dawn added a subscriber: lldb-commits.
Users:
spyffe (Author)
http://reviews.llvm.org/rL248048
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn raised a concern with this commit.
Users:
spyffe (Author)
dawn (Auditor)
http://reviews.llvm.org/rL248048
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
Hi Jay,
This test has been failing on OSX ever since this commit:
./dotest.py -f ConnectRemoteTestCase.test_connect_remote
dawn added a subscriber: dawn.
dawn added a comment.
Hi Sean,
These 3 tests have been failing on OSX ever since this commit:
Failure-TestLaunchWithShellExpand.LaunchWithShellExpandTestCase.test_with_dsym-x86_64-clang.log
1 - 100 of 136 matches
Mail list logo
