[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

dim accepted this revision. dim added a comment. This revision is now accepted and ready to land. LGTM, but if such SIGFPE's occur before the FPE_FLTIDO define was introduced, can they ever have value 9? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7abfaa0a815a: [lldb] Define LLDB_VERSION_PATCH correctly (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

dim updated this revision to Diff 426110. dim added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add llvm/utils/gn/secondary/lldb/include/lldb/Version/BUILD.gn while we're here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D124672: [lldb] Define LLDB_VERSION_PATCH correctly

dim created this revision. dim added reviewers: JDevlieghere, labath. Herald added a project: All. dim requested review of this revision. Herald added a project: LLDB. In commit ccf1469a4cdb lldb got its own generated

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

dim added a comment. In D115074#3170635 , @JDevlieghere wrote: > We should move this from the wrapper to the header block, similar to what > Pavel did for Python: > https://reviews.llvm.org/rG9a14adeae00015798843ff5cad987e5fdbdddb34 I agree, but I'm

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

dim created this revision. dim added reviewers: tammela, siger-young, emaste. dim requested review of this revision. Herald added a project: LLDB. When lldb Lua bindings are enabled, the generated `LLDBWrapLua.cpp` file generates a compiler warning about C-linkage:

[Lldb-commits] [PATCH] D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5a927b972b2: [lldb] Move create_relative_symlink function up in CMake hierarchy (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy

dim created this revision. dim added reviewers: clayborg, emaste, labath, lawrence_danna, siger-young, tammela. Herald added a subscriber: mgorny. dim requested review of this revision. Herald added a project: LLDB. Configuring lldb with `LLDB_ENABLE_PYTHON=OFF` and `LLDB_ENABLE_LUA=ON` results

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

dim added a comment. In D101406#2950731 , @aprantl wrote: >> This can't have been the intention of this commit? As far as I can see, >> there *is* no plugin for plain assembler? ... > Yes, there is no plugin for the language assembler. But that hasn't

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

dim added a comment. In D101406#2948152 , @clayborg wrote: > Everyone uses this for any assembly in their code. Should we get rid of this > warning? I find it is useless and would like to see it go. Well, for other languages it might be a helpful

[Lldb-commits] [PATCH] D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5033f0793fe6: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage (authored by dim). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108088: [lldb] Avoid unhandled Error in TypeSystemMap::GetTypeSystemForLanguage

dim created this revision. dim added reviewers: aprantl, emaste, JDevlieghere, teemperor. Herald added subscribers: krytarowski, arichardson. dim requested review of this revision. Herald added a project: LLDB. When assertions are turned off, the `llvm::Error` value created at the start of this

[Lldb-commits] [PATCH] D101406: Rename human-readable name for DW_LANG_Mips_Assembler

dim added a comment. Hmm so now on FreeBSD, basically *every* program will cause this warning, as our C startup objects are compiled from .S files, e.g.: % objdump --dwarf /bin/sleep|grep -B6 "MIPS assembler" <0><619>: Abbrev Number: 1 (DW_TAG_compile_unit) <61a> DW_AT_stmt_list

[Lldb-commits] [PATCH] D86355: Instantiate Error in Target::GetEntryPointAddress() only when necessary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ce07cd614be: Instantiate Error in Target::GetEntryPointAddress() only when necessary (authored by dim). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

dim updated this revision to Diff 287077. dim added a comment. As @JDevlieghere suggests, only instantiate `Error` objects when necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86355/new/ https://reviews.llvm.org/D86355 Files:

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

dim added inline comments. Comment at: lldb/source/Target/Target.cpp:2408-2446 llvm::Expected Target::GetEntryPointAddress() { Module *exe_module = GetExecutableModulePointer(); llvm::Error error = llvm::Error::success(); assert(!error); // Check the success value when

[Lldb-commits] [PATCH] D86355: Consume error for valid return from Target::GetEntryPointAddress()

dim created this revision. dim added reviewers: aprantl, emaste, JDevlieghere, jingham. Herald added subscribers: krytarowski, arichardson. Herald added a project: LLDB. dim requested review of this revision. When `Target::GetEntryPointAddress()` calls

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

This revision was automatically updated to reflect the committed changes. Closed by commit rGa42942e0ecd6: Fix process launch failure on FreeBSD after r365761 (authored by dim). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D68723?vs=224447=224460#toc

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

dim updated this revision to Diff 224447. dim added a comment. Herald added a subscriber: jfb. Convert `m_(monitor|operation)_thread` to `llvm::Optional<>`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 Files:

[Lldb-commits] [PATCH] D68723: Fix process launch failure on FreeBSD after r365761

dim added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68723/new/ https://reviews.llvm.org/D68723 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

dim added a comment. As I found out in https://reviews.llvm.org/rL303015, the `KERN_PROC_PATHNAME` has one drawback: if an executable file has multiple hard links, you will get just one of its filenames as the result. Since that filename is more or less randomly chosen, it does *not* have to