Re: [Lldb-commits] [lldb] r287354 - Resubmit "Remove an output-parameter from Variable function".

I tend to agree with Jim's point. I have sometimes put in things that look like "dead/vestigial code", which I am actually either planning to use later on, or actively using somewhere else. This is a quite realistic scenario due to Swift support for LLDB existing in an entirely separate

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

granata.enrico added inline comments. Comment at: scripts/Python/prepare_binding_Python.py:229 stderr=subprocess.PIPE, -shell=True) +) # Wait for SWIG process to terminate This worries me a little bit.. Are we sure we are not in any way

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

granata.enrico added a reviewer: beanz. granata.enrico added a comment. Chris, can you take a look at this? I am far from a CMake expert https://reviews.llvm.org/D26757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

I will gladly let Todd run tests on your diff, but I just thought I'd explain what is going on there In Cocoa, some NSURL objects are represented as "sub-URLs", e.g. you can start from www.apple.com and represent www.apple.com/macos as NSURL(base="www.apple.com", next="/macos") This can be

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

granata.enrico added a comment. Makes sense. Feel free to commit. Repository: rL LLVM https://reviews.llvm.org/D26403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Make what you will of my suggestion above, but in general the reasoning looks good Comment at:

[Lldb-commits] [lldb] r286176 - Simplify the PrintableRepresentationSpecialCases code; we never used the ePrintableRepresentationSpecialCasesOnly value and with enum classes the names doesn't need to

Author: enrico Date: Mon Nov 7 17:32:20 2016 New Revision: 286176 URL: http://llvm.org/viewvc/llvm-project?rev=286176=rev Log: Simplify the PrintableRepresentationSpecialCases code; we never used the ePrintableRepresentationSpecialCasesOnly value and with enum classes the names doesn't need to

[Lldb-commits] [lldb] r286116 - Fix an issue where LLDB would hang trying to launch tvOS simulator binaries

Author: enrico Date: Mon Nov 7 10:25:01 2016 New Revision: 286116 URL: http://llvm.org/viewvc/llvm-project?rev=286116=rev Log: Fix an issue where LLDB would hang trying to launch tvOS simulator binaries Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp

[Lldb-commits] [lldb] r286003 - Preliminary plumbing work to make 'parray' able to take offset and stride options

Author: enrico Date: Fri Nov 4 13:15:39 2016 New Revision: 286003 URL: http://llvm.org/viewvc/llvm-project?rev=286003=rev Log: Preliminary plumbing work to make 'parray' able to take offset and stride options Modified: lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h

[Lldb-commits] [lldb] r285943 - Add RenderScriptScriptGroup to the Xcode project

Author: enrico Date: Thu Nov 3 12:33:11 2016 New Revision: 285943 URL: http://llvm.org/viewvc/llvm-project?rev=285943=rev Log: Add RenderScriptScriptGroup to the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r285941 - Add support to the ObjC type scavenger for finding types via debug info

Author: enrico Date: Thu Nov 3 12:25:27 2016 New Revision: 285941 URL: http://llvm.org/viewvc/llvm-project?rev=285941=rev Log: Add support to the ObjC type scavenger for finding types via debug info Modified: lldb/trunk/include/lldb/Target/Language.h

[Lldb-commits] [lldb] r285736 - Add helpers for the notion of a type scavenger that is "either this or that" source, and one that is "both this and that" source

Author: enrico Date: Tue Nov 1 15:17:14 2016 New Revision: 285736 URL: http://llvm.org/viewvc/llvm-project?rev=285736=rev Log: Add helpers for the notion of a type scavenger that is "either this or that" source, and one that is "both this and that" source Use the helper to rewrite the ObjC

[Lldb-commits] [lldb] r285727 - Implement a general type scavenger that can dig types from debug info + a filtering mechanism to accept/reject results thusly obtained

Author: enrico Date: Tue Nov 1 13:50:49 2016 New Revision: 285727 URL: http://llvm.org/viewvc/llvm-project?rev=285727=rev Log: Implement a general type scavenger that can dig types from debug info + a filtering mechanism to accept/reject results thusly obtained Implement the C++ type lookup

[Lldb-commits] [lldb] r285599 - Remove a couple of old TODOs and don't make a new ConstString each time; none of this is super-critical since it applies to older versions of macOS (or OSX, I guess?) b

Author: enrico Date: Mon Oct 31 12:12:16 2016 New Revision: 285599 URL: http://llvm.org/viewvc/llvm-project?rev=285599=rev Log: Remove a couple of old TODOs and don't make a new ConstString each time; none of this is super-critical since it applies to older versions of macOS (or OSX, I guess?)

[Lldb-commits] [lldb] r285596 - Add the new minidump plugin files to the Xcode project

Author: enrico Date: Mon Oct 31 12:00:54 2016 New Revision: 285596 URL: http://llvm.org/viewvc/llvm-project?rev=285596=rev Log: Add the new minidump plugin files to the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r285332 - Add support for "type lookup" to find C and C++ types

Author: enrico Date: Thu Oct 27 13:44:45 2016 New Revision: 285332 URL: http://llvm.org/viewvc/llvm-project?rev=285332=rev Log: Add support for "type lookup" to find C and C++ types This is an important first step in closing the functionality gap between "type lookup" and "images lookup -t"

[Lldb-commits] [lldb] r285226 - Fix an issue where frame variable -s would not show the scope even though the user asked for it

Author: enrico Date: Wed Oct 26 14:17:49 2016 New Revision: 285226 URL: http://llvm.org/viewvc/llvm-project?rev=285226=rev Log: Fix an issue where frame variable -s would not show the scope even though the user asked for it Part of rdar://28434047 Added:

[Lldb-commits] [lldb] r285216 - Actually use = delete to mark constructors and operators we want to not exist. Just declaring them as private works, but it can confuse certain tools as it doesn't actu

Author: enrico Date: Wed Oct 26 13:12:52 2016 New Revision: 285216 URL: http://llvm.org/viewvc/llvm-project?rev=285216=rev Log: Actually use = delete to mark constructors and operators we want to not exist. Just declaring them as private works, but it can confuse certain tools as it doesn't

[Lldb-commits] [lldb] r284847 - I hadn't fixed all the instances of the old marker for scripted format strings; do so now

Author: enrico Date: Fri Oct 21 13:03:55 2016 New Revision: 284847 URL: http://llvm.org/viewvc/llvm-project?rev=284847=rev Log: I hadn't fixed all the instances of the old marker for scripted format strings; do so now Modified: lldb/trunk/www/formats.html Modified:

[Lldb-commits] [lldb] r284788 - frame.script became script.frame a while ago; fix up the docs

Author: enrico Date: Thu Oct 20 17:10:07 2016 New Revision: 284788 URL: http://llvm.org/viewvc/llvm-project?rev=284788=rev Log: frame.script became script.frame a while ago; fix up the docs Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL:

[Lldb-commits] [lldb] r284787 - This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory

Author: enrico Date: Thu Oct 20 17:05:21 2016 New Revision: 284787 URL: http://llvm.org/viewvc/llvm-project?rev=284787=rev Log: This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory It is misleading to users in its current form, and

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

granata.enrico added a comment. I see you already got a bunch of feedback on specific items. The overall idea looks good to me. I'll try to delve a little deeper in the code ASAP (I was out for a couple days and have some backlog...), but should be good to go assuming you address the feedback

[Lldb-commits] [lldb] r283396 - Fixes for libc++ std::unordered_map data formatter against trunk

Author: enrico Date: Wed Oct 5 17:04:43 2016 New Revision: 283396 URL: http://llvm.org/viewvc/llvm-project?rev=283396=rev Log: Fixes for libc++ std::unordered_map data formatter against trunk Fixes rdar://28237467 Modified:

Re: [Lldb-commits] [lldb] r283351 - Try to fix Android build.

Alright, I'll bite and ask... What is so special about the Android bot? Every so often, I'll see it reject a piece of syntax that other compilers gleefully handle > On Oct 5, 2016, at 10:58 AM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date:

[Lldb-commits] [lldb] r283167 - Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap

Author: enrico Date: Mon Oct 3 19:07:42 2016 New Revision: 283167 URL: http://llvm.org/viewvc/llvm-project?rev=283167=rev Log: Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap Also, proper formatting.. Modified:

Re: [Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

Woops... Guess I am just gonna reformat the entire file... Sorry about that! On 10/03/16 04:43 PM, Zachary Turner <ztur...@google.com> wrote: > > > Was this clang-formatted? some of these lines look way longer than 80 columns. > > > > On Mon, Oct 3, 2016 at 4:41

[Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

Author: enrico Date: Mon Oct 3 18:33:00 2016 New Revision: 283160 URL: http://llvm.org/viewvc/llvm-project?rev=283160=rev Log: Changes to the std::multimap formatter to make it work against trunk libc++ Fixes rdar://28237486 Modified:

[Lldb-commits] [lldb] r282824 - Prefer skipping over x-failing

Author: enrico Date: Thu Sep 29 19:41:07 2016 New Revision: 282824 URL: http://llvm.org/viewvc/llvm-project?rev=282824=rev Log: Prefer skipping over x-failing Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py Modified:

[Lldb-commits] [lldb] r282823 - Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode

Author: enrico Date: Thu Sep 29 19:40:04 2016 New Revision: 282823 URL: http://llvm.org/viewvc/llvm-project?rev=282823=rev Log: Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode Modified:

[Lldb-commits] [lldb] r282774 - This test will not work in i386 mode because we don't create interesting types from the ObjC runtime

Author: enrico Date: Thu Sep 29 16:20:56 2016 New Revision: 282774 URL: http://llvm.org/viewvc/llvm-project?rev=282774=rev Log: This test will not work in i386 mode because we don't create interesting types from the ObjC runtime "Fixes" rdar://28501616 Modified:

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

> On Sep 29, 2016, at 10:58 AM, Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > > >> On Sep 29, 2016, at 10:50 AM, Zachary Turner <ztur...@google.com >> <mailto:ztur...@google.com>> wrote: >> >> >>

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

...@google.com >> <mailto:ztur...@google.com>> wrote: >> >> >> >> On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >> >> - >> + >

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

> On Sep 28, 2016, at 5:58 PM, Zachary Turner <ztur...@google.com> wrote: > > > > On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > >

[Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

Author: enrico Date: Wed Sep 28 17:53:16 2016 New Revision: 282648 URL: http://llvm.org/viewvc/llvm-project?rev=282648=rev Log: Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator Fixes

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

ite this kind of test if we had a tool specifically for >> testing command line options similar to what I proposed with unwinding etc. >> oh well > > There already is a test for this - that's how the breakage was caught to > begin with :-) > >> On Mon, Sep

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

ar to what I proposed with unwinding etc. > oh well There already is a test for this - that's how the breakage was caught to begin with :-) > On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote:

[Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

Author: enrico Date: Mon Sep 26 16:36:17 2016 New Revision: 282445 URL: http://llvm.org/viewvc/llvm-project?rev=282445=rev Log: Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring Fixes rdar://28480275

[Lldb-commits] [lldb] r282310 - Add an accessor to get the value of RC_PLATFORM_NAME at build time

Author: enrico Date: Fri Sep 23 17:30:08 2016 New Revision: 282310 URL: http://llvm.org/viewvc/llvm-project?rev=282310=rev Log: Add an accessor to get the value of RC_PLATFORM_NAME at build time Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/trunk/scripts/Xcode/lldbbuild.py

[Lldb-commits] [lldb] r282297 - Install only the manpage and only in the proper location

Author: enrico Date: Fri Sep 23 16:24:08 2016 New Revision: 282297 URL: http://llvm.org/viewvc/llvm-project?rev=282297=rev Log: Install only the manpage and only in the proper location Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r282179 - Actually, do it this way because I will want to know if I am in a host build elsewhere too

Author: enrico Date: Thu Sep 22 12:59:58 2016 New Revision: 282179 URL: http://llvm.org/viewvc/llvm-project?rev=282179=rev Log: Actually, do it this way because I will want to know if I am in a host build elsewhere too Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified:

[Lldb-commits] [lldb] r282178 - The host version of lldb always builds for macosx

Author: enrico Date: Thu Sep 22 12:47:33 2016 New Revision: 282178 URL: http://llvm.org/viewvc/llvm-project?rev=282178=rev Log: The host version of lldb always builds for macosx Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/trunk/scripts/Xcode/lldbbuild.py URL:

[Lldb-commits] [lldb] r281993 - Make it so that one can register prefix matches as well as identical matches as extra cases for NSDictionary data formatting

Author: enrico Date: Tue Sep 20 13:26:30 2016 New Revision: 281993 URL: http://llvm.org/viewvc/llvm-project?rev=281993=rev Log: Make it so that one can register prefix matches as well as identical matches as extra cases for NSDictionary data formatting Modified:

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

granata.enrico added a comment. In https://reviews.llvm.org/D24591#543277, @beanz wrote: > @granata.enrico, we could migrate the existing tests into being executed by > lit even if they aren't using lit's features, so if that direction is desired > we could get everything in lit. That said,

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

granata.enrico added a subscriber: granata.enrico. granata.enrico added a comment. One piece of concern that I have is the multiplication of things that "testing LLDB" means. We have unit tests, Python tests, and now LIT tests. That means, for each change I want to commit, if I want confidence

[Lldb-commits] [lldb] r281282 - Fix an issue where LLDB was not masking enough bits off of objc classes data() pointers, effectively rendering us unable to generate descriptors for some classes

Author: enrico Date: Mon Sep 12 19:22:49 2016 New Revision: 281282 URL: http://llvm.org/viewvc/llvm-project?rev=281282=rev Log: Fix an issue where LLDB was not masking enough bits off of objc classes data() pointers, effectively rendering us unable to generate descriptors for some classes

[Lldb-commits] [lldb] r280513 - Check for null

Author: enrico Date: Fri Sep 2 13:15:48 2016 New Revision: 280513 URL: http://llvm.org/viewvc/llvm-project?rev=280513=rev Log: Check for null Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL:

[Lldb-commits] [lldb] r280395 - When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed

Author: enrico Date: Thu Sep 1 13:31:40 2016 New Revision: 280395 URL: http://llvm.org/viewvc/llvm-project?rev=280395=rev Log: When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed Modified: lldb/trunk/source/Core/ValueObjectRegister.cpp Modified:

Re: [Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

I am probably being a little dense right now, but I can't seem to find (const char*)0x1000 anywhere in the test case code... > On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Sep 1 04:17:37 2016 > New Revision:

[Lldb-commits] [lldb] r280389 - Change the formula for tagged NSIndexPath data formatting

Author: enrico Date: Thu Sep 1 13:09:01 2016 New Revision: 280389 URL: http://llvm.org/viewvc/llvm-project?rev=280389=rev Log: Change the formula for tagged NSIndexPath data formatting Fixes rdar://25192935 Added:

[Lldb-commits] [lldb] r280295 - Add a data formatter for std::function in libcxx

Author: enrico Date: Wed Aug 31 16:46:37 2016 New Revision: 280295 URL: http://llvm.org/viewvc/llvm-project?rev=280295=rev Log: Add a data formatter for std::function in libcxx Added:

[Lldb-commits] [lldb] r280294 - Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type

Author: enrico Date: Wed Aug 31 16:46:21 2016 New Revision: 280294 URL: http://llvm.org/viewvc/llvm-project?rev=280294=rev Log: Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type Modified:

Re: [Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

granata.enrico accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19 @@ -18,2 +18,3 @@ mydir = TestBase.compute_mydir(__file__) +

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

lt;ztur...@google.com >> <mailto:ztur...@google.com>> wrote: >> >> Is there going to be a test for this? >> >> On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits >> <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: >&g

[Lldb-commits] [lldb] r280173 - Rename the test class

Author: enrico Date: Tue Aug 30 18:00:52 2016 New Revision: 280173 URL: http://llvm.org/viewvc/llvm-project?rev=280173=rev Log: Rename the test class Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py Modified:

[Lldb-commits] [lldb] r280172 - Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider

Author: enrico Date: Tue Aug 30 18:00:02 2016 New Revision: 280172 URL: http://llvm.org/viewvc/llvm-project?rev=280172=rev Log: Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider This class enables one to easily write a synthetic child provider by writing a class that

[Lldb-commits] [lldb] r280166 - Teach ValueObject::ReadPointedString how to read char[] in host memory

Author: enrico Date: Tue Aug 30 16:33:47 2016 New Revision: 280166 URL: http://llvm.org/viewvc/llvm-project?rev=280166=rev Log: Teach ValueObject::ReadPointedString how to read char[] in host memory Modified: lldb/trunk/source/Core/ValueObject.cpp Modified:

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

is? > > On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Tue Aug 30 15:39:58 2016 > New Revision: 280151 > > URL: http://llvm.org/viewvc/llvm-pro

[Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

Author: enrico Date: Tue Aug 30 15:39:58 2016 New Revision: 280151 URL: http://llvm.org/viewvc/llvm-project?rev=280151=rev Log: Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type This is currently only implemented for the clang-based

Re: [Lldb-commits] [PATCH] D23951: Remove unused any_found local variable

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D23950: Remove unused local variable

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Looks good to me https://reviews.llvm.org/D23950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r279784 - Add a notification message in 'type lookup' when the current language doesn't yield results and one has to go across multiple languages to scan for types

Author: enrico Date: Thu Aug 25 17:11:01 2016 New Revision: 279784 URL: http://llvm.org/viewvc/llvm-project?rev=279784=rev Log: Add a notification message in 'type lookup' when the current language doesn't yield results and one has to go across multiple languages to scan for types Fixes

[Lldb-commits] [lldb] r279446 - Add a non-code-running data formatter for __NSCFBoolean

Author: enrico Date: Mon Aug 22 13:07:52 2016 New Revision: 279446 URL: http://llvm.org/viewvc/llvm-project?rev=279446=rev Log: Add a non-code-running data formatter for __NSCFBoolean Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp

[Lldb-commits] [lldb] r279353 - Add logic to the ObjC runtime in LLDB to extract the pointer values of the two singleton (pairtons?) instances of __NSCFBoolean that represent true and false

Author: enrico Date: Fri Aug 19 19:48:11 2016 New Revision: 279353 URL: http://llvm.org/viewvc/llvm-project?rev=279353=rev Log: Add logic to the ObjC runtime in LLDB to extract the pointer values of the two singleton (pairtons?) instances of __NSCFBoolean that represent true and false This is

[Lldb-commits] [lldb] r278166 - Adjust LLDB's iOS simulator interface for changes in CoreSimulator

Author: enrico Date: Tue Aug 9 16:16:58 2016 New Revision: 278166 URL: http://llvm.org/viewvc/llvm-project?rev=278166=rev Log: Adjust LLDB's iOS simulator interface for changes in CoreSimulator rdar://27732333 and rdar://27732377 Modified:

[Lldb-commits] [lldb] r278158 - Remove CFData from the xcodeproj as well

Author: enrico Date: Tue Aug 9 15:32:42 2016 New Revision: 278158 URL: http://llvm.org/viewvc/llvm-project?rev=278158=rev Log: Remove CFData from the xcodeproj as well Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r277897 - The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging /bin

Author: enrico Date: Fri Aug 5 19:57:07 2016 New Revision: 277897 URL: http://llvm.org/viewvc/llvm-project?rev=277897=rev Log: The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging

[Lldb-commits] [lldb] r277844 - Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the user

Author: enrico Date: Fri Aug 5 13:09:50 2016 New Revision: 277844 URL: http://llvm.org/viewvc/llvm-project?rev=277844=rev Log: Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the

Re: [Lldb-commits] [PATCH] D22863: Improve code of loading plugins that provide cmnds

granata.enrico added a comment. Everything Greg said makes total sense In general dynamically loadable C++ plugins as a feature is a little rough around the edges. I am glad to see interest in improving it! https://reviews.llvm.org/D22863 ___

[Lldb-commits] [lldb] r276709 - Print a warning if the directory passed to --test-subdir doesn't end up existing

Author: enrico Date: Mon Jul 25 18:26:24 2016 New Revision: 276709 URL: http://llvm.org/viewvc/llvm-project?rev=276709=rev Log: Print a warning if the directory passed to --test-subdir doesn't end up existing Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py Modified:

[Lldb-commits] [lldb] r276220 - Fix an issue where LLDB would detect an empty shared cache - which is legitimate albeit suboptimal - and warn about being unable to fetch ObjC class information, even t

Author: enrico Date: Wed Jul 20 19:13:40 2016 New Revision: 276220 URL: http://llvm.org/viewvc/llvm-project?rev=276220=rev Log: Fix an issue where LLDB would detect an empty shared cache - which is legitimate albeit suboptimal - and warn about being unable to fetch ObjC class information, even

[Lldb-commits] [lldb] r276061 - Fix an issue where the libc++ std::list formatter wasn't recognizing the new memory layout correctly

Author: enrico Date: Tue Jul 19 18:50:31 2016 New Revision: 276061 URL: http://llvm.org/viewvc/llvm-project?rev=276061=rev Log: Fix an issue where the libc++ std::list formatter wasn't recognizing the new memory layout correctly rdar://problem/26999542 Modified:

Re: [Lldb-commits] [PATCH] D22286: [LLDB] Help text overhaul

granata.enrico added inline comments. Comment at: source/Commands/CommandObjectCommands.cpp:2272 @@ -2271,3 +2271,3 @@ "command script", -"A set of commands for managing or customizing script commands.", +

[Lldb-commits] [lldb] r275199 - Tweaks to the NSIndexPath formatter to enhance stability

Author: enrico Date: Tue Jul 12 13:33:52 2016 New Revision: 275199 URL: http://llvm.org/viewvc/llvm-project?rev=275199=rev Log: Tweaks to the NSIndexPath formatter to enhance stability rdar://problem/25767901 Modified: lldb/trunk/source/Plugins/Language/ObjC/NSIndexPath.cpp Modified:

[Lldb-commits] [lldb] r275080 - Fix an issue where one could not define a Python command with the same name as an existing alias (or rather, one could but the results of invoking the command were far

Author: enrico Date: Mon Jul 11 12:36:55 2016 New Revision: 275080 URL: http://llvm.org/viewvc/llvm-project?rev=275080=rev Log: Fix an issue where one could not define a Python command with the same name as an existing alias (or rather, one could but the results of invoking the command were far

[Lldb-commits] [lldb] r274901 - Make IsSyntheticChildrenGenerated() virtual so that dynamic and synthetic values can refer back to their parents

Author: enrico Date: Fri Jul 8 13:39:36 2016 New Revision: 274901 URL: http://llvm.org/viewvc/llvm-project?rev=274901=rev Log: Make IsSyntheticChildrenGenerated() virtual so that dynamic and synthetic values can refer back to their parents Modified:

[Lldb-commits] [lldb] r274697 - Fix the installation of the vector data formatters in order to restore functionality

Author: enrico Date: Wed Jul 6 17:35:34 2016 New Revision: 274697 URL: http://llvm.org/viewvc/llvm-project?rev=274697=rev Log: Fix the installation of the vector data formatters in order to restore functionality Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp

[Lldb-commits] [lldb] r274683 - Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area:

Author: enrico Date: Wed Jul 6 16:24:28 2016 New Revision: 274683 URL: http://llvm.org/viewvc/llvm-project?rev=274683=rev Log: Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area: - if a synthetic child comes from the same hierarchy

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

granata.enrico added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665 @@ +664,3 @@ + +stl_summary_flags.SetDontShowChildren(true); +AddCXXSummary(cpp_category_sp, lldb_private::formatters::LibStdcppSmartPointerSummaryProvider,

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

granata.enrico added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665 @@ +664,3 @@ + +stl_summary_flags.SetDontShowChildren(true); +AddCXXSummary(cpp_category_sp, lldb_private::formatters::LibStdcppSmartPointerSummaryProvider,

[Lldb-commits] [lldb] r274164 - Add NSTaggedPointerString to the table of data formatters

Author: enrico Date: Wed Jun 29 16:00:18 2016 New Revision: 274164 URL: http://llvm.org/viewvc/llvm-project?rev=274164=rev Log: Add NSTaggedPointerString to the table of data formatters Fixes rdar://27002512 Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp Modified:

[Lldb-commits] [lldb] r273721 - The Objective-C Class type should not be treated as a potential dynamic type, since it actually doesn't resolve to the type of the class it points to

Author: enrico Date: Fri Jun 24 15:45:08 2016 New Revision: 273721 URL: http://llvm.org/viewvc/llvm-project?rev=273721=rev Log: The Objective-C Class type should not be treated as a potential dynamic type, since it actually doesn't resolve to the type of the class it points to Fixes

[Lldb-commits] [lldb] r273695 - Fix an issue where LLDB would show the key and value of a single entry NSDictionary in the wrong order

Author: enrico Date: Fri Jun 24 12:48:01 2016 New Revision: 273695 URL: http://llvm.org/viewvc/llvm-project?rev=273695=rev Log: Fix an issue where LLDB would show the key and value of a single entry NSDictionary in the wrong order Fixes rdar://26478641 Added:

Re: [Lldb-commits] [PATCH] D21680: Fix the libc++ pretty printers for the android NDK

granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r273640 - Fix an issue where the @lldb.command marker would not work with the new 5-argument version of the Python command function

Author: enrico Date: Thu Jun 23 21:07:15 2016 New Revision: 273640 URL: http://llvm.org/viewvc/llvm-project?rev=273640=rev Log: Fix an issue where the @lldb.command marker would not work with the new 5-argument version of the Python command function This: a) teaches PythonCallable to look

[Lldb-commits] [lldb] r270793 - It has been brought to my attention that, given two variables

Author: enrico Date: Wed May 25 18:19:01 2016 New Revision: 270793 URL: http://llvm.org/viewvc/llvm-project?rev=270793=rev Log: It has been brought to my attention that, given two variables T x; U y; doing x = *((T*)y) is undefined behavior, even if sizeof(T) == sizeof(U), due to pointer

[Lldb-commits] [lldb] r270770 - Add logging to ValueObjectSyntheticFilter such that one can trace through the creation of synthetic children

Author: enrico Date: Wed May 25 16:38:32 2016 New Revision: 270770 URL: http://llvm.org/viewvc/llvm-project?rev=270770=rev Log: Add logging to ValueObjectSyntheticFilter such that one can trace through the creation of synthetic children Modified:

[Lldb-commits] [lldb] r270621 - Fix an issue where the NSDate data formatter was not using the proper alignment on watchOS targets

Author: enrico Date: Tue May 24 17:11:57 2016 New Revision: 270621 URL: http://llvm.org/viewvc/llvm-project?rev=270621=rev Log: Fix an issue where the NSDate data formatter was not using the proper alignment on watchOS targets Fixes rdar://problem/23298264 Modified:

[Lldb-commits] [lldb] r269378 - Add a check for version 15 of the shared cache format

Author: enrico Date: Thu May 12 18:04:43 2016 New Revision: 269378 URL: http://llvm.org/viewvc/llvm-project?rev=269378=rev Log: Add a check for version 15 of the shared cache format Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [lldb] r268686 - Revert r268591

Author: enrico Date: Thu May 5 16:10:28 2016 New Revision: 268686 URL: http://llvm.org/viewvc/llvm-project?rev=268686=rev Log: Revert r268591 "Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery This is not meant to report that a value doesn't have a

[Lldb-commits] [lldb] r268591 - Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery

Author: enrico Date: Wed May 4 20:47:44 2016 New Revision: 268591 URL: http://llvm.org/viewvc/llvm-project?rev=268591=rev Log: Allow LanguageRuntimes to return an error if they fail in the course of dynamic type discovery This is not meant to report that a value doesn't have a dynamic type -

[Lldb-commits] [lldb] r268587 - Make the functions that fetch data from the ObjC runtime choose whether or not to log depending on whether the types log is enabled

Author: enrico Date: Wed May 4 20:15:57 2016 New Revision: 268587 URL: http://llvm.org/viewvc/llvm-project?rev=268587=rev Log: Make the functions that fetch data from the ObjC runtime choose whether or not to log depending on whether the types log is enabled This can prove helpful in debugging

[Lldb-commits] [lldb] r268303 - Add more debug logging to g_get_shared_cache_class_info_body

Author: enrico Date: Mon May 2 15:58:15 2016 New Revision: 268303 URL: http://llvm.org/viewvc/llvm-project?rev=268303=rev Log: Add more debug logging to g_get_shared_cache_class_info_body Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [lldb] r268274 - Add an argument to ValueObject::GetSyntheticBase that allows for name customization on the generated value

Author: enrico Date: Mon May 2 13:13:18 2016 New Revision: 268274 URL: http://llvm.org/viewvc/llvm-project?rev=268274=rev Log: Add an argument to ValueObject::GetSyntheticBase that allows for name customization on the generated value Modified: lldb/trunk/include/lldb/Core/ValueObject.h

Re: [Lldb-commits] [PATCH] D19690: Split out console and file writing cases in TestCommandScriptImmediateOutput

granata.enrico added a comment. LGTM http://reviews.llvm.org/D19690 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

granata.enrico added a comment. My personal preference would be to split up the test cases. I'd really like to keep testing the immediate output to console scenario since it is interesting for - e.g. - kernel debugging at Apple. http://reviews.llvm.org/D19633

Re: [Lldb-commits] [PATCH] D19633: Move TestCommandScriptImmediateOutput from PExpectTest to TestBase

granata.enrico added a comment. Why are we trying to do this in the first place? The entire purpose of this test is to verify the immediate output to the console. If you want to test the output to a file instead, make a separate test case, that would be fine. But I'd rather much leave this

[Lldb-commits] [lldb] r267372 - Add a --element-count option to the expression command

Author: enrico Date: Sun Apr 24 19:52:47 2016 New Revision: 267372 URL: http://llvm.org/viewvc/llvm-project?rev=267372=rev Log: Add a --element-count option to the expression command This option evaluates an expression and, if the result is of pointer type, treats it as if it was an array of

[Lldb-commits] [lldb] r266911 - Fix a bug where LLDB would crash if 'apropos ' was used after spawning an inferior process

Author: enrico Date: Wed Apr 20 15:48:05 2016 New Revision: 266911 URL: http://llvm.org/viewvc/llvm-project?rev=266911=rev Log: Fix a bug where LLDB would crash if 'apropos ' was used after spawning an inferior process Added:

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

> On Apr 14, 2016, at 10:56 AM, Oleksiy Vyalov via lldb-commits > wrote: > > ovyalov added a comment. > > In http://reviews.llvm.org/D19092#401450, @jingham wrote: > >> Why is this necessary? stdout is a local variable defined in this scope. >> Why would the

[Lldb-commits] [lldb] r266271 - Don't use auto - (try to) appease the Android g++ bot

Author: enrico Date: Wed Apr 13 20:23:01 2016 New Revision: 266271 URL: http://llvm.org/viewvc/llvm-project?rev=266271=rev Log: Don't use auto - (try to) appease the Android g++ bot Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp Modified:

  1   2   3   4   >