[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

2016-12-02 Thread Filipe Cabecinhas via Phabricator via lldb-commits
filcab accepted this revision. filcab added a comment. LGTM (I commented on a minor nit. It might just be me, so feel free to keep the current wording if you feel it's preferred) https://reviews.llvm.org/D27017 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

2016-11-29 Thread Filipe Cabecinhas via Phabricator via lldb-commits
filcab added a comment. I'd mostly use Anna's suggestions. Kuba: Can you remove the "detected" from the messages and refresh the patch, just so we can have one last look? Otherwise, if you think it's good enough, commit with these changes and we can do post-commit review.