[Lldb-commits] [PATCH] D72909: Make SymbolFileDWARF::ParseLineTable use std::sort instead of insertion sort

grimar added inline comments. Comment at: lldb/source/Symbol/LineTable.cpp:27 + LineTable::Entry::LessThanBinaryPredicate less_than_bp(this); + std::sort(sequences.begin(), sequences.end(), less_than_bp); + for (auto *sequence : sequences) { I wonder if this

[Lldb-commits] [PATCH] D69254: [lldb] drop .symtab removal in minidebuginfo tests

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69254/new/ https://reviews.llvm.org/D69254

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. I've posted a change for yaml2obj/obj2yaml here: D69041 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68943/new/ https://reviews.llvm.org/D68943

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. In D68943#1710525 , @MaskRay wrote: > In D68943#1709998 , @grimar wrote: > > > Ok, I was able to debug it finally. > > > > I think we should add a .symtab in a few more cases implicitly. > >

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. Ok, I was able to debug it finally. I think we should add a .symtab in a few more cases implicitly. For example, when we have a SHT_RELA/SHT_REL section that has an empty Link, i.e. it refers to .symtab by default and we should provide it. There are other cases, like when

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

grimar added inline comments. Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3 + +# Test that we report an error for an ExceptionStream where the specified +# number of parameters is greater than the number of ExceptionInformation

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. In D68943#1709330 , @kwk wrote: > I noticed that the order of sections does matter to some tests. Before the > `.symtab` section was always the first one and now it is the last of the > implicit sections being created. Some

[Lldb-commits] [PATCH] D68943: [llvm][yaml2obj] no more implicit ELF .symtab section

grimar added a comment. I have not looked what is needed to fix yaml2obj testcases yet, but below there are few first comments. Also, 2 LLVM side tests added should live in "llvm/test/tools/yaml2obj" I think (not in llvm/test/ObjectYAML/ELF/), because this is actually the place where we test

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM with 2 nits. Comment at: llvm/test/tools/yaml2obj/minidump-exception-missing-parameter.yaml:3 + +# Test that we report an error for an ExceptionStream where the

[Lldb-commits] [PATCH] D68657: Update MinidumpYAML to use minidump::Exception for exception stream

grimar added inline comments. Comment at: llvm/include/llvm/ObjectYAML/MinidumpYAML.h:113-114 + ExceptionStream() + : Stream(StreamKind::Exception, minidump::StreamType::Exception) { +memset(, 0, sizeof(minidump::ExceptionStream)); + } I'd avoid

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

grimar accepted this revision. grimar added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68645/new/ https://reviews.llvm.org/D68645 ___ lldb-commits

[Lldb-commits] [PATCH] D68645: MinidumpYAML: Add support for the memory info list stream

grimar added inline comments. Comment at: include/llvm/ObjectYAML/MinidumpYAML.h:111 + + explicit MemoryInfoListStream(std::vector Infos) + : Stream(StreamKind::MemoryInfoList, Maybe be more explicit here, i.e. ``` std::vector & ``` ?

[Lldb-commits] [PATCH] D62570: [WIP] Use LLVM's debug line parser in LLDB

grimar added inline comments. Comment at: lldb/include/lldb/Core/FileSpecList.h:29 + typedef std::vector collection; + typedef collection::iterator iterator; + typedef collection::const_iterator const_iterator; Seems you don't use `iterator` anywhere?

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351313: [lldb] - Fix crash when listing the history with the key up. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar added a comment. In D56014#1358769 , @JDevlieghere wrote: > Although I don't want to condone checking things in without a test case, > given that the fix is obvious and that testing it is non-trivial, I think > it's fine to check this in as is.

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar abandoned this revision. grimar added a comment. Yep, MSVS2017 works fine here for me too. Thanks, Pavel! I am abandoning it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar planned changes to this revision. grimar added a comment. In D56014#1341129 , @labath wrote: > I guess it should be possible to trigger this from dotest tests via pexpect. > I know we try to avoid it, but given that this is specifically testing >

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar planned changes to this revision. grimar added a comment. I'll try to switch to MSVS 2017 and recheck this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. In D55995#1352772 , @labath wrote: > BTW, I've been compiling lldb with VS2017 and haven't run into this issue. > Also, with the imminent release of VS2019, I expect someone will soon start a > thread proposing to drop VS2015, so

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar updated this revision to Diff 179535. grimar edited the summary of this revision. grimar added a comment. - Addressed review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55995/new/ https://reviews.llvm.org/D55995 Files: include/lldb/lldb-defines.h

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar added a comment. In D56014#1339419 , @davide wrote: > testcase? I investigated how to add it and I do not see a good way write a test :( Seems the proper place to test it would be `unittest/Editline`:

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar created this revision. grimar added reviewers: LLDB, clayborg. This is https://bugs.llvm.org/show_bug.cgi?id=40112, Currently, lldb crashes after pressing the up arrow key when listing the history for expressions. The patch fixes the mistype that was a reason.

[Lldb-commits] [PATCH] D55995: [lldb] - Fix compilation with MSVS 2015 update 3

grimar created this revision. grimar added reviewers: clayborg, LLDB. Currently, lldb fails to build with the following errors when MSVS update 3 is used: > fatal error C1001: An internal error has occurred in the compiler. > (compiler file 'msc1.cpp', line 1468) > To work around this

[Lldb-commits] [PATCH] D54844: [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo

This revision was automatically updated to reflect the committed changes. Closed by commit rL347859: [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB347842: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used… (authored by grimar, committed by ). Herald added subscribers: lldb-commits, teemperor, abidh. Repository:

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar marked an inline comment as done. grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:355-356 + if (addr_base == LLDB_INVALID_ADDRESS) +addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, +

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar updated this revision to Diff 175456. grimar added a comment. - Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751 Files: lit/Breakpoint/Inputs/split-dwarf-5-addrbase.dwo.yaml

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:351 + if (!addr_base) +addr_base = + cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_GNU_addr_base, 0); jankratochvil wrote: > Here I would find good also

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

grimar updated this revision to Diff 175222. grimar marked an inline comment as done. grimar added a comment. Thanks for looking at this, Jan! - Rewrote the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54751/new/ https://reviews.llvm.org/D54751 Files:

[Lldb-commits] [PATCH] D54844: [LLDB] - Improve the support of .debug_str_offsets/.debug_str_offsets.dwo

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, aprantl. A skeleton compilation unit may contain the DW_AT_str_offsets_base attribute that points to the first string offset of the CU contribution to the .debug_str_offsets. At the same

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 owere used for executable.

grimar updated this revision to Diff 174755. grimar added a comment. - Added the test case forgotten. https://reviews.llvm.org/D54751 Files: lit/Breakpoint/Inputs/split-dwarf-5-addrbase.dwo.yaml lit/Breakpoint/Inputs/split-dwarf-5-addrbase.yaml lit/Breakpoint/split-dwarf-5-addrbase.test

[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 owere used for executable.

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, aprantl. Imagine the following code: void baz() { } int main() { baz(); return 0; } When compiling with with `-gdwarf-4 -gsplit-dwarf` LLDB is able to set the

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar closed this revision. grimar added a comment. Committed as https://reviews.llvm.org/rLLDB346848. The commit message has a wrong review link by mistake. https://reviews.llvm.org/D52403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D53929: [LLDB] - Add support for DW_FORM_rnglistx and relative DW_RLE_* entries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345958: [LLDB] - Add support for DW_FORM_rnglistx and relative DW_RLE_* entries. (authored by grimar, committed by ). Changed prior to commit: https://reviews.llvm.org/D53929?vs=172121=172323#toc

[Lldb-commits] [PATCH] D53929: [LLDB] - Add support for DW_FORM_rnglistx and relative DW_RLE_* entries.

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1072-1079 + if (at_ranges_val != DW_INVALID_OFFSET) { +if (DWARFDebugRangesBase *debug_ranges = dwarf2Data->DebugRanges()) { + + dw_offset_t debug_ranges_offset; + if

[Lldb-commits] [PATCH] D53929: [LLDB] - Add support for DW_FORM_rnglistx and relative DW_RLE_* entries.

grimar updated this revision to Diff 172121. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D53929 Files: lit/Breakpoint/Inputs/debug_rnglistx_rlex.yaml lit/Breakpoint/debug_rnglistx_rlex.test source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

grimar added inline comments. Comment at: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:163 + uint64_t length = data.GetU32(); + bool isDwarf64 = false; + if (length == 0x) { xbolva00 wrote: > variable is not used anywhere Removed in

[Lldb-commits] [PATCH] D53929: [LLDB] - Add support for DW_FORM_rnglistx and relative DW_RLE_* entries.

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added a subscriber: JDevlieghere. This adds support for DW_RLE_base_addressx, DW_RLE_startx_endx, DW_RLE_startx_length, DW_FORM_rnglistx. https://reviews.llvm.org/D53929 Files:

[Lldb-commits] [PATCH] D53813: [LLDB] - Add support for DW_FORM_addrx[1-4]? forms.

This revision was automatically updated to reflect the committed changes. Closed by commit rL345706: [LLDB] - Add support for DW_FORM_addrx[1-4]? forms. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D53813: [LLDB] - Add support for DW_FORM_addrx[1-4]? forms.

grimar added a comment. I have a patch for `DW_FORM_rnglistx`. Will be happy to land this one first though, as they share a code in DWARFUnit.h/cpp a bit. https://reviews.llvm.org/D53813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D53813: [LLDB] - Add support for DW_FORM_addrx[1-4]? forms.

grimar updated this revision to Diff 171517. grimar retitled this revision from "[LLDB] - Add support for DW_FORM_rnglistx, DW_FORM_addrx[1-4]? forms." to "[LLDB] - Add support for DW_FORM_addrx[1-4]? forms.". grimar edited the summary of this revision. grimar added a comment. - Removed

[Lldb-commits] [PATCH] D53813: [LLDB] - Add support for DW_FORM_rnglistx, DW_FORM_addrx[1-4]? forms.

grimar planned changes to this revision. grimar added a comment. Planning changes. Going to remove the DW_FORM_rnglistx support from this patch, found it is incomplete and has other issues. https://reviews.llvm.org/D53813 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D53813: [LLDB] - Add support for DW_FORM_rnglistx, DW_FORM_addrx[1-4]? forms.

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added a subscriber: JDevlieghere. This adds the support for DW_FORM_rnglistx, DW_FORM_addrx, DW_FORM_addrx1, DW_FORM_addrx2, DW_FORM_addrx3, DW_FORM_addrx4 forms. https://reviews.llvm.org/D53813 Files:

[Lldb-commits] [PATCH] D53646: [LLDB] - Parse the DW_LLE_startx_length correctly for DWARF v5 case.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB345249: [LLDB] - Parse the DW_LLE_startx_length correctly for DWARF v5 case. (authored by grimar, committed by ). Herald added a subscriber: lldb-commits. Repository: rLLDB LLDB

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

This revision was automatically updated to reflect the committed changes. Closed by commit rL345127: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

grimar added a comment. Ping. https://reviews.llvm.org/D53140 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53436: [LLDB] - Implement the support for the .debug_loclists section.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB345016: [LLDB] - Implement the support for the .debug_loclists section. (authored by grimar, committed by ). Herald added a subscriber: abidh. Repository: rLLDB LLDB https://reviews.llvm.org/D53436

[Lldb-commits] [PATCH] D53436: [LLDB] - Implement the support for the .debug_loclists section.

grimar updated this revision to Diff 170468. grimar added a comment. - Used lldbassert as suggested. https://reviews.llvm.org/D53436 Files: include/lldb/Expression/DWARFExpression.h include/lldb/lldb-enumerations.h source/Core/Section.cpp source/Expression/DWARFExpression.cpp

[Lldb-commits] [PATCH] D53436: [LLDB] - Implement the support for the .debug_loclists section.

grimar added a comment. Since .debug_loclists contains locations descriptions for objects that can change location during lifetime, I do not see a way to write the test without relying on a compiler that has support for DWARF5. We should compile and run executable to test that location was

[Lldb-commits] [PATCH] D53436: [LLDB] - Implement the support for the .debug_loclists section.

grimar created this revision. grimar added reviewers: clayborg, LLDB. Herald added subscribers: JDevlieghere, arichardson, aprantl, emaste. Herald added a reviewer: espindola. This implements the support for .debug_loclists section, which is DWARF 5 version of .debug_loc. Currently, clang is

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

grimar updated this revision to Diff 170050. grimar added a comment. - Rebased, resolved conflicts. https://reviews.llvm.org/D53140 Files: lit/Breakpoint/Inputs/debug_rnglist_offset_pair.yaml lit/Breakpoint/debug_rnglist_offset_pair.test

[Lldb-commits] [PATCH] D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

This revision was automatically updated to reflect the committed changes. Closed by commit rL344674: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists) (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D53193: [LLDB] - Add support for DW_RLE_start_end entries (.debug_rnglists)

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, aprantl. DWARF5 describes DW_RLE_start_end as: > This is a form of bounded range entry that has two target address operands. > Each operand is the same size as used in DW_FORM_addr.

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h:51-55 + struct RngListEntry { +uint8_t encoding; +uint64_t value0; +uint64_t value1; + }; clayborg wrote: > Do we really need to store all this? Can't we

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB344328: [LLDB] - Add support for DW_FORM_implicit_const. (authored by grimar, committed by ). Herald added a subscriber: abidh. Changed prior to commit:

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added a subscriber: JDevlieghere. The patch implements the support for DW_RLE_base_address and DW_RLE_offset_pair .debug_rnglists entries https://reviews.llvm.org/D53140 Files:

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar updated this revision to Diff 169209. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52689 Files: lit/Breakpoint/Inputs/implicit_const_form_support.yaml lit/Breakpoint/implicit_const_form_support.test

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFAttribute.h:23 + DWARFAttribute(dw_attr_t attr, dw_form_t form, + DWARFFormValue::ValueType value) + : m_attr(attr), m_form(form), m_value(value) {} clayborg

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar updated this revision to Diff 169177. grimar marked 4 inline comments as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52689 Files: lit/Breakpoint/Inputs/implicit_const_form_support.yaml lit/Breakpoint/implicit_const_form_support.test

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h:51 + uint32_t idx, dw_attr_t , dw_form_t , + DWARFFormValue::ValueType *val = nullptr) const { +m_attributes[idx].get(attr, form, val);

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar updated this revision to Diff 169005. grimar marked 12 inline comments as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52689 Files: lit/Breakpoint/Inputs/implicit_const_form_support.yaml lit/Breakpoint/implicit_const_form_support.test

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

This revision was automatically updated to reflect the committed changes. Closed by commit rL344119: [LLDB] - Add basic support for .debug_rnglists section (DWARF5) (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

grimar added a comment. In https://reviews.llvm.org/D52981#1257888, @clayborg wrote: > For space savings it seems like we would want to support the > DW_RLE_base_address and DW_RLE_offset_pair pretty soon. I am working on a follow-up patch to support those. https://reviews.llvm.org/D52981

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar added a comment. Ping. https://reviews.llvm.org/D52689 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:134-144 +uint8_t encoding = data.GetU8(offset_ptr); + +if (encoding == DW_RLE_end_of_list) + return true; + +if (encoding == DW_RLE_start_length) { + dw_addr_t

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

grimar updated this revision to Diff 168759. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52981 Files: include/lldb/lldb-enumerations.h lit/Breakpoint/Inputs/debug_rnglist_basic.yaml lit/Breakpoint/debug_rnglist_basic.test source/Core/Section.cpp

[Lldb-commits] [PATCH] D52981: [LLDB] - Add basic support for .debug_rnglists section (DWARF5)

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, arichardson, emaste. Herald added a reviewer: espindola. This adds a basic support of the .debug_rnglists section. Only the DW_RLE_start_length and DW_RLE_end_of_list entries are

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar added a comment. In https://reviews.llvm.org/D52689#1253175, @vsk wrote: > Could you describe how the test exercises DW_FORM_implicit_const support? > It's not immediately clear to me. The abbreviation for `foo1` and `foo2` subprograms use it for `DW_AT_decl_file` and

[Lldb-commits] [PATCH] D52689: [LLDB] - Add support for DW_FORM_implicit_const.

grimar created this revision. grimar added reviewers: LLDB, clayborg. Herald added subscribers: JDevlieghere, aprantl. LLDB does not support this DWARF5 form atm. At least gcc emits it in some cases when doing optimization for abbreviations. As far I can tell, clang does not support it yet,

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added a comment. Thanks for the review! It still depends on -gsingle-file-split-dwarf (https://reviews.llvm.org/D52403), I'll wait for it some time. It should be possible to rewrite the comment in the test case to avoid mentioning the flag, but I would prefer to use it.

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar updated this revision to Diff 167440. grimar marked an inline comment as done. grimar added a comment. - Addressed review comments. https://reviews.llvm.org/D52403 Files: include/lldb/lldb-enumerations.h lit/Breakpoint/Inputs/single-file-split-dwarf.o.yaml

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added inline comments. Comment at: include/lldb/lldb-enumerations.h:643-660 + eSectionTypeDWARFDebugAbbrevDwo, eSectionTypeDWARFDebugAddr, eSectionTypeDWARFDebugAranges, eSectionTypeDWARFDebugCuIndex, eSectionTypeDWARFDebugFrame,

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar updated this revision to Diff 167287. grimar added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. - Addressed review comments. https://reviews.llvm.org/D52403 Files: include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar added a comment. Thanks for all the comments! In https://reviews.llvm.org/D52403#1243127, @clayborg wrote: > So the main questions is: do we need a new section enum called > eSectionTypeDWARFDebugInfoDWO? If so, then this patch changes. I think I > would prefer adding a new enum.

[Lldb-commits] [PATCH] D52403: [LLDB] - Support the single file split DWARF.

grimar created this revision. grimar added reviewers: LLDB, clayborg, aprantl, dblaikie, probinson. Herald added a subscriber: JDevlieghere. DWARF5 spec describes single file split dwarf case (when .dwo sections are in the .o files). Problem is that LLDB does not work correctly in that case.

[Lldb-commits] [PATCH] D51935: [LLDB] - Improved DWARF5 support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL342153: [LLDB] - Improved DWARF5 support. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51935?vs=165289=165322#toc

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar updated this revision to Diff 165289. grimar marked 2 inline comments as done. grimar added a comment. - Addressed comments. - Changed test case to use yaml2obj. https://reviews.llvm.org/D51935 Files: include/lldb/lldb-enumerations.h

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar added inline comments. Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugLine.cpp:442 +ReadDescriptors(debug_line_data, offset_ptr); +uint8_t dirCount = debug_line_data.GetU8(offset_ptr); +for (int i = 0; i < dirCount; ++i) { probinson

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar added a comment. In https://reviews.llvm.org/D51935#1232195, @clayborg wrote: > Patch looks good. A few fixes mentioned in inlined comments. And I am unsure > how the test suite will run with various compilers if they don't support the > -gdwarf-5 flag. We might need to run obj2yaml on

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar planned changes to this revision. grimar added a comment. Will reupload. https://reviews.llvm.org/D51935 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar updated this revision to Diff 165112. grimar added a comment. - Addressed review comments. - Added test case. - Minor cosmetic changes. https://reviews.llvm.org/D51935 Files: include/lldb/lldb-enumerations.h packages/Python/lldbsuite/test/functionalities/show_location/Makefile

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar marked 5 inline comments as done. grimar added a comment. Thanks for the review, Greg! I'll address your comments and add the test case when it will be ready. Hope soon. https://reviews.llvm.org/D51935 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D51935: [LLDB] - Improve reporting source lines and variables (improved DWARF5 support).

grimar created this revision. grimar added a reviewer: LLDB. Herald added subscribers: JDevlieghere, arichardson, aprantl, emaste. Herald added a reviewer: espindola. grimar edited the summary of this revision. This patch improves the support of DWARF5 by lldb. Imagine we have the following