[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

2023-06-13 Thread Hans Wennborg via Phabricator via lldb-commits 
hans edited reviewers, added: labath; removed: hans.
hans added a comment.
Herald added a subscriber: JDevlieghere.

+labath


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152712/new/

https://reviews.llvm.org/D152712

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

2023-05-25 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

This looks right to me. (I'm out of office at the moment, but this looks like 
what I tested in https://github.com/llvm/llvm-project/issues/62719 so it should 
work.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151344/new/

https://reviews.llvm.org/D151344

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-22 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

>>> Do you have a suggestion how we can move this patch forward?
>>
>> IIRC, D150688  + the diff in 
>> https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 + 
>> upgrading the pre-merge linux bot should take care of all known issues.
>
> Would it make sense to put all these patches in one new review and then test 
> that on Chromium and ask @glandium to test that too. Then we know whether it 
> solves the issues. Do you want me to make a patch or do you want to do it?

I tested 
https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 on 
Chromium already, and that looks good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-19 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D144509#4350052 , @Mordante wrote:

> In D144509#4349921 , @thakis wrote:
>
>> Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 
>>  for 
>> now.
>>
>> Sorry this is such a pain to land :(
>>
>> (See also discussion over in D150688 )
>
> I'm not happy that the patch needs to be reverted again.
>
> It has taken me a lot of time to contact all buildbots maintainers to get all 
> buildbots updated to the minimal CMake requirement.

I sympathize with this, but I still believe reverting in these situations is 
the right thing to do. It reduces disruption for everyone who needs their 
builds to keep working, while allowing the failures to be investigated without 
the pressure of knowing that head is currently broken. That this patch has been 
hard to land is in the nature of the change itself.

> Now that they are updated it turned out that one of the two last updated bots 
> has an issue with this patch and that has been fixed. But now it seems to 
> break Chromium. I don't have access to Windows so I don't know how I can test 
> patches.

I'm happy to test patches on my Windows machine.

> Do you have a suggestion how we can move this patch forward?

IIRC, D150688  + the diff in 
https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 + 
upgrading the pre-merge linux bot should take care of all known issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-17 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D144509#4349399 , @mstorsjo wrote:

> In D144509#4349051 , @hans wrote:
>
>> In D144509#4347562 , @glandium 
>> wrote:
>>
>>> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c 
>>>  is 
>>> causing problems on Windows compiler-rt for some reason I haven't 
>>> identified yet (with cmake 3.25.1). Which suggests for a same version of 
>>> cmake, this is actually altering its behavior, which I wouldn't have 
>>> expected...
>>
>> It is indeed unfortunate that this seems to come with such a fundamental 
>> behavior change. (we already have 
>> https://github.com/llvm/llvm-project/issues/62719) Do you have a repro for 
>> the issue you're seeing?
>>
>> Since the breakages are piling up, perhaps it's time to revert this.
>
> Unfortunately, much of this is hard to sort out without actually trying to 
> patch forward on main, since many of these issues don't show up easily in 
> e.g. premerge testing or similar (the patch has been tried many times for 
> months before in that form), so I'd appreciate if we'd give it a little more 
> time to actually try to sort out the issues...

But now we have identified issues and there are reproducers available (e.g. on 
https://github.com/llvm/llvm-project/issues/62719). Keeping it in main is just 
disruptive and risks making reverting harder (it's already not a clean revert). 
I think the policy of reverting back to green still applies.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

2023-05-17 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D144509#4347562 , @glandium wrote:

> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c 
>  is 
> causing problems on Windows compiler-rt for some reason I haven't identified 
> yet (with cmake 3.25.1). Which suggests for a same version of cmake, this is 
> actually altering its behavior, which I wouldn't have expected...

It is indeed unfortunate that this seems to come with such a fundamental 
behavior change. (we already have 
https://github.com/llvm/llvm-project/issues/62719) Do you have a repro for the 
issue you're seeing?

Since the breakages are piling up, perhaps it's time to revert this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144509/new/

https://reviews.llvm.org/D144509

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

2022-07-28 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

Here's an example where I think this regressed a Clang diagnostic. Consider:

  template  struct Template { Template(int x) {} };
  
  struct S1 {
struct Foo;
typedef Template Typedef;
  };
  
  struct S2 {
struct Foo;
typedef Template Typedef;
  };
  
  typedef S1::Typedef Bar;
  Bar f;

before this change, Clang would say:

  /tmp/a.cc:14:5: error: no matching constructor for initialization of 'Bar' 
(aka 'Template')
  Bar f;
  ^

however, after this change it says:

  /tmp/a.cc:14:5: error: no matching constructor for initialization of 'Bar' 
(aka 'Template')
  Bar f;
  ^

The problem is that just based on `Template` it's not clear whether it's 
`S1::Foo` or `S2::Foo` that's referred to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112374/new/

https://reviews.llvm.org/D112374

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

2022-05-27 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.
Herald added a project: All.

In D74727#1887325 , @stella.stamenova 
wrote:

> It looks like this broke the Windows LLDB Buildbot:
>
> http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14048/steps/build/logs/stdio

Seems it may have also broken the Windows LLDB releases is general: 
https://github.com/llvm/llvm-project/issues/54589

and should the docs be updated too? 
https://github.com/llvm/llvm-project/blob/llvmorg-14.0.4/lldb/docs/resources/build.rst#id7


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74727/new/

https://reviews.llvm.org/D74727

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

2022-04-19 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

Looks great to me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123957/new/

https://reviews.llvm.org/D123957

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

2022-04-19 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

If it's possible, maybe this could be worded in a way that strongly suggests 
the release notes should ideally be updated in the same patch as the code 
change?
I think we're generally good at doing this for tests. It would be great if we 
could treat release notes the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123957/new/

https://reviews.llvm.org/D123957

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

2022-01-04 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

Sorry, the attached file is here: F20424768: a.ii 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110216/new/

https://reviews.llvm.org/D110216

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

2022-01-04 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

> I am not sure how to reproduce this.

Attaching preprocessed source. With Clang built at 
508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this:

  $ clang++ -c /tmp/a.ii
  ../../base/containers/span_unittest.cc:11:13: error: no viable conversion 
from 'span' to 'span'
span s = make_span(v);
  ^   
  ../../base/containers/span.h:340:13: note: candidate constructor not viable: 
no known conversion from 'span' (aka 'span') to 'const base::span &' for 1st 
argument
constexpr span(const span& other) noexcept = default;
  ^
  ../../base/containers/span.h:303:13: note: candidate template ignored: could 
not match 'int[N]' against 'span' (aka 'span')
constexpr span(T ()[N]) noexcept : span(base::data(array), N) {}
  ^
  ../../base/containers/span.h:310:13: note: candidate template ignored: could 
not match 'array' against 'span'
constexpr span(std::array& array) noexcept
  ^
  ../../base/containers/span.h:317:13: note: candidate template ignored: could 
not match 'array' against 'span'
constexpr span(const std::array& array) noexcept
  ^
  ../../base/containers/span.h:328:13: note: candidate template ignored: 
requirement 
'conjunction>>, 
base::negation>>, base::negation>>, std::is_convertible, 
std::is_integral>::value' was not satisfied [with Container = 
base::span]
constexpr span(Container& container) noexcept{F20424748}
  ^
  ../../base/containers/span.h:337:13: note: candidate template ignored: 
requirement 
'conjunction>>, 
base::negation>>, base::negation>>, std::is_convertible, 
std::is_integral>::value' was not satisfied [with Container = 
base::span]
constexpr span(const Container& container) noexcept
  ^
  ../../base/containers/span.h:350:13: note: candidate template ignored: 
requirement 'is_convertible::value' was not 
satisfied [with U = const int, OtherExtent = 18446744073709551615]
constexpr span(const span& other)
  ^
  1 error generated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110216/new/

https://reviews.llvm.org/D110216

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

2022-01-04 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

We're seeing a diagnostic change in Chromium which looks funny. For the 
following code (span<> is our own class):

  int WontCompile() {
const std::vector v;
span s = make_span(v);
  }

the diagnostic changes from:

  fatal error: no viable conversion from 'span' to 'span

to

  fatal error: no viable conversion from 'span' to 'span

This looks very strange.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110216/new/

https://reviews.llvm.org/D110216

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-10 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added inline comments.



Comment at: llvm/cmake/config-ix.cmake:178
 
-if (LLVM_ENABLE_ZLIB STREQUAL "FORCE_ON" AND NOT HAVE_LIBZ)
-  message(FATAL_ERROR "Failed to configure zlib")

Could this check be put back? E.g. for now it seems building with 
-DLLVM_USE_SANITIZERS=Memory and -DLLVM_ENABLE_ZLIB=FORCE_ON will silently not 
use zlib.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-05 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D79219#2153585 , @phosek wrote:

> In D79219#2152747 , @labath wrote:
>
>> I wouldn't mind separate (internal) cache variable, though I am somewhat 
>> surprised by this problem. A (non-cache) variable set in one of the parent 
>> scopes should still take precedence over a cache variable with the same 
>> name. And since config-ix.cmake is included from the top CMakeLists.txt, the 
>> value it defines should be available everywhere. Was this a problem for the 
>> regular build, or only for some of the more exotic build setups that don't 
>> start with llvm/CMakeLists.txt ?
>
> Never mind, it's working as expected. The problem is that we disable zlib 
> detection on Windows which I missed before. I'm not sure why that's the case, 
> I tested this on Windows and it seems to be working fine, but for now I've 
> kept the existing behavior, we can consider enabling zlib on Windows in a 
> follow up change.

:-( We rely on zlib on Windows, and we pass -DLLVM_ENABLE_ZLIB=FORCE_ON to 
ensure that the build breaks if it can't be used for some reason.

It seems your change both disabled use of zlib on Windows, and also removed the 
check which made that an error when using FORCE_ON, which means we didn't catch 
this until further down the line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-05 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

Reverted in 3ab01550b632dad46f9595d74855749557ffd25c 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79219/new/

https://reviews.llvm.org/D79219

___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

2020-07-21 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D84070#2162932 , @mstorsjo wrote:

> @hans - I think this one could be a fairly safe backport to the release 
> branch. (Apparently phab lags behind regarding updating the reviews when they 
> are committed at the moment; this was committed as 
> f07ddbc9c4b66e91aa7a106042512ee903b6b3ba 
> .)


Thanks! Pushed to 11.x as bf2f2bffee244318a86fea90a0dfaf9be8a71b8c 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84070/new/

https://reviews.llvm.org/D84070



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

2020-05-18 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D79447#2041250 , @hans wrote:

> > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur 
> > during UDT emission, as suggested by @rnk
>
> It seems we hit the assert in Chromium. Here's a reproducer: 
> https://bugs.chromium.org/p/chromium/issues/detail?id=1083877#c3 (I'll try to 
> create a shorter one.)
>
> I've reverted in 525a591f0f48b9d54018bf5245f2abee09c9c1c8 
>  in the 
> meantime.


Reduced repro:

  $ cat /tmp/x.ii
  typedef int a;
  struct b;
  class c {
c();
a b::*d;
  };
  c::c() = default;
  
  $ clang -cc1 -triple x86_64-pc-windows-msvc19.16.0 -emit-obj -gcodeview 
-debug-info-kind=limited /tmp/x.ii
  clang: 
/work/llvm.monorepo/llvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp:2997: void 
llvm::CodeViewDebug::emitDebugInfoForUDTs(const 
std::vector> &): Assertion `OriginalSize 
== UDTs.size()' failed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79447/new/

https://reviews.llvm.org/D79447



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

2020-05-18 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

> - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur 
> during UDT emission, as suggested by @rnk

It seems we hit the assert in Chromium. Here's a reproducer: 
https://bugs.chromium.org/p/chromium/issues/detail?id=1083877#c3 (I'll try to 
create a shorter one.)

I've reverted in 525a591f0f48b9d54018bf5245f2abee09c9c1c8 
 in the 
meantime.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79447/new/

https://reviews.llvm.org/D79447



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

2020-03-11 Thread Hans Wennborg via Phabricator via lldb-commits 
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75406/new/

https://reviews.llvm.org/D75406



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

2020-03-04 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

There were some concerns raised on this patch, and also in PR44780.

I think at this point it's safer to revert these changes and start over. I've 
pushed the revert in 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e 
 and will 
merge that to 10.x after it's baked a little.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70764/new/

https://reviews.llvm.org/D70764



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

2020-02-27 Thread Hans Wennborg via Phabricator via lldb-commits 
hans accepted this revision.
hans added a comment.

Nice, lgtm!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75279/new/

https://reviews.llvm.org/D75279



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

2020-02-06 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D74084#1861269 , @mstorsjo wrote:

> @hans - this could be applied on 10.x (it seems to apply cleanly), to fix 
> PR44791.


Thanks! Cherry-picked as 22633f85bb7d317ff97c86b6ae7817b678777d93 
.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74084/new/

https://reviews.llvm.org/D74084



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

2019-07-23 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D64881#1596920 , @labath wrote:

> I think setting 
> -DPYTHON_EXECUTABLE=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32\python.exe
>  (or something) should be enough to get cmake to select python3 for the 
> interpreter as well.


Cool, that works. Thanks!


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64881/new/

https://reviews.llvm.org/D64881



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

2019-07-22 Thread Hans Wennborg via Phabricator via lldb-commits 
hans added a comment.

In D64881#1590204 , @amccarth wrote:

> An aside ...
>
> I'm still trying to get back to a buildable state the earlier changes, like 
> the one that tries to enforce version consistency between the libs and the 
> interpreter.  I'm currently bisecting to figure out what I hope is the final 
> blocker.


Do you have the revisions for these changes?

I built successfully at r363781, but now I can't build anymore.

I'm configuring with:

cmake -GNinja %cmake_flags% 
-DPYTHON_HOME=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32

And get the error:

CMake Error at tools/lldb/cmake/modules/LLDBConfig.cmake:204 (message):

  Found incompatible Python interpreter (2.7.15) and Python libraries (3.6.4)

Uninstalling Python 2.7 is not an option for me.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64881/new/

https://reviews.llvm.org/D64881



___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits