[Lldb-commits] [lldb] 066eea7 - Revert "Reland "clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (#70639)""

2023-11-07 Thread Hans Wennborg via lldb-commits
Author: Hans Wennborg Date: 2023-11-07T15:52:19+01:00 New Revision: 066eea75d38957353824b46474413ef2632d01a7 URL: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7 DIFF: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7.diff

[Lldb-commits] [lldb] 3ab0155 - Revert "[CMake] Simplify CMake handling for zlib"

2020-08-05 Thread Hans Wennborg via lldb-commits
Author: Hans Wennborg Date: 2020-08-05T12:31:44+02:00 New Revision: 3ab01550b632dad46f9595d74855749557ffd25c URL: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c DIFF: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c.diff

[Lldb-commits] [lldb] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

2020-07-22 Thread Hans Wennborg via lldb-commits
Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[Lldb-commits] [lldb] 525a591 - Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for globals"

2020-05-18 Thread Hans Wennborg via lldb-commits
Author: Hans Wennborg Date: 2020-05-18T11:26:30+02:00 New Revision: 525a591f0f48b9d54018bf5245f2abee09c9c1c8 URL: https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8 DIFF: https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8.diff

[Lldb-commits] [lldb] 916be8f - Revert abb00753 "build: reduce CMake handling for zlib" (PR44780)

2020-03-03 Thread Hans Wennborg via lldb-commits
Author: Hans Wennborg Date: 2020-03-03T11:03:09+01:00 New Revision: 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e URL: https://github.com/llvm/llvm-project/commit/916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e DIFF: https://github.com/llvm/llvm-project/commit/916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e.diff

Re: [Lldb-commits] [lldb] 2046d72 - build: improve python checks for Windows

2020-01-28 Thread Hans Wennborg via lldb-commits
Should https://llvm.org/docs/GettingStarted.html#requirements and https://llvm.org/docs/CMake.html#quick-start be updated to reflect the new requirement? And maybe a release note? On Sun, Dec 22, 2019 at 2:01 PM Saleem Abdulrasool via lldb-commits wrote: > > > Author: Saleem Abdulrasool > Date:

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

2020-01-28 Thread Hans Wennborg via lldb-commits
Cherry-picked that in 54b022d344412fc9f1dfe37ee05de934a01e1ea4 Thanks! On Tue, Jan 28, 2020 at 1:12 AM Raphael Isemann wrote: > > Quick follow up: apparently Pavel fixed some nondeterminism in the testing > code that had made the test fail on some systems. Could you also cherry-pick >

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

2020-01-27 Thread Hans Wennborg via lldb-commits
Sure, b5cf892651812003e64c4a8f0dbf81f74a499016 On Mon, Jan 27, 2020 at 12:18 AM Raphael Isemann wrote: > > This commit fixes a *very* frequent crash when debugging Clang with LLDB 10. > Could we get that cherry-picked into the 10.x branch? > > I’ve been running the patch since more than a week

[Lldb-commits] [lldb] r374148 - Unify the two CRC implementations

2019-10-09 Thread Hans Wennborg via lldb-commits
Author: hans Date: Wed Oct 9 02:06:30 2019 New Revision: 374148 URL: http://llvm.org/viewvc/llvm-project?rev=374148=rev Log: Unify the two CRC implementations David added the JamCRC implementation in r246590. More recently, Eugene added a CRC-32 implementation in r357901, which falls back to

Re: [Lldb-commits] [lldb] r372788 - Host: use the platform identifiers from LLVM (NFC)

2019-09-25 Thread Hans Wennborg via lldb-commits
This seems to have broken the build: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9182 I've reverted in r372847. On Wed, Sep 25, 2019 at 12:53 AM Saleem Abdulrasool via lldb-commits wrote: > > Author: compnerd > Date: Tue Sep 24 15:55:44 2019 > New Revision: 372788 > > URL:

[Lldb-commits] [lldb] r372847 - Revert r372788 "Host: use the platform identifiers from LLVM (NFC)"

2019-09-25 Thread Hans Wennborg via lldb-commits
Author: hans Date: Wed Sep 25 04:55:16 2019 New Revision: 372847 URL: http://llvm.org/viewvc/llvm-project?rev=372847=rev Log: Revert r372788 "Host: use the platform identifiers from LLVM (NFC)" > Use symbolic constants for the platform identifiers rather than replicating > them > locally. This

Re: [Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

2019-08-01 Thread Hans Wennborg via lldb-commits
Merged to release_90 in r367534. On Tue, Jul 30, 2019 at 2:53 PM Hans Wennborg wrote: > > Hi Raphael, > > Since this just landed, let's have it bake in trunk a little bit, and > then I'll merge it. > > Thanks, > Hans > > On Tue, Jul 30, 2019 at 2:36 PM Raphael “Teemperor” Isemann > wrote: > > >

Re: [Lldb-commits] [lldb] r367414 - [ProcessWindows] Choose a register context file by preprocessor

2019-08-01 Thread Hans Wennborg via lldb-commits
Merged to release_90 in r367523. On Wed, Jul 31, 2019 at 1:59 PM Tatyana Krasnukha via lldb-commits wrote: > > Author: tkrasnukha > Date: Wed Jul 31 05:00:30 2019 > New Revision: 367414 > > URL: http://llvm.org/viewvc/llvm-project?rev=367414=rev > Log: > [ProcessWindows] Choose a register

Re: [Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

2019-07-30 Thread Hans Wennborg via lldb-commits
Hi Raphael, Since this just landed, let's have it bake in trunk a little bit, and then I'll merge it. Thanks, Hans On Tue, Jul 30, 2019 at 2:36 PM Raphael “Teemperor” Isemann wrote: > > Hi Hans, > > Can you cherry-pick this to the 9.0 release? The issue is really easy to hit > when using LLDB

Re: [Lldb-commits] [lldb] r366985 - LLGS: fix tracking execve on linux

2019-07-26 Thread Hans Wennborg via lldb-commits
Merged to release_90 in r367128. On Wed, Jul 24, 2019 at 11:37 PM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Jul 24 23:38:33 2019 > New Revision: 366985 > > URL: http://llvm.org/viewvc/llvm-project?rev=366985=rev > Log: > LLGS: fix tracking execve on linux > > Summary: >

Re: [Lldb-commits] [lldb] r366433 - [CMake] Always build debugserver on Darwin and allow tests to use the system's one

2019-07-19 Thread Hans Wennborg via lldb-commits
Okay, merged in r366553. On Thu, Jul 18, 2019 at 3:38 PM Stefan Gränitz wrote: > > Hello Hans > > This commit would be very good to have on release/9.x. It simplifies a lot of > code in the code-sign and testing logic for LLDB on Darwin. This would be > useful for people who build their own

[Lldb-commits] [lldb] r360024 - Revert r359949 "[clang] adding explicit(bool) from c++2a"

2019-05-06 Thread Hans Wennborg via lldb-commits
Author: hans Date: Mon May 6 02:51:10 2019 New Revision: 360024 URL: http://llvm.org/viewvc/llvm-project?rev=360024=rev Log: Revert r359949 "[clang] adding explicit(bool) from c++2a" This caused Clang to start erroring on the following: struct S {   template explicit S(); }; struct T

Re: [Lldb-commits] [lldb] r354122 - [lldb] [MainLoop] Add kevent() EINTR handling

2019-02-18 Thread Hans Wennborg via lldb-commits
Merged to release_80 in r354255. On Fri, Feb 15, 2019 at 1:12 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Fri Feb 15 04:13:02 2019 > New Revision: 354122 > > URL: http://llvm.org/viewvc/llvm-project?rev=354122=rev > Log: > [lldb] [MainLoop] Add kevent() EINTR handling > >

Re: [Lldb-commits] [lldb] r354029 - [lldb] [MainLoop] Report errno for failed kevent()

2019-02-18 Thread Hans Wennborg via lldb-commits
Merged to release_80 in r354254. On Thu, Feb 14, 2019 at 2:51 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Thu Feb 14 05:52:31 2019 > New Revision: 354029 > > URL: http://llvm.org/viewvc/llvm-project?rev=354029=rev > Log: > [lldb] [MainLoop] Report errno for failed kevent()

Re: [Lldb-commits] [lldb] r353642 - lldb: Fix compilation on OpenBSD

2019-02-18 Thread Hans Wennborg via lldb-commits
Merged to release_80 in r354253. On Sun, Feb 10, 2019 at 4:23 PM Raphael Isemann via lldb-commits wrote: > > Author: teemperor > Date: Sun Feb 10 07:23:58 2019 > New Revision: 353642 > > URL: http://llvm.org/viewvc/llvm-project?rev=353642=rev > Log: > lldb: Fix compilation on OpenBSD > >

Re: [Lldb-commits] [lldb] r352116 - [Process/NetBSD] Add missing linkage to -lutil

2019-01-24 Thread Hans Wennborg via lldb-commits
Merged to 8.0 in r352134. Please let me know if there are any follow-ups. Thanks, Hans On Thu, Jan 24, 2019 at 2:20 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Thu Jan 24 14:20:47 2019 > New Revision: 352116 > > URL: http://llvm.org/viewvc/llvm-project?rev=352116=rev >

Re: [Lldb-commits] [lldb] r351327 - Revert "Simplify Value::GetValueByteSize()"

2019-01-16 Thread Hans Wennborg via lldb-commits
Merged to the 8 branch in r351342. On Wed, Jan 16, 2019 at 1:23 PM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Jan 16 04:19:22 2019 > New Revision: 351327 > > URL: http://llvm.org/viewvc/llvm-project?rev=351327=rev > Log: > Revert "Simplify Value::GetValueByteSize()" > >

[Lldb-commits] [lldb] r347758 - Revert r347673 "Catch up with EvaluateAsInt() clang API change."

2018-11-28 Thread Hans Wennborg via lldb-commits
Author: hans Date: Wed Nov 28 06:30:18 2018 New Revision: 347758 URL: http://llvm.org/viewvc/llvm-project?rev=347758=rev Log: Revert r347673 "Catch up with EvaluateAsInt() clang API change." r347417 was re-committed in Clang. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified:

Re: [Lldb-commits] [lldb] r339076 - [lit, python] Always add quotes around the python path in lit

2018-08-14 Thread Hans Wennborg via lldb-commits
Merged to 7.0 in r339657. On Tue, Aug 7, 2018 at 12:37 AM, Stella Stamenova via lldb-commits wrote: > Author: stella.stamenova > Date: Mon Aug 6 15:37:53 2018 > New Revision: 339076 > > URL: http://llvm.org/viewvc/llvm-project?rev=339076=rev > Log: > [lit, python] Always add quotes around the

Re: [Lldb-commits] [lldb] r338949 - Fix a bug in VMRange

2018-08-07 Thread Hans Wennborg via lldb-commits
Merged to 7.0 in r339107. On Sat, Aug 4, 2018 at 4:15 AM, Leonard Mosescu via lldb-commits wrote: > Author: lemo > Date: Fri Aug 3 19:15:26 2018 > New Revision: 338949 > > URL: http://llvm.org/viewvc/llvm-project?rev=338949=rev > Log: > Fix a bug in VMRange > > I noticed a suspicious failure: >

Re: [Lldb-commits] [lldb] r324234 - Fix a crash in *NetBSD::Factory::Launch

2018-02-06 Thread Hans Wennborg via lldb-commits
Merged to 6.0 in r324327. On Mon, Feb 5, 2018 at 2:16 PM, Kamil Rytarowski via lldb-commits wrote: > Author: kamil > Date: Mon Feb 5 05:16:22 2018 > New Revision: 324234 > > URL: http://llvm.org/viewvc/llvm-project?rev=324234=rev > Log: > Fix a crash in

Re: [Lldb-commits] [lldb] r324251 - Sync PlatformNetBSD.cpp with Linux

2018-02-06 Thread Hans Wennborg via lldb-commits
Merged to 6.0 in r324326. On Mon, Feb 5, 2018 at 6:12 PM, Kamil Rytarowski via lldb-commits wrote: > Author: kamil > Date: Mon Feb 5 09:12:23 2018 > New Revision: 324251 > > URL: http://llvm.org/viewvc/llvm-project?rev=324251=rev > Log: > Sync PlatformNetBSD.cpp

Re: [Lldb-commits] [lldb] r322081 - [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

2018-01-18 Thread Hans Wennborg via lldb-commits
Merged to 6.0 in r322833. On Tue, Jan 9, 2018 at 3:44 PM, Michal Gorny via lldb-commits wrote: > Author: mgorny > Date: Tue Jan 9 06:44:04 2018 > New Revision: 322081 > > URL: http://llvm.org/viewvc/llvm-project?rev=322081=rev > Log: > [test] Fix tests to use more

Re: [Lldb-commits] [lldb] r321932 - [test] Use full PATH lookup for tools

2018-01-18 Thread Hans Wennborg via lldb-commits
Merged to 6.0 in r322832. On Sat, Jan 6, 2018 at 11:20 AM, Michal Gorny via lldb-commits wrote: > Author: mgorny > Date: Sat Jan 6 02:20:25 2018 > New Revision: 321932 > > URL: http://llvm.org/viewvc/llvm-project?rev=321932=rev > Log: > [test] Use full PATH lookup

Re: [Lldb-commits] [lldb] r312008 - [IPv6] Fix a bug in the IPv6 listen behavior

2017-08-29 Thread Hans Wennborg via lldb-commits
Merged to 5.0 in r312016. On Tue, Aug 29, 2017 at 9:13 AM, Chris Bieneman via lldb-commits wrote: > Author: cbieneman > Date: Tue Aug 29 09:13:41 2017 > New Revision: 312008 > > URL: http://llvm.org/viewvc/llvm-project?rev=312008=rev > Log: > [IPv6] Fix a bug in the

Re: [Lldb-commits] [lldb] r311579 - Process: fix FXSAVE on x86

2017-08-23 Thread Hans Wennborg via lldb-commits
Merged in r311585. Thanks! On Wed, Aug 23, 2017 at 11:02 AM, Greg Clayton wrote: > Fine with me. > > On Aug 23, 2017, at 10:47 AM, Saleem Abdulrasool > wrote: > > This would be nice to merge to 5.0 IMO. It fixes reading the x87 FPU state. > What do

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Hans Wennborg via lldb-commits
Sorry for the noise, I must have gotten the numbers wrong somehow. On Fri, Feb 3, 2017 at 1:59 PM, Geoff Berry wrote: > Hans, > > Sorry for the confusion, but this isn't the change I was referring to. I > included the phabricator review numbers in my original message, not

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

2017-02-03 Thread Hans Wennborg via lldb-commits
Geoff asked for this to be merged to 4.0. It looks like a nice change, but I'm a little hesitant since it doesn't look like it's fixing a regression. Pavel, what do you think? On Fri, Feb 3, 2017 at 9:42 AM, Pavel Labath via lldb-commits wrote: > Author: labath >

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

2016-08-16 Thread Hans Wennborg via lldb-commits
Greg: ping? On Mon, Aug 8, 2016 at 1:38 PM, Hans Wennborg wrote: > Greg: ping? > > On Wed, Aug 3, 2016 at 9:06 AM, Hans Wennborg wrote: >> For LLDB, I think it's up to Greg to decide. >> >> On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote:

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

2016-08-08 Thread Hans Wennborg via lldb-commits
Greg: ping? On Wed, Aug 3, 2016 at 9:06 AM, Hans Wennborg wrote: > For LLDB, I think it's up to Greg to decide. > > On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote: >> Hi Hans! >> >> The author of this commit asks me is there a chance to include this changes

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

2016-08-03 Thread Hans Wennborg via lldb-commits
For LLDB, I think it's up to Greg to decide. On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote: > Hi Hans! > > The author of this commit asks me is there a chance to include this changes > to 3.9 release? I'm not sure about our policy when RC has already been > tagged. > > On Fri,

Re: [Lldb-commits] FW: [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

2016-08-02 Thread Hans Wennborg via lldb-commits
While this all seems very MIPS-specific, so probably fine to merge if you want to, it does look more like new development than just bug fixing. I'm OK with merging this if Clayton approves, though. Thanks, Hans On Tue, Aug 2, 2016 at 12:49 AM, Nitesh Jain wrote: > Hi

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

2016-08-02 Thread Hans Wennborg via lldb-commits
Looks like a pretty big change to merge at this stage. I'll let Clayton decide. Thanks, Hans On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote: > Hi Hans, > > Could you please add this to the LLDB 3.9 release branch ? > > Thanks & regards, > Nitesh Jain > > >

Re: [Lldb-commits] [lldb] r260072 - [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

2016-02-09 Thread Hans Wennborg via lldb-commits
Merged in r260236. Thanks, Hans On Tue, Feb 9, 2016 at 1:40 AM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r260072) to the release branch? > > Thanks, > Bhushan > > > -Original Message- > From: lldb-commits

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-02 Thread Hans Wennborg via lldb-commits
On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote: > On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde > wrote: >> Hi Hans, >> >> Could you please add this (r258919) to the release branch? >> Also commit r258967 (on top of this) by Zachary which

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-02 Thread Hans Wennborg via lldb-commits
On Tue, Feb 2, 2016 at 8:52 AM, Hans Wennborg wrote: > On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote: >> On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde >> wrote: >>> Hi Hans, >>> >>> Could you please add this (r258919) to

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2016-02-02 Thread Hans Wennborg via lldb-commits
r259525. On Mon, Feb 1, 2016 at 1:51 PM, Hans Wennborg wrote: > Greg: ping? > > On Mon, Jan 25, 2016 at 11:40 AM, Hans Wennborg wrote: >> SGTM if Greg approves. >> >> On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde >> wrote:

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

2016-02-01 Thread Hans Wennborg via lldb-commits
Greg: ping? On Tue, Jan 26, 2016 at 11:10 AM, Hans Wennborg wrote: > Greg: Ping? > > On Tue, Jan 19, 2016 at 1:12 PM, Hans Wennborg wrote: >> Sure. Greg, are you the code owner for this, or is there a specific >> owner for Go? >> >> Thanks, >> Hans >> >> On

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2016-02-01 Thread Hans Wennborg via lldb-commits
Greg: ping? On Mon, Jan 25, 2016 at 11:40 AM, Hans Wennborg wrote: > SGTM if Greg approves. > > On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde > wrote: >> Could you please add this to the release branch? >> >> Thanks, >> Bhushan >> >> >>

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

2016-02-01 Thread Hans Wennborg via lldb-commits
Thanks! r259423. On Mon, Feb 1, 2016 at 2:19 PM, Greg Clayton wrote: > Sorry for the delay. This is fine. > > In general, feel free to accept any patches that are architecture specific > for architectures that aren't x86 or ARM (MIPS, hexagon for example), and for > any

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

2016-02-01 Thread Hans Wennborg via lldb-commits
On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r258919) to the release branch? > Also commit r258967 (on top of this) by Zachary which fixes some python 3 > incompatibilities. Since this touched more than just

Re: [Lldb-commits] [lldb] r259188 - Fix linking of lldb-server with BUILD_SHARED_LIBS

2016-01-29 Thread Hans Wennborg via lldb-commits
Sgtm. Zach's the owner here. On Fri, Jan 29, 2016 at 6:47 AM, Pavel Labath wrote: > Zachary, Hans, > > this is not super-important, as a BUILD_SHARED_LIBS build of lldb will > still remain broken due to other issues, but I'd still like to get > this into 3.8, as it will reduce

Re: [Lldb-commits] [lldb] r259188 - Fix linking of lldb-server with BUILD_SHARED_LIBS

2016-01-29 Thread Hans Wennborg via lldb-commits
r259241. Thanks. On Fri, Jan 29, 2016 at 10:21 AM, Zachary Turner wrote: > lgtm, as Pavel points out build_shared_libs is already broken anyway and > this doesn't make it worse, while also not touching the non > build_shared_libs path. > > On Fri, Jan 29, 2016 at 10:15 AM

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Hans Wennborg via lldb-commits
hans added a comment. loladiro: Ping? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-28 Thread Hans Wennborg via lldb-commits
hans added a comment. I've committed the patch to 3.8 in r259081. Please confirm if this fixes the issue there. http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

2016-01-27 Thread Hans Wennborg via lldb-commits
Zach is the lldb cmake owner. Zach, does this seem OK for 3.8? On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote: > Hi, > > could we get this patch applied to the 3.8 branch? > > thanks, > pl > > > On 27 January 2016 at 11:02, Pavel Labath via lldb-commits >

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

2016-01-27 Thread Hans Wennborg via lldb-commits
Merged in r258964, thanks. (I accidentally committed some local changes too; reverted those in r258968.) On Wed, Jan 27, 2016 at 10:06 AM, Zachary Turner wrote: > Yea I think this is fine. > > On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote: >> >> Zach

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

2016-01-25 Thread Hans Wennborg via lldb-commits
SGTM if Greg approves. On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde wrote: > Could you please add this to the release branch? > > Thanks, > Bhushan > > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of >

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

2016-01-19 Thread Hans Wennborg via lldb-commits
hans added a comment. In http://reviews.llvm.org/D16284#329161, @loladiro wrote: > The Makefile system will be removed from trunk very soon, so it might not > necessarily make sense there, but I think it would be good to get this > applied to release-38. @clayborg @hans how would you like to

Re: [Lldb-commits] [lldb] r257691 - Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406.

2016-01-13 Thread Hans Wennborg via lldb-commits
On Wed, Jan 13, 2016 at 2:40 PM, Hans Wennborg via lldb-commits <lldb-commits@lists.llvm.org> wrote: > Author: hans > Date: Wed Jan 13 16:40:24 2016 > New Revision: 257691 > > URL: http://llvm.org/viewvc/llvm-project?rev=257691=rev > Log: > Include IR/DerivedTypes.h in

[Lldb-commits] [lldb] r257691 - Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406.

2016-01-13 Thread Hans Wennborg via lldb-commits
Author: hans Date: Wed Jan 13 16:40:24 2016 New Revision: 257691 URL: http://llvm.org/viewvc/llvm-project?rev=257691=rev Log: Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406. This is similar to r256407 and fixes the following warning: In file included from

[Lldb-commits] [lldb] r257692 - Fix -Wformat-pedantic warning

2016-01-13 Thread Hans Wennborg via lldb-commits
Author: hans Date: Wed Jan 13 16:40:26 2016 New Revision: 257692 URL: http://llvm.org/viewvc/llvm-project?rev=257692=rev Log: Fix -Wformat-pedantic warning /work/llvm-3.8/llvm.src/tools/lldb/source/API/SBProcess.cpp:1003:73: error: format specifies type 'void *' but the argument has type

Re: [Lldb-commits] [lldb] r257692 - Fix -Wformat-pedantic warning

2016-01-13 Thread Hans Wennborg via lldb-commits
On Wed, Jan 13, 2016 at 2:40 PM, Hans Wennborg via lldb-commits <lldb-commits@lists.llvm.org> wrote: > Author: hans > Date: Wed Jan 13 16:40:26 2016 > New Revision: 257692 > > URL: http://llvm.org/viewvc/llvm-project?rev=257692=rev > Log: > Fix -Wformat-pedantic warnin

Re: [Lldb-commits] [lldb] r245547 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-21 Thread Hans Wennborg via lldb-commits
I'm not happy about this. lldb builds fine on Linux for me. What's the build problem on mips? I also don't see the relation between r245240 (which was also a large patch) and this, but I haven't looked closely and am not familiar with the code. In general it would be nice if merge requests don't

Re: [Lldb-commits] [lldb] r245020 - [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

2015-08-18 Thread Hans Wennborg via lldb-commits
Greg: ping? On Fri, Aug 14, 2015 at 11:06 AM, Hans Wennborg h...@chromium.org wrote: Sure, if Greg approves. Thanks, Hans On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde bhushan.atta...@imgtec.com wrote: Hi Hans, Could you please merge this to the release branch? Thanks Bhushan

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-17 Thread Hans Wennborg via lldb-commits
Merged to 3.7 in r245240. There was a conflicts because r245141 isn't on the branch. Please check that I got it right: http://llvm.org/viewvc/llvm-project?rev=245240view=rev Thanks, Hans On Mon, Aug 17, 2015 at 1:28 PM, Greg Clayton clayb...@gmail.com wrote: Ok to merge. On Aug 17, 2015, at

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

2015-08-17 Thread Hans Wennborg via lldb-commits
I'm OK with it if Greg approves. - Hans On Mon, Aug 17, 2015 at 7:07 AM, sagar.tha...@imgtec.com wrote: Hi Hans, Could you please also merge r245217 in the release branch. Thanks, Sagar -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On

Re: [Lldb-commits] [lldb] r245216 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

2015-08-17 Thread Hans Wennborg via lldb-commits
+lldb-commits On Mon, Aug 17, 2015 at 1:25 PM, Hans Wennborg h...@chromium.org wrote: I'm OK with it if Greg approves. - Hans On Mon, Aug 17, 2015 at 7:06 AM, sagar.tha...@imgtec.com wrote: Hi Hans, Could you please merge r245216 in the release branch? Thanks, Sagar -Original

Re: [Lldb-commits] [lldb] r245020 - [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

2015-08-14 Thread Hans Wennborg via lldb-commits
Sure, if Greg approves. Thanks, Hans On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde bhushan.atta...@imgtec.com wrote: Hi Hans, Could you please merge this to the release branch? Thanks Bhushan -Original Message- From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org]

Re: [Lldb-commits] [lldb] r243091 - Handle old style S packet correctly

2015-08-11 Thread Hans Wennborg via lldb-commits
Ping? On Wed, Aug 5, 2015 at 1:20 PM, Hans Wennborg h...@chromium.org wrote: Ping? On Wed, Jul 29, 2015 at 8:56 AM, Hans Wennborg h...@chromium.org wrote: Greg, I believe you're the code owner here. OK to merge? On Tue, Jul 28, 2015 at 9:05 PM, Bhushan Attarde bhushan.atta...@imgtec.com