[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. I don't have commit access, would be great if you could do that for me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. Should this be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie updated this revision to Diff 319871. haampie added a comment. Herald added a subscriber: arphaman. I dropped the awk bits, since there's no portable way to do it there, and replaced all `perl -w` with `perl` and `use warnings`. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. @JDevlieghere, would you care to review? This is another instance of moving away from system binaries to whatever the user / package manager wants the build to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/

[Lldb-commits] [PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie created this revision. haampie added a reviewer: JDevlieghere. Herald added a reviewer: bollu. haampie requested review of this revision. Herald added projects: clang, Sanitizers, LLDB, OpenMP, LLVM. Herald added subscribers: llvm-commits, openmp-commits, lldb-commits, Sanitizers,

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. Also note that the changes are not likely to be backported to 11 even: https://reviews.llvm.org/rG31e5f7120bdd2f76337686d9d169b1c00e6ee69c#942622 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87590/new/

[Lldb-commits] [PATCH] D87590: Backport D79219, D85820, D86134 to 10.0 branch

haampie added a comment. D86134 should not be added, it was reverted afterwards. What eventually landed was D85820 , which adds a better fix for what D86134 was supposed to solve. Repository:

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie updated this revision to Diff 288864. haampie added a comment. Herald added a subscriber: danielkiss. Another take on this isuse, incorporating @phosek's comment on making find_library not find shared libs when compiling with `LLVM_BUILD_STATIC=ON`, and making sure that

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

haampie added a comment. @phosek it would be great to get that patch in, but the truth is it is difficult testing across multiple platforms for me; I can only test on Linux and macOS, not Windows (GNU). Since that patch would touch predefined, platform-dependent cmake variables, I would want

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

haampie created this revision. haampie added reviewers: JDevlieghere, phosek, gkistanova. Herald added subscribers: llvm-commits, lldb-commits, Sanitizers, hiraditya, mgorny. Herald added projects: Sanitizers, LLDB, LLVM. haampie requested review of this revision. The introduction of

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @gkistanova It's true that this change has lead to more issues I could ever imagine, but I think the link you provided is the last remaining problem. Pinging @phosek for a similar issue w.r.t. zlib: since https://reviews.llvm.org/D79219 zlib gets disabled on static

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added inline comments. Comment at: llvm/include/llvm/Config/config.h.cmake:212 /* Define if the setupterm() function is supported this platform. */ -#cmakedefine HAVE_TERMINFO ${HAVE_TERMINFO} +#cmakedefine LLVM_ENABLE_TERMINFO ${LLVM_ENABLE_TERMINFO}

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added inline comments. Comment at: llvm/lib/Support/CMakeLists.txt:217 + endif() + if(CMAKE_SHARED_LIBRARY_PREFIX AND CMAKE_SHARED_LIBRARY_SUFFIX AND + zlib_library MATCHES "^${CMAKE_SHARED_LIBRARY_PREFIX}.*${CMAKE_SHARED_LIBRARY_SUFFIX}$") This

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @gribozavr2: can you try https://reviews.llvm.org/D86134? It should fix your issue, as well as the same issue w.r.t. the ZLIB changes of https://reviews.llvm.org/D79219 on macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D85820: Use find_library for ncurses

haampie added a comment. @srj could you please try / review https://reviews.llvm.org/D86173 for a fix for your problem? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85820/new/ https://reviews.llvm.org/D85820

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

haampie added a comment. Great, one benefit of this is that zlib can now be detected in non-system libs. Maybe we should handle ncurses / TERMINFO in a similar manner? It currently has similar logic as finding zlib had Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION