[Lldb-commits] [PATCH] D85719: Initialize static const fields in the AST for expression evaluation

2020-08-11 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: shafik. jarin requested review of this revision. This patch is for discussion. Currently, the evaluator does not know about

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

2020-07-16 Thread Jaroslav Sevcik via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG93ec6cd68426: [lldb] Desugar template specializations (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

2020-07-15 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 278200. jarin added a comment. Undo the infinite loop detection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files:

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

2020-07-15 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D83858#2152772 , @teemperor wrote: > This could cause that `RemoveWrappingTypes` goes into an infinite loop under > some situations. Usually this function is reserved for types that are always > 'sugar', but

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

2020-07-15 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 278173. jarin marked 3 inline comments as done. jarin added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83858/new/ https://reviews.llvm.org/D83858 Files:

[Lldb-commits] [PATCH] D83858: [lldb] Desugar template specializations

2020-07-15 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Template specializations are not handled in many of the TypeSystemClang methods. For example, GetNumChildren does not handle the TemplateSpecialization type class,

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfac5d05eb75f: [lldb] Fix and enable Windows minidump tests (authored by jarin). Changed prior to commit: https://reviews.llvm.org/D81465?vs=269609=269649#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 269609. jarin added a comment. Added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81465/new/ https://reviews.llvm.org/D81465 Files: lldb/test/API/functionalities/postmortem/minidump-new/TestMiniDumpUUID.py Index:

[Lldb-commits] [PATCH] D81465: [lldb] Fix and enable Windows minidump tests

2020-06-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. jarin edited the summary of this revision. SBFileSpec.fullpath always uses the forward slash to join the directory with the base name. This causes mismatches when

[Lldb-commits] [PATCH] D81363: Disable remove-add module test on Windows

2020-06-08 Thread Jaroslav Sevcik via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6143874f734b: [lldb] Disable remove-add module test on Windows (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81363/new/

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-06-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1beffc18886a: Support build-ids of other sizes than 16 in UUID::SetFromStringRef (authored by jarin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-06-04 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 268497. jarin added a comment. Exclude UUID strings ending with "-". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h lldb/source/Interpreter/OptionValueUUID.cpp

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-06-01 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 267754. jarin added a comment. Added a test for missing nibble in UUID. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h lldb/source/Interpreter/OptionValueUUID.cpp

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-06-01 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 267739. jarin edited the summary of this revision. jarin added a comment. Removed size restrictions on UUIDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-06-01 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Utility/UUID.cpp:109 *this = fromData(bytes); -return str.size() - rest.size(); +return str.size(); } jankratochvil wrote: > Now the return type could be

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-05-31 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 267490. jarin marked an inline comment as done. jarin added a comment. Change SetFromStringRef to return bool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80755/new/ https://reviews.llvm.org/D80755 Files: lldb/include/lldb/Utility/UUID.h

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

2020-05-29 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 267241. jarin retitled this revision from "Support build-ids of other sizes than 16 in SBTarget::AddModule" to "Support build-ids of other sizes than 16 in UUID::SetFromStringRef". jarin edited the summary of this revision. Herald added subscribers: MaskRay,

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in SBTarget::AddModule

2020-05-29 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/API/SBTarget.cpp:1593 + llvm::StringRef rest = + UUID::DecodeUUIDBytesFromString(uuid_str, bytes, 20); + // If the UUID string was consumed and it is not empty, let us

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in SBTarget::AddModule

2020-05-28 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. SBTarget::AddModule currently handles the UUID parameter in a very weird way: UUIDs with more than 16 bytes are trimmed to 16 bytes. On the other hand,

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-25 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Raphael, could you land this for me? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80254/new/ https://reviews.llvm.org/D80254 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-22 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D80254#2047982 , @clayborg wrote: > This looks good, thanks for subscribing me. We need to have GetNumChildren > and GetChildAtIndex agreeing on things and we definitely shouldn't be walking > more than on pointer recursively.

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-20 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 265237. jarin marked 3 inline comments as done. jarin added a comment. Merged the ObjC pointer case with the reference case, simplified the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80254/new/ https://reviews.llvm.org/D80254 Files:

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-20 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D80254#2046275 , @labath wrote: > Looks fine to me too. The way this test is phrased, it would probably make > more sense under `test/API/python_api/value`, than here. (I mean, it's not > technically wrong because everything is

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-20 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as not done. jarin added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:5215 +uint32_t num_pointee_children = 0; +if (pointee_clang_type.IsAggregateType()) + num_pointee_children =

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-20 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 265141. jarin marked 2 inline comments as done. jarin added a comment. Added more assertions, reformatted the test code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80254/new/ https://reviews.llvm.org/D80254 Files:

[Lldb-commits] [PATCH] D80254: Prevent GetNumChildren from transitively walking pointer chains

2020-05-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added reviewers: teemperor, jingham. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This is an attempt to fix https://bugs.llvm.org/show_bug.cgi?id=45988, where SBValue::GetNumChildren returns 2, but SBValue::GetChildAtIndex(1) returns an

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Pavel, could you possibly land this for us? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Jim, do you think this is good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin reopened this revision. jarin added a comment. This revision is now accepted and ready to land. Reopening for further investigation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/test/API/functionalities/thread/break_step_other/TestThreadBreakStepOther.py:21 +class ThreadBreakStepOtherTestCase(TestBase): +mydir = TestBase.compute_mydir(__file__) + labath wrote: > You can add

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 262087. jarin marked 2 inline comments as done. jarin added a comment. ... now also fixed the 'volatile'. It took only three patches to copy four lines of code by hand. Not bad, huh? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 262082. jarin added a comment. ... and remove the extra braces. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 262081. jarin marked an inline comment as done. jarin added a comment. Addressed reviewer comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files:

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Do you think Raphael would want to review this as well? If you think it is not necessary, could you land the patch for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79404/new/ https://reviews.llvm.org/D79404

[Lldb-commits] [PATCH] D79404: Fix error handling after [] in 'frame variable'

2020-05-05 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added reviewers: teemperor, labath. Herald added subscribers: lldb-commits, arphaman. Herald added a project: LLDB. jarin retitled this revision from "Fix handling of [] in 'frame variable'" to "Fix error handling after [] in 'frame variable'". This fixes a bug

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-04 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 261805. jarin added a comment. Simplify the test based on the suggestion from labath@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79308/new/ https://reviews.llvm.org/D79308 Files:

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-04 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D79308#2017348 , @labath wrote: > The test setup here seems unnecessarily complex. Wouldn't an inferior like > this work better? > > void thread1() { > pseudo_barrier_wait(g_barrier); // See other tests how this works. >

[Lldb-commits] [PATCH] D79308: [lldb-server] Reset stop reason of all threads when resuming

2020-05-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: jingham. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes the stop reason reset logic similar to MacOS' debugserver, where exceptions are reset for all threads when resuming process for stepping or

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

2020-04-11 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D77790#1975324 , @clayborg wrote: > In D77790#1974047 , @jarin wrote: > > > It appears it is really hard to reach agreement about this, so another > > alternative is I submit a bug report

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

2020-04-11 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Abandoning the patch since we cannot reach agreement on how this should be tested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77765/new/ https://reviews.llvm.org/D77765 ___

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

2020-04-10 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Regarding the callback idea, I have bad experience with callbacks because they break if the code is not crafted for re-entrancy and they are much harder to understand. That change feels out of scope for just adding a test and fixing an unrelated bug. Adding the

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

2020-04-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. As labath@ suggested, I have teased apart the test and the testability refactoring into a separate patch. The patch lives at https://reviews.llvm.org/D77790, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

2020-04-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/source/Target/Memory.cpp:63 if (pos != m_L1_cache.begin()) { - --pos; + pos--; } labath wrote: > I guess this is a leftover from splitting the patches? > > Speaking of post-increment the [[ >

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

2020-04-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 256257. jarin marked 2 inline comments as done. jarin added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77790/new/ https://reviews.llvm.org/D77790 Files:

[Lldb-commits] [PATCH] D77790: [NFC] Add a test for the inferior memory cache (mainly L1)

2020-04-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added reviewers: labath, clayborg. jarin added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. This patch adds a test for L1 of the inferior's memory cache and makes the cache testable. This is mostly in

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

2020-04-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. I rewrote parts of the test, hopefully making it a bit clearer. Please let me know if this made it better. Comment at: lldb/source/Target/Memory.cpp:23-24 // MemoryCache constructor -MemoryCache::MemoryCache(Process )

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

2020-04-09 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 256207. jarin marked 10 inline comments as done. jarin added a comment. Addressed some of the reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77765/new/ https://reviews.llvm.org/D77765 Files:

[Lldb-commits] [PATCH] D77765: Fix incorrect L1 inferior memory cache flushing

2020-04-08 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added reviewers: labath, clayborg. jarin added a project: LLDB. Herald added subscribers: lldb-commits, mgorny. jarin retitled this revision from "Fix incorrect L1 cache flushing" to "Fix incorrect L1 inferior memory cache flushing". As discussed in

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-04-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Looking at the code for flushing L1 cache , it appears broken. I am guessing that is the reason for the failure of my patch on the bots. Here is the

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-04-02 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Pavel, could you land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-31 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D74398#1939372 , @jarin wrote: > In D74398#1935438 , @jasonmolenda > wrote: > > > (and if you're still seeing mystery reads, put a breakpoint on > > ProcessGDBRemote::DoReadMemory and

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-24 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D74398#1935438 , @jasonmolenda wrote: > (and if you're still seeing mystery reads, put a breakpoint on > ProcessGDBRemote::DoReadMemory and see who is doing it) Thanks for the great explanations! I did put a breakpoint into

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

2020-03-24 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 252276. jarin marked 2 inline comments as done. jarin added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76650/new/ https://reviews.llvm.org/D76650 Files:

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

2020-03-24 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Thanks for the review! Could you possibly land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76650/new/ https://reviews.llvm.org/D76650 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D76650: Data formatters: fix detection of C strings

2020-03-23 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: teemperor. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Detection of C strings does not work well for pointers. If the value object holding a (char*) pointer does not have an address (e.g., if it is a temp), the value

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-21 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Regarding the packet savings - there are still things that worry me. First of all, when lldb CLI stops on a breakpoint, it will first unwind top of the stack of each thread as part of ThreadList::ShouldStop. This sends lots of "x" packets to lldb-server and only then

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-20 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 251714. jarin marked 3 inline comments as done. jarin added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 Files:

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 251512. jarin added a comment. Adding a tighter x64 test as suggested by labath@. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74398/new/ https://reviews.llvm.org/D74398 Files:

[Lldb-commits] [PATCH] D76216: Improve step over performance

2020-03-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Pavel or Jim, could you possibly land this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76216: Improve step over performance

2020-03-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Thanks Greg, I will wait for Jim's comment. I also see that build-bot is not happy about my patch. Clang-tidy somewhat mysteriously fails on missing lldb/Target/ThreadPlanStepOverRange.h, which I did not touch at all (neither the fail nor the #include). Any idea what

[Lldb-commits] [PATCH] D76216: Improve step over performance

2020-03-18 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 251208. jarin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76216/new/ https://reviews.llvm.org/D76216 Files: lldb/source/Target/ThreadPlanStepOverRange.cpp Index:

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-18 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D74398#1929019 , @labath wrote: > Thanks. Could you also add the other kind of test (the one inline asm) I > mentioned. In an ideal world we'd have a test case for every boundary > condition, but we're pretty far from that

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-18 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 251181. jarin marked 5 inline comments as done. jarin added a comment. Addressed reviewer comments in the code, but still have no clue how to write the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-03-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 250951. jarin added a comment. - Added a test that checks consistency of thread info's memory chunks with the actual memory. - Using DataExtractor to extract pointers with the right endian-ness and the right size. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D76216: Improve step over performance

2020-03-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Thanks for all the clarifications, this is very useful. I have always wanted to learn about thread plans, and this was a nice opportunity to do that. The extra background from you guys is a nice bonus. Regarding the patch itself, is there anything preventing an LGTM?

[Lldb-commits] [PATCH] D76216: Improve step over performance

2020-03-16 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Target/ThreadPlanStepOverRange.cpp:176 +// rely on that breakpoint to trigger once we return to the range. +if (m_next_branch_bp_sp) + return false;

[Lldb-commits] [PATCH] D76216: Improve step over performance

2020-03-16 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added reviewers: clayborg, labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This patch improves step over performance for the case when we are stepping over a call with a next-branch-breakpoint (see

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

2020-02-18 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D74759#1880499 , @labath wrote: > I like this idea a lot, in principle. It is much simpler than a full blown > interval tree, and it should give us similar performance characteristics. > > Have you done a proper complexity

[Lldb-commits] [PATCH] D74759: Treat RangeDataVector as an augmented BST

2020-02-18 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Thanks for putting this together, some comments below. Let us see what Pavel thinks. Comment at: lldb/include/lldb/Utility/RangeMap.h:634 + // We can treat the vector as a flattened BST, augmenting it with upper bounds (max of + // range endpoints)

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

2020-02-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2814 + +if (reg_info->invalidate_regs && reg_info->invalidate_regs[0]) { + response.PutCString("invalidate_regnums=\""); I know this is

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

2020-02-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/TestGdbRemoteTargetXmlPacket.py:69 +self.assertEqual(q_info_reg["offset"], xml_info_reg.get("offset")) +

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

2020-02-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:465 + response.PutChar(','); +response.Printf("%" PRIx32, *reg_num); + } I think this is not correct: target.xml expects this to be

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-02-12 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Thank you for the feedback! I am a bit busy with other things ATM, but I should be able to get back to this next week. I should give credit where it's due - Pavel pointed me to the debug-server code and I took the idea from there. We do not always have the frame pointer

[Lldb-commits] [PATCH] D74398: [lldb-server] jThreadsInfo returns stack memory

2020-02-11 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds parts of the stack that should be useful for unwinding to the jThreadsInfo reply from lldb-server. We return the top of the stack (12 words), and we

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

2020-02-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2819 +response.Printf(""); +const int registersCount = 128; +for (int reg_index = 0; reg_index < registersCount; reg_index++) { As

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

2020-01-27 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D73191#1841372 , @labath wrote: > (I mean, if there is a real benefit to having some queries return only > non-methods, then we can certainly do something like that as well, but that > should be handled differently -- either we

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

2020-01-27 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Pavel, could you take another look, please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D73191: Only match mangled name in full-name function lookup (with accelerators)

2020-01-27 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 240480. jarin retitled this revision from "Ignore methods in full-name function lookup (with accelerators)" to "Only match mangled name in full-name function lookup (with accelerators)". jarin edited the summary of this revision. jarin added a comment. Only

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

2020-01-27 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45 if (name_type_mask & eFunctionNameTypeFull) { -dies.push_back(die); -return; +if (!die.IsMethod() || die.GetMangledName(false)

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

2020-01-24 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as done. jarin added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:45 if (name_type_mask & eFunctionNameTypeFull) { -dies.push_back(die); -return; +if (!die.IsMethod() || die.GetMangledName(false)

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

2020-01-24 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Pavel, does the latest patch address (and test) what you were worried about? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

2020-01-24 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 240144. jarin edited the summary of this revision. jarin added a comment. Updated to include all methods/non-methods with matching mangled name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73191/new/ https://reviews.llvm.org/D73191 Files:

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2020-01-23 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. > FWIW, the Sony debugger throws away the `` part of the DW_AT_name and > reconstructs it from the template_parameter children. The presence of > typedefs and/or enums can make the `` text inconsistent, especially > across enums. Our debugger reconstructs the

[Lldb-commits] [PATCH] D73191: Ignore methods in full-name function lookup (with accelerators)

2020-01-22 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a reviewer: labath. jarin added a project: LLDB. Herald added subscribers: lldb-commits, arphaman, aprantl. In the spirit of https://reviews.llvm.org/D70846, we only return non-methods in Apple/DebugNamesDWARFIndex::GetFunction if eFunctionNameTypeFull is

[Lldb-commits] [PATCH] D69933: [ASTImporter] Limit imports of structs

2020-01-21 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 239235. jarin added a comment. Herald added a subscriber: lldb-commits. I changed the diff so that it does not touch Clang's AST importer, instead it patches LLDB's wrapper of the AST importer. The idea is to only import complete a record if the current

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-10 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Raphael, could you possibly land the patch for me? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/ https://reviews.llvm.org/D72133 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D72133#1806822 , @clayborg wrote: > So as long as the following are true from this patch I am ok: > > - if I ask for the array element type of "str" in the test that was added, it > should return "MCHAR". We shouldn't be

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-07 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked 3 inline comments as done. jarin added inline comments. Comment at: lldb/source/API/SBType.cpp:215-218 + CompilerType canonical_type = + m_opaque_sp->GetCompilerType(true).GetCanonicalType(); + return LLDB_RECORD_RESULT( + SBType(TypeImplSP(new

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Actually, there is something unusually flaky in my current checkout, so you might be right that not canonicalizing is harmless. It still makes more sense to land that separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked an inline comment as not done. jarin added a comment. In D72133#1802727 , @teemperor wrote: > Also do you need someone to commit this for you? Yes, please (once we agree what to do with SBType.cpp). CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin marked 7 inline comments as done. jarin added a comment. I have addressed the comments, thanks for the quick review. Comment at: lldb/source/API/SBType.cpp:218 + return LLDB_RECORD_RESULT( + SBType(TypeImplSP(new TypeImpl(canonical_type.GetArrayElementType();

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 236021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72133/new/ https://reviews.llvm.org/D72133 Files: lldb/packages/Python/lldbsuite/test/functionalities/data-formatter/array_typedef/Makefile

[Lldb-commits] [PATCH] D72133: Data formatters: Look through array element typedefs

2020-01-03 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin created this revision. jarin added a project: LLDB. Herald added a subscriber: lldb-commits. Motivation: When formatting an array of typedefed chars, we would like to display the array as a string. The string formatter currently does not trigger because the formatter lookup does not

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-12-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D69309#1787481 , @labath wrote: > In D69309#1787468 , @jarin wrote: > > > What Fred proposes makes a lot of sense to me, although the lookup of > > instantiations might be slow because

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-12-17 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D69309#1787409 , @labath wrote: > In D69309#1787297 , @jarin wrote: > > > In D69309#1752738 , @friss wrote: > > > > > Basically, today the debug

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-12-16 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D69309#1752738 , @friss wrote: > Basically, today the debug info will describe an entity named "Foo". The > accelerator tables all reference this name. So when Clang asks us if we know > "Foo" (which is what happens when

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-12-16 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D69309#1763454 , @v.g.vassilev wrote: > https://reviews.llvm.org/D41416 could be relevant. I am not an expert but I > think when reading the DWARF you could only register 'lazy' specializations > which will be imported only

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-11-21 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. In D69309#1752738 , @friss wrote: > Sorry that I haven't reviewed the patch, but there's something I'd like to > point out before anyone invests a lot of time into plugin holes in our > current template support code. > > It would

[Lldb-commits] [PATCH] D69309: Support template instantiation in the expression evaluator

2019-11-19 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin updated this revision to Diff 230069. jarin added a comment. This update introduces a callback from clang for template specialization. The callback allows lldb to construct instantiations on demand, rather than having to create the instantiation eagerly. Perhaps it would still beneficial

[Lldb-commits] [PATCH] D69843: Expression eval lookup - prune methods without parsing

2019-11-06 Thread Jaroslav Sevcik via Phabricator via lldb-commits
jarin added a comment. Thanks for the feedback! We will experiment with filtering in GetFunctions sometime next week. Regarding the FindTypes patch, it would be really nice to have that for Linux, as well. I see the type pruning (TypeMap::RemoveMismatchedTypes) taking several seconds for some

  1   2   >