https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
I think this page leaves a lot to be desired but it's a good start.
https://github.com/llvm/llvm-project/pull/109427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/109266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,77 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/109266
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1,77 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
@@ -87,6 +40,14 @@ adds `FOO=1` and `bar` to the environment:
}
```
+### Attaching to a process
+
+When attaching to a process using LLDB you can attach in a few ways
JDevlieghere wrote:
Nit: missing period or colon.
https://github.com/llvm/llvm-project/pull
@@ -1,77 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
@@ -1,77 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
@@ -1,77 +1,30 @@
# LLDB DAP
-## `lldb-dap` Configurations
+## Procuring the `lldb-dap` binary
-The extension requires the `lldb-dap` (formerly `lldb-vscode`) binary. It is a
-command line tool that implements the [Debug Adapter
-Protocol](https://microsoft.github.io/debug-ad
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict):
print("Script exited with code %s" % e.code)
+class LLDBInteractiveConsole(code.InteractiveConsole):
+def __init__(self, locals=None):
+super().__init__(locals)
+self.result_output =
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict):
print("Script exited with code %s" % e.code)
+class LLDBInteractiveConsole(code.InteractiveConsole):
+def __init__(self, locals=None):
+super().__init__(locals)
+self.result_output =
https://github.com/JDevlieghere commented:
I assume you have tested this both with Python 3.9 and 3.11/3.12?
https://github.com/llvm/llvm-project/pull/109440
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/109440
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -116,19 +118,50 @@ def run_python_interpreter(local_dict):
print("Script exited with code %s" % e.code)
+class LLDBInteractiveConsole(code.InteractiveConsole):
+def __init__(self, locals=None):
+super().__init__(locals)
+self.result_output =
https://github.com/JDevlieghere approved this pull request.
Okay this is safe because after 65b13610a5226b84889b923bae884ba395ad084d,
`raw_string_ostream` is always unbuffered so you (1) don't need to flush and
(2) can use the underlying buffer directly. That makes sense. Please include
that i
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/108715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108715
Reverts llvm/llvm-project#106791 because it breaks `trap_frame_sym_ctx.test `
on x86_64.
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/
>From ba6e663299e1d7b54a3ac4a7c647d44f66
JDevlieghere wrote:
It looks like this breaks `Unwind.trap_frame_sym_ctx` on x86_64:
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/5745/testReport/junit/lldb-shell/Unwind/trap_frame_sym_ctx_test/
I'm going to revert this to get the bots green over the weekend.
https://gi
https://github.com/JDevlieghere approved this pull request.
Unless someone steps up to maintain these tests I'm fine with removing them.
https://github.com/llvm/llvm-project/pull/108629
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-09-12T22:52:58-07:00
New Revision: 8f653ca135cb8d4f8d08b97cc32a497091f68cdc
URL:
https://github.com/llvm/llvm-project/commit/8f653ca135cb8d4f8d08b97cc32a497091f68cdc
DIFF:
https://github.com/llvm/llvm-project/commit/8f653ca135cb8d4f8d08b97cc32a497091f68cdc.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108498
>From d15881207001934ff83934fae9cdeb52f61eaf6f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Sep 2024 22:43:40 -0700
Subject: [PATCH] [lldb] Emit signpost intervals for progress events (NFC
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/108495
>From 734088d8ec84d32304b4f78743999fd561fd4fe3 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 12 Sep 2024 22:29:46 -0700
Subject: [PATCH] [lldb] Introduce an always-on system log category/chann
@@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType {
Watchpoints = Log::ChannelFlag<30>,
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
+ AlwaysOn = Log::ChannelFlag<32>,
JDevlieghere wrote:
Yes, definitely. But this code shouldn't ha
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108498
Emit signpost intervals for progress events so that when users report an
operation takes a long time, we can see investigate the issue with Instruments.
>From 60096062924d8364e953d8479dcbd4b7ea2faaff Mon S
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/108495
Add an "always on" log category and channel. Unlike other, existing log
channels, it is not exposed to users. The channel is meant to be used sparsely
and deliberately for logging high-value information to
@@ -972,8 +974,9 @@ GetLargestRangeSize(const std::vector
&ranges) {
return max_size;
}
-Status MinidumpFileBuilder::AddMemoryList_32(
-std::vector &ranges) {
+Status
+MinidumpFileBuilder::AddMemoryList_32(std::vector &ranges,
+ Prog
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/108309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -837,15 +837,17 @@ Status MinidumpFileBuilder::AddMemoryList() {
error = m_process_sp->CalculateCoreFileSaveRanges(m_save_core_options,
all_core_memory_ranges);
+ if (error.Fail())
+return error;
+
+ lldb_private::
https://github.com/JDevlieghere commented:
The variable name should be `progress_tracker` but really we should just call
it `progress` for consistency with the rest of lldb.
https://github.com/llvm/llvm-project/pull/108309
___
lldb-commits mailing li
Author: Jonas Devlieghere
Date: 2024-09-11T15:29:59-07:00
New Revision: 0909e3027004bb710b1d761569eb15452ce10346
URL:
https://github.com/llvm/llvm-project/commit/0909e3027004bb710b1d761569eb15452ce10346
DIFF:
https://github.com/llvm/llvm-project/commit/0909e3027004bb710b1d761569eb15452ce10346.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/108183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/107968
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Closing in favor of https://github.com/llvm/llvm-project/pull/107968
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/71459
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/107968
Print a warning when the debugger detects a mismatch between the MD5 checksum
in the DWARF 5 line table and the file on disk. The warning is printed only
once per file.
>From 397e41bfb8516659ec6af7cf98c2d
JDevlieghere wrote:
CC @Jlalond
https://github.com/llvm/llvm-project/pull/107731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/107731
Reverts llvm/llvm-project#107159 as this is still causing
`TestSkinnyCorefile.py` to time out.
https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/11099/
https://ci.swift.org/view/all/j
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/107731
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-09-07T17:03:59-07:00
New Revision: b93457073762bb347b6c7f39c23636dec036a815
URL:
https://github.com/llvm/llvm-project/commit/b93457073762bb347b6c7f39c23636dec036a815
DIFF:
https://github.com/llvm/llvm-project/commit/b93457073762bb347b6c7f39c23636dec036a815.d
@@ -943,8 +935,20 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
}
}
}
+ return debugserver_file_spec;
+}
- if (debugserver_exists) {
+Status GDBRemoteCommunication::StartDebugserverProcess(
+const char *url, Platform *platform, ProcessLaunchInfo
https://github.com/JDevlieghere approved this pull request.
LGTM modulo one nit.
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/107388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM. I like having both options. That way we don't break existing use cases
while also supporting the more intuitive way of expressing this as a dictionary.
https://github.com/llvm/llvm-project/pull/106919
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/106799
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> Thanks! Is this asserting cause something changed in how llvm::formatv
> validates the format string?
Correct: https://github.com/llvm/llvm-project/pull/105745
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits ma
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/107325
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-09-03T15:40:39-07:00
New Revision: 7d3b81d06f96bc27673f31a7bd7d141ce4a2777b
URL:
https://github.com/llvm/llvm-project/commit/7d3b81d06f96bc27673f31a7bd7d141ce4a2777b
DIFF:
https://github.com/llvm/llvm-project/commit/7d3b81d06f96bc27673f31a7bd7d141ce4a2777b.d
Author: Jonas Devlieghere
Date: 2024-09-03T14:38:39-07:00
New Revision: 98bde7fd872c10e49035d5dc5d2f2b44489f6a07
URL:
https://github.com/llvm/llvm-project/commit/98bde7fd872c10e49035d5dc5d2f2b44489f6a07
DIFF:
https://github.com/llvm/llvm-project/commit/98bde7fd872c10e49035d5dc5d2f2b44489f6a07.d
Author: Jonas Devlieghere
Date: 2024-09-03T14:38:34-07:00
New Revision: d966d4708fe5084e47ca3d9d411935d6870aefff
URL:
https://github.com/llvm/llvm-project/commit/d966d4708fe5084e47ca3d9d411935d6870aefff
DIFF:
https://github.com/llvm/llvm-project/commit/d966d4708fe5084e47ca3d9d411935d6870aefff.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -97,7 +97,7 @@ class LLDB_API SBError {
friend class lldb_private::ScriptInterpreter;
friend class lldb_private::python::SWIGBridge;
- SBError(const lldb_private::Status &error);
+ SBError(lldb_private::Status &&error);
JDevlieghere wrote:
IIRC we ha
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -145,10 +194,12 @@ class Status {
bool Success() const;
protected:
- /// Status code as an integer value.
- ValueType m_code = 0;
- /// The type of the above error code.
- lldb::ErrorType m_type = lldb::eErrorTypeInvalid;
+ Status(llvm::Error &&error) : m_error(std::
@@ -96,16 +124,44 @@ Status Status::FromErrorStringWithFormat(const char
*format, ...) {
return Status(string);
}
-llvm::Error Status::ToError() const {
- if (Success())
-return llvm::Error::success();
- if (m_type == ErrorType::eErrorTypePOSIX)
-return llvm::erro
@@ -37,49 +39,75 @@ class raw_ostream;
using namespace lldb;
using namespace lldb_private;
-Status::Status() {}
+char MachKernelError::ID;
+char Win32Error::ID;
+char ExpressionError::ID;
+
+namespace {
+/// A std::error_code category for eErrorTypeGeneric.
+class GenericCateg
@@ -91,10 +136,14 @@ class Status {
~Status();
- // llvm::Error support
- explicit Status(llvm::Error error) { *this = std::move(error); }
+ /// Try not to use this in new code. Migrate APIs to llvm::Expected instead.
JDevlieghere wrote:
[nit] I'd word
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106773
>From a73b63a4b3e74b92b9ef5f913c75b4710859bca6 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 11:07:50 -0700
Subject: [PATCH 1/2] [lldb] Include checksum in source cache dump
This
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106773
This patch updates the source cache dump command to print both the actual
(on-disk) checksum and the expected (line table) checksum. To achieve that we
now read and store the on-disk checksum in the cached
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106740
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106740
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 07:20:26 -0700
Subject: [PATCH 1/3] [lldb] Deal with SupportFiles in SourceManager (NFC
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/106740
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 30 Aug 2024 07:20:26 -0700
Subject: [PATCH 1/2] [lldb] Deal with SupportFiles in SourceManager (NFC
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106740
To support detecting MD5 checksum mismatches, deal with SupportFiles rather
than a plain FileSpecs in the SourceManager.
>From f7b0874d6bd83c85f4fb6411fc4da7dfb4dd8453 Mon Sep 17 00:00:00 2001
From: Jonas
Author: Jonas Devlieghere
Date: 2024-08-30T07:21:45-07:00
New Revision: b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
URL:
https://github.com/llvm/llvm-project/commit/b0eefb4c4e5136fd606cf4cff566df9dbc0fa051
DIFF:
https://github.com/llvm/llvm-project/commit/b0eefb4c4e5136fd606cf4cff566df9dbc0fa051.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/106639
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/106639
To support detecting MD5 checksum mismatches, store a SupportFile rather than a
plain FileSpec in SourceManager::File.
>From 64b6c6419722ecd5865cdf3e734b63ed51763174 Mon Sep 17 00:00:00 2001
From: Jonas De
JDevlieghere wrote:
Looks like this is ready to go. @Da-Viper do you need someone to merge this for
you?
https://github.com/llvm/llvm-project/pull/104711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/106034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105890
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
This is great. It's something I've wanted since the first day I started working
on LLDB. We've made a lot of progress in this direction so it's great to see
that we've reached a point where we can make this actually happen.
https://g
JDevlieghere wrote:
There's a few things I don't really like about this patch:
- It's very specific to a single plugin.
- It sidesteps the plugin's `Initialize/Terminate` paradigm. It happens to
work because `ScriptInterpreterPython::Terminate` is a NOOP (see the comment
for `ScriptInterpr
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/105715
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
The change itself looks fine, but can you please update the PR description with
a meaningful message, preferably with a reference that shows that this was
added in 4.3?
https://github.com/llvm/llvm-project/pull/105715
_
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/105576
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/105576
In f9f3316, Adrian fixed an issue where LLDB wouldn't update the target's
architecture when the process reported a different triple that only differed in
its sub-architecture.
This unintentionally regress
https://github.com/JDevlieghere approved this pull request.
Sorry for breaking this & thanks for fixing it.
https://github.com/llvm/llvm-project/pull/105460
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
This looks like a nice improvement! Can we add a test for this?
https://github.com/llvm/llvm-project/pull/105457
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -137,12 +137,28 @@ class ScriptedPythonInterface : virtual public
ScriptedInterface {
llvm::Expected expected_return_object =
create_error("Resulting object is not initialized.");
- std::apply(
- [&init, &expected_return_object](auto &&...args
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -40,8 +41,49 @@ static ConstString g_coro_frame =
ConstString("__coro_frame");
char CPPLanguageRuntime::ID = 0;
+/// A frame recognizer that is installed to hide libc++ implementation
+/// details from the backtrace.
+class LibCXXFrameRecognizer : public StackFrameRecogni
@@ -1208,7 +1208,8 @@ bool SBThread::GetStatus(SBStream &status) const {
ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
if (exe_ctx.HasThreadScope()) {
-exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, true);
+exe_ctx.GetThreadPtr()->GetStatus(strm, 0, 1, 1, tr
@@ -17,6 +17,7 @@
#include "lldb/lldb-private-forward.h"
#include "lldb/lldb-public.h"
+#include <_types/_uint16_t.h>
JDevlieghere wrote:
+1, this looks fishy. `cstdint` or `cinttypes` should do.
https://github.com/llvm/llvm-project/pull/104523
@@ -518,33 +523,33 @@ class StackFrame : public ExecutionContextScope,
bool HasCachedData() const;
private:
- // For StackFrame only
+ /// For StackFrame only.
lldb::ThreadWP m_thread_wp;
uint32_t m_frame_index;
uint32_t m_concrete_frame_index;
lldb::RegisterCo
@@ -1202,6 +1202,19 @@ bool SBFrame::IsArtificial() const {
return false;
}
+bool SBFrame::IsHidden() const {
+ LLDB_INSTRUMENT_VA(this);
+
+ std::unique_lock lock;
+ ExecutionContext exe_ctx(m_opaque_sp.get(), lock);
+
+ StackFrame *frame = exe_ctx.GetFramePtr();
+ if
@@ -123,8 +126,13 @@ class StackFrameRecognizerManager {
lldb::StackFrameRecognizerSP GetRecognizerForFrame(lldb::StackFrameSP frame);
lldb::RecognizedStackFrameSP RecognizeFrame(lldb::StackFrameSP frame);
+ /// This number changes whenever the list of recognizers has bee
@@ -38,13 +42,21 @@
ScriptedStackFrameRecognizer::RecognizeFrame(lldb::StackFrameSP frame) {
ValueObjectListSP args =
m_interpreter->GetRecognizedArguments(m_python_object_sp, frame);
auto args_synthesized = ValueObjectListSP(new ValueObjectList());
- for (const aut
@@ -518,33 +523,33 @@ class StackFrame : public ExecutionContextScope,
bool HasCachedData() const;
private:
- // For StackFrame only
+ /// For StackFrame only.
JDevlieghere wrote:
Since you're touching this comment...
https://github.com/llvm/llvm-projec
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere commented:
Mostly nits.
https://github.com/llvm/llvm-project/pull/104523
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/104831
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
@DavidSpickett nailed it.
PS: I'm around but I've been busy with other stuff. If people start to think
I'm on vacation I really gotta step it up again :D
https://github.com/llvm/llvm-project/pull/104878
___
lldb-commits mailing
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/105037
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 1016 matches
Mail list logo
