[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

2022-02-25 Thread Michael Forster via Phabricator via lldb-commits
MForster added a comment. > The backtrace is pretty much useless Yes, sorry, that's all I had. Just added some evidence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

2022-02-25 Thread Michael Forster via Phabricator via lldb-commits
MForster added a comment. This fails under MSAN: ==3096==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f0e7899ce18 (/build/work/73ffa3b6f1cbc2218b7b71e21a3dd1e2e53b/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/@0x3a0b9000+0x2e3e18) (BuildId:

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

2020-05-20 Thread Michael Forster via Phabricator via lldb-commits
MForster added a comment. Reverts of a few follow-up changes were necessary as well: - 79fcd35c688b94becadd162a6c37e9b95df5c084 - 23f29b2fcc5668c51f15809067a1c3503b422c64

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

2020-05-20 Thread Michael Forster via Phabricator via lldb-commits
MForster added subscribers: gribozavr2, MForster. MForster added a comment. In D80150#2045632 , @omjavaid wrote: > This patch breaks lldb unit tests on lldb-arm-ubuntu buildbot. > > http://lab.llvm.org:8014/builders/lldb-arm-ubuntu/builds/1697 It also

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

2020-05-20 Thread Michael Forster via Phabricator via lldb-commits
MForster added a subscriber: echristo. MForster added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:797 + + if (date_value > std::numeric_limits::max() || + date_value < std::numeric_limits::min()) This is the line where the