[Lldb-commits] [PATCH] D158500: [lldb][AArch64] Linux corefile support for SME

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good with just one nit above. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:74 - if (m_register_info_up->IsSVEEnabled

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is good too. Thanks!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://reviews.llvm.org/D154927

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid added a comment. Are Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:1181 + + return {}; +} Shouldnt we build a relevant error message here incase ReadSMEControl fails on ReadZAHeader Comment at:

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. this looks good Comment at: lldb/test/API/commands/register/register/aarch64_za_register/za_dynamic_resize/main.c:12 +// (this is just how ptrace works). +// * Writing

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:201 +self.runCmd("register write za '{}'".format(za_value)) +self.expect("register read za", substrs=[za_value]) ---

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This look good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 _

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is LGTM as you suggested pending child reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp:839 + +void GDBRemoteDynamicRegisterInfo::UpdateARM64SMERegistersInfos(uint64_t svg) { + for (auto ® : m_regs) { can we combine UpdateARM64SVERegiste

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

omjavaid added a comment. This looks find just couple of nits inline. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:354 + + // ZA is part of the SME set but uses a seperate member buffer for storage. + // Therefore its effective

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This is LGTM. Thanks for your patience. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159502/new/ https://reviews.llvm.org/D159502

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:597 + // Here this means, does the system have ZA, not whether it is active. + if (GetRegisterInfo().IsZAEnabled()) { +error = ReadZAHeader(); ---

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:566 TLS, + ZA, + // SME pseudo registers are read only. ZA -> SME? Comment at: lldb/source/Plugins/Process/Utility/Register

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid added a comment. This apparently requires a rebase now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159504/new/ https://reviews.llvm.org/D159504 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D159504: [lldb][AArch64] Implement resizing of SME's ZA register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h:42 void UpdateARM64SVERegistersInfos(uint64_t vg); + void UpdateARM64SMERegistersInfos(uint64_t vg); }; svg Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D159503: [lldb][AArch64] Add SME streaming vector length pseduo register

omjavaid added a comment. Why do we have svg and za in different register sets? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159503/new/ https://reviews.llvm.org/D159503 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D159502: [lldb][AArch64] Add SME's Array Storage (ZA) register

omjavaid added a comment. This looks good overall thanks for doing the patch split makes the review way less overwhelming. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:342 + // header itself. + m_za_ptrace_payload.resize(((m_za_

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

omjavaid added a comment. In D157846#4644241 , @DavidSpickett wrote: >> In this test can we figure out whether SVE was read from Streaming mode or >> normal SVE mode?? and if yes may be add a check for that. > > Not sure what you mean. > > If you mean:

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's tests for SVE register state to TestArm64DynamicRegsets

omjavaid added a comment. In this test can we figure out whether SVE was read from Streaming mode or normal SVE mode?? and if yes may be add a check for that. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:156 + +

[Lldb-commits] [PATCH] D159505: [lldb][AArch64] Add testing for SME's ZA and SVG registers

omjavaid added a comment. This patch requires rebasing does not apply cleanly on top of its parent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159505/new/ https://reviews.llvm.org/D159505 ___ lldb-com

[Lldb-commits] [PATCH] D157846: [lldb][AArch64] Add SME's SVE register state to TestArm64DynamicRegsets

omjavaid added a comment. Can you add more description to this patch. at the moment reading it without SME context in mind does not provide enough information to figure out what we are doing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157846/ne

[Lldb-commits] [PATCH] D157883: [lldb][AArch64] Add SME's Array Storage (ZA) and streaming vector length (SVG) registers

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. The patch looks to implement all stuff needed at once lets break it down into three patches instead: 1. First patch that just adds SME register set and does not implement Regist

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:503 +enum SavedRegistersKind : uint32_t { + GPR, + SVE, // Used for SVE and SSVE. Consider renaming this to RegisterSetName or RegisterSetType

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:539 Status error; - uint32_t reg_data_byte_size = GetGPRBufferSize(); + uint32_t reg_data_byte_size = sizeof(SavedRegistersKind) + GetGPRBufferSize(); erro

[Lldb-commits] [PATCH] D157845: [lldb][AArch64] Remove bool return from UpdateARM64SVERegistersInfos

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157845/new/ https://reviews.llvm.org/D157845

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:573 - ::memcpy(dst, GetGPRBuffer(), GetGPRBufferSize()); - dst += GetGPRBufferSize(); + dst = AddSavedRegisters(dst, SavedRegistersKind::GPR, GetGPRBuffer(), +

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added a comment. In D156687#4628743 , @DavidSpickett wrote: > First thing to note is that WriteRegister also behaves this way, but there it > is more appropriate because it updates only part of the buffer before writing > it out in its entiret

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added a comment. > I don't know about expensive literally but I did wonder if we could rely on > the NativeRegisterContextLinux_arm64 buffers not being modified while the > expression runs. Then do what I think you mean which is just flush them all > to the process. > > I'll need to wo

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

omjavaid added a comment. I have a feeling that expressions are becoming an expensive operation with amount of data we need to move back and forth between various buffers. Is there a way we can optimise this may be write register directly from source buffer. Also how much minimum data we need t

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

omjavaid added a comment. This looks fine but instead of adding a new test cant we add MTE control register tests to already available MTE tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157488/new/ https://reviews.llvm.org/D157488 _

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/commands/register/register/aarch64_sve_simd_registers/main.c:43 +void write_simd_regs_expr() { +#define WRITE_SIMD(NUM)

[Lldb-commits] [PATCH] D156512: [lldb][AArch64] Save/restore TLS registers around expressions

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. Just a nit the summary seems to be using a lot pronouns. Could you kindly improve summary a little and add a one liner about expr_func and how it tests save/restore for fu

[Lldb-commits] [PATCH] D156118: [lldb][AArch64] Add reading of TLS tpidr register from core files

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks legit. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156118/new/ https://reviews.llvm.org/D156118

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid added a comment. I guess there is not much gain from telling the user between sve/ssve mode for the moment. Can we defer this patch till SME registers are implemented? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154927/new/ https://revi

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks very good much simpler from the first version. just a minor nit. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:81

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good just a minor suggestion inline. Comment at: lldb/test/API/linux/aarch64/tls_registers/TestAArch64LinuxTLSRegisters.py:84 + +self.check_tls_reg("t

[Lldb-commits] [PATCH] D154926: [lldb][AArch64] Add support for SME's SVE streaming mode registers

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:222 + // In SIMD or Full mode, the data comes from the SVE regset. In streaming + // mode, it also comes from that set, so we have to switch temporarily.

[Lldb-commits] [PATCH] D154927: [lldb][AArch64] Add SME's streaming vector control register

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:325 + } else if (IsSME(reg)) { +// This is a pseduo so it never fails. +ReadSMEControl(); typo: pseudo register? Comme

[Lldb-commits] [PATCH] D154930: [lldb][AArch64] Add the tpidr2 TLS register that comes with SME

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:279 +assert(offset < GetTLSSize()); +src = (uint8_t *)GetTLS() + offset; } else if (IsSVE(reg)) { GetTLS could be GetTLSBuffer similar t

[Lldb-commits] [PATCH] D154705: [lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Sounds ok to me. We can always fix it if starts to cause trouble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154705/new/ https://reviews.

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good to me, just a minor nit above. I have not run the test myself. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152519/new/ https://reviews.llvm.org/D152519 ___

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory" (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D149625?vs=518782&id=522285#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This introduced test failures on windows lldb-aarch64-windows buildbot. lldb-api :: functionalities/process_save_core/TestProcessSaveCore.py lldb-api :: python_api/symbol-context/TestSy

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

omjavaid added a comment. In D148752#4283899 , @manojgupta wrote: > I am building on ChromeOS. We only have headers from linux kernel 4.14 > available in our build system (The actual running kernel could be a higher > version). > But given these functi

[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

omjavaid added a comment. HI Manoj Which linux distro are you using for your cross build? I am wondering which version of gcc (aarch64-linux-gnu) are you using for your cross compilation build. I believe sve headers are not defined in older versions of gcc or its packaged sysroot causing cross

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks good to me as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147816/new/ https://reviews.llvm.org/D147816 ___

[Lldb-commits] [PATCH] D147816: Clarify how watchpoint description in stop packets work, fix AArch64 unintended behavior

omjavaid added a comment. I agree that silent continue was wrong and should be fixed. I tried for to remember what I was trying to do when I wrote that patch ... still dont remember much but digged out some information that may be useful for this patch review. We had a bunch of funny behaving

[Lldb-commits] [PATCH] D147674: Interpret ESR/FAR bits directly on watchpoint exceptions in debugserver, clarify how watchpoint descriptions in stop packets work

omjavaid added a comment. I agree that silent continue was wrong and should be fixed. I tried for to remember what I was trying to do when I wrote that patch ... still dont remember much but digged out some information that may be useful for this patch review. We had a bunch of funny behaving

[Lldb-commits] [PATCH] D145446: Fix LLDB windows build

This revision was automatically updated to reflect the committed changes. Closed by commit rG71b38063b282: Fix LLDB windows build (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145446/new/ https://

[Lldb-commits] [PATCH] D145446: Fix LLDB windows build

omjavaid created this revision. omjavaid added a reviewer: mib. Herald added a subscriber: mstorsjo. Herald added a project: All. omjavaid requested review of this revision. LLDB WoA buildbot is failing due to pid_t redefinition after recent changes in lldb/source/Plugins/ScriptInterpreter/Python

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde5d31e96f5: Revert "Revert "[lldb] Make SBSection::GetSectionData call Section… (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D142672?vs=492839&id=493267#toc Repository:

[Lldb-commits] [PATCH] D142672: [lldb] Make SBSection::GetSectionData call Section::GetSectionData.

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. LLDB windows buildbots were broken by the TestSectionAPI.py test. I dont have full context of the commit to fix it. Reverting it temporarily. https://lab.llvm.org/buildbot/#/builders/83/bui

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This rev has broken lldb-arm-ubuntu buildbot https://lab.llvm.org/buildbot/#/builders/17/builds/33173 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

omjavaid added a comment. This test fails on Arm/AArch64 Linux. I have marked it as an XFAIL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138077/new/ https://reviews.llvm.org/D138077 ___ lldb-commits m

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi this broke https://lab.llvm.org/buildbot/#/builders/245/builds/761 I have reverted the change to make the buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e6a71e6a3d1: [LLDB] Make build.py use uname to set platform (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133011/new/ https://revie

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

This revision was automatically updated to reflect the committed changes. Closed by commit rG4db78322031f: [LLDB] Make API tests to run using MSYS tools (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133002/new/ https://review

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

omjavaid created this revision. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes build helper script build.py to use platform.uname for machine/architecture detection. Visual studio envi

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

omjavaid created this revision. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. MSYS 'uname' on windows returns "MSYS_NT*" instead of windows32 and also MSYS 'pwd' returns non-windows path string. This

[Lldb-commits] [PATCH] D130985: [lldb] Fix TestDeletedExecutable on linux

omjavaid added a comment. This broke LLDB AArch64 buildbot: https://lab.llvm.org/buildbot/#/builders/96/builds/27004 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130985/new/ https://reviews.llvm.org/D130985 __

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

omjavaid added a comment. In D129489#3665218 , @DavidSpickett wrote: >> You mean "memory read --show-tags"? The details >> are tested on live processes already but a simple smoke test wouldn't hurt, >> I'll do that. > > I checked and to include the me

[Lldb-commits] [PATCH] D129489: [lldb][AArch64] Add support for memory tags in core files

omjavaid added a comment. I am wondering if we should also test memory reads with correct/wrong tags for corefiles as well? Do you see any value on doing it or have done it already in above test and i skipped it? Comment at: lldb/test/API/linux/aarch64/mte_core_file/main.c:1

[Lldb-commits] [PATCH] D129487: [lldb][AArch64] Add UnpackTagsFromCoreFileSegment to MemoryTagManager

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129487/new/ https://reviews.llvm.org/D129487 _

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG01bc838e4512: [LLDB] Add PDB/calling-conventions.test for Arm/Windows (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/ http

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

This revision was automatically updated to reflect the committed changes. Closed by commit rGa18baf16c665: [LLDB] Add Arm64 CodeView to LLDB regnum mapping (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128221/new/ https://rev

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG695c22c84a36: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

omjavaid added a comment. @labath @mstorsjo ok to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/ https://reviews.llvm.org/D128678 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

omjavaid added a comment. In D128678#3616685 , @mstorsjo wrote: > Thanks, this looks more complete and consistent to me now! > > In D128678#3615531 , @labath wrote: > >> It seems like this is not actually running

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

omjavaid added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/CodeViewRegisterMapping.cpp:51 +gpr_w27_arm64, // ARM64_W27, 37) +gpr_w28_arm64, // ARM64_W28, 38) +LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, LLDB_INVALID_REGNUM, Da

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

omjavaid updated this revision to Diff 440581. omjavaid added a comment. Added test for AArch64 and x64 calling conventions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128678/new/ https://reviews.llvm.org/D128678 Files: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/calling-conventions.test for Arm/Windows

omjavaid added inline comments. Comment at: lldb/test/Shell/SymbolFile/PDB/calling-conventions-arm.test:1 +REQUIRES: system-windows, lld, (target-arm || target-aarch64) +RUN: %build --compiler=clang-cl --arch=32 --nodefaultlib --output=%t.exe %S/Inputs/CallingConventionsTest.cp

[Lldb-commits] [PATCH] D127755: [lldb] [llgs] Add test for resuming via c in multiprocess scenarios

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. This breaks on LLDB Arm,AArch64/Linux buildbots https://lab.llvm.org/buildbot/#/builders/17 https://lab.llvm.org/buildbot/#/builders/96 Repository:

[Lldb-commits] [PATCH] D128678: [LLDB] Add PDB/Calling-conentions.test for Arm/Windows

omjavaid created this revision. omjavaid added reviewers: mstorsjo, DavidSpickett. omjavaid added a project: LLDB. Herald added subscribers: jsji, JDevlieghere, pengfei, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. This patch renames PDB/Calling-conention

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

omjavaid added inline comments. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:2 REQUIRES: system-windows, msvc RUN: %build --compiler=clang-cl --mode=compile --arch=32 --nodefaultlib --output=%T/PointerTypeTest.cpp.obj %S/Inputs/PointerTypeTest.cpp RUN: %build --co

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

omjavaid added inline comments. Comment at: lldb/test/Shell/SymbolFile/PDB/pointers.test:36 F: Variable{{.*}}, name = "this" -F-SAME:(ST *), scope = parameter, location = {{.*}}, artificial +F-SAME:(ST *), scope = parameter,{{( location = DW_OP.*,)?}} artificial F:

[Lldb-commits] [PATCH] D128668: [LLDB] Fix PDB/pointers.test for 32bit Arm/Windows

omjavaid created this revision. omjavaid added reviewers: mstorsjo, DavidSpickett. Herald added subscribers: jsji, pengfei, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. PDB/pointers.test was orignally written for 32bit x86 keeping in mind __cdecl and _

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

omjavaid added a comment. In D128221#3598132 , @DavidSpickett wrote: > Are there public docs for these numbers? There is no public doc but I have copied these mappings from https://github.com/microsoft/microsoft-pdb which was opensourced by microsoft.

[Lldb-commits] [PATCH] D128221: [LLDB] Add Arm64 CodeView to LLDB regnum mapping

omjavaid created this revision. omjavaid added reviewers: labath, aleksandr.urakov. omjavaid added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. This patch writes a mapping structure for converting

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

omjavaid added a comment. >> 1. This rev apparently assumes x86_64 only but what about Arm/AArch64? > > Where do you get that impression? This should all be architecture independent > (or done in the same way for all architectures). Sorry I just brushed over the code and saw x86_64 specifc obj f

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

omjavaid added a comment. I am not fully familiar with PE/COFF but lets try to get this merged. For starters I have a couple of questions here: 1. This rev apparently assumes x86_64 only but what about Arm/AArch64? 2. If we have DLLs what abi setting they ll follow the one set by the user or de

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

omjavaid added a comment. I have reverted this temporarily as It broke LLDB API test TestBadAddressBreakpoints.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124731/new/ https://reviews.llvm.org/D124731 _

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. LGTM. With a minor nit fix about FixAnyAddress vs FixDataAddress if required. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:288 + if (lldb::ABISP a

[Lldb-commits] [PATCH] D122411: [lldb][AArch64] Fix corefile memory reads when there are non-address bits

omjavaid added a comment. Very corner case but Is there a possibility of masks changing positions during the life-time of an inferior ? So this makes me think that code/data masks are per process and cant be changes once set. Should we worry about it?AFAIK this is fine but just asking to clear

[Lldb-commits] [PATCH] D124000: [lldb] Add FixAnyAddress to ABI plugins

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124000/new/ https://reviews.llvm.org/D124000 __

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5341b5f8d3ce: [LLDB] Update inspect getargspec to getfullargspec (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

omjavaid added a comment. Thanks for good detailed explanation. I think from the code readability point of view, we may use FixAddress function which i believe already exists in ABI and if not then introduce FixAnyAddress may be. We can put all the comments about PAC/TBI code vs data address bi

[Lldb-commits] [PATCH] D118794: [lldb] Remove non-address bits from read/write addresses in lldb

omjavaid added a comment. In D118794#3405724 , @DavidSpickett wrote: > Switch to removing non-address bits in lldb instead of lldb-server. > > The breakpoint issues I mention only really happen if you try to break on a > tagged > function pointer. Which

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

omjavaid added a comment. In D121786#3385619 , @DavidSpickett wrote: >> by python 11x release > > Is this a typo or some numbering system not related to the 2.x/3.x cadence? This is a typo. Sorry I missed 3.11x CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D121786: [LLDB] Update inspect getargspec to getfullargspec

omjavaid created this revision. omjavaid added a reviewer: labath. omjavaid added a project: LLDB. Herald added subscribers: JDevlieghere, kristof.beyls. Herald added a project: All. omjavaid requested review of this revision. This patch replaces getargspec with getfullargspec in funcutils.py. get

[Lldb-commits] [PATCH] D119797: Fix race condition when launching and attaching.

omjavaid added a comment. Hi @clayborg this rev has caused some lldb-vscode test failures across all LLDB/Linux buildbots. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119797/new/ https://reviews.llvm.org/D119797

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG73a961b9cca1: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

omjavaid added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117676/new/ https://reviews.llvm.org/D117676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. looks good thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 __

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. LGTM Thanks! for your patience Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112824/new/ https://reviews.llvm.org/D112824 _

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:83 +# Then that the location found does not display the ta

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:177 + // and exit early before it sees the overlap. + MemoryRegionInfos::const_iterator overlap = std::adjacent_find( + memory_regions.begin(), memory_regions.en

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

omjavaid added inline comments. Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:70 +# 1. It tries to search a gigantic amount of memory. +#We're not going to to test for this because a failure +#w

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

omjavaid added a comment. In D117676#3254662 , @labath wrote: > FWIW, I consider the build.py script a failed experiment. The idea itself was > not completely bad, but the lack of buy-in from sufficient amount of > developers meant that it never really

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

omjavaid created this revision. omjavaid added a reviewer: JDevlieghere. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch updates toolchain-msvc.test to cater for Arm64 windows platform. https://reviews.llvm.org/D117676 Files: lldb/test/Shell/Bu

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

omjavaid added a comment. This doesnt interfere with LLDB tests for SVE. Rather I have not used it in a while for SVE tests I ahve using setup similar to to one David has explained above. @labath Do you know if android adb based tests are being run anywhere? Are we still maintaining this suppo

  1   2   3   4   5   6   >